Jump to content

tpr

Members
  • Posts

    2,321
  • Joined

  • Last visited

  • Days Won

    44

Everything posted by tpr

  1. Thanks, will investigate them later.
  2. With the recent CKEditor update to 4.7 the Table Cells Selection plugin can be entirely removed, will do it in the next update.
  3. I guess it's th file compiler, try to disable it for the template (and clear cache).
  4. In v048 there's a new filter called group. This allows creating groups from a PageArray based on a page field value. I will probably further polish it later when I will use it in more projects but I think it's a nice time saver. {foreach ($page->children()->sort('sort')|group:'section') as $group} ... The filter just saved my *** from re-writing a thing to use Repeaters instead using child pages. It was much easier and fun to create the filter
  5. Thanks, I'll check them. I meant that magicline is removed by default by PW, you will need to edit the field in question, and on its Input tab go to the bottom and under Remove Plugins delete "magicline" text.
  6. Field Input tab, "Remove Plugins", delete magicline. What extra plugins are you using? In my module AdminOnSteroids I have a bunch of them, perhaps there are others I could integrate too.
  7. Icon replacements could work, I'll try. Btw its not my own skin but nico's, I'm just borrowing it
  8. Thanks, it was very informative! I could locate the TCS issue, the plugin had return false but false wasn't needed. Please try the attached js file. As for the Lightwire bug, the floating ckeditor toolbar was always an issue, the current solution is a workaround I've added earlier. Now that PW's default ckeditor skin looks nicer since the last ckeditor upgrade, I'm thinking of removing the skin entirely, what do you think? tablecellsselection.js
  9. Does it make any change if you rename the $page variable? It's better not to change.
  10. perhaps this could work too echo str_replace('<img', '<img class="img-responsive"', $page->body);
  11. Certainly, the workaround selector fails here, I'll update soon.
  12. I couldn't see this issue but it was also OK here after applying the fix so I committed the update.
  13. It's another module. I'll check it, thanks.
  14. AOS is at 1.4.7, containing Robin S's fixes and his IconsFilter module. I've spent much more time on the icons filter because I wanted it to be compatible with the current markup and with this PR too.
  15. I've added Robin's code to AOS (unreleased yet) with some tweaks (use placeholder search character instead ::before pseudo, on enter select first match and do not submit the form, focus on expanding the icons and position the filter next to the Show all button instead floating. I've also posted a PR to the core InputfieldIcon.
  16. Thanks @Robin S, I merged your codes into my aos work copy. Seems to work fine at first look but need to test a bit more to make sure there are no side effects. Bernhard's repeater profile also seems to be OK with your fixes, though it was also OK with mines.
  17. It's the same issue as of @bernhard's, could you try the fix I posted on June 2?
  18. Thanks, this part was always buggy but I think I've found a better way, namely floating clear btn and pagelist to the left, and setting pagelist width using calc(). It's OK here in Firefox and Chrome, even with long page titles, could you try? AdminOnSteroids.css
  19. Thanks! Could you try replacing the line 408 with this, and check if it fixes the issue and doesn't break other things? I clicked around in the admin and everything seems to be fine (in another PW). Update: there was an issue with the previous fix, pls try this (lines 408-414): $editedPageId = $this->input->get->id ? $this->sanitizer->int($this->input->get->id) : false; if ($editedPageId && is_numeric($editedPageId) && $this->pages->find('id=' . $editedPageId . ',check_access=0')->count()) { $this->editedPage = $this->pages->find('id=' . $editedPageId . ',check_access=0')->first(); } else { $this->editedPage = null; }
  20. I have a site with similar editor role and could not reproduce the issue. You could try uncommenting things above these lines in init() and ready() functions and see where it fails: if (!$this->enabled) { return; } Only lines above these will be run if you have disabled AOS in its settings page. By any chance have you added new permission from these pre-defined ones? I had a site where "page-edit-created" caused similar issues if I remember right.
  21. Thanks, I'll update the module soon.
  22. Perhaps it's $page->template->hasField()? Could you try?
  23. The iframe src should contain the fields too, not sure why not. But I guess the main problem is PW 2.7, perhaps loading fields only is not supported there.
  24. A new pagelist action "Refresh" will be added in the next update. This refreshes the displayed page data in the page list + reloads children too. Can be useful if you renamed or deleted pages in another browser tab and would like to save a page reload
  25. Sure, and a filter part in AOS if Ryan wouldn't like it to be in the core.
×
×
  • Create New...