Hey @ryan @diogo @jploch thx for your work on this!
I have some questions:
1) UIkit notifications seem to not use the theme's styling:
1.b) Is there a reason why primary buttons are black and not in the primary color?
2) Could you please add an option to make the button's border radius customisable?
3) Could you please add an option to make all input's border radius customisable?
Ideally both would use the same setting by default but could be also set differently. This was one of the changes proposed by @Chris-PW when we were working on a new admin style and I think it makes sense to have everything that can take user input (<input> <textarea> <button> etc) have some rounded borders. We already have lots of lots of lines in the admin to help with grouping content, wrapping inputfields etc. and all those lines add up. Having all clickable elements look slightly different from everything else (but identical on their own) helps a lot in my opinion.
4) Is there a reason why <select>s have white background and regular inputs have a light grey?
5) Is there an option to disable the new toggles and get back to good old checkboxes? See https://axesslab.com/toggles-suck/
Even if one prefered toggles over checkboxes in general, I think there are some situations where they are absolutely counterproductive, for example here:
6) I tried do add the file site/templates/admin.css with the following content:
:root {
--border-color: var(--main-background);
/* --inputs-background: var(--blocks-background); */
}
I then put both "site/templates/admin.css" and "/site/templates/admin.css" in the AdminThemeUikit config for "Custom CSS File", but it had no effect. Strangely when I put "wire/modules/AdminTheme/AdminThemeUikit/themes/default/examples/borderless.css" it worked!
I also tried with this content:
div {
border: 1px solid red;
}
Still no luck.
7) Would it be possible to have the admin theme load one CSS file by default. Similar to what we know from /site/ready.php it is often so much nicer to just place a file in a predefined location than to have to update a module's config somewhere.
This might not sound like a lot to do, but when working with migrations and automated deployment workflows these things get more tedious, because you can't simply change the module config, you have to migrate these changes and then commit them. Also a predefined location reduces the risk of typos, of missing leading slashes, etc.
8 ) Where to report bugs/issues/requests? In the PW issues repo? Here in this thread? Somewhere else?
9) When editing a page in a modal (just add &modal=1 to any page edit form) there is a lot of unused space at the top:
10) On the page tree I think it is ok to have the action items text-only in this case (though I'd probably prefer the old style here):
But on the trash we have some text followed by the action buttons and there this text-only style is really not good imho:
11) +1 for this:
I'm using #0a2b99 for the primary color and links are near to not readable in dark mode:
12) @ryan As you can see in the screenshot above when using dark mode I'd probably want to change the logo to a white version. If that image were an <svg> this would be quite easy to do with CSS, but at the moment it is using <img src='...'>
Could you probably update the theme to make it inject SVG markup for the logo directly?
13) Regular UIkit <div class='uk-alert'> are not styled properly (they use the default uikit blueish), which is even worse in dark mode:
Thx!