Manfred62 Posted September 10, 2013 Posted September 10, 2013 just need an advice from the GitHub pros... Kongondo told me, to submit changes in both forum and GitHub. I already have created an account on GitHub and forked the german language pack from Matthias (yellowled). Also I did my first updates and pull requests there. Now I found some more points to check in the PW dev repo (regarding translations in 2.3.4/2.4). Do I have to fork the full PW dev repo, do the changes and then commit them? Or can I do this only with the files which need the changes? thanks Manfred
Martijn Geerts Posted September 12, 2013 Posted September 12, 2013 Don't know your awswer. Just want to bump your post. 2
adrian Posted September 12, 2013 Posted September 12, 2013 I am no Github expert, but the only way I have ever been able to submit a pull request is to fork the full repo. This seems to confirm this: http://stackoverflow.com/questions/14821583/pull-request-without-forking However maybe I am not exactly understanding what you mean by "Or can I do this only with the files which need the changes?"
kongondo Posted September 12, 2013 Posted September 12, 2013 Yep... Before you can open a pull request, you must create a branch in your local repository, commit to it, and push the branch to a repository or fork on GitHub. https://help.github.com/articles/creating-a-pull-request
kongondo Posted September 12, 2013 Posted September 12, 2013 (edited) just need an advice from the GitHub pros... Kongondo told me, to submit changes in both forum and GitHub. I already have created an account on GitHub and forked the german language pack from Matthias (yellowled). Also I did my first updates and pull requests there. Now I found some more points to check in the PW dev repo (regarding translations in 2.3.4/2.4). Do I have to fork the full PW dev repo, do the changes and then commit them? Or can I do this only with the files which need the changes? thanks Manfred It is not possible to just fork part of a repo (in this case PW) - not that I know of. You lose nothing btw by forking "the full PW dev repo" as Github offers unlimited repos . So, yes. Please, fork the dev branch, make your changes and submit a pull request for those changed files. See this link for step-by-step instructions: https://help.github.com/articles/creating-a-pull-request Edit: OK, there seems to be a way to partially fork a repo though I am not sure it is worth the effort. There is something called "sparse checkout" in Git. There's tonnes of topics on SO and other places about this. I would just fork the whole branch. One advantage with that is that it allows you to easily test your changes in the whole system to see if they break anything... Edited September 12, 2013 by kongondo 2
horst Posted September 13, 2013 Posted September 13, 2013 ... One advantage with that is that it allows you to easily test your changes in the whole system to see if they break anything... This point I want double-like! (but it isn't an available feature) 2
diogo Posted September 13, 2013 Posted September 13, 2013 Even for very simple changes, like correcting typos on the readme, youhave to fork the repo. This can even be done just by editing the file directly on the original github repo (I mean , on the website) This is what you will see: You are editing a file in a project you do not have write access to. We are forking this project for you (if one does not yet exist) to write your proposed changes to. Submitting a change to this file will write it to a new branch in your fork so you can send a pull request. very handy 1
Manfred62 Posted September 13, 2013 Author Posted September 13, 2013 thanks a lot for all your explanations... I will fork the complete repo (PW dev) and hopefully contribute something to PW. 1
horst Posted September 13, 2013 Posted September 13, 2013 This can even be done just by editing the file directly on the original github repo (I mean , on the website) That's the way I have done it. Now I am searching if / how it is possible to create another parallel branch (separate). On the Github website the (auto) forked repo has a "branch-1". I would like to have a "branch-2" too: forked-repo-| | |---- branch-1 (with changes) | |---- branch-2 (with other changes) Did someone know how to do it (directly on the GitHub website if possible)?
kongondo Posted September 13, 2013 Posted September 13, 2013 (edited) That's the way I have done it. Now I am searching if / how it is possible to create another parallel branch (separate). On the Github website the (auto) forked repo has a "branch-1". I would like to have a "branch-2" too: forked-repo-| | |---- branch-1 (with changes) | |---- branch-2 (with other changes) Did someone know how to do it (directly on the GitHub website if possible)? In your repository's branch selector, just start typing a new branch name. We'll give you the option to create a new branch: Create and delete branches: https://github.com/blog/1377-create-and-delete-branches E.g. "master" and "dev" are the 2 branches of PW: https://github.com/ryancramerdesign/ProcessWire/branches Stuff others may find useful Branches Commit branch and tag labels: https://help.github.com/articles/commit-branch-and-tag-labels Setting the default branch: https://help.github.com/articles/setting-the-default-branch Other FYIs: How do I work with branches in GitHub for Windows? https://help.github.com/articles/how-do-i-work-with-branches-in-github-for-windows Fork A Repo: https://help.github.com/articles/fork-a-repo Creating Releases: https://help.github.com/articles/creating-releases What are the differences between SVN and Git?: https://help.github.com/articles/what-are-the-differences-between-svn-and-git Edited September 13, 2013 by kongondo 1
Recommended Posts