Allowed memery size exausted - DB Backups module

[Zeka]

Hi. After update to 3.0.109 from 3.0.106 when I try to access DB backup modules page I get

Fatal error: Allowed memory size of 536870912 bytes exhausted (tried to allocate 262144 bytes) 

PHP 7.2.4 

Laragon

Does anybody get the same error? 

[horst]

I have

PW 3.0.109,

PHP 7.1.19-nmm1

and a older DB-Backup-Moduleversion. Everything is working fine. Which version of DB-Backup module do you use?

[Robin S]

1 hour ago, Zeka said:

Does anybody get the same error?

Yes, I get the same error.

Seems to be caused by two button inputfields being rendered in the same form. I have created a simple test case and have opened a GitHub issue: https://github.com/processwire/processwire-issues/issues/653

[kongondo]

11 minutes ago, Robin S said:

Seems to be caused by two button inputfields being rendered in the same form.

So potentially affecting any (process?) module that renders two button inputfields in a single form? 

[Robin S]

Just now, kongondo said:

So potentially affecting any (process?) module that renders two button inputfields in a single form?

Yes, I get an out of memory error with this simple test module:

<?php namespace ProcessWire;

class ProcessTest extends Process {

    public static function getModuleInfo() {
        return array(
            'title' => 'Process Test',
            'version' => 1,
            'page' => array(
                'name' => 'test',
                'parent' => 'setup',
                'title' => 'Test',
            ),
        );
    }

    public function ___execute() {

        $form = $this->modules->get('InputfieldForm');

        $f = $this->modules->get('InputfieldButton');
        $f->value = 'foo';
        $form->add($f);

        $f = $this->modules->get('InputfieldButton');
        $f->value = 'bar';
        $form->add($f);

        return $form->render();

    }

}

 

[kongondo]

That's crazy! Wild guess: does giving them custom names or IDs change anything?

[Robin S]

Just now, kongondo said:

custom names

I was just thinking the same thing and giving them names does fix it. But up until now it hasn't been a requirement for button inputfields to have name attributes. 

[kongondo]

Great catch. Existing modules better watch out then.