renobird

I just sent Ryan several other updates, which should include the target attribute stuff and all the image CSS changes from the screenshots on the previous page.

Whoa. Ummm....well — that is bizarre. Anyone else seeing that with Chrome? I've tried on a Mac and a PC, and I can't recreate it. Do you have any other custom css/js files being added with the admin custom files module?

@peter, I can't recreate that one. PW 2.6.9 and Chrome 43.0.2357.134

@justB3a, @Macrura, Thanks, that issue is the same one that Juergen reported. It's been fixed in the upcoming update (hopefully later today). It will override the fix you have, but glad you have it working for now. @Peter, Wow, that is a weird issue. I'll see if I can recreate it.

@Juergen, You are correct, that doesn't work (yet). Pete requested this for the superuser quicklinks, and I didn't get around to adding it until now. I'll submit this and a bunch of other little updates to Ryan today. This won't work until these changes are added to the dev branch, but you can now define link attributes like so: $newItem[] = array( "class" => "my-class", "label" => "<i class='fa fa-asterisk'></i>", "link" => $config->urls->root, "attrs" => "target='_blank' rel='foo'", // whatever attributes you would like to set here, other than class. "children" => array( // The key/value for the children now accepts an array for the value. // if the value is an array, the first item is considered the link, any other items are considered attributes. "Google" => array('http://google.com', 'target="_blank"', 'rel="foo"'), "Github" => array('http://github.com', 'target="_blank"', 'rel="foo"'), "ProcessWire" => "http://www.processwire.com" // non-array value works as well. ) );

Juergen, I can't recreate that one either. What browser/version? I missed this earlier, I'll check into it now.

I haven't looked at the styles there in a bit, perhaps a quick update to something like this?

@Lostkobrakai, are you having an issue with Drag/Drop not working correctly? Even with the smaller space between the images — which is desirable for fields with lots of images IMO — sorting seems to work fine. I'll glady add some space there, but I want to be sure of the actual issue that needs solved, so I know how much. This is what I'm seeing here, and functionally it seems to work as expected.

I see it, on it.

Is this the same in the default theme? I haven't done any customizations to the styles for images grid-view. I'll take a look though.

Juergen, ​I can confirm this here with a fresh install, and I know exactly what happened. It's fixed now, and I'll send a patch to Ryan later today. Thanks for reporting this, and I appreciate your patience.

@Mike, yeah that is intended. It worked out best to do it that way with all the other masthead changes. @Juergen, I'm away from a computer now, but can you verify that the image field you selected in the module settings stayed set, and that there is at least one image added to that field in your profile. @LostKobrakai, I'll look into it. Probably something for the next release. It might be something you can do now with a hook before page render, but not sure.

Nice one Nico! Looking forward to checking it out.

Lots of additional updates today. I'll get them over to Ryan tomorrow, and hopefully they will make it to the dev branch later this week. The most notable is support for multiple user templates. (Thanks to LostKobrakai for reminding me of that feature.) The module config will now pick up any templates defined in your /site/config/ For example: $config->userTemplateIDs = array(3, 43); Now you can define separate image fields and/or display name properties for each of your user templates. I don't suspect this will be a commonly used feature, but it's nice to support it, and while implementing I discovered a nice use for it myself.

Thanks. I'll check that now.

I also reworked how the top navigation is built, so it's easier to add/remove items now via hook. I'll work on getting some instructions and examples written up.

I have this working locally. I'll test a bit more tomorrow and send it to Ryan.

That module — or if you are creating your own ProcessModules and want to add your own markup.

To echo what LostKobrakai said above... I think it's too limiting to have default max-width. Building complex admin systems requires a lot of space at times, and being able to create multiple columns in the admin is a major strength. However, it's pretty easy to add the CSS yourself without modifying the theme. Check out the Admin Custom Files module for adding your own CSS that will persist across updates.

Ah, right. I forgot about that. Support for that would be good to have.

Is there some built-in way to define an alternate user template, or do you just mean allowing you to choose which template to pull the image from?

Thanks Mike.

Ryan mentioned having a few things to add that were related to modifications he hasn't committed to dev yet. Sounds like they aren't style related, but I may take one last look after he adds the things he's been working on. I'll be out of the office tomorrow, so I'm guessing it would be early next week before it's available.

I've submitted the updated theme to Ryan. Beer:30.

Thanks Wanze! @LostKobrakai, That's right. All the other executeWhatever() methods have the same path as the execute() method, which is why it's always showing as current. The fix I posted above seems to work fine here.