bernhard

Thx for the explanation. I'm aware of that, but my question was more if there is a good reason in this special case why I should use !== instead of != I tend to use !== whenever it is NECESSARY (eg when doing strpos where a 0 is something different than FALSE) and != whenever it is not necessary. That way I know instantly that the type matters... PS: Welcome to the forum ?

Voila ? https://github.com/BernhardBaumrock/RockTabulator/commit/6920de2120ade50099e269b6fa025acc98659d8a

Thx, I've read all your posts and links. "use strict" atm breaks my module. I'll have a look into that. I don't see any harm in using != instead of !== wherever I'm using it, but if you can explain why it should be a problem I'm happy to learn and change it.

Now guess what @dragan ... I've changed nothing in my code. Just pulled the changes for the not supported subdir installations and everything just WORKS! ?

Pushed a fix for RockMarkup2 and related modules (RockTabulator) not working in subdir installations. Thx for finding that @dragan

Pushed a fix for RockMarkup2 and related modules (RockTabulator) not working in subdir installations. RockFinder2 was also affected because of the wrong api endpoint url.

I don't understand what you mean. I also don't get all the errors shown in your screenshot. Or at least I don't know when they occur. Maybe you could do a short screencast? I'm working on the subdir fix now...

RockTabulator is the global object that is loaded in RockTabulator.js and therefore it's available in all files that are loaded after RockTabulator.js - which is the case for all plugins...

RockTabulator is just a way to present tabular data. Which data is completely up to you. You can list text, images, html code, whatsoever. So you can definitely also show diffs... as it's just html. The great thing about tabulator is that it supports multiline rows out of the box (aggrid has troubles with that). And this might especially be handy in your situation. http://tabulator.info/docs/4.4/format

I've had a look into the code and it does not seem to be too easy to fix. That's exactly the reason why I think that a $config->url() and $config->path() method would make a LOT of sense. It would reduce the chance of such bugs drastically... https://github.com/processwire/processwire-requests/issues/326

Thx for reminding me about that ?

I guess that's the issue! I'm never using installations in a subdir so there might be some quirks about paths and urls...

Well... restoring an existing installation should not have been the challenge ? No idea what's going on. I think the best would be to reinstall everything, clear everything (db, browser cache/cookies)... You can also try to follow the instructions there: https://github.com/BernhardBaumrock/tabulator.test and install it via GIT (make sure to specify the new-init-method branch) git clone -b new-init-concept git@github.com:BernhardBaumrock/tabulator.test.git .

Yeah sorry for that... The default db dump sucks unfortunately... Just remove those lines from the code ?

Strange, I'm also on Win10+Laragon... can you access the example directly at /tabulator/setup/rocktabulator/?name=rt12_rowactions ?

Please try the second db dump that I linked above (takes 1min on my laptop). Just tried and everything works ?

no, but that should not be the issue as it works when the grid is freshly loaded https://stackoverflow.com/a/1357151/6370411 ? That one should be better: https://transfer.sh/KFjiY/tabulator.zip Thx for having a look! PS: The second sql file is a regular sql backup while the first one is a PW interal database backup. I know that PW adds some overhead to the backup files with additional checks but I've been wondering for a while now if that is really the best... But that's a different topic ?

I've a strange problem where I got stuck developing RockTabulator and I'd really appreciate getting help. I had to refactor quite a bit and the earlier working "rowactions" now don't work any more. See the short screencast demonstrating the problem: You can install this setup easily by downloading the files here: https://transfer.sh/3YGE7/tabulator.zip (will be available for 14 days) Please make sure you are not installing it in a sub-folder!! Then just restore the database from https://transfer.sh/KFjiY/tabulator.zip and login as tabulator/tabulator The interesting parts of the code are: https://github.com/BernhardBaumrock/RockTabulator/blob/a868858bdd85d20dba056d6b07c6ecbd0c69c894/rowactions/_rowactions.js#L90-L99 https://github.com/BernhardBaumrock/RockTabulator/tree/a868858bdd85d20dba056d6b07c6ecbd0c69c894#L38 https://github.com/BernhardBaumrock/RockTabulator/blob/a868858bdd85d20dba056d6b07c6ecbd0c69c894/RockTabulatorGrid.js#L122-L139 I wonder why grid.reload() behaves differently in the ajax callback and when using it from the console. And also why the clicks on the trash icons are not intercepted correctly after reloading the grid ? Thx for your help!

This sound like you don't know them well enough ? If using RockFinder I'd definitely go with RF2 and not RF1. 8 lines of code when using RockTabulator. Maybe 10 more for applying the diff (if you have a library for that). I bet you'll save hours of work using RockTabulator, but as I don't fully understand your scenario that's just a guess... If you take the RockGrid or RockTabulator route you'll definitely be better off using pages. I'm using pages for almost anything nowadays because it makes many things a lot easier (like finding data with RockFinder, creating joins and relations, creating fields programmatically etc.; One could create something very similar to Repeater Matrix using RockGrid/RockTabulator but with a lot more options regarding the listing/display part in the backend.

Well, you can either write your own valueGetter for this column (very easy) or teach your clients how to double-click ?

Thx, one can do a of great stuff with those tools and I think not many know about that... ? But RockTabulator and RockFinder2 will make things a lot easier (if everything goes well).

Hi Psy, In aggrid you have two concepts: valueGetters (https://www.ag-grid.com/javascript-grid-value-getters/) and cellRenderers (https://www.ag-grid.com/javascript-grid-cell-rendering-components/) The filter filters the RAW VALUE of the cell, not the rendered value. You can either change the valueGetter of the cell or do another "workaround". But that's something conceptional when you are working with aggrid and you have to decide when to take which approach. Have you tried double-clicking the cell, then it should filter for the value of the cell automatically. A triple click removes the filter from that column.

I haven't had a look into repeaters yet. I'm avoiding them at all for all my projects as they brought up several problems (especially for finding data via RockFinder). I have a lot more control using regular pages for that tasks and using RockGrid / RockTabulator for presentation and as GUI. Though it should be quite easy to support Repeaters. That's what the concept of relations is for. The column would list the page ids of the repeater pages and the relations would hold the data of those pages (using regular RockFinder2 syntax $repeater->addColumns(['foo', 'bar'])). If you need further help you can PM me.

I'm happy to accept PRs ? I'd like to have a dashboard for RockMigrations that makes it easy to see which Migrations where run when, which versions are currently installed etc., but I have not enough time for that at the moment and it could be a lot easier when RockTabulator is ready ?

Yes, it does. Intellisense helps a lot working with RockMigrations: Hm... I don't understand why that would be helpful. RockMigrations was built for all non-code-related stuff. Meaning everything that's going on in the database. Everything else is in my case under control of GIT. So the idea is to create a new template php file in my dev environment, then create the new fields in a rockmigration, push everything to git, pull it to the live server, refresh the modules cache and everything is done. Does that make sense? Why would you need your approach? How did you do that? I don't understand. The module should show the version that is defined in it's module config and that has nothing to do with RockMigrations ?