jtborger

Members
  • Content Count

    32
  • Joined

  • Last visited

Community Reputation

11 Good

About jtborger

  • Rank
    Jr. Member

Profile Information

  • Gender
    Not Telling
  • Location
    The Netherlands
  • Interests
    Music, audio, etc.
  1. jtborger

    Hi Wanze, Thanks for your reply and idea. I have tried to use it while generating the page with the image I'd like to have the right orientation, which can be different for each page...but this does not work for me. It would be very nice to be able to pass options to mpdf when in the pdf template I guess. I now have fixed it with CSS rotation, this works for me for the moment. Also, it's a bit counter intuitive to find that the footer is parsed before the main template; I tried to set some variables to get parsed in the footer, but this did not work.. Perhaps a quick fix to manage? Thanks again!
  2. jtborger

    Hi, First of all, thanks for this great module!! I have tried to search the forum and this topic, but no result... If Im overlooking something please excuse me... Im trying to find a way to set the orientation of a page in the template. I now try to do this by CSS with rotate and so, but its not working the way I want it to be. I also read in mPDF docs that this is an option when creating a page. In the global module configuration it can be set, but I wantt to set it for the template. Is this possible?
  3. Hi Karl, Thanks for pointing this out to me. I had searched the forum and couldn't find anything about this. It seems that the issues you filed and my question here is the same thing... And Ryan's explaination seems fine, though I have one question for Ryan (hope he'll read this): Indeed I output some stuff before doctype, which is tried to being rendered as a markup region as I understand from your comment on the issue Karl mentions above. Since it cannot be substituted, it gets displayed anyway, as I understand it. But, why does it gets displayed the first time then anyway? It feels illogical to me to be honest. I understand that all output before doctype is seen as if it should be put in a region later on, and when not, it gets displayed. But shouldn't it be removed from output first, then searched for a region to be put in, and if not, then outputted anyway? Perhaps this logic is too advance/heavy since replacement gets done by regexes I think, but anyway.... just a suggestion. Perhaps I don't understand it correctly anyway so please excuse me for this... I still find it a very neat solution anyway!
  4. jtborger

    Hi Arjen, I know it doesn't state to support PW 3.0 on the module page, but is it difficult to adapt the language pack so it will support 3.0? I now get an installation error. Would be nice if it would install and run on PW 3.0 too. Thanks for all your effort! Jan
  5. Hi, Yesterday I found out about the relatively new markup regions functionality and I love it. The ease of use and simplicity is just what I think is typically ProcessWire and is why Im still happy I chose for PW four years ago when changing CMS/CMF. So thanks Ryan for your vision and all you put into it. That said, Im running into an issue I'm not sure what to think of it. I have enabled markup regions in config.php and it does what I suppose it should: it replaced and all. Very neatly. The only thing I discovered is that while Im debugging some issues and I use var_dump to echo some stuff, it does that two times in a row. And this only happens when useMarkupRegions is enabled. I dont get this, does it mean the template file gets called twice (and thus the script is run twice?) or is it only displayed twice, where the first time most output is erased and /or replaced by the substituted output? I don't really get whats going on there. Is this behavior normal when using markup regions? Thanks!
  6. jtborger

    Thanks Kogondo for your answer and the welcome back. Great that it is a focus point for this year. I sure do understand the limits of these goals and also the great value of the forum for more advanced usage examples. But this render($options) thing seemed so obvious fundamental to me that I wanted to know what was going (or not) on about it in general. Is there a place to file 'doc' issues or is it too early for that? I'd like to turn my 'effort' from investigating 'why hasnt this not being done yet' to something more proactive and positive.. instead of just sort of being grumpy
  7. jtborger

    Sure, could be. Although the docs are much more extended and more up to date than the earliest forum post I found about it accepting the options. But still could very well be. I dont want to sound like a whining boy who points out what is not right. I know I do but this is not my reason for posting this. Its mainly curiousity and the question if it is missed on purpose, if one is aware of it and is by choice of is just the way things are to be done... Dont wanna waste anyones time here.
  8. jtborger

    Thanks for your reply. I know there is a lot of info to find on the forums. What I tried to mention is that I in a way do not get that some basic stuff is pretty good documented in the api docs and cheatsheet and the more conceptual stuff on the docs section, but that this quite basic stuff of methods and its arguments are not to find there. If only it would state that render($options) is available but not yet documented, one can figure out to look in the forums or the source code to see what happens there... Thats what I think would be a good to do since I understand that documentation is a time consuming and not the most popular thing to do...
  9. Hi, Its been a while since I dived into PW. I'm still very happy PW being the CMS/F of my choice two years ago of a website I had to transform and maintain. Now I am developing a new one and I stumble upon this issue which I solved with some forum search. Its good to see the community is growing and a lot new documentation is up since I came here for the first time. Also the developments of PW are exciting! Good work ryan and all others! But even still I couldn't find the following: I wanted to render a partial, and I couldnt find any (API) documentation about the $page->render() method. I found in the forum I could give an array of options (['prependFile=>'']) and this worked. So problem solved. But since I like to see PW grow more, I wonder why is there no documentation about this feature in the docs I could find? Or do I look at the wrong place? If so please accept my apologies. But not at the cheatsheet nor at the docs section nor at the API docs I couldn't even find that render() accepted arguments. Is there a place where one can drop documentation issues and a documentation team to the rescue? I think we all would benefit if these 'hidden' options would be findable and in one spot instead of just going through the forums to find out that there is even more you can do with PW Thanks!
  10. jtborger

    Ah, I didn't know there was an $urlSegmentStr but that seems the right one to use indeed. Ok problem solved then.
  11. jtborger

    Ok I'll do that but I have to wipe some stuff out of it and write a bit more comments to be helpfull for newbies
  12. jtborger

    I looked at where $page->urlSegment gets retrieved, and I think for the pageNav functionality it should be done different. it reads: (Page.php, line 545) case 'urlSegment': $value = $this->fuel('input')->urlSegment1; // deprecated, but kept for backwards compatibility break; Since it says deprecated, I made a modification to markupPageArray.module line 146: if(empty($options['baseUrl'])) $pager->setBaseUrl($this->page->url . ( count($this->input->urlSegments)>0 ? '/'.implode($this->input->urlSegments,"/") . '/' : '')); Replacing $this->page->urlSegment to $this->input->urlSegments, which seems more proper to me. Should I file a bug report via Github and fork and make a pull request Ryan, or what is the best way to fix this? Or am I just messing things up by thinking this is the error while its not?
  13. Hi, I have a problem getting pagination working with urlSegments. I read the docs and the forum, and another issue comes up with sort of the same thing. The problem there was that baseUrl got set by options and was left empty, while in the code below, the baseUrl is first set by the module manager (or something deep down..) Anyhow, the problem is: my urlSegments wont get rendered in the link. I have the template setup correctly and the strange thing is, only the first part of the urlSegments shows up. Strange eh? All the others are added via $queryString I think because I added them to $input->whitelist(); But I'm not sure if this is necessary. Is it correct that normally, it would work out of the box because the urlSegments are part of the baseUrl? And, if I read the code in MarkupPageArray.module line 146, where the baseUrl is set by default, I read: if(empty($options['baseUrl'])) $pager->setBaseUrl($this->page->url . ($this->page->urlSegment ? $this->page->urlSegment . '/' : '')); This seems wrong and the reason only the first urlSegment gets added. Or, should $page->urlSegment contain all segments? And if it doesn't what could be the problem? (btw: maxUrlSegments=4, default)
  14. It is just what I did along the way, changing from multiple to single (and back, for reproduction). But I'm sure that the first, it wasn't working as expected. Strange...Is this some known quirk of PW that you 'guessed' this was the case why the strange behaviour came up? As with ->has(), I now see that isSelected() isnt necessary anymore because the multiple page array contains only selected values and has() suits another need than what i was looking for. I mark it as solved. Thanks kodongo for reminding.
  15. Well... OK there was some misunderstanding here. What you both describe here, is what I expected from the beginning. But, in my implementation, this didn't work: it gave all the possible options. Somehow. Then I fiddled a bit further and found another way. And that worked. I checked this topic today and went to my code (which didn't work) again, trying to reproduce the problem, which I couldn't (of course..? hmmm ). Now, it behaved like it should: I got only one 'channel' and Page in PageArray and that is the selected page. So it is solved.. by time and perhaps some better understanding of my own code.. Thanks for the help and my excuses for the misunderstanding of things.