Bug: ImageSizer size() and co

[Soma]

1. I noticed a strange thing when using 

$page->image->size(0,50)->url;

and the image is already 50px height the image variation won't get created!

2. I also remember someone else mention this, but haven't been able to search

When I have a image that has like 200x800px (extreme portrait) and using upscaling=false

$page->image->size(200,100)->url;

will create an image that isn't 200x100 !? I think it has to do with the ratio and the upscaling feature. When I set upscaling=true it doesn't work. Anybody able to reproduce.

[horst]

@soma: this is already filed as a Github issue and also fix is posted / committed. Ryan has said that he will work on that. (There is Github conversation and also posts somewhere in the Forums here, but I'm on mobile and Not able to link to it)

I think currently it could be that some other parts (language) has higher prio and he is only one man. (?? maybe ??)

[Soma]

I'm not able to find it though.

[adrian]

Is this the post you guys are looking for:

http://processwire.com/talk/topic/2960-upscalingfalse-not-working-when-one-dimension-set-to-0/

[horst]

on GitHub: https://github.com/ryancramerdesign/ProcessWire/pull/237

and https://github.com/horst-n/ProcessWire/commit/33e5b168a11bf2c6648d0ae7dc7e8d8c88e56305

in Forum: http://processwire.com/talk/topic/3768-processwire-231-dev-branch/page-5#entry43253

I'm on hurry, ...