Bugs with regards to custom Payment Module

[csaggo.com]

Hi @kongondo

long time since we spoke, i am in the process of going live with another padloper shop as the first we started is still on hold on customer side...

i just developed a custom payment module for klarna hostet payment pages.

two things did not work as expected:
 

in the __construct method i had to put 
 

(array $klarnaConfigs = null)

instead of just 

array $klarnaConfigs

as parameters, because when it instatiates the module the first time on padloper - addons page, it wont be able to, as it does not pass configs there.


the second issue is more important:
in PadloperUtilites the methods getNonCorePaymentProvidersIDs, getNonCorePaymentProvidersNames, getNonPaymentCustomAddonsIDs, getNonPaymentCustomAddonsNames will not work if i am not logged in as a superuser (so being able to access all pages). I had to add check_access=0 to the processwire-selectors there.

this should be fixed for future updates.

[kongondo]

Hi @csaggo.com,

9 hours ago, csaggo.com said:

as the first we started is still on hold on customer side...

I was looking forward to a showcase 😄 .

9 hours ago, csaggo.com said:

i am in the process of going live with another padloper shop

Excellent! Congrats!

9 hours ago, csaggo.com said:

two things did not work as expected:

Thanks for reporting. Yes, I noticed these a few weeks ago and fixed the code. The fixes will be available in the next release.

9 hours ago, csaggo.com said:

in the __construct method i had to put 
 

(array $klarnaConfigs = null)

I have something similar in the code fix, i.e. $configs=[].

9 hours ago, csaggo.com said:

the second issue is more important:
in PadloperUtilites the methods getNonCorePaymentProvidersIDs, getNonCorePaymentProvidersNames, getNonPaymentCustomAddonsIDs, getNonPaymentCustomAddonsNames will not work if i am not logged in as a superuser (so being able to access all pages). I had to add check_access=0 to the processwire-selectors there.

True. All already have the fix per your description.

Thanks!