Soma Posted February 16, 2013 Share Posted February 16, 2013 In my theme I have changed CSS to show page actions when hovering the row. Now there seems to be a little issue with then I hit move when the page is not selected yet, I can't move the page. I then press cancel and hit move again and it works. It only works when the page is open but not when closed. I'm not sure why that is but found it surprising. Link to comment Share on other sites More sharing options...
Martijn Geerts Posted February 16, 2013 Share Posted February 16, 2013 Move needs the (extra) click. Barely in memory, think mindplay.dk reported it before. I had the same issue on a tweeked admin & put it back to the default. Link to comment Share on other sites More sharing options...
Joss Posted February 16, 2013 Share Posted February 16, 2013 Move is the thing that has messed up my nice action button idea. The JS for it seems to be very path specific, so when I did my nice drop down with inevitable additional markup, it no longer knew where it was. I must admit, it would be nice to just grab and move items in the same way as you can with template fields - lots quicker. What I would love to do (but I cant work out how) is layout each item like so (going from left to right across the table row) Expand - a familiar Arrow Title - Clicking on it goes straight to edit, if that is allowed Actions Icon - Opens a little drop down for delete, publish/unpublish, new, copy, etc Move - a move symbol. grab and move immediately rather than click and then move as a separate action Personally I would split those so the action and move icons are to the far right of the row. This takes into account the things people do most often while making additional options the same number of clicks as now. Apart from speeding up some operations, That also compresses down better in small viewports. Link to comment Share on other sites More sharing options...
ryan Posted February 17, 2013 Share Posted February 17, 2013 I had the same issue on a tweeked admin & put it back to the default. Same here. I couldn't figure out how to make it compatible with the move action. Spent a couple hours on it and than gave up. We'll eventually figure it out. Link to comment Share on other sites More sharing options...
ryan Posted February 17, 2013 Share Posted February 17, 2013 I must admit, it would be nice to just grab and move items in the same way as you can with template fields - lots quicker. Lots more dangerous too. Dragging around the fields in a template has no effect on the front-end of a site. It's a totally safe action. Dragging around your pages can break external and internal links, hurt your SEO, or even worse, break your entire site. Move and delete actions are intentionally not as obvious as they would be in an actual file manager. At least, I don't want my clients performing these actions unless they really really mean it. Web sites aren't file systems. In web sites, stuff really shouldn't get moved or deleted very often (it's bad for business). In a file system, these actions are very common. But in a web site, they should be avoided. Though I understand that as developers, everything we do is intentional and we'd like it to behave like a file system for our convenience. But ultimately the admin panel is balanced towards both the client and the developer. The client will be the primary user long term, so feel it's a careful balance. To be honest, I was reluctant to even have a "move" action in the Page List, as it's a lot safer and more intentional to move stuff around using the Settings > Parent field on each page's settings tab. 1 Link to comment Share on other sites More sharing options...
Soma Posted February 17, 2013 Author Share Posted February 17, 2013 I didnt wanted to discuss how it should work, im with ryan here but it seems it breaks when i show actions in hover then click move while hovering. Because i cant give my clients a broken page move and i think other themes will have the same issue. Link to comment Share on other sites More sharing options...
Martijn Geerts Posted February 17, 2013 Share Posted February 17, 2013 Soma, you're right about those other themes. They suffer the same issue. Link to comment Share on other sites More sharing options...
Soma Posted February 18, 2013 Author Share Posted February 18, 2013 I pulled a request which fixes this behavior. https://github.com/ryancramerdesign/ProcessWire/pull/163/files#L0L533 2 Link to comment Share on other sites More sharing options...
Joss Posted February 18, 2013 Share Posted February 18, 2013 Hi Soma - can I test this somehow? I am wondering whether it is the same issue that effected by actions button, because that also meant that when you selected "move" you hadn't actually selected the row first (which I hadn't thought about before). Link to comment Share on other sites More sharing options...
Soma Posted February 18, 2013 Author Share Posted February 18, 2013 Yeah sure, you have to get the js from here and replace it. https://github.com/somatonic/ProcessWire/tree/53e02a6bdc07eaf42eb425f84cb5ce6f90706c99/wire/modules/Process/ProcessPageList Link to comment Share on other sites More sharing options...
Joss Posted February 18, 2013 Share Posted February 18, 2013 This should be interesting. I tried to modify that file my self to see the implications, but all I managed was to scare next doors cat EDit: Okay, I think mine is still another issue. Well, worth a try! Link to comment Share on other sites More sharing options...
ryan Posted February 18, 2013 Share Posted February 18, 2013 Thanks for the PR Soma. If you solved this one, I owe you a beer (or a case of beer). Link to comment Share on other sites More sharing options...
Soma Posted February 18, 2013 Author Share Posted February 18, 2013 Thanks for the PR Soma. If you solved this one, I owe you a beer (or a case of beer). Thanks for the beer because it works. Took me only 5 minutes . I knew exactly in what behaviour it failed and I even painted in my head why this could be and it was exactly that and just a really minor change. Prosit! 2 Link to comment Share on other sites More sharing options...
Martijn Geerts Posted February 18, 2013 Share Posted February 18, 2013 Soma, you're the best..... 1 Link to comment Share on other sites More sharing options...
Wanze Posted February 18, 2013 Share Posted February 18, 2013 Thanks for the beer because it works. Took me only 5 minutes . I knew exactly in what behaviour it failed and I even painted in my head why this could be and it was exactly that and just a really minor change. Prosit! C'mon be honest and confess that it actually took you 6 minutes 1 Link to comment Share on other sites More sharing options...
ryan Posted February 20, 2013 Share Posted February 20, 2013 Thanks Soma, I've brought this in and just testing locally so it should be in the dev branch very soon. 1 Link to comment Share on other sites More sharing options...
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now