Comments module translation

[doolak]

As the administration backend of the Comments module is not translated and i have a costumer which does not speak English i am trying to make it translatable.

I already made some parts translatable (Dropdown with "Pending", "Approved", "Spam" and "Delete" and the status which is shown at the right side ("Approved" and "Pending") - now i am trying to translate this part:

"\n\t\t\t<span class='CommentsAdminItemBy'>Comment #$num Posted " . date('m/d/y H:i', $comment->created) . " by " . htmlentities($comment->cite, ENT_QUOTES, 'UTF-8') . "</span>" . 

As this is my first attempt to make a module translatable i made it like this, which works fine for my personal use:

"\n\t\t\t<span class='CommentsAdminItemBy'>".$this->_("Comment")." #$num "
.$this->_("Posted") ." ". date('m/d/y H:i', $comment->created) ." "
.$this->_("by"). " ". htmlentities($comment->cite, ENT_QUOTES, 'UTF-8') . "</span>" . 

But of course it's not very smart to have the words "Comment", "Posted" and "by" translatable as seperate strings and as i saw in the documentation there seems to be a possibility using something like:

$out = sprintf(__("Created %d pages."), $count); 

I tried to make the string translatable in a similar way but i cannot get it to work - would be great if somebody could help me with the part above to show me the right direction.

[Martijn Geerts]

Think you just forget the $this

[doolak]

$out = sprintf(__("Created %d pages."), $count); 

That code was just an example from the Code Internationalization (i18n) docu (http://processwire.com/api/multi-language-support/code-i18n/) and as far as i understood it right, sprintf or printf are used instead  of the $this->  - i just cannot get the part to work where you use a variable within the translatable string.

[Soma]

Like this

$out = sprintf($this->_("Created %d pages."), $count); 

for within modules.

[Martijn Geerts]

 sprintf is just a php function to return a formatted string.

sprintf on php.net

[ryan]

Doolak, I will go ahead and make this translatable and included in the core this week -- didn't realize I'd missed this one. 

[doolak]

Doolak, I will go ahead and make this translatable and included in the core this week -- didn't realize I'd missed this one. 

Great, thanks - that will make it unnecessary that i have to replace the InputfieldCommentsAdmin.module everytime after an update - or use a duplicate of that module just for the translated part ;-)

But certainly it was a good thing for me to learn a bit about the translatable strings - and thanks to Martijn and Soma, i managed it to include the #$num - part now with the sprintf function:

"\n\t\t\t<span class='CommentsAdminItemBy'>".sprintf($this->_("Comment #%d Posted"),$num)." ". date('d.m.Y H:i', $comment->created) ." "
.$this->_("by"). " ". htmlentities($comment->cite, ENT_QUOTES, 'UTF-8') . "</span>" . 

@ryan: If you will be working on the InputfieldCommentsAdmin.module making it translatable, i have a fews suggestions for the module:

1. Don't know if this makes sense, but would be nice to have a possibility to change the date format in the field settings

2. If you sort newes to oldest - the comment numbers stay counting from 1 to ... - they should be inverted, too.

3. Would be great if instead of "Spam is automatically deleted after the amount of time specified in the field configuration." one could display the amount of time or the date the Spam will be deleted

[doolak]

Ahh, forgot to mention: In the FieldtypeComments.module there are several strings untranslated, too (all the field settings and the text of the notification email).

[ryan]

Sounds good, I'll get both files updated.