Curious image API issue

[JayGee]

This short script loops through some images from an XML feed and pushes new ones to an image field. It all works perfectly, except for some reason the last image (only) in the loop each time doesn't receive the image description... can everyone spot why? TIA! ? 

foreach ($propertyImages as $img) {

            $fileName = trim($img[0]);

            if ( !empty($fileName) ) {
                
                $imgPath = '../property_data/'.$fileName;
    
                if(file_exists($imgPath) && !in_array(strtolower($fileName),$currentImages)) {
                    $p->property_images->add($imgPath);
                    $p->save();
                    $newImg = $p->property_images->last();
                    $newImg->description = $img[1];
                    $p->save();
                }

            }            
            
        }

 

Edited February 26, 2020 by Guy Incognito
Problem changed slightly!

[Robin S]

Give this a try:

// Create WireUpload instance (it doesn't matter what name you give it)
$wu = new WireUpload('foo');

$file_path = '/the/path/to/your/image.jpg';
// Get the basename only
$basename = basename($file_path);
// Sanitise basename the same as would be done if the file was uploaded via admin
$sanitised_basename = $wu->validateFilename($basename);
// Look for an existing file with that sanitised basename
$existing_file = $page->images->get($sanitised_basename);
// Add the file if it doesn't exist
if(!$existing_file) $page->images->add($file_path);

 

[JayGee]

Thanks @Robin S - although, not sure if I'm being thick here ?, but will that change anything on the specific problem of the final image's description not being updated? The rest of my loop seems to work fine, but for some reason it doesn't apply the description to the final image/iteration. Really odd.

[Robin S]

37 minutes ago, Guy Incognito said:

but will that change anything on the specific problem of the final image's description not being updated?

I think you edited your original post and topic title, right? My answer was for the original question and isn't relevant now that you've changed it. Better to mark a topic as solved and start a new topic in such situations I think.

[JayGee]

On 2/27/2020 at 11:11 AM, Robin S said:

I think you edited your original post and topic title, right? My answer was for the original question and isn't relevant now that you've changed it. Better to mark a topic as solved and start a new topic in such situations I think.

Oh sorry you got me!! I was originally going to post two threads for the slightly different (but related) issues. But shortly after posting I fixed one of them and as nobody had seen or responded to it yet (or so I thought) I edited it into one post... but you must have responded at the same time. Apologies ?