Jump to content

Jo J

Members
  • Posts

    32
  • Joined

Recent Profile Visitors

The recent visitors block is disabled and is not being shown to other users.

Jo J's Achievements

Jr. Member

Jr. Member (3/6)

20

Reputation

  1. I vaguely recall this happening to me too. But that was a while back for me to know how it got fixed. Have you tried checking your httpHosts in config is complete? $config->httpHosts = array('localhost','yourdomain.com') or ensure you have the correct index.php & .htaccess that goes with ProcessWire 3.0.229?
  2. I use unix sockets in my dev environment too and am surprised to find just one of you here. I opened an issue to see if it gets in.
  3. I used to do this. Sometime before version 3.0.184. I symlinked just the wire folder inside multiple installations...until I started getting duplicate module errors. I don't remember if it was due to class loading issues or minor differences in file path/directory structure between installations but there was definitely conflicting issues. It could have been cache related too. It didn't work for me.
  4. JSYK, this issue has been fixed by Ryan. His preferred fix also addresses when the #login_start gets stale via cache which is important. Issue #1839 corrects ProcessLogin refresh issue when client and server have different times for UTC/GMT. The fix has been pushed to the current dev branch as of today for continued testing.
  5. I also experienced this issue. Following on netcarver's advice above, it turns out that my device clock is ahead by over 5 minutes. I adjusted my device time & it worked but thought a broader solution might be better. This fixed my issue. var startTime = parseInt($('#login_start').val()); // GMT/UTC // var maxSeconds = 300; // max age for login form before refreshing it (300=5min) var clientStartTime = Math.floor(new Date().getTime() / 1000); var clockDifference = clientStartTime - startTime; var maxSeconds = 300 + clockDifference; But I prefer it be done in the core, so I opened an issue in github.
  6. I ought to have known better. It's not a title issue, rather it's the name--that I should be validating for existence. (And the sanitizer->selectorValue doesn't help either. So, here's what worked: --same-- $title = $row['title']; $name = wire('sanitizer')->name($title,true,128,'-'); $p = wire('pages')->get("name={$name}"); // check if name already exists if(0 < $p->id) { continue; } --same-- Is there a better answer?
  7. I thought I solved it with addslashes($title). But it didn't work either.
  8. I seem to remember this happen to me too. I came across @horst's comment to avoid it: with old wire version, make a db dump, but for all caches use drop table, create table, without inserts. Or, if you are able, remove the inserts in the live db. remove all files within the cache disc subdirectories switch wire folder, load the admin for 2 or 3 times
  9. Using the ff snippet I derived from one kind member here (sorry, I can't remember & I also cleared my browser cache), I cannot figure out how to avoid double quote enclosures on titles with commas that are being added in the admin: while($row = $files->getCSV('importwines.csv',['separator' => '|'])) { $title = wire('sanitizer')->selectorValue($row['title']); $title = wire("sanitizer")->text($title, array("maxLength"=>128)); // fetch and sanitize the title $p = wire('pages')->get("title={$title}"); // check if it already exists if(0 < $p->id) continue; // move on to the next record if it exists $p = new Page(); $p->template = "wine-item"; $p->parent = "wine-list"; $p->title = $title; // use the sanitized title $p->vintage = wire("sanitizer")->int($row['vintage']); $p->price = wire("sanitizer")->float($row['price']); $p->category = wire("sanitizer")->int($row['category']); $p->location = wire("sanitizer")->text($row['location'], array("maxLength"=>128)); $p->of(false); $p->save(); } These are the escape characters i've tried: "vintage"|"title"|"price"|"location"|"category" 2020|"Cross Barn Chardonnay\\, Sonoma Coast"|105.00|"United States"|1324 2020|Truchard Chardonnay, Carneros|115.00|"United States"|1324 2018|"""Grgich Chardonnay, Napa Valley"""|170.00|"United States"|1324 Undesired results as page titles in the admin includes the double quotes: "Cross Barn Chardonnay , Sonoma Coast" "Truchard Chardonnay, Carneros" "Grgich Chardonnay, Napa Valley" These 3 are also being excluded by a broad $page->find($selector) selector filter unless I manually delete the double quotes in the admin. I think the $sanitizer->selectorValue() above also calls the new selectorValueV1() & selectorValueV2() because I am using PW3.0.210. Is there another sanitizer I should be using for the title?
  10. I have no access to the module to test it myself but.. have you tried enclosing it with html tags? html:<h1>Thank you!<br>We will contact you soon.</h1>
  11. I also see your point in wanting to put it all in the same flow. It might take more time, but I would explore the module in depth coz after quick inspection the necessary methods for registration are hookable.
  12. ...you'd have to add $loginRegister = modules()->get('LoginRegister'); $content = $loginRegister->execute(); echo $content;
  13. Yes you can. I have something similar for a blogging site. Copy/edit/improve here what makes sense to your case... wire()->addHookBefore('LoginRegister::renderList', function($event) { $links = array(); $defaults = $event->arguments(0); if(user()->isLoggedin()) { if (user()->hasRole('member')) { $links['member-list'] = "<a href='" . $this->wire('pages')->get('/directory/')->url . "'>" . $this->_('Member Directory') . "</a>"; } if (user()->hasRole('author')) { $links['blog-admin'] = "<a href='" . $this->wire('pages')->get('/utilities/blog-admin/')->url . "'>" . $this->_('Blog Admin') . "</a>"; } if (user()->hasRole('admin')) { $links['back-admin'] = "<a href='" . $this->wire('pages')->get('template=admin')->url . "'>" . $this->_('Page Admin') . "</a>"; } } else { if($event->object->allowFeature('register')) { $defaults['register'] = "<p>Don't have an account yet? Members can <a href='./?register=1' class='inline'>" . $this->_("register for an account") . "</a></p>"; } } $links = array_merge($links, $defaults); $event->arguments('items', $links); });
  14. Was curious too. I searched and, yes, it was brought up before. Here. TLDR. As mentioned there, it becomes more important when multiple programmers are (or will be--next guy after you) involved. Also mentioned, was the additional benefit of self-documentation when you follow a naming convention. To answer your question, being all implementors of the PW architecture (and PHP), it probably makes sense for us to be consistent with it. (Compared to other frameworks PW made it easy for us.) Still, I did another round of refactoring recently and felt happier after. None of my direct templates have echos. Reduced them to about 10. Since they mostly describe a type of page (model), it's a 1 word all-lowercase filename. I have a couple of controller classes that I camelCased with an .inc extension so the admin wont see it...and added an underscore so its listed on top. I guess we all have different reasons.
×
×
  • Create New...