A little v2.5+ page edit tab weirdness

[netcarver]

Anybody seeing any weirdness in 2.5+ with tabs added to the page edit forms by either Nik's PageReference module or Soma's Template Notes module?

The fieldset in the tabs those modules add to the page form seem to always migrate below the save button. Like this...

Doesn't matter if its the legacy theme or Tom's new theme. I don't ever remember these modules having a problem prior to 2.5 -- but I've not tried them in ages.

[Soma]

There looks like there was some changes to the way the page edit form is built or css related. I just build a new wrapper and append it to form. The wrapper gets inserted at the end, but since the submit button is also a inputfield added to the form it is before newly added tabs afterwards the form is built already. I tried and found that prepend the wrapper to the form works around this issue (until next time). While at it I found a missing CSS class in Reno in 2.5.3 where hidden labels would show in the forms.

Regarding tabs. I'm not sure if that's really a long term "the best way" to add tabs, I also tried to find a way using the $this->tabs used by ProcessPageEdit but that is protected and after all maybe not suitable to add tabs at certain position since you never know what there will be. A float right hack with css would position the tab at the right, but I don't know if that's maybe used by some other theme already and so on. So no real dedicated fool proof way in PW I guess.

I'll see if I can test this with 2.4 and or 2.3 and release a fix.