[potential bug] edit popups "allowed child templates" and "allowed parent templates" don't save

[poljpocket]

Hi all,

I am dealing a very strange bug and I am not sure if this only happens for me, or if you have experienced the same as well.

It's about the popups which open when you directly edit allowed child/parent templates in the "Family" settings. For me, sometimes they don't save (e.g. the popup closes and nothing happens). It feels intermittent and I couldn't dig deep enough yet to get to something 100% reproducible. It is now, see below.

Do you guys mind trying the following:

On a vanilla installation of PW, add two templates. Next, edit the family settings for one of them.

1. Add the other template as "allowed as child" template. To my best knowledge, you could also choose "allow as parent" here.
2. Save the template
3. Open the corresponding family edit popup (click the template name in the list).
4. In the popup, add the first template as "allowed as parent". To my best knowledge, that also works the other way around for allow child (see above).

Now comes the sketchy part:

• When I click "Save" immediately, the popup closes but nothing happens (you can check the Network tab in DevTools, it shows absolutely no requests for me.). This is not the expected result.
• When I switch to any of the other tabs available in the popup and then click "Save", the popup closes and the changes are saved. This is the expected result.

And it gets sketchier:

• Open the edit popup again and remove the parent entry, then immediately click "Save". Watch the changes get saved now without issue.

Also, it seems as if this is completely agnostic of the PW version. It happens on the dev branch, as does it happen in all of the most recent stable versions: 3.0.246, 3.0.229 and also 3.0.210. This makes me feel like it's either a very rare and old bug or something systematically wrong on my side.

Do you guys experience the same? I want to gather some more experience before I am writing an issue about it. Thank you!

EDIT:

Whilst testing around a bit more, I can shed some light into the issue:

Instead of me needing to switch tabs, I can just click anywhere in the popup (or press TAB) to have the save happen successfully afterwards. I think I can narrow the problem down to the select field not correctly losing focus when the "Save" button is clicked immediately. That might also explain why the "remove" action is unaffected.

So we should gather information about the Browsers now?

Mine is Chromium 138

I tested on Brave 80 (based on Chromium 138) as well, same result.

In Firefox 141, this does NOT happen.

EDIT 2:

It's also not any extensions interfering as far as I can tell. I have tried a vanilla browser as well for both Chromium and Brave.

Edited August 5 by poljpocket
add more info, twice

[matjazp]

I'm on Edge 138.0.3351.121 and can't replicate. Maybe I'm not fast enough?

[Jo J]

If I understood your instructions correctly, it appears to work for me. Both in Firefox Dev 141.0b2 as well as in Chrome ver 138.0.7204.184 

 

• PHP 8.3.23
• Apache/2.4.64
• Processwire 3.0.251

 

[poljpocket]

You did exactly what I did, but let me show you how it works for me. This must be a browser thing!

First, I am not clicking anywhere before clicking "Save" in the popup. Nothing happens. Next, I do the same again and click (by changing tabs) before clicking "Save". Result is as expected.

 

 

[poljpocket]

And for good measure, on the dev version, same story:

 

 

[Jo J]

It looks like an issue with the JqueryWireTabs module--but i'm just guessing. Have you tried switching admin themes to see if there is any change in behaviour?

[poljpocket]

So I tested a bit more:

The same happens on the legacy admin theme.

I think it's a problem with AsmSelect:

Using a Page Reference field with AsmSelect as a starting point. This is the field the family edit screen uses for parent/child relationships. When I select a page inside a modal popup (you can get any edit screen in a popup by long-pressing the "Edit" button in the page tree), I can't save. Literally nothing happens unless i click anywhere in the modal other than the select input of the AsmSelect and then the "Save" button will start working.

The field config:

Screencast of what I explained above on dev branch:

 

@Jo J to reiterate on your suggestion, that "clicking anywhere" includes clicking on another tab. It's the same. Means, it shouldn't have anything to do with the JqueryWireTabs module.

The result is, clicking anywhere will make the select field lose focus and thus the change is registered.

I am using a completely vanilla Chromium 138 on Arch Linux with Wayland. Maybe it's something outside of the browser.

Edited August 7 by poljpocket