vscode edit links breaking on latest vscode

[bernhard]

Hey @adrian tracy debugger creates links like this: vscode://file/%2FUsers%2Fbernhard%2Fbaumrock%2Fbaumrock.com%2Fsite%2Fready.php:8

With the latest vscode these links don't work any more. Turns out that the issue is the file// instead of file/

I've changed that in RockFrontend and RockMigrations and all fine again. See https://github.com/microsoft/vscode/issues/197319

Not sure why I get those %2F instead of / ? Would be great if you could push a fix for this. I tried to find it myself but seems I didn't find the right spot.

Thx in advance!

PS: Just did an update to the latest version and got this error:

Error: Undefined constant Tracy\Debugger::Version in /var/www/html/site/modules/TracyDebugger/tracy-2.10.x/src/Tracy/Bar/assets/bar.phtml:15 Stack trace: #0 /var/www/html/site/assets/cache/FileCompiler/site/modules/TracyDebugger/tracy-2.10.x/src/Tracy/Bar/Bar.php(119): require() #1 /var/www/html/site/modules/TracyDebugger/tracy-2.10.x/src/Tracy/Helpers.php(364): Tracy\Bar->Tracy\{closure}() #2 /var/www/html/site/assets/cache/FileCompiler/site/modules/TracyDebugger/tracy-2.10.x/src/Tracy/Bar/Bar.php(120): Tracy\Helpers::capture(Object(Closure)) #3 /var/www/html/site/assets/cache/FileCompiler/site/modules/TracyDebugger/tracy-2.10.x/src/Tracy/Bar/Bar.php(89): Tracy\Bar->renderPartial('main') #4 /var/www/html/site/modules/TracyDebugger/tracy-2.10.x/src/Tracy/Debugger/DevelopmentStrategy.php(123): Tracy\Bar->render(Object(Tracy\DeferredContent)) #5 /var/www/html/site/assets/cache/FileCompiler/site/modules/TracyDebugger/tracy-2.10.x/src/Tracy/Debugger/Debugger.php(309): Tracy\DevelopmentStrategy->renderBar() #6 [internal function]: Tracy\Debugger::shutdownHandler() #7 {main} (stored in /var/www/html/site/assets/logs/tracy/exception--2023-11-05--11-52--6565da4fb6.html)

PPS: Weird - now everything seems to work with the old links as well! Don't know what's going on, but I think changing to the official vscode://file/... format would be a good idea nonetheless ? 

[adrian]

Hey @bernhard - you can change this in the module settings in the "Editor Links" section.

Just change: 

vscode://file/%file:%line

to:

vscode://file%file:%line

I'll change the default value and note in the next version.

[adrian]

14 hours ago, bernhard said:

PS: Just did an update to the latest version and got this error:

Error: Undefined constant Tracy\Debugger::Version in /var/www/html/site/modules/TracyDebugger/tracy-2.10.x/src/Tracy/Bar/assets/bar.phtml:15 Stack trace: #0 /var/www/html/site/assets/cache/FileCompiler/site/modules/TracyDebugger/tracy-2.10.x/src/Tracy/Bar/Bar.php(119): require() #1 /var/www/html/site/modules/TracyDebugger/tracy-2.10.x/src/Tracy/Helpers.php(364): Tracy\Bar->Tracy\{closure}() #2 /var/www/html/site/assets/cache/FileCompiler/site/modules/TracyDebugger/tracy-2.10.x/src/Tracy/Bar/Bar.php(120): Tracy\Helpers::capture(Object(Closure)) #3 /var/www/html/site/assets/cache/FileCompiler/site/modules/TracyDebugger/tracy-2.10.x/src/Tracy/Bar/Bar.php(89): Tracy\Bar->renderPartial('main') #4 /var/www/html/site/modules/TracyDebugger/tracy-2.10.x/src/Tracy/Debugger/DevelopmentStrategy.php(123): Tracy\Bar->render(Object(Tracy\DeferredContent)) #5 /var/www/html/site/assets/cache/FileCompiler/site/modules/TracyDebugger/tracy-2.10.x/src/Tracy/Debugger/Debugger.php(309): Tracy\DevelopmentStrategy->renderBar() #6 [internal function]: Tracy\Debugger::shutdownHandler() #7 {main} (stored in /var/www/html/site/assets/logs/tracy/exception--2023-11-05--11-52--6565da4fb6.html)

Yeah, I know about this and not sure there is an easy way around it, but it fixes itself after a modules refresh.

[bernhard]

7 hours ago, adrian said:

Yeah, I know about this and not sure there is an easy way around it, but it fixes itself after a modules refresh.

Ok great, that's fine, thx ? 

[adrian]

Actually, something to consider - what about on Windows - wouldn't that need the extra slash because instead of the filepath starting with a slash it would start with a drive letter.

[bernhard]

@adrian thx. Actually I'm not sure if that is still an issue. First they have pushed something to vscode and closed the issue: https://github.com/microsoft/vscode/issues/197319

And second it seems to work on my end again. No idea what's going on...