Problems with inserting image thru TinyMCE

[Sylvio]

Hi,

I am not able to solve this issue I'm having with adding images thru the TineMCE editor, specifically when choosing an image from another page! If I already assigned an image to this page there is no problem.

I am getting the insert image dialog, when I select another page that containes images, I get to see the list of images, select one, resize, etc..... When I finally select to 'Insert This Image', I am getting a broken image link.

When I view the html in TinyMCE it looks like this '<img class="align_center" src="undefined" width="284" height="188" alt="ShowLED Classic LED starcloth Plopsaland Indoor Coevoorden" />'

So the attributes are propagated EXCEPT the 'src' attribute, it says undefined!!

Also one other thing, but I think this is configuration of CSS, image alignment does not work, it always positions to the left?

This is pretty urgent

Sylvio

[apeisa]

Which version you are using? 2.0 or 2.1?

[ryan]

What browser (and version)? There are a few known issues with Internet Explorer (7, 8, haven't tried 9) which I've been unable to resolve in a manner I'm happy with. That's one reason why I'm looking at developing an alternate Inputfield type that uses the CKEditor instead. So I don't recommend using the TinyMCE Inputfield with IE (7,8) at present: though basic edits should be fine, but anything that involves popup dialogs are buggy in IE.  Mozilla and Webkit browsers should work well, and if a bug is found in these it's something I can fix. In addition to knowing what browser (and version) you are using, I have the same question as Apeisa: which PW version and are you running the latest commit of that version?

[Sylvio]

I am using 2.0, I don't think 2.1 is suitable for production yet

Latest commit, just installed it now

Browser Chrome 12.0.742.91, Firefox 4.0.1 same issue

[ryan]

Thanks for the report. I was able to duplicate it and am now working on a fix.

[ryan]

I've just posted a fix. Strangely, I could duplicate it in 2.1 but not 2.0. Then I discovered I had an update already waiting in the 2.0 source for this particular problem and it just hadn't been added to Git or committed. I must have fixed it at some point, been distracted, and completely forgot about it. But now it is committed in both the 2.0 and 2.1 source. Please let me know if this fixes it for you? Thanks again for letting me know of this problem.

https://github.com/ryancramerdesign/ProcessWire/commit/03b60394fddc186aa8cfe3dd9f4de7670dc73c8a

I wasn't able to duplicate the image alignment issue that you mentioned. Are you referring to image alignment in the actual TinyMCE editor, or in your site? If it's in your site, note that you have to add your own classes to your site's stylesheet. This is what I have in the default profile, which may serve as a good solution or starting point for further tweaks:

/**
* Alignment styles that are used by the InputfieldTinyMCE for 
* positioning images in bodycopy. If you are using this field type, 
* you may want to include these or similar styles in your site.
*
*/
.align_left {
        float: left;
        margin: 0 1em 0.25em 0;
}

.align_right {
        float: right;
        margin: 0 0 0.25em 1em;
}

.align_center {
        display: block;
        margin-left: auto;
        margin-right: auto;
}

[Sylvio]

Super, thanks for the quick fix, I'll test it asap....

About the alignment, yes it's not in TinyMCE, that works fine, it's on my site, strangly enough I knew this, I think I need a good long sleep

I'll let you know how the fix turned out

[Sylvio]

Ryan

Thanks, problem solved!

Cheers

[ryan]

Great! glad that fixed it, thanks for letting me know.