RockIcons Backend Error after Upgrade of RockFrontend and Less modules

[gebeer]

Hi @bernhard,

after we upgraded RockFrontend and Less to latest versions in a project, we got this error in the backend:

This is caused by the call to $this->createAssets() call in RockIcons.module.php init() method.

Further tracing it back, we found that the L1101 in RockFrontend.module.php is the cause.
Changing $lessFile = $this->getFile($lessFile); to $lessFile = $this->getFile($lessFile, true); fixes it.

The getFile method has default false for $forcePath and returns an empty string when $forcePath is set to false  which causes L1102 to throw a WireException. and ultimately leads to the error message from wire/core/ModulesLoader.php around L167. When passing $forcePath = true, the correct file path is returned. We checked and in our setup the createAssets method in RockIcons.module.php is the only caller of the lessToCss method in RockFrontend.

This might be related to your refactor of RockFrontend/RockDevTools.

While it is only happening when logged in as superuser, it still is troublesome because the error in the backend never goes away and icons don't display in the frontend. Frontend is still  functional when not logged in as superuser. 

 

[bernhard]

Hey @gebeer thx for that report! I have pushed your suggested fix on the dev branch of RockFrontend 🙂 

[gebeer]

24 minutes ago, bernhard said:

Hey @gebeer thx for that report! I have pushed your suggested fix on the dev branch of RockFrontend 🙂 

Wow, that was quick. Thanks. Will wait until it goes into main and then update through module interface.