gornycreative Posted June 25, 2023 Share Posted June 25, 2023 Regarding the "include version in admin footer from package.json if it exists" feature - I'm a little confused about what this is for. The code points to the package.json in the site root, not the module root. https://github.com/baumrock/RockMigrations/blob/d957caeb5e4607d0b0afbb00ef18cdcb52895d83/RockMigrations.module.php#L923 But I don't think Ryan stores the processwire version there - which version number is this supposed to show? RockMigrations? My site root package.json looks like: { "dependencies": { "htmx.org": "^1.8.6", "jquery-typeahead": "^2.11.1" } } I started looking into this because I was getting a stdClass::$version warning. 1 Link to comment Share on other sites More sharing options...
bernhard Posted June 26, 2023 Share Posted June 26, 2023 Hey @gornycreative thx for the question ? I've setup automatic version numbers (https://processwire.com/talk/topic/28235-how-to-get-fully-automated-releases-tags-changelog-and-version-numbers-for-your-module-or-processwire-project/) not only for all my modules but also for all my projects. Also I have a staging and production system for many of them and there it is nice to know with version of the project is currently deployed. Maybe staging is at 1.2.3 whereas live is still at 1.2.0 Does that make sense? Should I add an explanation somewhere or change wording to make it clearer? 1 Link to comment Share on other sites More sharing options...
gornycreative Posted June 26, 2023 Author Share Posted June 26, 2023 If you want - I'm not sure if others just haven't ticked the box and gotten the errors, but if its more internal use for you I won't bother with it. Thanks. Link to comment Share on other sites More sharing options...
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now