New URL hooks do not consider user language

[Juergen]

In PW version 3.0.173, new hooks for urls were introduced (ProcessWire 3.0.173 core updates: New URL hooks).

The problem is, I am using translatable strings inside the hook, but the language is always default. I can remember there was also a problem within another hook and Ryan mentioned that this is the usual behaviour, because language is always detected before and after the hook but not within.

Maybe someone struggles with the same problem and has found a solution to post it here? I need translatable strings inside this hook.

[bernhard]

I guess you are adding the hook in init(). If you add it at ready() it will work. Init() is too early for the system to know anything about the user or the language...

I think my explanation above is wrong - it works because of the way my language switcher for tracy works! I've updated the code which works for me:

$wire->addHookAfter("/foo", function($event) {
  // first we get a fresh copy of the current user
  $user = $this->wire->pages->getFresh($this->wire->user->id);
  $lang = $user->language;

  // then we set the correct language to retrieve values
  $this->wire->user->language = $lang;

  // output to check results
  $title = $this->wire->pages->get(1)->title;
  return "user name = $user->name, language = $lang, homepate title = $title";
});

So you are right, the hook does not seem to have the correct language of the user by default. Which it should I guess. Maybe open an issue on github?

[Juergen]

Maybe could it be the same issue as in this topic?

Bug report - Get $user->language in hook Pages::saveReady

[bernhard]

Yeah, looks like! Thx for remembering me about that ? https://processwire.com/talk/topic/22503-bug-report-get-user-language-in-hook-pagessaveready/?do=findComment&comment=193243

 

[Juergen]

I found a workaround:

Put the user language inside a session variable and call this session variable inside the hook.

public function init()
    {
        //set language id inside a session variable for later usage in url hook
        $this->wire('session')->set('userlang', $this->wire('user')->language->id);
       
        // Show details about the blocked IP address inside a panel
        $this->wire->addHook('/detail-view/{ip}', function ($event) {
            $userLang = $this->wire('session')->get('userlang'); // grab current user lang from session
            $this->wire('user')->language = $userLang;
           	// here comes the code

        });
    }

Not really elegant, but it works. Now translatable strings work as expected.

[bernhard]

Hey @Juergen got bit by this again.

I think the reason why the language is always the default one is because the hook adds to an URL that looks like the default language in PW - which makes sense.

My solution today was to add two hooks for two languages:

<?php
public function init() {
  wire()->addHook("/create-cv",                 $this, "createCV");
  wire()->addHook("/de/create-cv",              $this, "createCV");
}

public function createCV(HookEvent $event): void
{
  // more code here
  $url = $this->wire->user->language->isDefault()
    ? $pdfs->first()->url
    : $pdfs->last()->url;
  $this->wire->session->redirect($url);
}

I created an issue on github: https://github.com/processwire/processwire-issues/issues/1871

[Juergen]

Hello @bernhard

12 minutes ago, bernhard said:

I think the reason why the language is always the default one is because the hook adds to an URL that looks like the default language in PW - which makes sense.

This seems to me also as the most possible reason for this behavior. BTW, I was not confronted with this issue since then, but thank you for reporting an issue at GitHub and for the information.

Have a nice day!