Jump to content

adrian

PW-Moderators
  • Posts

    10,912
  • Joined

  • Last visited

  • Days Won

    349

Everything posted by adrian

  1. Just wanted to say that this is an essential module for me on all sites. Being able to see what changes have been made and by whom and to revert if needed is so important.
  2. @sz-ligatur - please try changing this line: https://github.com/adrianbj/TableCsvImportExport/blob/b1cf4b9d9c396f7f50e8a33a7b8ba871614a6f50/TableCsvImportExport.module.php#L455 to: require_once __DIR__ . '/parsecsv-for-php/parsecsv.lib.php'/*NoCompile*/; I think that should sort out the issue with this module. Let me know if it works and I'll add to the repo. As for the Tracy panel notices. Not sure about those but it does seem like in general you have some permission/role issues preventing PHP from writing to files in the modules directory.
  3. Just an update that AdminerEvo is officially dead unfortunately so I have migrated Tracy to use https://github.com/pematon/adminer - Peter Knut is the creator of the theme that Tracy's Adminer uses and has created a few other plugins we use so I think we are in good hands, so if you want to show some love, please go star his repo to help get it better recognition and support from other contributors.
  4. Note that Nette is now using these: https://blog.nette.org/en/one-line-in-configuration-will-speed-up-your-nette-application-how-is-that-possible so it might be worth looking into how they have implemented them.
  5. Thanks @teppo - I knew I had seen it somewhere before :) I have a very long Content tab and so didn't notice it at the bottom. Thanks!
  6. @teppo - I could have sworn this was already an option I'd seen, but can't find it now, so what do you think about having a LoginHistory tab (or fieldset on the Settings tab) on user pages?
  7. @elvina - I've added some basic ML support (for text based fields) so hopefully it will now do what you need. Just a note that I couldn't even get a simple ML Text field to show results (they were in the DB but not in the table) when adding via the admin GUI. Textarea fields worked though, so that is what I used to test this. Hopefully if Text fields work for you, the import should also work for them.
  8. Well, it took a long time, but the Console tabs are now available in the latest version - turns out there were actually a lot of things left to do which took way longer than I expected. If anyone finds any issues, please let me know. Please note that you will have to do a hard reload to get the tab CSS working - the way the core Tracy package loads CSS I can't seem to figure out how to bust the caching of it.
  9. Thanks @Robin S - all fixed in the latest version.
  10. Thanks @Robin S - I have fixed the history forward icon - I honestly have no idea why I used the left arrow and flipped it :) I have also changed the behaviour if a snippet is already open in a tab and also added scroll into view for the tabs as needed (if lots are open and some are out of view due to horizontal scrolling). Anything else you can see that needs attention before release?
  11. @Robin S - just occurred to me that my fix for the history issue won't work if you upgrade your already upgraded version, so if you do that, please delete these localStorage items manually so that they will be automatically re-created in the right format. https://github.com/adrianbj/TracyDebugger/commit/9d7d42501ead93460d27cda4829eed780239c2aa
  12. Thanks @Robin S for the testing, much appreciated. 1) Sorry, I thought I had dealt with all upgrade issues but missed that one 2) Yeah, that is the intended behaviour - I was treating it as a way of loading up the saved version in a separate tab without losing any potential changes to the currently open version. I know it's different to how VSCode (and probably other editors) work though, so maybe I should reconsider. Anyone else have thoughts? 3) This was also an upgrade issue - the structure of the history stack needed updating but wasn't being overwritten if it already existed. 4) I am not seeing this pixel issue - any chance you could help narrow that down: Latest commit should fix 1 & 3 Thanks again.
  13. Happy new year everyone! I've been working on adding multiple tab support for the console panel. It works in conjunction with the snippets panel so you can load up multiple snippets, or create any number of temporary (unsaved) tabs of code. Each tab has its own execution history stack and the last result for each tab is also maintained so you can flip between tabs to see the differences between results. It automatically names tabs like a typical code editor does: Untitled-1 initially, and then using the first line of code. Of course when you save the tab to a snippet, the tab name will be that of the snippet filename saved to disk. I'll push it live soon, but if anyone sees this and would like to test and provide feedback beforehand, please take a look at this branch: https://github.com/adrianbj/TracyDebugger/tree/console-tabs Thanks!
  14. The hooks info that Tracy shows is basically a copy of what is shown in PW's Debug Mode Tools (using getHooks()) and AFAIK it's only hooks that are triggered by AddHookAfter/Before calls. From what I can tell what Bernhard is showing is all hooks that are run as PW is booting up - there are lots of entries missing in that list. Not saying that it's not a useful list, but they are very different things. Unfortunately it seems that Tracy isn't available at the point that runHooks() is called, so I couldn't replace your log file approach with a bd() call so at the moment it will need Ryan's input to make it possible to display this list in Tracy.
  15. @bernhard - available in the latest version.
  16. @artfulrobot @ryan - I wonder if some of the new techniques described here would help?
  17. Thanks for the help debugging @elvina - I have a new version which should work for you. Note that at the moment it will only work if your CSV has an empty column for the image field, but I also have the code in place to support importing images and files, but there is a bug in the Table field which I need to get @ryan to fix before it will work. Here's the report I prepared for Ryan which includes a hacky fix to get things working if you do want to import images:
  18. That line #1189 suggested there is an image subfield/column involved: I wonder if there is some old image field that wasn't properly deleted. If you look at the database table for the table field, does it contain any unexpected fields? Or maybe the json settings for the field have reference to an image field? Can you please try on a new table field built from scratch with just the fields you need and see if that still has issues?
  19. It looks to me like it has something to do with your table settings under the "What pages should be selectable?" section. Can you try a simple example with just a template, eg: If that works, then maybe you can help to figure out what selector is causing the issue.
  20. Hi @elvina - sorry, but I am having troubles reproducing this - I have successfully imported and Page Select columns matched the page based on the title I entered in the CSV. Even if I enter a page title that doesn't exist, I don't get that error - the row just doesn't populate anything for that field. What version of this module and FieldtypeTable are you running?
  21. Hey @ryan - sounds like a potentially useful input for certain needs. I am wondering what you think about the option of the closed label being something like "3 of 50" or "3/50" because I think in some cases it's important to know if all are selected vs a limited selection.
  22. Seems to be creating quite a bit of excitement. @ryan - not sure yet how much of a performance improvement this might be for PW, but definitely worth looking at.
  23. Hey @Robin S - yep, all you need to do is populate: $this->output = 'this'; $this->output .= 'and that'; return true; inside the executeAction() method.
  24. Thanks Ryan for your hard work getting things ready for 8.4. While I see your frustration with PHP's change here, and appreciate your humorous commentary, I do actually think it makes sense when you consider that null is not a string or an array or some PW object, so there needs to be some way to explicitly state that null is an allowed option, rather than implicitly allowing it, which is exactly what the error states: "Implicitly marking parameter $var as nullable is deprecated". I actually think I prefer the use of union types, eg: (PageArray|null $items = null) rather than the obscure question mark, but as we figured out, that requires PHP 8. Anyway, thanks again for getting this implemented so very quickly so we can all start proper testing of 8.4 with our projects.
  25. Hi @gebeer - please try the latest version. I have modified to use $_SERVER['REQUEST_URI'] which I hope should solve things when you guys have these unusual redirects in place and well as @Jonathan Lahijani's issue from here: https://github.com/adrianbj/TracyDebugger/issues/96 Please let me know if you can now work without that modification to your hook.
×
×
  • Create New...