Richard Jedlička
-
Posts
105 -
Joined
-
Last visited
-
Days Won
1
Recent Profile Visitors
5,183 profile views
Richard Jedlička's Achievements
Sr. Member (5/6)
131
Reputation
-
@kalimati It means it was fixed by the new version so you didn't have to deal with the colorspace?
-
I see, you have the old version. Update to the latest one (2.0.0).
-
It is in the field settings (Details tab) not the module settings.
-
@kalimati Also this looks useful https://imagemagick.org/discourse-server/viewtopic.php?p=80210&sid=88e589266091f18cef53b8adc6a4d0b1#p80210 Try to identify the colorspace, this way it would be useful to detect the colorspace in the code if possible.
-
Hi @kalimati, not exactly sure, but I guess it will be related to the colorspace the PDF is in? 🤔 I am no expert on this area and don't know if PDF can have different colorspace, but the field has an option to set the colorspace to be used for the image generating (on Details tab), so you can experiment with it. You can also check https://github.com/uiii/ProcessWire-FieldtypePDF/blob/9f07314883cd281e09851f149b8889c1a3e8daa0/FieldtypePDF/PDFConverter.php#L149 where is the code to generate the image, and you can find a way how to use ImageMagick to generate image for your PDF, we may reflect it in the code after.
-
Merged into new version 1.1.8. Haven't tried to install so if someone can check if it's ok.
-
@sz-ligatur Perfect, thank you, I'll merge it.
-
Actually the response wasn't quick at all ? you were just 4th person in a row who complained ?
-
Hi @bernhard , yes I agree, we can leave it as it is. And in the case if there are more issues in the future we can consider the transition ?.
-
@Stefanowitsch @szabesz @bernhard @cpx3 All right, the issue should be fixed, haven't tested it, please check it. EDIT: fixed version 1.1.7
-
@bernhard Sorry guys, this is difficult to me, because I don't use PW actively, only occasionally, so other priorities takes my time. I any of you will be interested I can give you access to the repo.
-
Hi @bernhard, you are right the change is simple, I can do it. I was thinking about it. But I think it is not only about the change but also about testing the module if it really works. I don't have set up the dev environment for it yet. So this was the reason for PR. I don't like throwing the change in to the wild and realizing later it doesn't work because I forgot something like increasing the module's version etc. ?
-
Hi guys, feel free to make PR. Unfortunately, I'm not able to find a time for this now.
-
Maybe some PW API changed so it broke it. I'll try to check it soon.
-
Hi @Stefanowitsch, is this the whole error message? Looks like the stack trace only.
