Jump to content

matjazp

Members
  • Posts

    693
  • Joined

  • Last visited

  • Days Won

    5

Everything posted by matjazp

  1. FieldtypeSelect is very old module from 2013 that "produces a drop down list (via a "select" input) that would allow you to define a list of options in the field's configuration from which to select a value. After installing, you'll have a new "Select" fieldtype that will allow you to define the items you'd like in the drop down. You'll be able to define these options in a text box on the field's configuration screen. Just put each option on it's own line." Github Repo: https://github.com/Hani79/Processwire_FieldType_Select_Drop_Down My fork: https://github.com/matjazpotocnik/Processwire_FieldType_Select_Drop_Down You should use FieldtypeOptions nowdays. Can't answer that, see if the fieldtype Select is used in any template?
  2. Links to the Community, Docs, Download, Blog at the footer are incorrect (links on the home page are ok).
  3. I'm using a keyboard and can't access menu items. I can, for an example, tab to "The CMS", Enter (or Space) opens a menu, but how to go to (focus on) "Features"?
  4. I'm on Edge 138.0.3351.121 and can't replicate. Maybe I'm not fast enough?
  5. Maybe this should be an option in the default theme?
  6. As someone already mentioned, there are accessibility issues. I miss focus indicators on inputs. The blue main color lacks contrast, so I'm using #2374e2 instead of #2380e6. Also, muted color seem to have a low contrast in the page list.
  7. Should be fixed now: https://github.com/processwire/processwire-issues/issues/1823#issuecomment-2494183074
  8. https://github.com/processwire/processwire-issues/issues/1516 https://github.com/processwire/processwire-issues/issues/1823
  9. It's working here. That 0 is error code (and ? is error text) returned from WireHttp::GetHttpCode(). Hard to tell what went wrong. Can you provide original image?
  10. https://github.com/processwire/processwire-issues/issues/1893
  11. Thx Robin! While the Save + Close button is there (as expected), the js part makes the edit links all open home page, eg. they all have the link /processwire/page/edit/?id=1&quick_edit=1 I fixed that with: const $links = $('.PageListActionEdit a:not([data-autoclose])'); $links.each(function() { $link = $(this); $link.attr('data-autoclose', '#save-and-close').attr('href', $link.attr('href') + '&quick_edit=1'); }); Just to mention that using uk-hidden class (as a "belt and suspender" approach) would only work in AdminThemeUIkit, leaving out newer (and older) admin themes.
  12. Now that you explain it, I remember this behavior of modal.js. But, unfortunately, it doesn't work here, only the Save button is cloned. Looking at the modal.js line 417, $icontents.find(buttonSelector) only returns one button, not two as expected. It seems like the Save+Close button is added too late, after the modal has already cloned the Save button. While debugging, I added the button unconditionally and also removed the uk-hidden class, and then edited the page in a new tab with modal=1, and both buttons were there, as expected. But not in modal. I guess if I add the button directly to the ProcessPageEdit.module (or via hook), it would work. But it's working for you, so there must be something with my installation. It's a bit late here, so I'll continue testing tomorrow.
  13. Hey Robin! Thanks for this. I haven't had time to test this, but looking the code I see uk-hidden class on button. Would button even show? (and I know it's there for a reason)
  14. Just to say, that 4.0 beta is working just fine. I had to tweak jquery migrate, but this issue will be fixed soon.
  15. I don't like toggles at all. I find them confusing. I use a checkbox or radio group. It’s clear what you want, accessible and doesn’t make me think.
  16. https://github.com/processwire/processwire-issues/issues/1867 ?
  17. @Lutz I think this is addressed in https://github.com/processwire/processwire/commit/24fc229be563de0157ed18ee199dfab889286169 , but this was already fixed in 3.0.184 so I wonder if this is something new?
  18. Please open an issue report.
  19. I installed SkyScraper profile (last commit from year 2013, not compatible with PW3) on PW 3.0.221 and loaded home page: 1.10 seconds: no cache enabled 1.00 seconds: built-in cache enabled 0.35 seconds: AIOM+ enabled
  20. 1.10 seconds: no cache enabled 1.00 seconds: built-in cache enabled 0.095 seconds: AIOM+ enabled I'm not using debug timer, just timings in browser network tab. @bernhardperhaps you could test AIOM+ on the same setup as you tested with ProCache (29 seconds ???).
  21. Nope, as I don't have ProCache, but based on what I've read and info from the forum, ProCache serves static files and there might be directives needed in .htaccess. I'm on IIS so it's not an option for me. AIOM+ leverages the template page cache built in core and uses a small php file to render those files. It's not perfect as modification of index.php is needed for best results (I have a feature request open). It also works if you modify some settings in site config.php, but it's not that effective.
  22. Yes, it even works on PHP 8.3 and it's caching option is almost as fast as ProCache.
  23. You can try my fork of aiom https://github.com/matjazpotocnik/ProcessWire-AIOM-All-In-One-Minify
  24. Thanks. You can comment this line. This module is still working, but need some love and could be simplified if required PHP version is bumped up. There is also a new version of file editor (with the same namespace) written by someone else (can't remember the name), I think it's actively maintained?
  25. I'm not sure this is ok, as saveModuleConfigData is: "@deprecated Please use saveConfig() method instead". saveConfig() is hookable and it should fire, so not sure what's going on. Maybe others have an idea?
×
×
  • Create New...