Jump to content

DrQuincy

Members
  • Posts

    141
  • Joined

  • Last visited

Profile Information

  • Location
    UK

Recent Profile Visitors

The recent visitors block is disabled and is not being shown to other users.

DrQuincy's Achievements

Sr. Member

Sr. Member (5/6)

41

Reputation

  1. I just wanted to check how the new “Prevent direct access to file assets owned by pages using this template?” option works under the template Access tab. The first option works as PW has done historically. If I choose the third option then it seems I only get a 404 if the current user doesn't have view access to the page. So, that's great. It seems to change the folder now so that is satisfies a different .htaccess rule to control access. What I'm unsure of is in the second option where it says: What is meant by “publicly accessible”? Would this be a page that uses the admin template? I just wanted to understand how it works because to me this implies role access — which seems to be the job of the third option. To be honest, if I ever wanted to secure files in this way I think I'd use the third option anyway. One general question: if you chose the third option and wanted to log the number of times a restricted file is accessed, which hook would you use? Thanks.
  2. Thanks for confirming. Another problem solved on this great forum. 🙂
  3. Thanks. I have found out the issue and it was not permission-related. In file-errors.txt I had this error: allowPath: pathname may not traverse “../” I don't really understand how it works but from looking at the source is seems WireFileTools->allowPath() is blocking it. This fixes the error: public static function createDuplicateImage($src, $dest) { if (file_exists($src) === false) { return false; } // Duplicate the file \ProcessWire\wire('files')->copy($src, $dest); // NOTE new line $dest = realpath($dest); return new \ProcessWire\ImageSizer($dest); } You need to call realpath() after file duplication (since realpath() does not work on non-existent files). This sends the full canonicalised absolute pathname and WireFileTools via ImageSizer deletes the -tmp files. I'm not sure if this is intended behaviour but I hope that helps anyone else who needs to do this. I presume it is a security feature that blocks certain paths from file manipulation.
  4. @horst Thanks, this works great but I am left with some -tmp images. What I needed to do was create thumbnail images outside of PageImage context. So I need to duplicate the file first and then pass it to a new ImageSizer object and resize per your example. My code is like this: public static function createDuplicateImage($src, $dest) { if (file_exists($src) === false) { return false; } // Duplicate the file \ProcessWire\wire('files')->copy($src, $dest); return new \ProcessWire\ImageSizer($dest); } // ... $image = Util::createDuplicateImage('./foo.png', './foo-cropped.png'); $image->resize(250, 250); I get foo-cropped.png sized to 250px x 250px but am left with a duplicate foo-cropped.png-tmp.png. Looking at the ImageSizeEngine class this line is returning false for some reason: $this->wire('files')->unlink($this->tmpFile); Any ideas why? I am just on a local MAMP set up and have never had problems creating and deleting files with PHP before. Thanks. 🙂
  5. Ah, thanks. The documentation is great but with some many features it's easy to miss things. Here's the relevant page from the docs should anyone need it: https://processwire.com/api/ref/image-sizer/ Thanks to you both. 🙂
  6. If you want to resize an image that is not a PageImage is there a way to do it? No worries if not as I can just get Intervention Image via composer but didn't want to include a library I didn't need if PW can do it. I can't see anything in $files and it seems functions like size() can only be applied to PageImages. Thanks.
  7. It seems this is part of the ProcessWire core now so if you install 3.0.184 there is a template option: If you look in the latest PW there is a new rule that blocks access to folders in site/assets that start with a hyphen. If you attempt to access the corresponding URL without the hyphen PW will do authentication checks. Direct access to the folder throws a Forbidden error. If access is blocked to the file it 404s irrespective of the What to do when user attempts to view a page and has no access? setting. See
  8. Not sure if this is the best way as it involves adding code to every template file but this seems to work. Add a function in functions.php such as killWithstatusCode() that returns a simple HTML error template. This can check the current HTTP response code and output a message accordingly. Then at the top of each template add: if (http_response_code() != 200) return killWithstatusCode(); Technically, the response code could be between 200 and 299 and be regarded as a success so you could replace http_response_code() with a more concise function that checks if the code starts with a 2. if (!statusCodeSuccess()) return killWithstatusCode(); I did see Ryan say in an old forum post that if you don't wish to render a template then you can simply call return and ProcessWire will still handle the process. I also noticed that whatever string you return from the template ProcessWire will render. You might wonder the use case for this. I find it useful to be able to allow a CMS to use HTTP response codes that typically the server would handle. Being able to send 405 Method Not Allowed, for example, when creating a RESTful API or handling POST forms can be useful. Or if you wish to block POST requests to a certain page. Also, 400, 401, 403 and 500 are useful codes when building web apps. I have adapted ProcessWire to use a MVP pattern so this means I can send out a non-2XX status code before the view (template) is rendered and not have to worry about that part. Unlike a 404, these errors are generally unlikely to be encountered under normal usage are are more indicative of server or application error and so it doesn't matter that the full blown ProcessWire error page is not shown. If there's a better way I'm all ears. 🙂
  9. Great work, thanks!
  10. P.S. One “gotcha” that caught me out was the items did not appear in the mobile nav until I logged in and out again. 👍
  11. Just installed this and it is really good! Thanks @Robin S, I am abandoning my Process class from the other thread. 🙂 One suggestion. Can you dynamically set permissions? If so, it might be nice to restrict the appearance of the menus to a permission. It doesn't really matter for my use case but thought it might be worth adding if it's easy enough.
  12. Thanks, I wasn't aware of the $http variable. 🙂 Looking through the functions I think possibly this is more suitable in this instance. https://processwire.com/api/ref/wire-http/send-status-header/ I'm sure HEAD work work — though I may be wrong! What I am wanting to do is send something other than a 200 status for the current request. It looks like $http->sendStatusHeader(405) would send the right header per my above exmaple. Is it possible to then show the error page template?
  13. Ooh, this looks great! Thanks Robin. I'm still on .165 at the moment so will have to upgrade. 🙂 Out of interest is there a technical reason why it's limited to three menus? Also, do you think there will ever be support for the navJSON type links? I.e. Main > drop down item > third-level item.
  14. Thanks for clearing that up. I've pretty much got it doing what I want no anyway! I don't really need links to other hosts, etc. I just wondered if it was possible should the need arise.
  15. Bear in mind each time you make a change to your .module file you need to refresh modules. Here's a working sample that should get you started. namespace ProcessWire; class ProcessSiteOptions extends Process { private $cmsPath = null; public static function getModuleInfo() { return [ 'title' => __('Site options', __FILE__), 'summary' => __('Custom site options', __FILE__), 'version' => '0.0.1', 'permanent' => false, 'useNavJSON' => true, 'permission' => 'page-edit', 'nav' => [ [ // URls relative to where this admin page is added 'url' => '../page/edit/?id=1023', 'label' => 'Settings', // These labels are HTML entity encoded 'icon' => 'cog' ], [ 'url' => '../page/edit/?id=6601#ProcessPageEditChildren', 'label' => 'Project filters', 'icon' => 'filter', 'navJSON' => 'navJSON' ] ] ]; } public function ___execute() { return $this->render(); } protected function render() { $html = '<p>Manage site options.</p><ul>'; $sanitizer = wire('sanitizer'); $nav = self::getModuleInfo()['nav']; foreach ($nav as $item) { $html .= '<li><a href="' . $sanitizer->entities($item['url']) . '">' . $sanitizer->entities($item['label']) . '</a></li>'; } return $html . '</ul>'; } public function ___executeNavJSON($options = []) { $options = []; $options['list'] = []; // Unlike nav children above these can be dynamic $options['list'] = self::getChildArray(); return json_encode($options); } private function getCMSPath() { // Caches the CMS path return $this->cmsPath === null ? wire('pages')->get(2)->path : $this->cmsPath; } private function getChildArray() { $page = wire('pages')->get('/'); $sanitizer = wire('sanitizer'); return [ ['url' => $this->getCMSPath() . 'foo-bar', 'label' => 'Arbitrary CMS link', 'icon' => 'smile-o'], ['url' => '/about/', 'label' => 'Arbitrary site link', 'icon' => 'user-o'], ['url' => $page->path, 'label' => $sanitizer->entities($page->title), 'icon' => 'home'] // Dynamic; these labels are not HTML entity encoded ]; } A few points: Don't put any comments before the namespace declaration as PW can't pick up on the module info properly As @Robin S pointed out the first level of items are static, the rest (navJSON) can be dynamic Questions (just me being picky/trying to understand): I don't know how you add third-level items, i.e. children on navJSON but I probably don't need these anyway The labels on navJSON aren't HTML encoded but the labels on 'nav' are — why is this? Is it so you can add HTML into the dynamic options? (strong, em) — just wondering why they are different How can you make a link in 'nav' not do anything when clicked — i.e. just act as a parent for the child links (not a big deal, just curious) How can you add a link (in either 'nav' or navJSON) that goes to an external site? I.e. to a different HTTP host
×
×
  • Create New...