Found myself needing to filter repeater items based upon start and end date fields. These fields aren't required, so repeater items with no dates should be included and those with dates (or a just one date -- start or end) should be evaluated for inclusion.
I slowly figured out that I was dealing with in-memory filtering (of a RepeaterPageArray) and not a database-driven operation. So, that eliminated the possibility of using or-groups in my selector. I still thought I could use the 'filter' and 'not' functions to get the job done. Turns out the way selectors are handled for in-memory filtering is quite different from database-driven selectors.
Here is what I want(ed) to do to filter the dates:
// Start date not specified or in the past
$repeater->filter('start_time<='.$now);
// Not when end date is specified and has passed
$repeater->not('end_time>0, end_time<'.$now);
The first one worked exactly as expected. The second it where I ran into problems. The 'filter' function (which calls the 'filterData' function) takes a $selector argument. From everything I read about selectors, I assumed that the entire selector would have to match. In other words, each comma represented an 'and' scenario. Turns out that each separate comma-separated-selector in the $selector as a whole gets evaluated independently. In the case of the 'filterData' function, the elements are removed if any one of those selectors matches. Essentially, we have an 'or' scenario instead of an 'and' scenario.
In my case above, there was no way for me to filter for a non-empty date AND one that occurs before a given date...at least that I could think of.
So, my main question is if the filter (and related) function should operate on the entire selector passed to the function instead of its individual parts in some sequence. That is what I would have assumed a selector to do.
In my project, altering the segment of the WireArray::filterData function solved my problem for now. ...at least till I forget about it and overwrite it when I upgrade next. Here is the code I changed within the function
// now filter the data according to the selectors that remain
foreach($this->data as $key => $item) {
$filter_item = true;
foreach($selectors as $selector) {
if(is_array($selector->field)) {
$value = array();
foreach($selector->field as $field) $value[] = (string) $this->getItemPropertyValue($item, $field);
} else {
$value = (string) $this->getItemPropertyValue($item, $selector->field);
}
if($not === $selector->matches($value))
continue;
$filter_item = false;
break;
}
if($filter_item && isset($this->data[$key])) {
$this->trackRemove($this->data[$key], $key);
unset($this->data[$key]);
}
}
I would love to hear what you all think. If I have misunderstood something, then I would welcome a different solution.
Thanks!
