Pierre-Luc

@hellomoto yes, that will give some guidance.

What do you mean by very old? Many of the later 5.x releases are now EOL or simply unsupported anymore. I haven't done much housekeeping on the plugin for a while, the original smartypants code needs a good code review..

It replaces some typographic marks with better ones depending on context.

Well there's quite a few things lacking if you ask me, CC, BCC, attachments, batch mode on/off. I don't know if these are mail() constraints, I never use that thing. Basic things in email protocols are left out I believe because you could hack things up with the headers method, but that's far from an obvious thing especially for beginners. I don't have much preference on adding to the WireMail class, or having a supplemental interface to implement, or else. Personally I believe the interface specification for send should not be an int, but a true-ish or a false-ish value. Many ways of sending mail don't return numbers sent, but will tell you if it went ok or not. By the very nature of email, it could take hours/days until an email is certified as being accepted by the receiving servers, and some email servers don't even return accept/decline messages. true/1…n should be correct return values for success, false/0 should also be correct for failure. It's just a matter of documenting it and using == instead of ===. It's all fun insisting on integers but if we can't realistically meet those requirements it's just for show..

You could do ``` return count($this->getToRecipients()) + count($this->getCCRecipients()) + count($this->getBCCRecipients()); ```

I agree but Mailgun doesn't return that info. I felt like returning true might be better since at least it's not giving you fake info. Further faking it might include counting the number of addresses in the emails array, but that feels even worse to me. For the other methods, I'd be more than happy if the interface was updated so we could standardize on things like attachments.

Most probably. When you said it was referencing the fieldset I knew something else was fishy. By the way I know from the GitHub stats that a few of you use the module. Is it working as expected, do you think I should provide a default stylesheet? I'd really like some feedback on the direction to go with.

Thanks Adrian, I'll look if there are other side effects and better ways to fix this one and commit something by this weekend.

Also this page tracks the problem and will eventually contain patches: https://imagetragick.com

Major vulnerability, doesn't seem to have a patch yet.. http://arstechnica.com/security/2016/05/easily-exploited-bug-exposes-huge-number-of-sites-to-code-execution-attacks/

@tpr, what OS? I have the same intl version on my test box. It seems your build might be linking the wrong ICU (outdated) package. I just added a check in the module to test if the transliterator ID was valid on a given system. https://github.com/plauclair/WireMailMailgun/releases/tag/0.4.2 Note that I am not able to replicate your environment or the issue, so please let if know if this release corrects the issue on your end.

Bingo!

If you run this : echo transliterator_transliterate('Any-Latin; Latin-ASCII; [\u0080-\u7fff] remove', "YOUR TAG HERE"); in PHP in interactive mode on your host, (php -a .. then type in commands), what's the output, and what was the exact input for "your tag here". Also do your setup satisfy both requirements >> PHP >= 5.4.0, PECL int >= 2.0.0? It's weird that it would give out an error since it succeeds checking the function exists. Also anything comes up in Logs > Mailgun ?

Hmm, I'm not sure to be honest! I think once you instantiate the WireMail class it will automatically call the installed module. Maybe Ryan has an idea on this..

Glad you found your problem!