Jump to content
renobird

Module: Activity Log

Recommended Posts

Hi @renobird

I keep getting these since I've been using the module:

2× PHP Notice: Trying to get property of non-object in .../modules/MarkupActivityLog/MarkupActivityLog.module:405
2× PHP Notice: Undefined variable: fieldID in .../modules/MarkupActivityLog/MarkupActivityLog.module:370

And because I use Tracy, they kept popping up in the debug bar but today I though it is just enough of them and applied these: 

if (!isset($fieldID) || $fieldID == null) continue; 

https://github.com/Renobird/MarkupActivityLog/blob/9d37de692b74185e6391828806c84b730ab07630/MarkupActivityLog.module#L370

also:

$string = is_object($field) ? $field->className : $field;

 switch($string) {

https://github.com/Renobird/MarkupActivityLog/blob/9d37de692b74185e6391828806c84b730ab07630/MarkupActivityLog.module#L404

I don't know if this is enough but the module seems to work as before but without the notices.

Edited by szabesz
!isset($fieldID) ||
  • Like 3

Share this post


Link to post
Share on other sites

Hi All,

Apologies for the radio silence. This module has evolved quite a bit to suit some very specific needs at my day job. So I now have a private version that is much more robust, but far too customized to release. I'll get my head around where things are with the current public version and take a look as these pull requests as soon as I can.

@jmartsch Other than tracking the changes from the beginning, I don't think there is any way to determine the first time the field was changed. I could be misunderstanding what you need though.

  • Like 1

Share this post


Link to post
Share on other sites

I am tracking the changes from the beginning with your module, and want to query the markupactivitylog table for the first entry a specific field named "status" (not processwires status) was changed at first.

Share this post


Link to post
Share on other sites
On 5/2/2018 at 4:45 PM, renobird said:

So I now have a private version that is much more robust, but far too customized to release. I'll get my head around where things are with the current public version and take a look as these pull requests as soon as I can.

Hello @renobird, Any news on this?

Share this post


Link to post
Share on other sites
On 5/2/2018 at 4:45 PM, renobird said:

So I now have a private version that is much more robust, but far too customized to release.

It would be great to be able to install the new version. Also, the old one keeps generating log entries ("Trying to get property of non-object..."). Maybe we could help somehow? Thanks in advance.

Share this post


Link to post
Share on other sites
On 9/3/2018 at 11:20 AM, Torsten Baldes said:

@renobird

Is there a way to purge the activity log?

I tried removing and readding templates, but the older log entries were still there.

Thanks!

 

I do it this way:

$t = $this->database->query("DELETE FROM MarkupActivityLog WHERE `page_id` = $page->id");

 

  • Like 2

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Recently Browsing   0 members

    No registered users viewing this page.

×
×
  • Create New...