adrian

Restrict Tab View

Recommended Posts

Hey @valan - sorry about that - it was a bug in Hide mode. I just committed a new version that should fix things for you.

  • Like 3

Share this post


Link to post
Share on other sites

@arjen: why don't just hide them using custom css and admincustomfiles module?

Hey Nico, sorry for responding late. Been on a long, long holiday. This is off course another option which I've used in the past too. Thanks for adding.

Share this post


Link to post
Share on other sites

@arjen: FYI and possible fix - since upgrade to PW 2.6.10 in some cases module throws error "Call to a member function attr() on a non-object (line 245 of /var/www/pw/wire/core/InputfieldWrapper.php)". Playing with settings I've mentioned that it happens when I check tab-children-hide for user that gets this error. There were major permission system updates in PW 2.6.10 so I guess new core may conflict with module somehow.

EDIT: Continued experiments and found that tab-settings-hide causes this error when trying to edit user page. Also tab-delete-hide does not function at user page. E.g. clearly there are some conflicts btw PW 2.6.10 and this module.

Share this post


Link to post
Share on other sites

@arjen: FYI and possible fix - since upgrade to PW 2.6.10 in some cases module throws error "Call to a member function attr() on a non-object (line 245 of /var/www/pw/wire/core/InputfieldWrapper.php)". Playing with settings I've mentioned that it happens when I check tab-children-hide for user that gets this error. There were major permission system updates in PW 2.6.10 so I guess new core may conflict with module somehow.

I assume this was directed at me, and not @arjen?

I am trying to replicate your issue here but can't at the moment. Just quickly, I am wondering if that might be a bug in InputfieldWrapper.php

Could you please try to replace that line 245:

} if($this->getChildByName($item->attr('name')) && $item->parent) {

with:

} elseif($this->getChildByName($item->attr('name')) && $item->parent) {

I am not sure this is the problem, but it's weird to me the styling Ryan has with the "if" starting on the same line as the closing curly brace, so I think it might be meant to be an "elseif".

Anyway, let me know if that fixes things - if not can you narrow down a particular setup that results in the new error.

Share this post


Link to post
Share on other sites

@adrian, ups, yes this is directed to you.)

Replaced, but it does not fix a problem.(

Particular setup:

- module is installed with checked Hide "children, settings, delete" in settings

- there is user X with role "content-editor".

- when role "content-editor" has only "tab-settings-hide" and "tab-delete-hide" permissions - everything is OK, e.g. no any tabs in the page (btw children tab is also hidden)

- when role "content-editor" has also "tab-children-hide" permission => error above

 
Again, this happened in PW 2.6.10 dev - could be either result of permission system changes or simply dev bugs... Anyway, looks like this code may not setup $fieldset in some cases:
 
        if($tab == "Settings" || $tab == "Children") {
            $fieldset = $form->find("id=ProcessPageEdit".$tab)->first();
        }
        else {
            $fieldset = $form->find("id=ProcessPageEdit".$tab);
        }

P.S. The same error is thrown in another scenario - when editing "user" page by different user/role. But now issue is with "tab-settings-hide" only...

P.S. Just idea - may be some tabs in some cases can't be found with $form->find? E.g. for example when user does not have access to add children (restricted at template level) then Children tab is not displayed. 

EDIT: Temporarily made quickfix after if-else block above: if (!is_object($fieldset)) return;

It prevents errors - module works as expected at all pages. Except "user" page - here "delete" tab does not disappear (while "tab-delete-hide is ON"), but "children" tab disappears ("tab-children-hide" is ON too).

  • Like 1

Share this post


Link to post
Share on other sites

@valan - thank you for helping to figure this out. I added your is_object check and also fixed the issue with the Delete tab not being hidden. 

Could you please try the new version and let me know if everything is working as expected?

Share this post


Link to post
Share on other sites

@adrian - this is to confirm that now it works as expected. Thank you for this module!

  • Like 1

Share this post


Link to post
Share on other sites

Module should add additional permissions automatically.

For most modules, I would agree with you, but this one potentially has 8 custom permissions. I think most users will probably only want the "tab-settings-view" or "tab-settings-hide" permission. I'd rather not pollute the permissions list with 7 additional unnecessary permissions if you are planning on only using one.

Do you see my point?

  • Like 3

Share this post


Link to post
Share on other sites

Maybe the "new" permission suggestion screen, which ryan implemented for the various optional core permissions, could also hold optional module permissions.

  • Like 3

Share this post


Link to post
Share on other sites

Not sure if this one is connected with the module directly, but still...

Is there an easy way to hide the Content tab if all the other tabs are disabled with permissions?

Share this post


Link to post
Share on other sites
1 hour ago, Ivan Gretsky said:

Not sure if this one is connected with the module directly, but still...

Is there an easy way to hide the Content tab if all the other tabs are disabled with permissions?

Hi Ivan - not sure I am understanding - do you want to hide all tabs, or do you have some custom fieldsettabs that would still be displayed? I could perhaps implement, but if it's a case of just not wanting a tab named "Content", don't forget that you can actually rename this.

Does that help, or am I not understanding your scenario?

Share this post


Link to post
Share on other sites

I got all tabs but Content turned off. So the lonely Content Tab seems unnecessary and confusing. I thought that it would be better to see no tabs at all when only one is present. I know I can rename it, but that hardly makes it look any better. I surely can live with this tab, just wanted to know if there is an easy workaround.

Share this post


Link to post
Share on other sites

So you want the fields from the content tab to still be there, just not the tab "button" (for want of a better description)?

That sounds more like a job for CustomAdminFiles or maybe a feature request for AOS?

This module hides entire tabs, including their content.

Am I on the right track now?

 

  • Like 1

Share this post


Link to post
Share on other sites
1 minute ago, PWaddict said:

I've just installed the module. Isn't possible to hide the children tab ONLY on a specific template?

Currently no, the module is designed for site-wide use, but you could extend it to have a template selector in the module config, or just steal the relevant code from the module and add it as a hook in your /site/ready.php file.

  • Like 1

Share this post


Link to post
Share on other sites
58 minutes ago, adrian said:

Currently no, the module is designed for site-wide use, but you could extend it to have a template selector in the module config, or just steal the relevant code from the module and add it as a hook in your /site/ready.php file.

Ok I hide the children tab on the template I wanted but now the order of tabs is changed on the other templates. It shows them in this order: Content, Settings, Delete, View, Children instead of Content, Children, Settings, Delete, View. I'm not sure how can I fix that.

Share this post


Link to post
Share on other sites
2 minutes ago, PWaddict said:

Ok I hide the children tab on the template I wanted but now the order of tabs is changed on the other templates. It shows them in this order: Content, Settings, Delete, View, Children instead of Content, Children, Settings, Delete, View. I'm not sure how can I fix that.

Can't really help without knowing exactly how you did the hiding :)

Share this post


Link to post
Share on other sites
2 minutes ago, adrian said:

Can't really help without knowing exactly how you did the hiding :)

Sorry you're right :)

I've edited the function removeTabs:

    public function removeTabs ($tab, $event) {

        $form = $event->return;
        $p = $event->object->getPage();

        if($p->template->name == 'mytemplatename' && $tab == "Children") {
            $fieldset = $form->find("id=ProcessPageEdit".$tab)->first();
        }
        else {
            $fieldset = $form->find("id=ProcessPageEdit".$tab);
        }

        $form->remove($fieldset);
        $event->object->removeTab("ProcessPageEdit".$tab);
    }

 

Share this post


Link to post
Share on other sites

I figured it out. I changed this function:

    public function afterBuildForm(HookEvent $event){

        if($this->user->isSuperuser()) return;

        $form = $event->return;

        foreach($this->data['viewTabs'] as $tab) {
            if(!$this->user->hasPermission("tab-".strtolower($tab)."-view")) {
                $this->removeTabs($tab, $event);
            }
        }

        foreach($this->data['hideTabs'] as $tab) {
            if($this->user->hasPermission("tab-".strtolower($tab)."-hide")) {
                $this->removeTabs($tab, $event);
            }
        }

        $event->return = $form;
    }

to this:

    public function afterBuildForm(HookEvent $event){

        if($this->user->isSuperuser()) return;

        $form = $event->return;
        $p = $event->object->getPage();

        foreach($this->data['viewTabs'] as $tab) {
            if(!$this->user->hasPermission("tab-".strtolower($tab)."-view")) {
                $this->removeTabs($tab, $event);
            }
        }

        foreach($this->data['hideTabs'] as $tab) {
            if($this->user->hasPermission("tab-".strtolower($tab)."-hide") && $p->template->name == 'mytemplatename') {
                $this->removeTabs($tab, $event);
            }
        }

        $event->return = $form;
    }

 

  • Like 1

Share this post


Link to post
Share on other sites

Nice work :)

Or you could try out the new version of the module which adds support in the config settings for restricting by template(s)

Screen Shot 2017-01-31 at 1.15.22 PM.png

  • Like 2

Share this post


Link to post
Share on other sites
5 minutes ago, adrian said:

Nice work :)

Or you could try out the new version of the module which adds support in the config settings for restricting by template(s)

Screen Shot 2017-01-31 at 1.15.22 PM.png

PERFECT :)

Share this post


Link to post
Share on other sites
2 hours ago, adrian said:

Currently no, the module is designed for site-wide use, but you could extend it to have a template selector...

Just wait for about an hour, and @adrian will extend it too :P 

Thank you, BTW!

  • Like 2

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By Robin S
      Pages At Bottom
      Keeps selected pages at the bottom of their siblings.
      A "bottom page" will stay at the bottom even if it is drag-sorted to a different location or another page is drag-sorted below it (after Page List is refreshed the bottom page will still be at the bottom).
      Newly added sibling pages will not appear below a bottom page.
      The module also prevents the API methods $pages->sort() and $pages->insertAfter() from affecting the position of bottom pages.
      Note: the module only works when the sort setting for children on the parent page/template is "Manual drag-n-drop".
      Why?
      Because you want some pages to always be at the bottom of their siblings for one reason or another. And someone requested it. 🙂
      Usage
      Install the Pages At Bottom module.
      Select one or more pages to keep at the bottom of their siblings. If you select more than one bottom page per parent then their sort order in the page list will be the same as the sort order in the module config.

       
      https://github.com/Toutouwai/PagesAtBottom
      https://modules.processwire.com/modules/pages-at-bottom/
    • By Robin S
      Another little admin helper module...
      Template Field Widths
      Adds a "Field widths" field to Edit Template that allows you to quickly set the widths of inputfields in the template.

      Why?
      When setting up a new template or trying out different field layouts I find it a bit slow and tedious to have to open each field individually in a modal just to set the width. This module speeds up the process.
      Installation
      Install the Template Field Widths module.
      Config options
      You can set the default presentation of the "Field widths" field to collapsed or open. You can choose Name or Label as the primary identifier shown for the field. The unchosen alternative will become the title attribute shown on hover. You can choose to show the original field width next to the template context field width.  
      https://github.com/Toutouwai/TemplateFieldWidths
      https://modules.processwire.com/modules/template-field-widths/
    • By horst
      Croppable Image 3
      for PW 3.0.20+
      Module Version 1.1.16
      Sponsored by http://dreikon.de/, many thanks Timo & Niko!
      You can get it in the modules directory!
      Please refer to the readme on github for instructions.
       
      -------------------------------------------------------------------------
       
      Updating from prior versions:
       
      Updating from Croppable Image 3 with versions prior to 1.1.7, please do this as a one time step:
      In the PW Admin, go to side -> modules -> new, use "install via ClassName" and use CroppableImage3 for the Module Class Name. This will update your existing CroppableImage3 module sub directory, even if it is called a new install. After that, the module will be recogniced by the PW updater module, what makes it a lot easier on further updates.
      -------------------------------------------------------------------------
       
      For updating from the legacy Thumbnail / CropImage to CroppableImage3 read on here.
       
      -------------------------------------------------------------------------
       
    • By MoritzLost
      UPDATE: I have published a stable version of this module!
      Discussion thread:
      Github: https://github.com/MoritzLost/TextformatterPageTitleLinks
      ---
      Hello there,
      I'm working on a tiny textformatter module that searches the text for titles of other pages on your site and creates hyperlinks to them. I'm not sure if something like this exists already, but I haven't found anything in the module directory, so I wrote my own solution 🙂
      It's not properly tested yet and is still missing some functionality I would like to implement, so at the moment it should be considered in BETA. Features include limiting the pages that will get searched by template, and adding a custom CSS class to the generated hyperlinks. As I'm writing this I noticed that it will probably include unpublished and hidden pages at the moment, so yeah ... it's still in development alright 😅
      You can download the module from Github:
      https://github.com/MoritzLost/TextformatterPageTitleLinks
      There's some more information in the readme as well.
      Anyway, let me know what you think! I'm happy about any feedback, possible improvements or ideas on how to improve the module. Cheers.
    • By blad
      Hi guys!
      I just uploaded a module to explore files based on elFinder. By default it will show the "Files" folder.
      Screenshots:

      Video:
       
      To do:
       More options To fix:
       The function of rotating or scaling an image fails  Image editors V 1.01 (view issue)
      Fixed the bug working with the Multi-Language support ( translation of folders ). Fixed the name of elfinder.en  Github:
      https://github.com/LuisSantiago/ProcessElFinder/
      I hope you like it.