FilenameArray class to implement Countable interface

[hwmaier]

It would be beneficial if the FilenameArray class would have a count() method.

 

Suggested implementation:

class FilenameArray implements IteratorAggregate, Countable {

...

/**
 * Returns the number of items in this FilenameArray.
 *
 * Fulfills Countable interface.
 *
 * @return int
 */
 public function count() {
     return count($this->data);
 }

Rationale:

 

A count method can be used to check if any scripts or stylesheets are configured as shown in the following example:

 

<?if (count($config->scripts)):?>
    <script type="text/javascript" src="<?=AllInOneMinify::JS($config->scripts?>"></script>
<?endif?>

The current implementation of FilenameArray does not implement the Countable interface and count() will return a 1 regardless of the number of elements in the FilenameArray.

[Pierre-Luc]

I would greatly suggest you post this in GitHub's issue/request tracker.

[hwmaier]

I would greatly suggest you post this in GitHub's issue/request tracker.

Done. Refer to https://github.com/ryancramerdesign/ProcessWire/issues/929