Mike Rockett Posted January 24, 2017 Author Share Posted January 24, 2017 @owzim - It's a third-party parser that I chose as it has automatic delimiter detection. I read somewhere that str_getcsv is not RFC-compliant, but more importantly, it doesn't escape quotes correctly. That said, I might look into it and see what workarounds are worth the switch. Regarding your issue, I'll need to look into it further - I don't know where those dates are even coming from, or why it's even trying to set dates at all (in the first instance); it could be something to do with the SQL defaults. What version of MySQL are you using? Link to comment Share on other sites More sharing options...
Mike Rockett Posted January 24, 2017 Author Share Posted January 24, 2017 Interesting, when I use foo;bar, it translates uses that as the source and / as the destination, even though it has been set up to detect the delimiter. Anyways, I've never really liked that parser, so will switch to League\Csv shortly, especially since it will be used in v2. It could well fix the issue you have. Link to comment Share on other sites More sharing options...
Mike Rockett Posted January 24, 2017 Author Share Posted January 24, 2017 Bumped to 1.5.48: Now using League\Csv for CSV importing. Note that delimeters are no longer automatically detected, and you need to specify your delimeter and enclosure characters separately. Blank lines are now also ignored. @owzim - This might fix your issue as the importer now delegates the start and end times to the same method used for the main jumplink editor. If that works for you, then this will as well. If it doesn't fix the problem, then I'll need to investigate further. On my side, however, all looks good. 2 Link to comment Share on other sites More sharing options...
owzim Posted January 24, 2017 Share Posted January 24, 2017 Works now, thanks a lot @Mike Rockett for reacting so fast. 1 Link to comment Share on other sites More sharing options...
Mike Rockett Posted January 24, 2017 Author Share Posted January 24, 2017 @owzim -- Sigh of relief from my side! You're welcome. Link to comment Share on other sites More sharing options...
Mike Rockett Posted January 30, 2017 Author Share Posted January 30, 2017 Hehe, 404 replies! (Wonder why the topic tags are stretched out like that...) Anyways, for those of you who have not seen this yet, here's an update on progress. When v2 is ready for a release of any kind, I'll create a new thread for it. v1 will continue to be supported for those who still use PW 2.7- (for everyone using 2.8+, there will be no reason to stay on v1). v2 will have it's own repo (or perhaps I'll have v1 have it's own branch, and v2 will be dev/master -- maybe that's better). 1 Link to comment Share on other sites More sharing options...
d'Hinnisdaël Posted February 7, 2017 Share Posted February 7, 2017 What's the best way to handle spaces in the original URL? (and whitespace in general) I found that if the requested URL contains spaces, the plugin won't start at all, i.e. there's also no debug screen on matches or compiled jumplinks even when debug mode is turned on. It doesn't seem to make a difference if the links are requested with spaces intact or by directly typing in %20 instead. Also, the pattern itself doesn't make a difference. I tried: GEORGIA GARDNER GRAY.html GEORGIA%20GARDNER%20GRAY.html GEORGIA{space:any}GARDNER{space:any}GRAY.html Is there a preferred way of handling this or am I missing something obvious? Thanks Link to comment Share on other sites More sharing options...
Mike Rockett Posted February 7, 2017 Author Share Posted February 7, 2017 @d'Hinnisdaël - The htaccess ruleset doesn't allow spaces in URIs as ProcessWire doesn't use them. However, this can easily be modified. Open the htaccess file and go to rules 16a and 16b. The default installation uses 16a by default, and you should switch to 16b if you require UTF-8 URIs. At the beginning of each character class (inside the square brackets), add \s to allow spaces. So, if you are using 16a: RewriteCond %{REQUEST_URI} "^/~?[\s-_.a-zA-Z0-9/]*$" (This assumes you are using the latest versions of PW - that is, 2.8 or 3.0.) You can then just use normal spaces in your jumplinks, and they will be detected just fine, provided the correct wildcard type is used. 1 Link to comment Share on other sites More sharing options...
d'Hinnisdaël Posted February 7, 2017 Share Posted February 7, 2017 I knew I was missing something. Works like charm now, thanks a lot, @Mike Rockett 1 Link to comment Share on other sites More sharing options...
quickjeff Posted February 25, 2017 Share Posted February 25, 2017 Hi Mike, any progress in the export functionality, I installed the latest version of Jumplinks on a site that was already using your older version. however the jump links got all wiped out. I need to get the old ones back in. Link to comment Share on other sites More sharing options...
quickjeff Posted February 25, 2017 Share Posted February 25, 2017 Followup, I did it through PHPMyAdmin, but it would be nice to have an export feature as well. Thanks Mike! Link to comment Share on other sites More sharing options...
Mike Rockett Posted February 25, 2017 Author Share Posted February 25, 2017 1 hour ago, quickjeff said: Hi Mike, any progress in the export functionality, I installed the latest version of Jumplinks on a site that was already using your older version. however the jump links got all wiped out. I need to get the old ones back in. Hi Jeff - it's been a busy while for me, so dev is paused at this stage. Exporting will definitely be in v2, as well as a v1 to v2 migrator; no plans to add an exporter to v1. Hoping to get back into it soon, though I can already see the next few weeks being quite busy. Link to comment Share on other sites More sharing options...
quickjeff Posted February 26, 2017 Share Posted February 26, 2017 Sounds good, thanks for the update! Link to comment Share on other sites More sharing options...
kater Posted March 21, 2017 Share Posted March 21, 2017 thanks for this great module! I need to redirect some old drupal links without cleaning, query string directly after the root: www.mydomain.com/?q=content/samplepage ?q=content/samplepage as source does not work. Could you push me on the right track? PW 3.04.42 URL segmentation disabled. ProCache. thanks! Link to comment Share on other sites More sharing options...
Mike Rockett Posted March 21, 2017 Author Share Posted March 21, 2017 Hi @kater, you're most welcome. A plain query string request to the root of the site won't get caught by Jumplinks. You would be better off using htaccess to convert these to request URIs and then having Jumplinks process them. RewriteEngine on # These should go directly after the above RewriteCond %{QUERY_STRING} ^q=(.+)$ [NC] RewriteRule ^$ /%1 [R,L] (Haven't actually tested it, but it should redirect /?q=something/else to /something/else with a 302 status code.) Then omit ?q= from the source. 1 Link to comment Share on other sites More sharing options...
kater Posted March 21, 2017 Share Posted March 21, 2017 1 hour ago, Mike Rockett said: RewriteEngine on # These should go directly after the above RewriteCond %{QUERY_STRING} ^q=(.+)$ [NC] RewriteRule ^$ /%1? [R,L] Thanks! Works perfectly (little adjustment "?" to avoid passing through of query). I've seen this solution in your former post but hoped there is a more direct way 1 Link to comment Share on other sites More sharing options...
Mike Rockett Posted March 21, 2017 Author Share Posted March 21, 2017 @kater - Yeah, I thought I'd said it before, just wasn't going to go find it. Thanks for pointing that out. I might find a way to resolve this with v2 (when I get back into its development). I could probably use an early hook (instead of the pageNotFound hook) for jumplinks that require it. Just a thought from the top of my head. Link to comment Share on other sites More sharing options...
k07n Posted April 25, 2017 Share Posted April 25, 2017 I have resolved my case with nginx maps, maybe someone finds this usefull. Put all redirects to site-redirect.map map $request_uri $redirect_uri { /index.php?id=1 /page/; /index.php?id=53 /another/page/; /index.php?id=62 /and/so/on/; } Nginx looks thru the list, and if it finds $request_uri match line in left column - it set $redirect_uri = value of right side of line ($redirect_uri var can be named as you want). Then include site-redirect.map in http section of nginx config. Now we must check for $redirect_uri in server section and if it is set - redirect to new URI, just like that: include site-redirect.map; server { # … if ( $redirect_uri ) { return 301 $redirect_uri; } } If map is big enought you may need to set map_hash_bucket_size to bigger value (in http section). Here is some more examples to play with: map $request_uri $redirect_uri { # ... ~/post-(?<id>\d+)\.html /post/$id/; ~*/catalog/(?<page>.+)\.html?$ /goods/$page/; } (~)o Link to comment Share on other sites More sharing options...
Mike Rockett Posted April 25, 2017 Author Share Posted April 25, 2017 Hi All, I know I've been distant, but work has kept creeping up on me and I simply haven't been able to commit time to continue work on Jumplinks 2. At this stage, it's difficult to tell when I'll be able to continue, but I do hope it will be soon as I'd like to deprecate v1 as v2 is already so much better. Again, truly sorry for the delays... 7 Link to comment Share on other sites More sharing options...
Mike Rockett Posted June 14, 2017 Author Share Posted June 14, 2017 Small update 2 Link to comment Share on other sites More sharing options...
HerTha Posted June 15, 2017 Share Posted June 15, 2017 Hi Mike, appreciate your work, even with tight time budget, thank you so much! I'd like to leave a comment on your suggestion to focus module development on PW V3 for future releases. As long as new PW versions are being released in the 2.8 branch, module support for this branch would be desireable, IMHO. Thanks for considering! Link to comment Share on other sites More sharing options...
Mike Rockett Posted June 15, 2017 Author Share Posted June 15, 2017 2 hours ago, HerTha said: Hi Mike, appreciate your work, even with tight time budget, thank you so much! I'd like to leave a comment on your suggestion to focus module development on PW V3 for future releases. As long as new PW versions are being released in the 2.8 branch, module support for this branch would be desireable, IMHO. Thanks for considering! You're welcome. I can do that, considering that it is already implemented. It's a workaround that I'm not particularly fond of though (from a namespace point of view). I'll keep it in until an alpha release, at which point maybe someone has a better alternative that can be used instead - so we can take it from there. Are you using the legacy branch? Link to comment Share on other sites More sharing options...
HerTha Posted June 19, 2017 Share Posted June 19, 2017 On 15.6.2017 at 1:54 PM, Mike Rockett said: Are you using the legacy branch? Thanks, Mike! Not sure what's the overall statistics (all users/installs), but for me it's still 100% 2.8.x (never touch a running system ) 1 Link to comment Share on other sites More sharing options...
Joss Posted June 21, 2017 Share Posted June 21, 2017 HI I have installed this on one site with no issues, but running into a problems on another: Module reported error during install (ProcessJumplinks): SQLSTATE[HY000]: General error: 1293 Incorrect table definition; there can be only one TIMESTAMP column with CURRENT_TIMESTAMP in DEFAULT or ON UPDATE clause Failed to init module: ProcessJumplinks - SQLSTATE[42S02]: Base table or view not found: 1146 Table 'db-name.process_jumplinks' doesn't exist I uninstalled and reinstalled and no joy. I am on PW 3.0.64 I had redirects installed previously, but uninstalled first. Any thoughts? Link to comment Share on other sites More sharing options...
Mike Rockett Posted June 22, 2017 Author Share Posted June 22, 2017 @Joss Hi - that's a legacy error from an earlier version of MySQL. What version are you running? Link to comment Share on other sites More sharing options...
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now