Mike Rockett

module
Jumplinks

428 posts in this topic

@owzim - It's a third-party parser that I chose as it has automatic delimiter detection. I read somewhere that str_getcsv is not RFC-compliant, but more importantly, it doesn't escape quotes correctly. That said, I might look into it and see what workarounds are worth the switch.

Regarding your issue, I'll need to look into it further - I don't know where those dates are even coming from, or why it's even trying to set dates at all (in the first instance); it could be something to do with the SQL defaults. What version of MySQL are you using?

Share this post


Link to post
Share on other sites

Interesting, when I use foo;bar, it translates uses that as the source and / as the destination, even though it has been set up to detect the delimiter. Anyways, I've never really liked that parser, so will switch to League\Csv shortly, especially since it will be used in v2. It could well fix the issue you have.

Share this post


Link to post
Share on other sites

Bumped to 1.5.48: Now using League\Csv for CSV importing. Note that delimeters are no longer automatically detected, and you need to specify your delimeter and enclosure characters separately. Blank lines are now also ignored.

@owzim - This might fix your issue as the importer now delegates the start and end times to the same method used for the main jumplink editor. If that works for you, then this will as well. If it doesn't fix the problem, then I'll need to investigate further. On my side, however, all looks good.

2 people like this

Share this post


Link to post
Share on other sites

Hehe, 404 replies!

scrn_processwire.com-2017-01-30-08-03-26.png

(Wonder why the topic tags are stretched out like that...)

Anyways, for those of you who have not seen this yet, here's an update on progress. When v2 is ready for a release of any kind, I'll create a new thread for it. v1 will continue to be supported for those who still use PW 2.7- (for everyone using 2.8+, there will be no reason to stay on v1). v2 will have it's own repo (or perhaps I'll have v1 have it's own branch, and v2 will be dev/master -- maybe that's better).

1 person likes this

Share this post


Link to post
Share on other sites

What's the best way to handle spaces in the original URL? (and whitespace in general)

I found that if the requested URL contains spaces, the plugin won't start at all, i.e. there's also no debug screen on matches or compiled jumplinks even when debug mode is turned on. It doesn't seem to make a difference if the links are requested with spaces intact or by directly typing in %20 instead. Also, the pattern itself doesn't make a difference. I tried:

  • GEORGIA GARDNER GRAY.html
  • GEORGIA%20GARDNER%20GRAY.html
  • GEORGIA{space:any}GARDNER{space:any}GRAY.html

Is there a preferred way of handling this or am I missing something obvious?

Thanks :)

Share this post


Link to post
Share on other sites

@d'Hinnisdaël - The htaccess ruleset doesn't allow spaces in URIs as ProcessWire doesn't use them. However, this can easily be modified. Open the htaccess file and go to rules 16a and 16b. The default installation uses 16a by default, and you should switch to 16b if you require UTF-8 URIs. At the beginning of each character class (inside the square brackets), add \s to allow spaces. So, if you are using 16a:

RewriteCond %{REQUEST_URI} "^/~?[\s-_.a-zA-Z0-9/]*$"

(This assumes you are using the latest versions of PW - that is, 2.8 or 3.0.)

You can then just use normal spaces in your jumplinks, and they will be detected just fine, provided the correct wildcard type is used.

1 person likes this

Share this post


Link to post
Share on other sites

Hi Mike, any progress in the export functionality, I installed the latest version of Jumplinks on a site that was already using your older version. however the jump links got all wiped out. I need to get the old ones back in. :-)

Share this post


Link to post
Share on other sites

Followup, I did it through PHPMyAdmin, but it would be nice to have an export feature as well. Thanks Mike!

Share this post


Link to post
Share on other sites
1 hour ago, quickjeff said:

Hi Mike, any progress in the export functionality, I installed the latest version of Jumplinks on a site that was already using your older version. however the jump links got all wiped out. I need to get the old ones back in. :-)

Hi Jeff - it's been a busy while for me, so dev is paused at this stage. Exporting will definitely be in v2, as well as a v1 to v2 migrator; no plans to add an exporter to v1. Hoping to get back into it soon, though I can already see the next few weeks being quite busy.

Share this post


Link to post
Share on other sites

Hi @kater, you're most welcome.

A plain query string request to the root of the site won't get caught by Jumplinks. You would be better off using htaccess to convert these to request URIs and then having Jumplinks process them.

RewriteEngine on

# These should go directly after the above
RewriteCond %{QUERY_STRING} ^q=(.+)$ [NC]
RewriteRule ^$ /%1 [R,L]

(Haven't actually tested it, but it should redirect /?q=something/else to /something/else with a 302 status code.)

Then omit ?q= from the source.

1 person likes this

Share this post


Link to post
Share on other sites
1 hour ago, Mike Rockett said:

 

 


RewriteEngine on

# These should go directly after the above
RewriteCond %{QUERY_STRING} ^q=(.+)$ [NC]
RewriteRule ^$ /%1? [R,L]

 

Thanks!
Works perfectly (little adjustment "?" to avoid passing through of query).
I've seen this solution in your former post but hoped there is a more direct way :)

1 person likes this

Share this post


Link to post
Share on other sites

@kater - Yeah, I thought I'd said it before, just wasn't going to go find it. Thanks for pointing that out. I might find a way to resolve this with v2 (when I get back into its development). I could probably use an early hook (instead of the pageNotFound hook) for jumplinks that require it. Just a thought from the top of my head.

Share this post


Link to post
Share on other sites

I have resolved my case with nginx maps, maybe someone finds this usefull.

Put all redirects to site-redirect.map

map $request_uri $redirect_uri {
    /index.php?id=1     /page/;
    /index.php?id=53    /another/page/;
    /index.php?id=62    /and/so/on/;
}

Nginx looks thru the list, and if it finds $request_uri match line in left column - it set $redirect_uri = value of right side of line ($redirect_uri var can be named as you want).

Then include site-redirect.map in http section of nginx config.
Now we must check for $redirect_uri in server section and if it is set - redirect to new URI, just like that:

include site-redirect.map;
server {
    # …
    if ( $redirect_uri ) {
        return 301 $redirect_uri;
    }
}

If map is big enought you may need to set map_hash_bucket_size to bigger value (in http section).

Here is some more examples to play with:

map $request_uri $redirect_uri {
    # ...
    ~/post-(?<id>\d+)\.html            /post/$id/;
    ~*/catalog/(?<page>.+)\.html?$     /goods/$page/;
}

(~)o

Share this post


Link to post
Share on other sites

Hi All,

I know I've been distant, but work has kept creeping up on me and I simply haven't been able to commit time to continue work on Jumplinks 2. At this stage, it's difficult to tell when I'll be able to continue, but I do hope it will be soon as I'd like to deprecate v1 as v2 is already so much better.

Again, truly sorry for the delays...

7 people like this

Share this post


Link to post
Share on other sites

Hi Mike, appreciate your work, even with tight time budget, thank you so much!

I'd like to leave a comment on your suggestion to focus module development on PW V3 for future releases.

As long as new PW versions are being released in the 2.8 branch, module support for this branch would be desireable, IMHO.

Thanks for considering!

Share this post


Link to post
Share on other sites
2 hours ago, HerTha said:

Hi Mike, appreciate your work, even with tight time budget, thank you so much!

I'd like to leave a comment on your suggestion to focus module development on PW V3 for future releases.

As long as new PW versions are being released in the 2.8 branch, module support for this branch would be desireable, IMHO.

Thanks for considering!

You're welcome. :) I can do that, considering that it is already implemented. It's a workaround that I'm not particularly fond of though (from a namespace point of view). I'll keep it in until an alpha release, at which point maybe someone has a better alternative that can be used instead - so we can take it from there.

Are you using the legacy branch?

Share this post


Link to post
Share on other sites
On 15.6.2017 at 1:54 PM, Mike Rockett said:

Are you using the legacy branch?

Thanks, Mike!

Not sure what's the overall statistics (all users/installs), but for me it's still 100% 2.8.x

(never touch a running system :-) )

1 person likes this

Share this post


Link to post
Share on other sites

HI

I have installed this on one site with no issues, but running into a problems on another:

 Module reported error during install (ProcessJumplinks): SQLSTATE[HY000]: General error: 1293 Incorrect table definition; there can be only one TIMESTAMP column with CURRENT_TIMESTAMP in DEFAULT or ON UPDATE clause

 Failed to init module: ProcessJumplinks - SQLSTATE[42S02]: Base table or view not found: 1146 Table 'db-name.process_jumplinks' doesn't exist

I uninstalled and reinstalled and no joy.

I am on PW 3.0.64

I had redirects installed previously, but uninstalled first.

Any thoughts?

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By bernhard
      Hi,
      just stumbled over a little module that i built for my last project. it helped me to test performance of my rockdatatables module to generate 3000 random json datasets and i want to share it with you. maybe it saves some time for someone.
      https://gitlab.com/baumrock/RockDummyData/
      easy example:
      $rdd = $modules->get('RockDummyData'); for($i=0; $i<15; $i++) { // this has to be inside the for-loop to always get a new dummy $dummy = $rdd->getDummy(); echo date("d.m.Y H:i:s", $dummy->timestamp) . "<br>"; } more advanced:
      $json = new stdClass(); $json->data = array(); $rdd = $modules->get('RockDummyData'); for($i=0; $i<3000; $i++) { // this has to be inside the for-loop to always get a new dummy $dummy = $rdd->getDummy(); $obj = new stdClass(); $obj->name = $dummy->forename . ' ' . $dummy->surname; $obj->position = $dummy->job; $obj->office = $dummy->city; $obj->color = $dummy->color; $obj->start_date = new stdClass(); $obj->start_date->display = date('d.m.Y',$dummy->timestamp); $obj->start_date->sort = $dummy->timestamp; $obj->salary = rand(0,10000); $json->data[] = $obj; } echo json_encode($json); you have to store your random datasets on your own into the /data folder. there are several services for creating all kinds of random data on the web - if you know one service that allows sharing those datasets let me know and i can include common needed data into the module
    • By AndySh
      Hello!
      I need your assistance please. I purchased the module FormBuilder. Unfortunately, the module discontinued delivering customer submissions to e-mail box specified in the module settings. Direct mailing to the e-mail box works OK. The module settings stays the same and are correct, like "Send e-mail to administrator(s) is checked. The last version of FormBuilder 3.0 has been installed. Please advise how to resolve the issue becase I cannot get orders from customers anymore (((
    • By kixe
      As described in this post (https://processwire.com/talk/topic/8551-custom-urls-for-pages/?p=82742) the option 'Name Format Children' under the tab 'Family' in template settings doesn't work properly and also not as expected. I had a look inside the code and made some changes which are working properly, which offers much more options, more consistency and less code too.

      The result is the following. You have 3 Options for generating name and title, which could be combined in endless variations.
      Name is always derived from title, same like creating pages manually.
      type date: if function detects # character anywhere in the string, conversion will be: deletion of # and string will be used as format parameter for PHP date() function type field: if string is a fieldname of the parent page the value of this field will be used type string: if string doesn't fit to the 2 preceeding it will be taken as it is All parts (separated by comma) will be composed in the order of setting. You can use unlimited numbers of parts

      I made a pull request on github: https://github.com/ryancramerdesign/ProcessWire/pull/831

      Example screenshots

      Setting ...


      will result in


       
    • By kongondo
      FieldtypeRuntimeMarkup and InputfieldRuntimeMarkup
       
      Modules Directory: http://modules.processwire.com/modules/fieldtype-runtime-markup/
      GitHub: https://github.com/kongondo/FieldtypeRuntimeMarkup
       
      This module allows for custom markup to be dynamically (PHP) generated and output within a page's edit screen (in Admin).
       
      The value for the fieldtype is generated at runtime. No data is saved in the database. The accompanying InputfieldRuntimeMarkup is only used to render/display the markup in the page edit screen.
       
      The field's value is accessible from the ProcessWire API in the frontend like any other field, i.e. it has access to $page and $pages.
       
      The module was commissioned/sponsored by @Valan. Although there's certainly other ways to achieve what this module does, it offers a dynamic and flexible alternative to generating your own markup in a page's edit screen whilst also allowing access to that markup in the frontend. Thanks Valan!
       
      Warning/Consideration
      Although access to ProcessWire's Fields' admin pages is only available to Superusers, this Fieldtype will evaluate and run the custom PHP Code entered and saved in the field's settings (Details tab). Utmost care should therefore be taken in making sure your code does not perform any CRUD operations!! (unless of course that's intentional) The value for this fieldtype is generated at runtime and thus no data is stored in the database. This means that you cannot directly query a RuntimeMarkup field from $pages->find(). Usage and API
       
      Backend
      Enter your custom PHP snippet in the Details tab of your field (it is RECOMMENDED though that you use wireRenderFile() instead. See example below). Your code can be as simple or as complicated as you want as long as in the end you return a value that is not an array or an object or anything other than a string/integer.
       
      FieldtypeRuntimeMarkup has access to $page (the current page being edited/viewed) and $pages. 
       
      A very simple example.
      return 'Hello'; Simple example.
      return $page->title; Simple example with markup.
      return '<h2>' . $page->title . '</h2>'; Another simple example with markup.
      $out = '<h1>hello '; $out .= $page->title; $out .= '</h1>'; return $out; A more advanced example.
      $p = $pages->get('/about-us/')->child('sort=random'); return '<p>' . $p->title . '</p>'; An even more complex example.
      $str =''; if($page->name == 'about-us') { $p = $page->children->last(); $str = "<h2><a href='{$p->url}'>{$p->title}</a></h2>"; } else { $str = "<h2><a href='{$page->url}'>{$page->title}</a></h2>"; } return $str; Rather than type your code directly in the Details tab of the field, it is highly recommended that you placed all your code in an external file and call that file using the core wireRenderFile() method. Taking this approach means you will be able to edit your code in your favourite text editor. It also means you will be able to type more text without having to scroll. Editing the file is also easier than editing the field. To use this approach, simply do:
      return wireRenderFile('name-of-file');// file will be in /site/templates/ If using ProcessWire 3.x, you will need to use namespace as follows:
      return ProcessWire\wireRenderFile('name-of-file'); How to access the value of RuntimeMarkup in the frontend (our field is called 'runtime_markup')
       
      Access the field on the current page (just like any other field)
      echo $page->runtime_markup; Access the field on another page
      echo $pages->get('/about-us/')->runtime_markup; Screenshots
       
      Backend
       

       

       
      Frontend