Soma

Fieldtype ColorPicker

Recommended Posts

Soma, I had a couple of questions...

How do you test for if it is set? Is this possible? isset doesn't appear to work, guess that's probably normal though...

Also, is it possible to unset it so that people can choose a colour but if they want to return to the default, they can remove all output from the field?

I'm using a default background pattern for my site but want to give the user an option to change the header colour. If they want to go back to the pattern, I'm not to sure how to do this without adding a checkbox where they have to tick "I want to use a bg color" and also provide a color.

Share this post


Link to post
Share on other sites

As you may noticed or not it has FFFFFF as default value. You could test for it. Im not really sure if having it this way makes sense for a color field or not.

Resetting the value to default isnt implemented simply bcause I havent had the need. Maybe a button or something to reset would be good.

Share this post


Link to post
Share on other sites

Thanks Soma, not sure whether it would be useful to others to have a reset or not but it may be. Is a colorpicker field essentially always set?

For now, using a checkbox alongside it works fine

Share this post


Link to post
Share on other sites

I have implemented a default value you can set in the field settings. Which means you can decide for yourself. i.e. "EAEAEA" or "". Which has effect on how you can test the field. Not sure how others have implemented the colorpicker, but this would be backward compatible if you set it to default "FFFFFF" as before.

And a link "reset" alongside every colorpicker. I'll have to test a little more, but it works fine but haven't had time to commit the changes.

Share this post


Link to post
Share on other sites

Just because I am really nice and like to keep things nice and tidy for young Soma...

Is there an issue with using the color picker in conjunction with a repeater or a page select field? (or in my case, a mixture of both)

Happy Days!
 

Joss

Share this post


Link to post
Share on other sites

Hey Joss, thanks for the report! ;)

I just commited an update that may fix your issue, even though I don't know what it is. I haven't tried with repeater until now, and I couldn't even open the page as It throws a fatal error. In the last implementation of the default value feature it seems it was not compatible with repeaters.

** 1.0.4 **

- fixed bug with use in repeater

  • Like 1

Share this post


Link to post
Share on other sites

Okay, I will try later!

I am creating a sort of "metro" demo, so lots of flat colours and no gradients!

Actually, that would be an interesting addon - create a limited pallet of colours to pick from.

Share this post


Link to post
Share on other sites

The colorpicker has been updated to 1.0.7. with fixed and a new swatches feature.

- Since 1.0.6 the colorpicker supports color swatches to add predefined colors for easy selection. Thanks @Rayden for the implementation.

- It's now also possible to add a transparent default or swatch value with the string "transp".

- fixed a bug with numeric values like 333333, 555555 which caused the colorpicker to not init correctly.

A screen showing the swatches.

post-100-0-76063500-1376302472_thumb.png

Thanks for Raymond Geerts for the update and fixes.

  • Like 1

Share this post


Link to post
Share on other sites

Plugin needed the color as string not as int.  Was fixed with parseInt.

Update also prevent box collapse on the container.

I'm not to happy about the transp as name for transparent.

Share this post


Link to post
Share on other sites

Plugin needed the color as string not as int.  Was fixed with parseInt.

Update also prevent box collapse on the container.

I'm not to happy about the transp as name for transparent.

Thanks Martijin for you help also. It was fixed with value.toString() :)

The "transp" is ok and it was the easiest way to keep backward compatibility. It would require to reinstall the module to change the schema, though it could also be done with a update script check. I don't see why transp is a problem. And just because of transparent making the data field to 11 chars instead of 6 is not nice at the end.

But I'm not happy at all to add the prevent collapse issue, which is IMO a problem of the admin theme from the start. And since the default admin theme has no clearing on the widget content box, I'm fighting with this in various modules and custom admin pages and the admin theme. Resulting in the same fix in different modules and themes over and over again. Some solve it this way some the other way. It would be a easy fix in the core and I mentioned this so many times already that I gave up. This results in so many inconsistency now throughout the themes and modules, I hope with the new admin theme update in the future this will be fixed in some way. 

Share this post


Link to post
Share on other sites

Totally agree with the point about the box collapse. (Ryan Help!, see Soma's post before this one "ui-widget-content")

And oops, you you're right about toString my mind's a floating int string... 

  • Like 1

Share this post


Link to post
Share on other sites
It would be a easy fix in the core and I mentioned this so many times already that I gave up. This results in so many inconsistency now throughout the themes and modules, I hope with the new admin theme update in the future this will be fixed in some way. 

Totally agree with the point about the box collapse. (Ryan Help!, see Soma's post before this one "ui-widget-content")

I actually have no idea what you guys are talking about–tell me what to change? I understand code better than concept when it comes to CSS, so might need you to be literal as to what you suggest?

Share this post


Link to post
Share on other sites

.ui-widget-content needs to calculate it's height, the css overflow property can solve it.

post-577-0-78815700-1376404487_thumb.pngpost-577-0-74786800-1376404489_thumb.png

Welcome Pauline !

Edited by Martijn Geerts
  • Like 2

Share this post


Link to post
Share on other sites
.ui-widget-content needs to calculate it's height, the css overflow property can solve it.

Thanks, I have added this to the /wire/templates-admin/styles/inputfields.css

.Inputfields > .Inputfield > .ui-widget-content {
        /* the Inputfield's content, padded from the borders */
        padding: 1em;
        overflow: auto; 
}

...but am seeing odd results, specifically this scrollbar:

post-2-0-22858300-1376477096_thumb.png

So I changed it to this:

.Inputfields > .Inputfield > .ui-widget-content {
        /* the Inputfield's content, padded from the borders */
        padding: 1em;
        overflow-y: auto;
        overflow-x: hidden;
}

...and that seems to work. I'm not seeing any more oddities, but will keep testing. 

Just wanted to make sure this is consistent with what you guys are suggesting?

Also, it was mentioned earlier that there were various CSS hacks already in place to solve the problem that this CSS fixes? I guess I'm not sure what or where those are, but if you can point them out, it might help me to better understand the issue. Not to mention, if there is redundant/unnecessary code somewhere, I'd like to remove it. 

 

Share this post


Link to post
Share on other sites

Think your new styles will do, but there are more options.

Maybe the clearfix way is more robust, when I think about it.

You can do it with the clearfix way from Nicolas Gallagher.

.Inputfields > .Inputfield > .ui-widget-content {
    /* the Inputfield's content, padded from the borders */
    padding: 1em;
}

/* clearfix way, ps, don't need the IE7 zoom as PW doesn't allow IE7 in admin */
.Inputfields > .Inputfield > .ui-widget-content:before,
.Inputfields > .Inputfield > .ui-widget-content:after {
    content:"";
    display:table;
}
.Inputfields > .Inputfield > .ui-widget-content:after {
    clear:both;
}
  • Like 2

Share this post


Link to post
Share on other sites

Thanks, that looks better–I will give this one a try. 

  • Like 1

Share this post


Link to post
Share on other sites

With the new admin templates that come with the 2.3.5 version of PW there seems to be a bug related to the color swatches.

When clicked they do not execute anymore, so the color value of the swatch is not send to the color value. I'm almost certain it is related to CSS.

Removing the "templates-admin" folder from the site folder gives the "old" admin template in which it works fine.

I had no luck yet looking for a fix. Has anybody an idea what change causes this problem, or how to fix it?

Share this post


Link to post
Share on other sites

Adrian, thanks for posting the links to that topic.

But taking a look at the code i see its not realy a solution. I think it will not work when having multiple color pickers in one template.

The thing is that the colorpicket swatch work fine in the default admin template. But stop working in the new admin template.

I have taken a closer look and see that the solution Pete has posted is working great

http://processwire.com/talk/topic/4650-new-processwire-admin-theme-on-dev-branch/?p=46380

I have modified the javascript from the colorpicker module and it works now great on the "old" and "new" template aswell. And made a pull request on GitHub for soma.

Thanks guys!

Edited by Raymond Geerts
  • Like 2

Share this post


Link to post
Share on other sites

Got ColorPicker installed. Works nicely. Thanks!

Just found a small issue when validating the admin page: "No p element in scope but a p end tag seen." I fixed it by moving the <p> tag in InputfiedColorPicker.module from line 51 to line 56 like so:

from:

		$out  = "\n<p><div id='ColorPicker_$this->name' style='border:2px solid #444; display:block;";
		$out .= "width:40px; height:40px; background-color:";
		$out .= $this->value == "transp"
				? $this->value . "; background-image:url({$this->config->urls->InputfieldColorPicker}transparent.gif);"
				: "#" . $this->value . "; background-image:none";
		$out .= "' data-color='" . $this->value . "'></div>";

to:

		$out  = "\n<div id='ColorPicker_$this->name' style='border:2px solid #444; display:block;";
		$out .= "width:40px; height:40px; background-color:";
		$out .= $this->value == "transp"
				? $this->value . "; background-image:url({$this->config->urls->InputfieldColorPicker}transparent.gif);"
				: "#" . $this->value . "; background-image:none";
		$out .= "' data-color='" . $this->value . "'></div><p>";

My admin theme is modified a little, but I think the error came from this. Anyway, very useful module!

Share this post


Link to post
Share on other sites

I'm not sure what version you got, but the p tag wasn't missing closing tag, but it was wrong and not needed. Thanks for mention.

I pushed a little update with other small fixes.

  • Like 1

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By MoritzLost
      Hello there,
      I'm working on a tiny textformatter module that searches the text for titles of other pages on your site and creates hyperlinks to them. I'm not sure if something like this exists already, but I haven't found anything in the module directory, so I wrote my own solution 🙂
      It's not properly tested yet and is still missing some functionality I would like to implement, so at the moment it should be considered in BETA. Features include limiting the pages that will get searched by template, and adding a custom CSS class to the generated hyperlinks. As I'm writing this I noticed that it will probably include unpublished and hidden pages at the moment, so yeah ... it's still in development alright 😅
      You can download the module from Github:
      https://github.com/MoritzLost/TextformatterPageTitleLinks
      There's some more information in the readme as well.
      Anyway, let me know what you think! I'm happy about any feedback, possible improvements or ideas on how to improve the module. Cheers.
    • By adrian
      This module provides a way to rapidly generate Page fields and the required templates and pages for use as a drop down select (or any other Page field type).
      This module will let you create a full page field setup in literally a few seconds 
      To use, run Page Field Select Creator from the Setup Menu
      Enter a Field Title, eg: Room Types Select Options - These will become the child pages that will populate the page field select options. There are two different options.
       
      Option 1. TITLE FIELD ONLY - enter one option per line, eg:
       
      Single
      Double
      Suite
       
       
      Option 2. MULTIPLE FIELDS - the first line is used for the field names and the first field must be 'Title'. Subsequent lines are the values for the fields, eg:
       
      Title, Number of Beds, Number of People, Kitchen Facilities
      Single, 1, 1, Fridge Only
      Double, 2, 2, Fridge Only
      Suite, 3, 6, Full Kitchen
        Choose the parent where the page tree of options will be created, eg a hidden "Options" parent page Select a "Deference in API as" option depending on your needs Choose the input field type Check whether "Allow new pages to be created from field?" should be enabled. As an example, if you entered "Room Types" as the field title, you would end up with all of the following automatically created:
      a fully configured page field called: room_types MULTIPLE FIELDS OPTION - 3 additional fields - number_of_beds, number_of_people, kitchen a parent template called: room_types a child template called: room_types_items (with either just a title field, or with the 3 additional fields as well) a parent page called: Room Types a series of child pages named and titled based on the per line entries in the Select Options textarea The templates are configured such that the "room_types_items" child template can only have the main "room_types" template as a parent, and vice versa.

      Then all you have to do is add the newly created page field to any template you want and you're ready to go!
       
      You can grab it from:
       
      Modules directory: http://modules.processwire.com/modules/process-page-field-select-creator/
      Github: https://github.com/adrianbj/ProcessPageFieldSelectCreator
       

    • By bernhard
      WHY?
      This module was built to fill the gap between simple $pages->find() operations and complex SQL queries.
      The problem with $pages->find() is that it loads all pages into memory and that can be a problem when querying multiple thousands of pages. Even $pages->findMany() loads all pages into memory and therefore is a lot slower than regular SQL.
      The problem with SQL on the other hand is, that the queries are quite complex to build. All fields are separate tables, some repeatable fields use multiple rows for their content that belong to only one single page, you always need to check for the page status (which is not necessary on regular find() operations and therefore nobody is used to that).
      In short: It is far too much work to efficiently and easily get an array of data based on PW pages and fields and I need that a lot for my RockGrid module to build all kinds of tabular data.

      Basic Usage

       
      Docs & Download
      https://modules.processwire.com/modules/rock-finder/
      https://github.com/BernhardBaumrock/RockFinder
       
      Changelog
      180817, v1.0.6, support for joining multiple finders 180810, v1.0.5, basic support for options fields 180528, v1.0.4, add custom select statement option 180516, change sql query method, bump version to 1.0.0 180515, multilang bugfix 180513, beta release <180513, preview/discussion took place here: https://processwire.com/talk/topic/18983-rocksqlfinder-highly-efficient-and-flexible-sql-finder-module/
    • By BitPoet
      MediaLibrary
      Update: MediaLibrary can now be found in the official module list.
      Out of necessity, I've started to implement a simple media library module.
      The basic mechanism is that it adds a MediaLibrary template with file and image fields. Pages of this type can be added anywhere in the page tree.
      The link and image pickers in CKEditor are extended to allow quick selection of library pages from dropdowns. In the link picker this happens in the MediaLibrary tab, where you can also see a preview of the selected image. In the image picker, simply select a library from the dropdown at the top, everything else is handled by standard functionality.
      I've put the code onto github. This module is compatible with ProcessWire 3.
      Steps to usage:
      Download the module's zip from github (switch to the pw3 branche beforehand if you want to test on PW 3.x) and unpack it into site/modules Click "Modules" -> "Refresh" in the admin Click "Install" for MediaLibrary For testing, create a page with the MediaLibrary template under home (give it an expressive title like 'Global Media') and add some images and files Edit a differnt page with a CKEditor field and add a link and an image to see the MediaLibrary features in action (see the screencap for details) Optionally, go into the module settings for MediaLibrary Note: this module is far from being as elaborate as Kongondo's Media Manager (and doesn't plan to be). If you need a feature-rich solution for integrated media management, give it a look.
      Feel free to change the settings for MediaFiles and MediaImages fields, just keep the type as multiple.
      There are some not-so-pretty hacks for creating and inserting the correct markup, which could probably be changed to use standard input fields, though I'm a bit at a loss right now how to get it to work. I've also still got to take a look at error handling before I can call it fit for production. All feedback and pointers are appreciated (that's also why I post this in the development section).

      Edit 09.03.2016 / version 0.0.4: there's now also a "Media" admin page with a shortcut to quickly add a new library.

      Edit 01.05.2016:
      Version 0.0.8:
      - The module now supports nested media libraries (all descendants of eligible media libraries are also selectable in link/image picker).
      - There's a MediaLibrary::getPageMediaLibraries method you can hook after to modify the array of available libraries.
      - You can switch between (default) select dropdowns or radio boxes in the module configuration of MediaLIbrary to choose libraries.
      Edit 10.10.2018:
      Version 0.1.3:
      - Dropped compatibility for ProcessWire legacy versions by adding namespaces
      - Allow deletion of libraries from the Media overview admin page
      - Added an option to hide media libraries from the page tree (optionally also for superusers)
    • By Robin S
      This module corrects a few things that I find awkward about the "Add New Template" workflow in the PW admin. I opened a wishlist topic a while back because it would good to resolve some of these things in the core, but this module is a stopgap for now.
      Originally I was going to share these as a few standalone hooks, but decided to bundle them together in a configurable module instead.
      Add Template Enhancements
      A module for ProcessWire CMS/CMF. Adds some efficiency enhancements when adding or cloning templates via admin.

      Features
      Derive label from name when new template added: if you like to give each of your templates a label then this feature can save some time. The label can be added automatically when templates are added in admin, in admin/API, or not at all. There are options for underscore/hyphen replacement and capitalisation of the label. Edit template after add: when adding only a single template, the template is automatically opened for editing after it is added. Copy field contexts when cloning: this copies the field contexts (a.k.a. overrides such as column width, label and description) from the source template to the new template when using the "Duplicate/clone this template?" feature on the Advanced tab. Copy field contexts when duplicating fields: this copies the field contexts if you select the "Duplicate fields used by another template" option when adding a new template. Usage
      Install the Add Template Enhancements module.
      Configure the module settings according to what suits you.
       
      https://github.com/Toutouwai/AddTemplateEnhancements
      https://modules.processwire.com/modules/add-template-enhancements/