Guy Incognito Posted March 18, 2019 Share Posted March 18, 2019 11 minutes ago, adrian said: Not sure - I fixed so many bugs I can't recall anymore 🙂 Maybe have a read through my Github commits - it might note this, not sure. ha - great work on this - love the PW community! 😄 I've tried dropping your branch of the module into one of the affected sites but it doesn't seem to have fixed it 😕. Bit puzzled, as I'm almost certain things were working fine on all these sites previously. Link to comment Share on other sites More sharing options...
Peter Knight Posted April 14, 2019 Share Posted April 14, 2019 I'm using MarkupSEO 0.8.7 The Smart Image field which lets me select some image fields doesn't recognise one of an image field. Not sure if I should be using a different version? Thanks Link to comment Share on other sites More sharing options...
adrian Posted April 14, 2019 Share Posted April 14, 2019 1 minute ago, Peter Knight said: I'm using MarkupSEO 0.8.7 The Smart Image field which lets me select some image fields doesn't recognise one of an image field. Not sure if I should be using a different version? Thanks Try this: https://github.com/adrianbj/MarkupSEO/tree/various-fixes-enhancements Link to comment Share on other sites More sharing options...
Peter Knight Posted April 14, 2019 Share Posted April 14, 2019 Should I uninstall the previous one first? Quote Compile Error: Cannot declare class MarkupSEO, because the name is already in use (line 12 of /domain.com /site/modules/MarkupSEO/MarkupSEO.module.php) This error message was shown because: site is in debug mode. ($config->debug = true; => /site/config.php). Error has been logged. Link to comment Share on other sites More sharing options...
adrian Posted April 14, 2019 Share Posted April 14, 2019 Just now, Peter Knight said: Should I uninstall the previous one first? No need - that's just an error because PW doesn't like that I have added a .php extension to the module file when there is already a plain .module one installed. Just do a Modules > Refresh and you should be good. Link to comment Share on other sites More sharing options...
Peter Knight Posted April 14, 2019 Share Posted April 14, 2019 1 minute ago, adrian said: No need - that's just an error because PW doesn't like that I have added a .php extension to the module file when there is already a plain .module one installed. Just do a Modules > Refresh and you should be good. Thanks Adrian. That looks interesting. So essentially, I have more customised SEO options on a page level. Thanks for the work on this. I don't have the image field available yet. I might try creating a few other images fields and generally good around and see if I can track down the issue. Link to comment Share on other sites More sharing options...
adrian Posted April 14, 2019 Share Posted April 14, 2019 Actually @Peter Knight - you might try installing that version from scratch - I made several changes to fields and field types, so it might no longer be possible to simply upgrade from the old version. 1 Link to comment Share on other sites More sharing options...
Peter Knight Posted April 15, 2019 Share Posted April 15, 2019 On 4/14/2019 at 6:06 PM, adrian said: Actually @Peter Knight - you might try installing that version from scratch - I made several changes to fields and field types, so it might no longer be possible to simply upgrade from the old version. I tracked down the culprit of the Image field not appearing in the Smart Image option of this module. When an image field is set to Type=CroppableImages3, it is not recognised as an Images field. Setting my Images field from CroppableImages3 back to plain old Image worked. Obviously, you then loose your CroppableImages3 function but this was just to prove a theory. Not sure if this is something for you or @horst but just flagging here in case it's useful to anyone. BTW, upgrading over the existing install seemed to work fine in general. It might be safer to install from scratch but that completely removes all my existing settings. I tried it on a development environment first. Phew! Link to comment Share on other sites More sharing options...
horst Posted April 16, 2019 Share Posted April 16, 2019 Also worth a look for new projects: 2 Link to comment Share on other sites More sharing options...
frthr Posted April 22, 2019 Share Posted April 22, 2019 Hi, I am encoutering a strange issue, everything is on my local server, but I can't the customs value to print on the live stage. I have tried erasing the whole site and installed a fresh export profile, I tried uninstalling and reinstalling the module, nothing works. The data is in the db, so this either has to do with my server setup or a class import problem?? Anybody came across the same issue? Thanks Link to comment Share on other sites More sharing options...
iNoize Posted April 25, 2019 Share Posted April 25, 2019 On 4/14/2019 at 6:09 PM, adrian said: Try this: https://github.com/adrianbj/MarkupSEO/tree/various-fixes-enhancements Its still renders the keywords Meta from The older versions. How can i hide the Keyword meta ? Link to comment Share on other sites More sharing options...
adrian Posted April 25, 2019 Share Posted April 25, 2019 4 hours ago, iNoize said: Its still renders the keywords Meta from The older versions. How can i hide the Keyword meta ? I you sure the keywords are being generated by this module? As you can see, I removed all references to them: https://github.com/adrianbj/MarkupSEO/commit/d6d65af93127b88f63d328d61c55fa2544133342 Are you definitely using that branch of my fork? I guess I should probably merge that branch into my master now. Link to comment Share on other sites More sharing options...
iNoize Posted April 30, 2019 Share Posted April 30, 2019 On 4/25/2019 at 4:00 PM, adrian said: I you sure the keywords are being generated by this module? As you can see, I removed all references to them: https://github.com/adrianbj/MarkupSEO/commit/d6d65af93127b88f63d328d61c55fa2544133342 Are you definitely using that branch of my fork? I guess I should probably merge that branch into my master now. I had the old one also installed and the keywords were in the templates. Now it works great thanks 1 Link to comment Share on other sites More sharing options...
buster808 Posted June 9, 2019 Share Posted June 9, 2019 Hi, sorry if I'm being a bit naive here. Where there is Include basic twitter cards and Twitter username Would this then post to Twitter? Thanks, Great Module the way. Link to comment Share on other sites More sharing options...
Tyssen Posted September 11, 2019 Share Posted September 11, 2019 Is there a way for the SEO Title field to automatically be filled in with the Page Title if it's left blank? Link to comment Share on other sites More sharing options...
adrian Posted September 11, 2019 Share Posted September 11, 2019 1 minute ago, Tyssen said: Is there a way for the SEO Title field to automatically be filled in with the Page Title if it's left blank? Not sure, but I think my fork/branch does take care of that: https://github.com/adrianbj/MarkupSEO/tree/various-fixes-enhancements Link to comment Share on other sites More sharing options...
Tyssen Posted September 11, 2019 Share Posted September 11, 2019 I've tried updating with your fork Adrian, but it doesn't seem to. Also, after updating Use parent's values if empty doesn't work. Link to comment Share on other sites More sharing options...
adrian Posted September 11, 2019 Share Posted September 11, 2019 1 hour ago, Tyssen said: I've tried updating with your fork Adrian, but it doesn't seem to. Also, after updating Use parent's values if empty doesn't work. Did you try the Smart Title in the overall defaults? Link to comment Share on other sites More sharing options...
Tyssen Posted September 11, 2019 Share Posted September 11, 2019 Sorry, I had Use parent's values if empty checked previously and those fields didn't show until I unchecked it. All good now. 👍 1 Link to comment Share on other sites More sharing options...
iNoize Posted September 22, 2020 Share Posted September 22, 2020 12 hours ago, Ace864 said: I don't really get how this app should work. Can someone help me, please? I recently started a new blog, and I am searching for a less costly way to promote it. Hello, ok so what is the problem ? Ill try to explain it short. 1. Install the Module 2. Create a Field called "seo" with the type of "SeoMaestro" (Screen 1) 3. Edit your Template e.G. basic to add Seo field to the template which you heve created (Screen 2) 4. Put the code in your head from the site. (Screen 3) echo $page->seo->render(); So i hope you can understand:). The other settings you can setup in the seo field under the "Details" tab 1 Link to comment Share on other sites More sharing options...
gebeer Posted September 22, 2020 Share Posted September 22, 2020 @iNoize you are talking about SeoMaestro. But this is the thread for MarkupSeo module 😆 3 Link to comment Share on other sites More sharing options...
iNoize Posted September 22, 2020 Share Posted September 22, 2020 5 minutes ago, gebeer said: @iNoize you are talking about SeoMaestro. But this is the thread for MarkupSeo module 😆 Ups it was too early in the morning. 🤦♂️ Link to comment Share on other sites More sharing options...
Guy Incognito Posted January 22 Share Posted January 22 Hi all, Not sure if if everyone has jumped to SeoMaestro these days but I'm still fond of MarkupSeo and it's still live in many of our sites so I've made a few small but important tweaks based on real world usage. @adrian I've just made a pull request with these changes to your fixes branch in case others find these changes useful: Stopped canonical links from being able to inherit from parent pages: Inherited canonical links could cause problems with search engine indexing whereby you're inadvertently telling Google your new page is the same as another purely because you (or a client) missed the canonical field. So I think it is better for the default to be current page URL if the field is left blank rather than inherit the parent. Implemented handling of relative URLs in the canonical field: You can now use relative URLs in the canonical field for internal links. They will still render on the front end as SEO-friendly absolute URLs, but this way it is easier if you use different domains for testing or if you need to change the site domain. (https://github.com/mrjcgoodwin/MarkupSEO/tree/various-fixes-enhancements) 2 Link to comment Share on other sites More sharing options...
adrian Posted January 22 Share Posted January 22 Thanks @Guy Incognito I have merged your PR. I have switched to using SeoMaestro, but to be honest I am not particularly happy with either of these modules - both have their issues for my way of working / thinking. It will be interesting to see what RockSEO brings to the table. 2 1 Link to comment Share on other sites More sharing options...
Guy Incognito Posted January 23 Share Posted January 23 1 hour ago, adrian said: Thanks @Guy Incognito I have merged your PR. I have switched to using SeoMaestro, but to be honest I am not particularly happy with either of these modules - both have their issues for my way of working / thinking. It will be interesting to see what RockSEO brings to the table. Thanks 😊. I will check out RockSEO. The thing that has kept us on MarkupSEO to date is the simplicity for implementation and also for clients. Combined with the changes you’ve made previously it’s pretty effective at doing what it needs to. I’ll have a think if there’s anything else that can be done to improve it further. 1 Link to comment Share on other sites More sharing options...
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now