ryan

Module: ProcessWire Core Upgrade

106 posts in this topic

3 minutes ago, adrian said:

Definitely working here. Have you done a Modules > Refresh? Maybe it is caching the source?

Something must be wrong. I even deleted the cache folder, but nothing changed.

Share this post


Link to post
Share on other sites

I've found the problem. There is a method getCoreBranches which returns the branches already loaded in session if the second parameter is false. But it is never called with the second parameter set to true:

https://github.com/ryancramerdesign/ProcessWireUpgrade/blob/5333322703f0f47a6d6454e8fdb3107db330eec4/ProcessWireUpgradeCheck.module#L171

So I changed temporarily the call and it works now. But I gues it should be enough to relogin.

3 people like this

Share this post


Link to post
Share on other sites
1 minute ago, Richard Jedlička said:

I've found the problem. There is a method getCoreBranches which returns the branches already loaded in session if the second parameter is false. But it is never called with the second parameter to true: https://github.com/ryancramerdesign/ProcessWireUpgrade/blob/master/ProcessWireUpgradeCheck.module#L171

So I changed temporarily the call and it works now. But I gues it should be enough to relogin.

 

Nice sleuthing - sorry, I should have thought to mention that since I posted this issues ages ago: https://github.com/ryancramerdesign/ProcessWireUpgrade/issues/10

1 person likes this

Share this post


Link to post
Share on other sites
On 12/10/2016 at 8:50 PM, adrian said:

Have you done a Modules > Refresh? Maybe it is caching the source?

Thanks @adrian that worked for me - was getting 'Error loading GitHub branches' etc, but only for core. That fixed it.

<edit>..or at least it did temporarily. It let me upgrade the core (3.0.42 => 3.0.55) and install the new Uikit admin, and now it's back to saying there's a 403 error loading the core repository. Hmmm.</edit>

Edited by DaveP
Update (and it's not good...)
1 person likes this

Share this post


Link to post
Share on other sites

Update - I can confirm @Richard Jedlička's earlier post is correct. Changing line 171 of ProcessWireUpgradeCheck.module to 

$branches = $this->getCoreBranches(false, true);

fixes the (intermittent) problems I have been experiencing.

Share this post


Link to post
Share on other sites

I upgraded manually to 3.0.36 on one of my sites by replacing the wire folder and ProcessWireUpgrade worked. Then I upgraded via the module to 3.0.62. Now the error is back....

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.