Jump to content

Version Control


teppo

Recommended Posts

  • 2 weeks later...

Hey @Manon!

This seems like a good idea, so I've gone ahead and implemented it in Version Control 2.x (available via the dev branch int the GitHub repository). Note that if you're using Version Control 1.x, this update is not available there — I'm planning to merge the dev branch into master soon (this year at least), making 2.x the default version, and as such I'm not going to make any additional feature updates for 1.x releases.

Link to comment
Share on other sites

On 6/26/2020 at 7:49 PM, Jan Romero said:

But also, one thing, does anyone else feel that the diff should always be old to new? Right now when you open the history and click the most recent compare button, it’s the other way around. Wikipedia gives you one radio button for each version to compare and simply doesn’t let you select old to new. It’s kind of awkward and over-engineered, but I think the spirit of not going backwards in time is intuitive.

I guess it depends on your point of view. I can see how "always compare old to new" might make sense, but personally I prefer current approach, which is basically just "selected revision compared to any other revision".

At least for now I think that current approach is straightforward and makes sense (without requiring additional UI tricks, such as the one used by Wikipedia) 🤷‍♂️🙂

Link to comment
Share on other sites

In my site I use a templating system Template Engine Factory and I'm having a small issue when trying to visualize the preview revision inside the History tab, I get this error, the way the template engine passes variables between the controller and the view is not recognized  ($view->set('myvar',$myvar)), is something fixable? Thanks

image.thumb.png.47babb1b4e579622608022c0387708a6.png

Link to comment
Share on other sites

Hey @Sevarf2. Which version of Template Engine Factory is this? If it's 2.x, do you have auto_page_render setting enabled via module config?

I'm not particularly well versed in the inner workings of said module, but my initial assumption would be that it's related to the way it chooses which pages to render. It may also have something to do with hook priority, etc.

Anyway, let me know which version you're using, and I'll see if I can set up a quick test case.

Link to comment
Share on other sites

6 hours ago, teppo said:

Hey @Sevarf2. Which version of Template Engine Factory is this? If it's 2.x, do you have auto_page_render setting enabled via module config?

I'm not particularly well versed in the inner workings of said module, but my initial assumption would be that it's related to the way it chooses which pages to render. It may also have something to do with hook priority, etc.

Anyway, let me know which version you're using, and I'll see if I can set up a quick test case.

mmhhh never knew there was a 2.0 version...I was always relying on the automatic upgrade module and the 1.3 was the latest available...I'm gonna try it, maybe the issue will solve itself with the newer version, thanks

Link to comment
Share on other sites

  • 2 months later...

Curious if there is a use case for this module in conjunction with ProDrafts. Is there still utility in being able to callback past version of field values outside the realm of full page drafts? Is it redundant to have both Version Control and ProDrafts on a site? Does having drafts enabled for a template/field make things more confusing for VC?

Link to comment
Share on other sites

Thanks for a great module Teppo.

I don't suppose anyone has had success recording version control changes with front-end inline editing? I'm using inline editing on a personal project with just one specific field which is a large textarea (the rest use dialogue editor - works great).

Edit: Silly me, Version Control changes are indeed recorded with in-line editing. The field is within a repeater, so the front-end editor only saves changes to the repeater ID. It's still saved to the appropriate Version Control database tables.

  • Like 1
Link to comment
Share on other sites

  • 4 weeks later...

Has anyone been able to install any of the 2.x versions of Version Control with PW 3.0.165? I keep running into the following error:

Quote

[04-Jan-2021 18:49:50 America/Denver] PHP Fatal error:  Uncaught TypeError: Argument 1 passed to ProcessWire\Modules::setModuleConfigData() must implement interface ProcessWire\Module, string given, called in /home/word/public_html/wire/core/Wire.php on line 397 and defined in /home/word/public_html/wire/core/Modules.php:3697
Stack trace:
#0 /home/word/public_html/wire/core/Wire.php(397): ProcessWire\Modules->setModuleConfigData('ProcessVersionC...')
#1 /home/word/public_html/wire/core/WireHooks.php(823): ProcessWire\Wire->_callMethod('setModuleConfig...', Array)
#2 /home/word/public_html/wire/core/Wire.php(465): ProcessWire\WireHooks->runHooks(Object(ProcessWire\Modules), 'setModuleConfig...', Array)
#3 /home/word/public_html/site/modules/VersionControl/ProcessVersionControl.module(75): ProcessWire\Wire->__call('setModuleConfig...', Array)
#4 /home/word/public_html/wire/core/Modules.php(557): ProcessWire\ProcessVersionControl->__construct()
#5 /home/word/public_html/wire/core/Modules.php(1878): ProcessWire\Modules->newModule( in /home/word/public_html/wire/core/Modules.php on line 3697

 

Link to comment
Share on other sites

  • 1 month later...
1 hour ago, adrian said:

@Arcturus - I think you should be using the dev branch - I believe that the 2.0 branch is obsolete. @teppo ?

I'm pretty sure that aforementioned issue is now fixed in all the branches — but yes, you're correct, 2.0 branch is deprecated and the ones that are maintained — sort of — are dev (2.x) and master (1.x) 🙂

  • Like 1
Link to comment
Share on other sites

  • 3 months later...

@teppo Thank you very much for this module. I have enable version control on some fields at the user template. I'm using PHP 7.4.9 and when I visit a user page I'm getting this PHP Notice:

Trying to access array offset on value of type int in C:\laragon\www\mysite\wire\core\WireDatabasePDOStatement.php on line 107

 

Link to comment
Share on other sites

Hey @PWaddict!

So far I've been unable to reproduce that. I'm running PHP8, which should be close enough, but there are no warnings for me.

The error you've mentioned — assuming that you're using recent ProcessWire version — seems to point to WireDatabasePDOStatement::setDebugParam(), and more precisely it getting an integer as the param name. I've no idea how that could happen, and at the very least I can't find anything in Version Control that should (directly) cause it.

So... if you have any additional details, like where in the Version Control this error might originate, that'd be great. Also: which version of ProcessWire and which version of Version Control are you using?

Link to comment
Share on other sites

5 hours ago, teppo said:

Hey @PWaddict!

So far I've been unable to reproduce that. I'm running PHP8, which should be close enough, but there are no warnings for me.

The error you've mentioned — assuming that you're using recent ProcessWire version — seems to point to WireDatabasePDOStatement::setDebugParam(), and more precisely it getting an integer as the param name. I've no idea how that could happen, and at the very least I can't find anything in Version Control that should (directly) cause it.

So... if you have any additional details, like where in the Version Control this error might originate, that'd be great. Also: which version of ProcessWire and which version of Version Control are you using?

I guess you have to switch to 7.4.x to actually get the notice. I'm using the PW master version 3.0.165 and the 1.3.1 of Version Control. It happens only on the pages where I have enabled Version Control. I tested it also on a brand new PW installation where only Padloper module installed and I'm getting the same notice on the php_errors.log.

Link to comment
Share on other sites

5 hours ago, PWaddict said:

I guess you have to switch to 7.4.x to actually get the notice. I'm using the PW master version 3.0.165 and the 1.3.1 of Version Control. It happens only on the pages where I have enabled Version Control. I tested it also on a brand new PW installation where only Padloper module installed and I'm getting the same notice on the php_errors.log.

Generally speaking PHP 7 and 8 tend to work similarly in these situations — PHP 5 was more "forgiving" 🙂

Anyway, it could be related to VC 1.3.1. I've been using VC 2.x for a very long time, will have to set up a test site for 1.x.

Edit: turns out it's an issue affecting PW < 3.0.166. At least this particular instance of it is pretty easy to circumvent; I've prepared a fix, but will have to test carefully before releasing it.

  • Like 1
Link to comment
Share on other sites

  • 4 weeks later...
  • 3 weeks later...
19 hours ago, tires said:

Is there an easy way to echo the number of page edits / versions?

Currently you could get this from the versionControlRevisions property of the page. The value of said property is an array of all existing revisions, or null if none were found, so passing it to count() will tell you how many of those there were:

echo count($page->versionControlRevisions);
  • Like 2
Link to comment
Share on other sites

On 7/14/2021 at 8:11 PM, teppo said:

Currently you could get this from the versionControlRevisions property of the page. The value of said property is an array of all existing revisions, or null if none were found, so passing it to count() will tell you how many of those there were:

echo count($page->versionControlRevisions);

Thanks for your answer!

But it outputs nothing although there are about 10 versions.

When i do a "print_r" it outputs a "1":

print_r($page->versionControlRevisions)

Any ideas?

Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
  • Recently Browsing   0 members

    • No registered users viewing this page.
  • Similar Content

    • By MarkE
      This fieldtype and inputfield bundle was built for storing measurement values within a field, rendering them in a variety of formats and converting them to other units or otherwise modifying them via the API.
      The API consists of a number of predefined functions, some of which include...
      render() for rendering the measurement object, valueAs() for converting the value to another unit value, convertTo() for converting the whole measurement object to different units, and add() and subtract() for for modifying the stored value by the value (converted as required) in another measurement. In the admin the inputfield includes a checkbox (which can be optionally disabled) for converting values on page save. For an example if a value was typed in as centimeters, the unit was changed to metres, and the page saved with this checkbox selected, said value would be automatically converted so that e.g. 170 cm becomes 1.7 m.

      A simple length field using Fieldtype Measurement and Inputfield Measurement.
      Combination units (e.g. feet and inches) are also supported.
      Please note that this module is 'proof of concept' at the moment - there are limited units available and quite a lot of code tidying to do. More units will be added shortly.
      See the GitHub at https://github.com/MetaTunes/FieldtypeMeasurement for full details and updates.
    • By tcnet
      File Manager for ProcessWire is a module to manager files and folders from the CMS backend. It supports creating, deleting, renaming, packing, unpacking, uploading, downloading and editing of files and folders. The integrated code editor ACE supports highlighting of all common programming languages.
      https://github.com/techcnet/ProcessFileManager

      Warning
      This module is probably the most powerful module. You might destroy your processwire installation if you don't exactly know what you doing. Be careful and use it at your own risk!
      ACE code editor
      This module uses ACE code editor available from: https://github.com/ajaxorg/ace

      Dragscroll
      This module uses the JavaScript dragscroll available from: http://github.com/asvd/dragscroll. Dragscroll adds the ability to drag the table horizontally with the mouse pointer.
      PHP File Manager
      This module uses a modified version of PHP File Manager available from: https://github.com/alexantr/filemanager
       
    • By tcnet
      This module implements the website live chat service from tawk.to. Actually the module doesn't have to do much. It just need to inserted a few lines of JavaScript just before the closing body tag </body> on each side. However, the module offers additional options to display the widget only on certain pages.
      Create an account
      Visit https://www.tawk.to and create an account. It's free! At some point you will reach a page where you can copy the required JavaScript-code.

      Open the module settings and paste the JavaScript-code into the field as shown below. Click "Submit" and that's all.

      Open the module settings
      The settings for this module are located int the menu Modules=>Configure=>LiveChatTawkTo.

       
    • By tcnet
      Session Viewer is a module for ProcessWire to list session files and display session data. This module is helpful to display the session data of a specific session or to kick out a logged in user by simply delete his session file. After installation the module is available in the Setup menu.

      The following conditions must be met for the module to work properly:
      Session files
      Session data must be stored in session files, which is the default way in ProcessWire. Sessions stored in the database are not supported by this module. The path to the directory where the session files are stored must be declared in the ProcessWire configuration which is by default: site/assets/sessions.
      Serialize handler
      In order to transform session data easier back to a PHP array, the session data is stored serialized. PHP offers a way to declare a custom serialize handler. This module supports only the default serialize handlers: php, php_binary and php_serialize. WDDX was dropped in PHP 7.4.0 and is therefore not supported by this module as well as any other custom serialize handler. Which serialize handler is actually used you can find out in the module configuration which is available under Modules=>Configure=>SessionViewer.

      Session data
      The session data can be displayed in two different ways. PHP's default output for arrays print_r() or by default for this module nice_r() offered on github: https://github.com/uuf6429/nice_r. There is a setting in the module configuration if someone prefers print_r(). Apart from the better handling and overview of the folded session data the output of nice_r() looks indeed nicer.

      Links
      ProcessWire module directory
      github.com
    • By Robin S
      Repeater Easy Sort
      Adds a compact "easy-sort" mode to Repeater and Repeater Matrix, making those fields easier to sort when there are a large number of items.
      The module also enhances Repeater Matrix by allowing a colour to be set for each matrix type. This colour is used in the item headers and in the "add new" links, to help visually distinguish different matrix types in the inputfield.
      Screencasts
      A Repeater field

      A Repeater Matrix field with custom header colours

      Easy-sort mode
      Each Repeater/Matrix item gets an double-arrow icon in the item header. Click this icon to enter easy-sort mode.
      While in easy-sort mode:
      The items will reduce in width so that more items can be shown on the screen at once. The minimum width is configurable in the field settings. Any items that were in an open state are collapsed, but when you exit easy-sort mode the previously open items will be reopened. You can drag an item left/right/up/down to sort it within the items. The item that you clicked the icon for is shown with a black background. This makes it easier to find the item you want to move in easy-sort mode. You can click an item header to open the item. An "Exit easy-sort mode" button appears at the bottom of the inputfield. Configuration
      In the field settings for Repeater and Repeater Matrix fields you can define a minimum width in pixels for items in easy-sort mode. While in easy-sort mode the items will be sized to neatly fill the available width on any screen size but will never be narrower than the width you set here.
      In the field settings for Repeater Matrix you can define a custom header colour for each matrix type using an HTML "color" type input. The default colour for this type of input is black, so when black is selected in the input it means that no custom colour will be applied to the header.
      Exclusions
      The easy-sort mode is only possible on Repeater/Matrix fields that do not use the "item depth" option.
       
      https://github.com/Toutouwai/RepeaterEasySort
      https://processwire.com/modules/repeater-easy-sort/
×
×
  • Create New...