horst

WireMailSmtp

Recommended Posts

OK thanks Horst. I did start to use it this way, but was unsure about the other aspects and if more was included. I don't have a problem with the validation/sanitising routines per se. So thank you.

  • Like 1

Share this post


Link to post
Share on other sites

Horst, please can you tell me where the changelog for 0.2.2 is (I checked the usual spots), or am I safe to assume any _ . _ . N level change is so minor I can always just install it without any other checking on my sites etc? Thank you ^_^

Share this post


Link to post
Share on other sites

Using WireSmtp for WireMail so far...so great...my question is more based on the basic WireMail thing i think but i'm not shure:

using this call:

$mail = wireMail();
$mail->to($u->email);
$subject = '=?UTF-8?B?'.base64_encode('ÖÄÜ ö ä ü ß').'?=';
$mail->subject($subject);
$mail->bodyHTML($emailContentHtml);
$mail->send();

i don't get german umlaute öäüß working in the subject??

I've read the forum and stackoverflow but this is the only solution everyone points out so i'm a little lost...how to debug or get it work.

Best regards mr-fan

Share this post


Link to post
Share on other sites

You don't need anything like this. Just make sure that your php files are really stored in utf-8 encoding!! (PHP files you need to check in this reagrd are: the calling template file(s), the WireMailSMTP module files and the base WireMail files) Normally they all should be in utf-8 encoding, but better you check this thouroughly.

Then it works with simply using:

$subject = 'Ö Ä Ü ö ä ü ß';

I tested this just yet. The source of the received email looks like:

Subject: Wiremail-SMTP Test 15:57:23 =?UTF-8?q?=C3=A4=C3=B6=C3=BC_=C3=84=C3=96=C3=9C_=C3=9F?=
X-Mailer: ProcessWire/WireMailSmtp
Date: Wed, 8 Jun 2016 13:57:25 GMT +00:00
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

It does automated encoding, but you don't have to do anything by yourself.

  • Like 2

Share this post


Link to post
Share on other sites

Thank you very much - has a wrong encoding on my PHP Editor setup....so you saved my day!

Best regards mr-fan

Share this post


Link to post
Share on other sites

Horst did a nice job building this module.

One thing I'm missing though: Is there a method to embed an image? (cid-method). I've searched through the documentation of Manuel Lemos classes and found the following:

Quote

 

Alternatively, an image file can be embedded in an HTML message using multipart/related message parts. This type of message part is composed by creating the image file part with the CreateFilePart function.

Then use the GetPartContentID function the image part identifier text. Prepend the string 'cid:' to this identifier to form a special URL that should be used in the HTML part to reference the image part like this:

$image_tag = '<img src="cid:' . $message_object->GetPartContentID($image_part) . '">';

When you have composed the whole HTML document, create the HTML message part with the CreateHTMLPart or the CreateQuotedPrintableHTMLPart functions, and finally use the CreateRelatedMultipart function to create a message part that can be added to the message with the function AddAlternativeMultipart like HTML messages with alternative text parts described before.

Note that the HTML part must be the first listed in the parts array argument that is passed to the function CreateRelatedMultipart, or else the message may not appear correctly.

Note also that when you are composing an HTML message with embedded images and an alternative text part, first you need to create the multipart/alternative part with the HTML and the text parts using the CreateAlternativeMultipart function, and then you add the multipart/related part to the message with the AddRelatedMultipart function, passing an array of parts that lists first the multipart/alternative part and then the image part created before.

 

Seems the classes support embedding, but I guess the module does not yet?

Share this post


Link to post
Share on other sites

No, the module doesn't support it. And I cannot see much benefit for it. This is the only part what would be a really pain in the ***, if one would try to integrate this. And AFAIK, you get the same effect if you use the base64 data with your img src. And this can be done outside of the module.

 

// when building your HTML-content, you simply can add something like

$htmlcontent .= "<img src='data:image/png;base64," . base64_encode(file_get_contents($image->width(300)->filename)) . "' />";

 

Edited by horst
added code example
  • Like 1

Share this post


Link to post
Share on other sites

Hello,

I am building one form to send email with WireMailSmtp

every thing is working fine, only thing attachments are sending with email without any extension.

what i want to do is
Send email with attachment, this script send attachment with email but files are names like bnvft & angth (random names without extensions).
 

here is my code

if (isset($input->post->submit)) {

$form = array(
'name' => $input->post->name,
'email' => $input->post->email,
'message' => $input->post->message,
'email2' => $input->post->email2
);

$photo=$filetemp = $_FILES["photo"];
/// how to check that file is only image

$resume=$filetemp = $_FILES["resume"];
/// how to check the file is only PDF or word file

/// email12 is for spam boot
if($form[email2] =="")
{
$toName='my website';
$toEmail=$page->email;
$subject="CV EMail";
$textBody= "Full name: $form[name]\n" .
               "Email: $form[email]\n" .
			   "Message: $form[message]";

$mail = wireMail();
$mail->to($toEmail, $toName);
$mail->from = $toEmail; 
$mail->subject($subject);

$mail->attachment($photo);
$mail->attachment($resume);

$mail->body($textBody);

$numSent = $mail->send();
if($numSent)
{
  $output="Message Send";
}else{
  $output="Message Not Send";
}

}

}

Share this post


Link to post
Share on other sites

From where do you get the file(s)?

Can you please show this exact code snippet? (and only this, please) :)

The module is working fine. It just uses what you passes to it. So, you probably do something wrong in regard of your filenames / files passing to the module.

Share this post


Link to post
Share on other sites

Hello @horst,

Thanks for quick response, i am getting files from form , bellow is my form code

<form id="contactForm" action="" method='post' enctype="multipart/form-data" accept-charset='UTF-8'>
 <input type='text' name='name' id='name' required="" value='' maxlength="50" /><br/>
<input type='email' name='email' id='email' required="" value='' maxlength="50" /><br/>
<input type="file" name='photo' id='photo' accept='image/jpg,image/jpeg,image/gif,image/png' /><br/>
<input type="file" name='resume' required="" id='resume' accept="application/pdf,application/msword" /><br/>
</form>

and my php code is as i post above
 

$photo=$_FILES["photo"];
$resume=$_FILES["resume"];

$mail = wireMail();
$mail->to($toEmail, $toName);
$mail->from = $toEmail; 
$mail->subject($subject);

/// these are attachemnts
$mail->attachment($photo);
$mail->attachment($resume);

$mail->body($textBody);
$numSent = $mail->send();

But when i got email i got two attachments with random names but no extension.

Thanks

 

Share this post


Link to post
Share on other sites

Yes you get random names because you assigned them to your variables. If you don't like them, don't assign them. :)

$photo=$filetemp = $_FILES["photo"]["tmp_name"];

This has nothing to do with my module nor with PW. I suggest to follow up with the php docs on how to upload files, followed by how to use it with PWs WireUpload class. There you also have validation options for filetypes. IMO this is essential knowledge in regard of security to your website. Open it for uploads must be done in a secure way. Therefore you must understand, at least to a small extend, what you are doing.

  • Like 1

Share this post


Link to post
Share on other sites
3 minutes ago, horst said:

Yes you get random names because you assigned them to your variables. If you don't like them, don't assign them. :)

$photo=$filetemp = $_FILES["photo"]["tmp_name"];

This has nothing to do with my module nor with PW. I suggest to follow up with the php docs on how to upload files, followed by how to use it with PWs WireUpload class. There you also have validation options for filetypes.

even i use bellow i code i am getting same random names with no extension, why extensions are missing ?
 

$photo=$_FILES["photo"];
$resume=$_FILES["resume"];

Share this post


Link to post
Share on other sites

@mrkhan You are not handling the uploads correctly at the moment, take a close look at the first comment on the page horst pointed you to. It shows you what you need to know about handling file uploads. You should not trust the file-name supplied by the upload so that example shows you how to

  • validate that the file was supplied via an upload (using the move_uploaded_file() function)
  • how to name it without having to trust the supplied file name
  • how to validate the mime type of the file
  • how to append the extension that represents the file type of the uploaded file

You just need to remember the name you gave it when you moved it and attach that to your outgoing email. I've updated part of the code from the comment I linked to so that you can see how you might generate the new name and extension.

    // You should name it uniquely.
    // DO NOT USE $_FILES['upfile']['name'] WITHOUT ANY VALIDATION !!
    // On this example, obtain safe unique name from its binary data.
    $new_name = "./uploads/" . sha1_file($_FILES['upfile']['tmp_name'] . ".$ext";
    if (!move_uploaded_file($_FILES['upfile']['tmp_name'], $new_name))) {
        throw new RuntimeException('Failed to move uploaded file.');
    }

    // Now attach the uploaded, validated & renamed file to your email.
    $mail->attachment($new_name);

You'll need to tailor the code to do the needed validation on both of the files you want your users to upload of course. Don't forget to change where you want the files copied to as well.

  • Like 6

Share this post


Link to post
Share on other sites

Good day!
Is it somehow possible to test sending emails with WireMailSMTP without them actually being send? Something like you can do with regular php mail function in xampp where all the mail is put into a folder.

Share this post


Link to post
Share on other sites

Hi, no, it isn't possible currently out of the box.

You can hook into the ___send() method, and add / change the line 705, where the message normally will be send. Don't know if this is an easy task, as the method is really huge. I find this useful too, and add it to the feature request list of the module, but don't expect an early release.

  • Like 2

Share this post


Link to post
Share on other sites

I've just created a custom WireMail module, which does currently plainly logs all method calls and it's parameters to a logfile. I simply installed that one locally and WireMailSmtp on the live site.

  • Like 3

Share this post


Link to post
Share on other sites

@LostKobrakai: Nice and much better solution! This way, one can use it for all WireMail modules out there!

Share this post


Link to post
Share on other sites
14 minutes ago, LostKobrakai said:

I've just created a custom WireMail module, which does currently plainly logs all method calls and it's parameters to a logfile. I simply installed that one locally and WireMailSmtp on the live site.

Can you share it?

  • Like 2

Share this post


Link to post
Share on other sites
10 minutes ago, LostKobrakai said:

It could certainly be improved, but here you go. I'll probably not going to release it officially, so if someone would like to take a shot at it, feel free.

WireMailTesting.zip

Thank you very much!

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By dreerr
      TemplateEnginePug (formally TemplateEngineJade)
       
      This module adds Pug templates to the TemplateEngineFactory. It uses https://github.com/pug-php/pug to render templates.
      doctype html html(lang='en') head meta(http-equiv='content-type', content='text/html; charset=utf-8') title= $page->title link(rel='stylesheet', type='text/css', href=$config->urls->templates . 'styles/main.css') body include header.pug h1= $page->title if $page->editable() p: a(href=$page->editURL) Edit Project on GitHub: github.com/dreerr/TemplateEnginePug
      Project in modules directory: modules.processwire.com/modules/template-engine-pug/
       
      For common problems/features/questions about the Factory, use the TemplateEngineFactory thread.
       
    • By tpr
      ProcessNetteTester
      Run Nette Tester tests within ProcessWire admin.
      (continued from here)

      Features
      AJAX interface for running Nette Tester tests, in bulk or manually display counter, error message and execution time in a table run all tests at once or launch single tests show formatted test error messages and report PHP syntax errors stop on first failed test (optional) hide passed tests (optional) display failed/total instead passed/total (optional) re-run failed tests only (optional) auto scroll (optional) include or exclude tests based on query parameters start/stop all tests with the spacebar reset one test or all tests (ctrl+click) https://modules.processwire.com/modules/process-nette-tester/
      https://github.com/rolandtoth/ProcessNetteTester
    • By bernhard
      Some of you might have followed the development of this module here: https://processwire.com/talk/topic/15524-previewdiscussion-rockdatatables/ . It is the successor of "RockDataTables" and requires RockFinder to get the data for the grid easily and efficiently. It uses the open source part of agGrid for grid rendering.
       
      WHY?
      ProcessWire is awesome for creating all kinds of custom backend applications, but where it is not so awesome in my opinion is when it comes to listing this data. Of course we have the built in page lister and we have ListerPro, but none of that solutions is capable of properly displaying large amounts of data, for example lists of revenues, aggregations, quick and easy sorts by the user, instant filter and those kind of features. RockGrid to the rescue 😉 
       
      Features/Highlights:
      100k+ rows Instant (client side) filter, search, sort (different sort based on data type, eg "lower/greater than" for numbers, "contains" for strings) extendable via plugins (available plugins at the moment: fullscreen, csv export, reload, batch-processing of data, column sum/statistics, row selection) all the agGrid features (cell renderers, cell styling, pagination, column grouping etc) vanilla javascript, backend and frontend support (though not all plugins are working on the frontend yet and I don't plan to support it as long as I don't need it myself)  
      Limitations:
      While there is an option to retrieve data via AJAX the actual processing of the grid (displaying, filtering, sorting) is done on the client side, meaning that you can get into troubles when handling really large datasets of several thousands of rows. agGrid should be one of the most performant grid options in the world (see the official example page with a 100k row example) and does a lot to prevent problems (such as virtual row rendering), but you should always have this limitation in mind as this is a major difference to the available lister options that do not have this limitation.
      Currently it only supports AdminThemeUikit and I don't plan to support any other admin theme.
       
      Download: https://gitlab.com/baumrock/RockGrid
      Installation: https://gitlab.com/baumrock/RockGrid/wikis/Installation
      Quikckstart: https://gitlab.com/baumrock/RockGrid/wikis/quickstart
      Further instructions: https://gitlab.com/baumrock/RockGrid/wikis/quickstart#further-instructions
       
      Module status: alpha, License: MIT
      Note that every installation and uninstallation sends an anonymous google analytics event to my google analytics account. If you don't want that feel free to remove the appropriate lines of code before installation/uninstallation.
       
      Contribute:
      You can contribute to the development of this and other modules or just say thank you by
      testing, reporting issues and making PRs at gitlab liking this post buying me a drink: paypal.me/baumrock/5 liking my facebook page: facebook.com/baumrock hiring me for pw work: baumrock.com  
      Support: Please note that this module might not be as easy and plug&play as many other modules. It needs a good understanding of agGrid (and JavaScript in general) and it likely needs some looks into the code to get all the options. Please understand that I can not provide free support for every request here in the forum. I try to answer all questions that might also help others or that might improve the module but for individual requests I offer paid support for 60€ per hour.
       
      Changelog
      180711 bugfix (naming issue) 180630 alpha realease  
      Use Cases / Examples:
      Colored grid cells, Icons, Links etc. The Grid also has a "batcher" feature built in that helps communicating with the server via AJAX and managing resource intensive tasks in batches:

      Filters, PW panel links and instant reload on panel close:

      You can combine the grid with a chart library like I did with the (outdated) RockDataTables module:

    • By tpr
      Update 2018-07-09: ProcessNetteTester module is available in the Modules Directory and on GitHub.

      This is a short tutorial on how to use Nette Tester with ProcessWire.
      As you will see it's very easy to setup and use and it's perfect for testing your code's functionality. With bootstrapping ProcessWire it's also possible to check the rendered markup of pages using the API, checking page properties, etc. It's also a great tool for module developers for writing better code. 
      While there will be nothing extraordinary here that you couldn't find in Tester's docs this can serve as a good starting point.
      Prerequisites: PHP 5.6+
      01 Download Tester
      Go to https://github.com/nette/tester/releases and download the latest release (currently 2.0.2). Download from the link reading "Source code (zip)". You can use composer also if you wish.
      02 Extract Tester files
      Create a new directory in your site root called "tester". Extract the zip downloaded here, so it should look like this:
      /site /tester/src /tester/tools /tester/appveyor.yml /tester/composer.json /tester/contributing.md /tester/license.md /tester/readme.md /wire ... 03 Create directory for test files
      Add a new directory in "/tester" called "tests". Tester recognizes "*.Test.php" and "*.phpt" files in the tests directory, recursively. 
      04 Create your first test
      In the "tests" directory create a new "MyTest.php" file.
      The first test is a very simple one that bootstraps ProcessWire and checks if the Home page name is "Home". This is not the smartest test but will show you the basics.
      Add this to "/tester/tests/MyTest.php":
      <?php namespace ProcessWire; use \Tester\Assert; use \Tester\DomQuery; use \Tester\TestCase; use \Tester\Environment; require __DIR__ . '/../src/bootstrap.php'; // load Tester require __DIR__ . '/../../index.php'; // bootstrap ProcessWire Environment::setup(); class MyTest extends TestCase {     // first test (step 04)     public function testHomeTitle()     {         $expected = 'Home'; // we expect the page title to be "Home"         $actual = wire('pages')->get(1)->title; // check what's the actual title Assert::equal($expected, $actual); // check whether they are equal     }     // second test will go here (step 06)     // third test will go here (step 07) } // run testing methods (new MyTest())->run(); I've added comment placeholders for the second and third tests that we will insert later.
      05 Run Tester
      Tester can be run either from the command line or from the browser. The command line output is more verbose and colored while in the browser it's plain text only (see later).
      Running from the command line
      Navigate to the "/tester" directory in your console and execute this:
      php src/tester.php -C tests This will start "/tester/src/tester.php" and runs test files from the "/tester/tests" directory. The "-C" switch tells Tester to use the system-wide php ini file, that is required here because when bootstrapping ProcessWire you may run into errors (no php.ini file is used by default). You may load another ini file with the "-c <path>" (check the docs).
      If the title of your Home page is "Home" you should see this:

      If it's for example "Cats and Dogs", you should see this:

      Running from the browser
      First we need to create a new PHP file in ProcessWire's root, let's call it "testrunner.php". This is because ProcessWire doesn't allow to run PHP files from its "site" directory.
      The following code runs two test classes and produces a legible output. IRL you should probably iterate through directories to get test files (eg. with glob()), and of course it's better not allow tests go out to production.
      <?php ini_set('html_errors', false); header('Content-type: text/plain'); echo 'Starting tests.' . PHP_EOL; echo '--------------------------' . PHP_EOL; $file = __DIR__ . '/PATH_TO/FirstTest.php'; echo basename($file) . ' '; require $file; echo '[OK]' . PHP_EOL; $file = __DIR__ . '/PATH_TO/SecondTest.php'; echo basename($file) . ' '; require $file; echo '[OK]' . PHP_EOL; echo '--------------------------' . PHP_EOL; echo 'Tests finished.'; exit; Navigate to "DOMAIN/testrunner.php" in your browser to execute the file. If every test succeeds you should get this:

      If there are failed tests the execution stops and you can read the error message. If there were more tests (eg. ThirdTest), those won't be displayed under the failed test.

      06 DOM test
      This test will check if a page with "basic-page" template has a "h1" element. We will create the page on the fly with ProcessWire's API. To keep things simple we will add the new test as a new method to our MyTest class.
      Add this block to the MyTest class:
      public function testBasicPageHeadline() {     $p = new Page();     $p->template = 'basic-page';     $html = $p->render();     $dom = DomQuery::fromHtml($html);     Assert::true($dom->has('h1')); } This will most likely be true but of course you can check for something more specific, for example "div#main". Note that we have used the DomQuery helper here (check the "use" statement on the top of the file).
      07 Custom function test
      You will probably want to make sure your custom functions/methods will work as they should so let's write a test that demonstrates this.
      I don't want to complicate things so I'll check if the built-in "pageName" sanitizer works as expected. Add this to the myTest class:
      public function testPageNameSanitizer() {     $expected = 'hello-world';     $actual = wire('sanitizer')->pageName('Hello world!', true);     Assert::equal($expected, $actual); } This should also be true. Try to change the expected value if you are eager to see a failure message.
       
      08 Next steps
      You can add more methods to the MyTest class or create new files in the "tests" directory. Check out the range of available Assertions and other features in the docs and see how they could help you writing more fail-safe code.
      Once you make a habit of writing tests you'll see how it can assist making your code more bulletproof and stable. Remember: test early, test often 🙂
      If you find out something useful or cool with Tester make sure to share.
    • By bernhard
      @Sergio asked about the pdf creation process in the showcase thread about my 360° feedback/survey tool and so I went ahead and set my little pdf helper module to public.
      Description from PW Weekly:
       
      Download & Docs: https://gitlab.com/baumrock/RockPdf
       
      You can combine it easily with RockReplacer: 
      See also a little showcase of the RockPdf module in this thread: