Jump to content

Recommended Posts

Ok, now that files are flying like flies (heh heh), I think I will focus to next version of AdminBar, but will also try to implement Aloha Editor module.

I will start from Ryan's code and concept above. Idea is that Aloha Editor would play nice with or without AdminBar. If you have AB installed, then it would use the same UI.

Share this post


Link to post
Share on other sites

Current dev version of AdminBar gives a nasty js alert on IE9 (not sure about earlier ones): "Load jQuery first!". It happens occasionally when clicking "Edit page" link. Not everytime, but about 50% of times.

It comes from tiny_mce.js file. I changed that part from:

return alert("Load jQuery first!");

to

return false;

and everything seems to be running smoothly. I assume that jQuery is needed for those link & image modals? If so, then silent fail here should be ok, since it won't take long that jQuery gets loaded (those works in my tests even when I get the alert). IE9 seems to have many bugs related to how it loads javascript files, and this is probably just one of those. Whatever the reason is, it seems that occasionally in IE9 and using Adminbar, tinymce gets loaded before jQuery.

In the other news: for some reason removing pages from AdminBar works now (I haven't done anything, and it didn't work in 2.0). It redirects to /processwire/ after deleting (I think that is good solution here).

Share this post


Link to post
Share on other sites

mmm...i'm trying to use this adminbar but when editing a page i get this error:

Template '/home/processw/public_html/site/templates/' is not allowed

If i edit the page via admin it works.  :-\

Share this post


Link to post
Share on other sites

Ryan, I took your code and started taking it further. It is very good start and not much to do really. I have Aloha editor floating around my content already and I am starting to implement the saving.

<?php

    public function format(&$str) {
        if(!$this->page->editable()) return;
        $str = "<div id='fieldname' class='aloha-editable'>$str</div>";        
    }

Is there any easy way to get that id='fieldname' to textformatter? So does the textformatter know what is the field name that uses it? Fieldname is something that I wanna know, when I save the edited content, isn't it?

PS: testing this made me think that there probably will be some issues using Aloha on front and TinyMCE on the back. Not sure though? If they both provide clean enough output, then it will work. Need to test this well after this is ready.

PPS: http://drupal.org/node/1018352 (it seems to be much harder to implement on drupal - not a surprise though, but interesting read)

Share this post


Link to post
Share on other sites

Played more with Aloha:

  • Since Aloha makes only one instance for multiple editables (which is great for performance), it makes this harder to implement. We need to strip functionality based on what kind of field is edited (textarea or just text). We don't want to allow adding headers inside of header etc. There probably are methods on Aloha API that let us do that. If not, then we have to live with it or just use very bare bones version of Aloha (inline elements only).
  • Editing feels very fast and natural. Now I want to also drop images to the website :)
  • I already implemented this to play nicely with AdminBar - it adds new button to Adminbar, if you have it installed (Quick Edit). And after you start editing content, there appears second new button: "Save Aloha" which gives you a nice little alert with all the editable content.

Share this post


Link to post
Share on other sites
Is there any easy way to get that id='fieldname' to textformatter? So does the textformatter know what is the field name that uses it? Fieldname is something that I wanna know, when I save the edited content, isn't it?

I've just depreciated the Textformatter::format($str) function in favor of Textformatter::formatValue(Page $page, Field $field, $value). I guess I didn't consider the things we'd be using Textformatter for in the future. :) But it should be ready to go now. Just grab the latest commit and implement the 'formatValue' version rather than the 'format' version in your Textformatter module. You can now get the field name from $field->name.

Since Aloha makes only one instance for multiple editables (which is great for performance), it makes this harder to implement. We need to strip functionality based on what kind of field is edited (textarea or just text). We don't want to allow adding headers inside of header etc. There probably are methods on Aloha API that let us do that. If not, then we have to live with it or just use very bare bones version of Aloha (inline elements only).

I see what you mean, though am surprised they don't provide built in capability to deal with single-line (titles) vs multi-line (textareas) markup. We could always strip paragraph and heading tags from the single line fields.

PS: testing this made me think that there probably will be some issues using Aloha on front and TinyMCE on the back. Not sure though? If they both provide clean enough output, then it will work. Need to test this well after this is ready.

So long as they are both dealing with the same kind of markup tags, I think we'll be fine here. Though not positive.:)

I'm excited to see how this goes!

Thanks,

Ryan

Share this post


Link to post
Share on other sites
Title fields - I was too pessimistic, even one of their examples have different options for title

Not sure I understand? Looks like this is one giant field to cover the entire page. :) Pretty impressive with the 3 columns actually. That's not something I'm used to seeing in HTML. Definitely not something I've seen in TinyMCE. This 1-giant-field for the entire page is probably not something you'd see much of in the real world, beyond a demo.

Aloha seems pretty useful even if just used for multiline fields. Though it'd be great if it had some option to place limits on the markup a user can use, for single line fields at least. But I don't see anything like that, looking through their site. We can always just strip the block-level stuff.

Share this post


Link to post
Share on other sites

If you click the big "Moby Dick" header, then you can only add links, not change formatting at all. Exactly what we want to do with headers (probably many times want to disable links too...).

The 3 columns is simple stuff, using vendor specific css:

-webkit-column-width: 300px;
-webkit-column-gap: 30px;
-moz-column-width: 300px;
-moz-column-gap: 30px;
width: 960px;

Share this post


Link to post
Share on other sites
If you click the big "Moby Dick" header, then you can only add links, not change formatting at all. Exactly what we want to do with headers (probably many times want to disable links too...).

Pretty cool!  Somehow I completely missed that, thinking it was a background image or something.

The 3 columns is simple stuff, using vendor specific css:

Nice, I've not experimented with the multi-column stuff... looks interesting.

Share this post


Link to post
Share on other sites

Just realized that aloha.js is almost 1 meg javascript minified... it has jquery build in, but also ExtJS. That does complicates things (I had this first loading in admin also, and earlier version (I assume) of jQuery was messing things up...). It would be real problem on front end to make sure that your site jQuery or ExtJS (if you use either one) is always the same version than Aloha requires... There was aloha-nodeps.js included, but need to add ExtJS and jQuery separately then. It just feels damn bloated for such a "small" functionality (I really want to have quick edits and save).

This made me thinking of building super simple editor by myself (there is nice html5 API for that too). Or might add some other light weight editor (I don't consider aloha a light weight anymore)... Not sure though and will definitely take Aloha further and test it more (make it save stuff).

What do you guys think? What are the features you are expecting from "quick editing"? Just editing text & save? Strong, italics? Headers? Links? Images?

Share this post


Link to post
Share on other sites

Just realized that aloha.js is almost 1 meg javascript minified... it has jquery build in, but also ExtJS. That does complicates things (I had this first loading in admin also, and earlier version (I assume) of jQuery was messing things up...). It would be real problem on front end to make sure that your site jQuery or ExtJS (if you use either one) is always the same version than Aloha requires... There was aloha-nodeps.js included, but need to add ExtJS and jQuery separately then. It just feels damn bloated for such a "small" functionality (I really want to have quick edits and save).

I also was shocked about the 1meg. Quite a bummer. ExtJS alone is beyond imaginable, and that just for quick edits. Let alone the complications that can occur. Well it would be possible to run your site jQuery in a seperate namespace and make sure your JQ loads before Aloha ones... headache granted – Well in first place I was also thinking about doing something simple self brewn, that fits into PW. Just discovered Aloha few days ago. I thought it may usable but also sensed it may overkill and too akward to implement, use. Not to mention depend on it.

This made me thinking of building super simple editor by myself (there is nice html5 API for that too). Or might add some other light weight editor (I don't consider aloha a light weight anymore)... Not sure though and will definitely take Aloha further and test it more (make it save stuff).

What do you guys think? What are the features you are expecting from "quick editing"? Just editing text & save? Strong, italics? Headers? Links? Images?

Yeah images would be extasic.

Lists? Small? Paragraph?

Are you planning writing a wysiwyg in this case? Or using tinymce?

Also what are you seeing will be the way to define what fields are editable on page? Something that's controlled in by the template file would be cool.

BTW: I already hear a "Oooooh! my text is screwed, I copied from Word into the page!"

Share this post


Link to post
Share on other sites

I spend few hours last night to read about contenteditable and how to implement simple js rich text editor. It sounds simple (browsers have it built in, since IE 5.5 - then reverse engineered from there to other browsers). But (and pretty big but) - the implementation is very messy. Gotta respect TinyMCE & Co more, that is actually super messy stuff that different browsers provide (I tested just chrome, ff and opera) and amazed that there has been so little progress on that area. This being said I don't think I have time (or skills) to build solid rt-editor from scratch.

I started to look if there is any library that can clean the html (I found some stuff to clean word pasting) that different browsers provide and make them similar in each, but no luck there. Maybe I could loan some parts from other projects (if their licencing allows) if it possible. Not sure though.

If someone finds simple editor, that provides about the same markup and can be added to any element (not just textarea), that would be great. If not, I probably continue with Aloha and try to do my best with multiple jQuery versions.

Share this post


Link to post
Share on other sites
Just realized that aloha.js is almost 1 meg javascript minified... it has jquery build in, but also ExtJS.

Wow that's surprising... rather bloated for what it does. On the other hand, every one of their demos has loaded fast and I would have never guessed about the file size. So maybe it's not the issue that it appears to be at first, given that it's for admin rather than public users. I'm just thankful for browser JS caching.

When it gets down to it, all web-based rich text editors seem problematic for one reason or another. It's always a compromise… just the nature of the beast I guess.

Share this post


Link to post
Share on other sites

Yep. After reading more about how contentEditable/designMode work (most of the editors use designMode - textarea goes into iframe) and how buggy the support is, then it is not surprise that there are so much issues. Add in tons of features, many different use cases (copy from word, from another website, undo button etc), normal browser rendering differencies, then it will be clear that it's not a simple case. And aloha-editor does use contentEditable instead of designMode, which seems to be even more buggier.

But it seems that Aloha is the best (only inline editor?) there is currently so I will continue with that.

Share this post


Link to post
Share on other sites

It does look interesting–good find. I couldn't get their demo to work (in the latest Chrome, other than the nav bar at the top), but am curious about it. Have you tried it out or had any luck getting it to work?

Share this post


Link to post
Share on other sites

It does work. Not the whole page is editable, only left sidebar and bottom at the middle column. Editable areas have blue outlines.

Share this post


Link to post
Share on other sites

Strangely I couldn't get it to work before (must have been something up with my browser). It works great now. Seems like quite a nice solution they've got here. What's your opinion of this vs. Aloha?

Share this post


Link to post
Share on other sites

Not sure yet. After playing a while with Aloha the floating bar starts to annoy a little. The more I use the more I wish it wouldn't float. It's true that you can lock the aloha position, but you would do that always depending on the placement. "Always on top" feels more solid and it is what we (and our clients) have used to. Word doesn't have anything floating around.

This is just a gut feeling, but Mercury also feels like better coded, and better documented (not much, but there is nice annotated source: http://jejacks0n.github.com/mercury/annotated_source/mercury.html) it has cleaner licencing and uses only jQuery (where aloha uses jQuery & ExtJS). So far it feels like Mercury would be better, but it is more just a feeling than anything. I really need to dive deeper to know which one suits better.

Share this post


Link to post
Share on other sites

I'm on the same wavelength. I already after 1 minute of aloha, thought the floating thing is annoying... I really like the top bar of mercury. I would chose it. Just my 2 cents.

Share this post


Link to post
Share on other sites

I agree. I think Aloha is being marketed better, but Mercury seems like the better product based on my relatively brief experience with them. Though Aloha's massive size weighs heavily on my impression too. :)

Share this post


Link to post
Share on other sites

Few minor additions to AdminBarNew (I will soon switch that as a master and leave 2.0 adminbar as a legacy branch):

  • Only show add page button when adding pages is allowed (thanks Soma!)
  • Show lock icon with description text when editing is not allowed or page is locked - instead of hiding the bar totally
  • Added js files to bottom instead of head - will work even if you load your jQuery at bottom (and you might wanna do that for performance reasons)

Share this post


Link to post
Share on other sites

Added "adminbar" permission (other roles than superuser needs that, otherwise they won't see adminbar).

If anyone got the last version, you might wanna update. Just realized that it probably did show adminbar for everyone (guests too).

This (AdminBarNew branch) feels pretty stable now, but please report any issues to GitHub or here. I wanna keep this as slim as possible. Probably only new feature that I will add is logout-button that Soma suggested at GitHub. While testing aloha editor I realized that it is super simple to extend adminbar from additional modules, so that is the way I take with new ideas (and hopely others want to extend AdminBar too).

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By gebeer
      I am happy to present my new fieldtype FieldtypeImageFromPage. It is made up of 2 modules:
      Fieldtype Image Reference From Another Page is a Fieldtype that stores a reference to a single image from another page. The image can be selected with the associated Inputfield.
      Inputfield Select Image From Page is an Inputfield to select a single image from images on a predefined page and it's children.
      And there also is a helper module that takes care of cleanup tasks.
      This module evolved out of a discussion about my other Module FieldtypeImagePicker.  It caters for use cases where a set of images is being reused multiple times across a site. With this fieldtype these images can be administered through a chosen page. All images uploaded to that page will be available in the inputfield.
      When to use ?
      Let editors choose an image from a set of images that is being used site-wide. Ideal for images that are being re-used across the site.
      Suited for images that are used on multiple pages throughout the site (e.g. icons).
      Other than the native ProcessWire images field, the images here are not stored per page. Only references to images on another page are stored. This has several advantages:
      one central place to organize images when images change, you only have to update them in one place. All references will be updated, too. (Provided the name of the image that has changed stays the same) Features
      Images can be manipulated like native ProcessWire images (resizing, cropping etc.) Image names are fully searchable through the API Accidental image deletion is prevented. When you want to delete an image from one of the pages that hold your site-wide images, the module searches all pages that use that image. If any page contains a reference to the image you are trying to delete, deletion will be prevented. You will get an error message to help you edit those pages and remove references there before you can finally delete the image. How to install and setup
      Download and install this module like any other modules in ProcessWire Create a page in the page tree that will hold your images. This page's template must have an images field Upload some images to the page you created in step 2 Create a new field. As type choose 'Image Reference From Another Page'. Save the field. In 'Details' Tab of the field choose the page you created in step 2 Click Save button Choose the images field name for the field that holds your images (on page template from step 2) Click Save button again Choose whether you want to include child pages of page from step 2 to supply images Add the field to any template You are now ready to use the field View of the inputfield on the page edit screen:

      View of the field settings

      The module can be installed from this github repo. Some more info in the README there, too.
      In my tests it was fairly stable. After receiving your valued feedback, I will eventually add it to the modules directory.
      My ideas for further improvement:
      - add ajax loading of thumbnails
      Happy to hear your feedback!
       
    • By gebeer
      Although the PW backend is really intuitive, ever so often my clients need some assistance. Be it they are not so tech savvy or they are not working in the backend often.
      For those cases it is nice to make some help videos available to editors. This is what this module does.
      ProcessHelpVideos Module
      A Process module to display help videos for the ProcessWire CMS. It can be used to make help videos (screencasts) available to content editors.
      This module adds a 'Help Videos" section to the ProcessWire backend. The help videos are accessible through an automatically created page in the Admin page tree. You can add your help videos as pages in the page tree. The module adds a hidden page to the page tree that acts as parent page for the help video pages. All necessary fields and templates will be installed automatically. If there are already a CKEditor field and/or a file field for mp4 files installed in the system, the module will use those. Otherwise it will create the necessary fields. Also the necessary templates for the parent help videos page and it's children are created on module install. The module installs a permission process-helpvideos. Every user role that should have access to the help video section, needs this permission. I use the help video approach on quite a few production sites. It is stable so far and well received by site owners/editors. Up until now I installed required fields, templates and pages manually and then added the module. Now I added all this logic to the install method of the module and it should be ready to share.
      The module and further description on how to use it is available on github: https://github.com/gebeer/ProcessHelpVideos
      If you like to give it a try, I am happy to receive your comments/suggestions here.
    • By Robin S
      A module created in response to the topic here:
      Page List Select Multiple Quickly
      Modifies PageListSelectMultiple to allow you to select multiple pages without the tree closing every time you select a page.
      The screencast says it all:

       
      https://github.com/Toutouwai/PageListSelectMultipleQuickly
      https://modules.processwire.com/modules/page-list-select-multiple-quickly/
    • By gebeer
      Hello all,
      sharing my new module FieldtypeImagePicker. It provides a configurable input field for choosing any type of image from a predefined folder.
      The need for it came up because a client had a custom SVG icon set and I wanted the editors to be able to choose an icon in the page editor.
      It can also be used to offer a choice of images that are used site-wide without having to upload them to individual pages.
      There are no image manipulation methods like with the native PW image field.
      Module and full description can be found on github https://github.com/gebeer/FieldtypeImagePicker
      Kudos to @Martijn Geerts. I used his module FieldTypeSelectFile as a base to build upon.
      Here's how the input field looks like in the page editor:

      Hope it can be of use to someone.
      If you like to give it a try, I'm happy to hear your comments or suggestions for improvement. Eventually this will go in the module directory soon, too.
    • By bernhard
      @Sergio asked about the pdf creation process in the showcase thread about my 360° feedback/survey tool and so I went ahead and set my little pdf helper module to public.
      Description from PW Weekly:
       
      Modules Directory: https://modules.processwire.com/modules/rock-pdf/
      Download & Docs: https://github.com/BernhardBaumrock/RockPDF
       
      You can combine it easily with RockReplacer: 
      See also a little showcase of the RockPdf module in this thread:
       
×
×
  • Create New...