Jump to content
adrian

Custom Upload Names

Recommended Posts

I have an image field inside repeater along with some text fields. Is it possible to rename the image using 1 of those text fields?

Share this post


Link to post
Share on other sites
1 hour ago, PWaddict said:

I have an image field inside repeater along with some text fields. Is it possible to rename the image using 1 of those text fields?

I am sure support could be added for this. Any chance you feel like having a go at implementing it? Sorry I am juggling lots of different commitments right now, but I'll take a look when I can if you don't get to it first 🙂

Share this post


Link to post
Share on other sites
54 minutes ago, adrian said:

I am sure support could be added for this. Any chance you feel like having a go at implementing it? Sorry I am juggling lots of different commitments right now, but I'll take a look when I can if you don't get to it first 🙂

I don't know If I can do it but I will try.

  • Like 1

Share this post


Link to post
Share on other sites

Unfortunately I haven't figured it out yet. This could take me days to fully understand your module and currently can't spend more time on it as I need to finish 2 projects.

Share this post


Link to post
Share on other sites
21 hours ago, PWaddict said:

Unfortunately I haven't figured it out yet. This could take me days to fully understand your module and currently can't spend more time on it as I need to finish 2 projects.

Turns out it already works 🙂

Just use $repeaterPage instead of $page.

Let me know if it works ok for you.

  • Like 1

Share this post


Link to post
Share on other sites

Actually, an even better option is probably to use $filePage as this will automatically choose the field from the repeater if the image is uploaded to a repeater image field or the main $page if the image is uploaded to an image field on the main page. Does that make sense?

 

  • Like 1

Share this post


Link to post
Share on other sites
1 hour ago, adrian said:

Actually, an even better option is probably to use $filePage as this will automatically choose the field from the repeater if the image is uploaded to a repeater image field or the main $page if the image is uploaded to an image field on the main page. Does that make sense?

 

Yep. It works perfect. Thanks again.

Btw in case you don't know if re-order the rules and then press submit the re-order doesn't saved.

  • Like 1

Share this post


Link to post
Share on other sites
20 hours ago, PWaddict said:

Yep. It works perfect. Thanks again.

Great!

20 hours ago, PWaddict said:

Btw in case you don't know if re-order the rules and then press submit the re-order doesn't saved.

Thanks, not sure when that happened - probably newly broken in UiKit theme. Should be fixed now.

Share this post


Link to post
Share on other sites
34 minutes ago, adrian said:

Thanks, not sure when that happened - probably newly broken in UiKit theme. Should be fixed now.

It needs a simple fix to properly work. You're using cache busting on js & css files by using the module version.

You have to replace module's version to 111 otherwise we get this: ProcessCustomUploadNames.js?v=1 instead of ProcessCustomUploadNames.js?v=111

  • Like 1

Share this post


Link to post
Share on other sites
25 minutes ago, PWaddict said:

You have to replace module's version to 111

Or rather not cast the version to int for use in the query string. I had to make this change in several of my modules after I switched to semantic version numbers.

  • Like 2

Share this post


Link to post
Share on other sites
6 hours ago, PWaddict said:

It needs a simple fix to properly work. You're using cache busting on js & css files by using the module version.

You have to replace module's version to 111 otherwise we get this: ProcessCustomUploadNames.js?v=1 instead of ProcessCustomUploadNames.js?v=111

Sorry about that - fixed in the latest version.

  • Thanks 1

Share this post


Link to post
Share on other sites

Hi!
There is a problem trying to upload a file from a custom frontend.

PHP Warning: count(): Parameter must be an array or an object that implements Countable in ...\ProcessCustomUploadNames.module.php:176


I have this problem since v. 1.1.0. So I had to rollback to 1.0.9.

The file is saved on the disc but not on the database.

My setup is:
Apache 2.4
Php 7.2.6
PW 3.0.120

error-custom-upload-names.JPG

Share this post


Link to post
Share on other sites
6 minutes ago, adrian said:

@Crowdland Technology - please try the attached version. I don't have any time to test right at the moment. If that doesn't work as is, please also uncomment line 160.

 

ProcessCustomUploadNames.zip

Thank you Adrian, I tryed it and now the error is:
Parse error: syntax error, unexpected 'if' (T_IF) in D:\var\www\realhomecrm\site\assets\cache\FileCompiler\site\modules\ProcessCustomUploadNames\ProcessCustomUploadNames.module.php on line 177

Share this post


Link to post
Share on other sites
47 minutes ago, Crowdland Technology said:

Thank you Adrian, I tryed it and now the error is:
Parse error: syntax error, unexpected 'if' (T_IF) in D:\var\www\realhomecrm\site\assets\cache\FileCompiler\site\modules\ProcessCustomUploadNames\ProcessCustomUploadNames.module.php on line 177

Sorry, please try this one.

ProcessCustomUploadNames.zip

Share this post


Link to post
Share on other sites
8 hours ago, Crowdland Technology said:

It worked. Thank you!
Only this warning remaings but not sure why.


PHP Warning: filemtime(): stat failed for D:/var/www/realhomecrm/site/assets/files/1319/andorra-729795_1280.jpg in D:\var\www\realhomecrm\wire\core\Pagefile.php:524

I am not seeing anything like that, but it might be something specific to your frontend upload form - it looks to me like it is trying to access the old filename. Could you share the code you are using?

Is that error there in 1.0.9?

PS - I have update the module to the last version I sent to you above.

Share this post


Link to post
Share on other sites
4 hours ago, adrian said:

I am not seeing anything like that, but it might be something specific to your frontend upload form - it looks to me like it is trying to access the old filename. Could you share the code you are using?

Is that error there in 1.0.9?

PS - I have update the module to the last version I sent to you above.

Hi! The is no problem in version 1.0.9.

This is my code.

 

if (isset($_POST['galeria'])) {
	// process form input
	$formGaleria->processInput($input->post);

	if (!count($formGaleria->getErrors())) {
		// if no error occured
		// create new page and save values
		$uploadpage = $pages->findOne("template=db-propiedad,id=$idPropiedad");
		$uploadpage->of(false);
		$files = explode("|", $formGaleria->get("imagenes")->value);
		$targetWidth = 1024;
		$targetHeight = 768;
		foreach ($files as $file) {
			if ($file && file_exists($upload_path . $file)) {

				$filenameOrig = $file;
				$options = array('upscaling' => false, 'quality' => 100, 'sharpening' => 'soft');
				$imageSizer = new ImageSizer($upload_path.$filenameOrig, $options);
				$success = $imageSizer->resize($targetWidth, $targetHeight);
				if($success) {
					$uploadpage->imagenes->add($upload_path . $filenameOrig);
				}
				unlink($upload_path . $file);
			}
		}
		$uploadpage->save();
		$session->redirect($pages->get("/crm/propiedades/imagenes")->url . $idPropiedad);
	} else {
		// form incomplete or errors happened
		// we remove uploaded files
		$files = explode("|", $formGaleria->get("imagenes")->value);
		foreach ($files as $file) {
			if ($file && file_exists($upload_path . $file)) {
				unlink($upload_path . $file);
			}
		}
		$formGaleria->get("imagenes")->value = ''; // reset field value
	}
}

 

Share this post


Link to post
Share on other sites

@Crowdland Technology - thanks for posting that. I honestly think you should consider converting the upload form to be a little more ProcessWire-y. Take a look at the second set of code blocks (the ones that include the file field) in this post: https://processwire.com/talk/topic/3105-create-pages-with-file-upload-field-via-api/

I just tested CustomUploadNames with this approach and there are no errors. I think the problem you are having is related to unlinking, but it would be good to get confirmation on where that error you are seeing is originating from - a stack tracy from TracyDebugger should help with that - you might need to toggle strict mode on from the Panel Selector to get the trace because it's a warning rather than a fatal error.

 

 

Share this post


Link to post
Share on other sites

I have a repeater field with 12 repeater items and each item has an image field too. I've added the related rename rule on the module but when I save the page it only renames the top 3 items. I'm using the latest version (1.1.5).

EDIT: On another repeater with 5 repeater items everything is working properly. The only difference between those 2 repeaters is that the one with the 12 items is on a hidden page without a template file and it has svg images.

  • Like 1

Share this post


Link to post
Share on other sites
1 hour ago, PWaddict said:

I have a repeater field with 12 repeater items and each item has an image field too. I've added the related rename rule on the module but when I save the page it only renames the top 3 items. I'm using the latest version (1.1.5).

EDIT: On another repeater with 5 repeater items everything is working properly. The only difference between those 2 repeaters is that the one with the 12 items is on a hidden page without a template file and it has svg images.

Could you please narrow it down to whether it's due to no template file, the page being hidden, or because they're svg files?

 

Share this post


Link to post
Share on other sites
2 hours ago, adrian said:

Could you please narrow it down to whether it's due to no template file, the page being hidden, or because they're svg files?

None of the above is the problem. It seems that the module doesn't work well with repeaters. I tried to add new item on the repeater that is supposed to be working properly and it messed up that too. When I upload the image on the repeater item and saved the page the image gets renamed but I get just a broken blank image. 

In the files folder I'm getting the following images:

test_1544143931.-thumbnail.0x48n.jpg (Broken / blank)
test_1544143931.-thumbnail.300x0n.jpg (Broken / blank) This shouldn't be even there yet as I'm generating this variation via API and I didn't visit the frontend page during the test.

test_1544143934.260x0.jpg
test_1544143934.jpg
test_1544143934.-thumbnail.0x48n.jpg
test_1544143934.-thumbnail.jpg

Also if I try to delete that broken image from the image field that is inside the repeater item I'm getting this:

Quote

Warning: filemtime(): stat failed for C:/xampp/htdocs/mysite/site/assets/files/9091/test_1544143931.jpg in C:\xampp\htdocs\mysite\wire\core\Pagefile.php on line 541

 

  • Like 1

Share this post


Link to post
Share on other sites

@PWaddict - I have been testing here with repeaters a lot for the last few versions and it all seems to be working fine. Do you get the same issues on a new page starting from scratch? Just wondering if there are some effects of old images in existing repeaters instigated from an older version of this module?

Also wondering if your Filename Format setting is contributing to the problem - what are you currently using?

Share this post


Link to post
Share on other sites
3 minutes ago, adrian said:

@PWaddict - I have been testing here with repeaters a lot for the last few versions and it all seems to be working fine. Do you get the same issues on a new page starting from scratch? Just wondering if there are some effects of old images in existing repeaters instigated from an older version of this module?

All these days I was testing only with already uploaded images. I will test from scratch and will let you know.

4 minutes ago, adrian said:

Also wondering if your Filename Format setting is contributing to the problem - what are you currently using?

I thought that this could the problem but it isn't. On the filename format I tried even with just the word "test" and when I was saving the page only some of them were renamed and when I saved again and again more and more images were getting renamed to "test".

  • Like 1

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By Robin S
      A community member raised a question and I thought a new sanitizer method for the purpose would be useful, hence...
      Sanitizer Transliterate
      Adds a transliterate method to $sanitizer that performs character replacements as defined in the module config. The default character replacements are based on the defaults from InputfieldPageName, but with uppercase characters included too.
      Usage
      Install the Sanitizer Transliterate module.
      Customise the character replacements in the module config as needed.
      Use the sanitizer on strings like so:
      $transliterated_string = $sanitizer->transliterate($string);
       
      https://github.com/Toutouwai/SanitizerTransliterate
      https://modules.processwire.com/modules/sanitizer-transliterate/
       
    • By dimitrios
      Hello,
      this module can publish content of a Processwire page on a Facebook page, triggered by saving the Processwire page.
      To set it up, configure the module with a Facebook app ID, secret and a Page ID. Following is additional configuration on Facebook for developers:
      Minimum Required Facebook App configuration:
      on Settings -> Basics, provide the App Domains, provide the Site URL, on Settings -> Advanced, set the API version to 2.10, add Product: Facebook Login, on Facebook Login -> Settings, set Client OAuth Login: Yes, set Web OAuth Login: Yes, set Enforce HTTPS: Yes, add "http://www.example.com/processwire/page/" to field Valid OAuth Redirect URIs. This module is configurable as follows:
      Templates: posts can take place only for pages with the defined templates. On/Off switch: specify a checkbox field that will not allow the post if checked. Specify a message and/or an image for the post.
      Usage
      edit the desired PW page and save; it will post right after the initial Facebook log in and permission granting. After that, an access token is kept.
       
      Download
      PW module directory: http://modules.processwire.com/modules/auto-fb-post/ Github: https://github.com/kastrind/AutoFbPost   Note: Facebook SDK for PHP is utilized.


    • By thomasaull
      I created a little helper module to trigger a CI pipeline when your website has been changed. It's quite simple and works like this: As soon as you save a page the module sets a Boolean via a pages save after hook. Once a day via LazyCron the module checks if the Boolean is set and sends a POST Request to a configurable Webhook URL.
      Some ideas to extend this:
      make request type configurable (GET, POST) make the module trigger at a specified time (probably only possible with a server cronjob) trigger manually Anything else? If there's interest, I might put in some more functionality. Let me know what you're interested in. Until then, maybe it is useful for a couple of people 🙂
      Github Repo: https://github.com/thomasaull/CiTrigger
    • By Robin S
      I created this module a while ago and never got around to publicising it, but it has been outed in the latest PW Weekly so here goes the support thread...
      Unique Image Variations
      Ensures that all ImageSizer options and focus settings affect image variation filenames.

      Background
      When using methods that produce image variations such as Pageimage::size(), ProcessWire includes some of the ImageSizer settings (height, width, cropping location, etc) in the variation filename. This is useful so that if you change these settings in your size() call a new variation is generated and you see this variation on the front-end.
      However, ProcessWire does not include several of the other ImageSizer settings in the variation filename:
      upscaling cropping, when set to false or a blank string interlace sharpening quality hidpi quality focus (whether any saved focus area for an image should affect cropping) focus data (the top/left/zoom data for the focus area) This means that if you change any of these settings, either in $config->imageSizerOptions or in an $options array passed to a method like size(), and you already have variations at the requested size/crop, then ProcessWire will not create new variations and will continue to serve the old variations. In other words you won't see the effect of your changed ImageSizer options on the front-end until you delete the old variations.
      Features
      The Unique Image Variations module ensures that any changes to ImageSizer options and any changes to the focus area made in Page Edit are reflected in the variation filename, so new variations will always be generated and displayed on the front-end.
      Installation
      Install the Unique Image Variations module.
      In the module config, set the ImageSizer options that you want to include in image variation filenames.
      Warnings
      Installing the module (and keeping one or more of the options selected in the module config) will cause all existing image variations to be regenerated the next time they are requested. If you have an existing website with a large number of images you may not want the performance impact of that. The module is perhaps best suited to new sites where image variations have not yet been generated.
      Similarly, if you change the module config settings on an existing site then all image variations will be regenerated the next time they are requested.
      If you think you might want to change an ImageSizer option in the future (I'm thinking here primarily of options such as interlace that are typically set in $config->imageSizerOptions) and would not want that change to cause existing image variations to be regenerated then best to not include that option in the module config after you first install the module.
       
      https://github.com/Toutouwai/UniqueImageVariations
      https://modules.processwire.com/modules/unique-image-variations/
    • By Sebi
      I've created a small module which lets you define a timestamp after which a page should be accessible. In addition you can define a timestamp when the release should end and the page should not be accessable any more.
      ProcessWire-Module: http://modules.processwire.com/modules/page-access-releasetime/
      Github: https://github.com/Sebiworld/PageAccessReleasetime
      Usage
      PageAccessReleasetime can be installed like every other module in ProcessWire. Check the following guide for detailed information: How-To Install or Uninstall Modules
      After that, you will find checkboxes for activating the releasetime-fields at the settings-tab of each page. You don't need to add the fields to your templates manually.
      Check e.g. the checkbox "Activate Releasetime from?" and fill in a date in the future. The page will not be accessable for your users until the given date is reached.
      If you have $config->pagefileSecure = true, the module will protect files of unreleased pages as well.
      How it works
      This module hooks into Page::viewable to prevent users to access unreleased pages:
      public function hookPageViewable($event) { $page = $event->object; $viewable = $event->return; if($viewable){ // If the page would be viewable, additionally check Releasetime and User-Permission $viewable = $this->canUserSee($page); } $event->return = $viewable; } To prevent access to the files of unreleased pages, we hook into Page::isPublic and ProcessPageView::sendFile.
      public function hookPageIsPublic($e) { $page = $e->object; if($e->return && $this->isReleaseTimeSet($page)) { $e->return = false; } } The site/assets/files/ directory of pages, which isPublic() returns false, will get a '-' as prefix. This indicates ProcessWire (with activated $config->pagefileSecure) to check the file's permissions via PHP before delivering it to the client.
      The check wether a not-public file should be accessable happens in ProcessPageView::sendFile. We throw an 404 Exception if the current user must not see the file.
      public function hookProcessPageViewSendFile($e) { $page = $e->arguments[0]; if(!$this->canUserSee($page)) { throw new Wire404Exception('File not found'); } } Additionally we hook into ProcessPageEdit::buildForm to add the PageAccessReleasetime fields to each page and move them to the settings tab.
      Limitations
      In the current version, releasetime-protected pages will appear in wire('pages')->find() queries. If you want to display a list of pages, where pages could be releasetime-protected, you should double-check with $page->viewable() wether the page can be accessed. $page->viewable() returns false, if the page is not released yet.
      If you have an idea how unreleased pages can be filtered out of ProcessWire selector queries, feel free to write an issue, comment or make a pull request!
×
×
  • Create New...