Jump to content
adrian

Custom Upload Names

Recommended Posts

Just now, PWaddict said:

It seems that only if the value is empty the cleanBasename will properly work in Windows.

@matjazp - can you confirm this on your setup?

If this is reproducible it sounds like we need to file an issue as it's not related to this module.

Share this post


Link to post
Share on other sites

I was suspecting locale problems from the very beginning, that's why I asked to dump basename() and pathinfo() calls since they are both locale aware. Just to test again, could you @PWaddict try this:

d(basename("ä"));

with and without translated "C" in LanguageSupportModule? Though I'm getting the correct results regardless of "C" value.

That's why we have a check that is performed on every login (and some changes are introduced recently to better clarify the issue here)! Do you get a warning message when you log in, something like "Note: your current server locale setting isn’t working as expected with the UTF-8 charset and may cause minor issues. Your current locale setting is “en_US.UTF-8”. Please translate the “C” locale setting for each language to the compatible locale in  ... " ? if not, then why you translated the "C" in the first place and also translated to the nonexisting locale? There is no need to translate "C" string on windows (from my experience). Windows don't have "en_US.UTF-8" locale, that's why PW suggest "en-US". The list of supported locales on windows: https://msdn.microsoft.com/library/cc233982.aspx , see the language tag column.

As for getting mixed results: the locale information is maintained per process, not per thread. If you are running PHP on a multithreaded server API like IIS, HHVM or Apache on Windows, you may experience sudden changes in locale settings while a script is running, though the script itself never called setlocale(). This happens due to other scripts running in different threads of the same process at the same time, changing the process-wide locale using setlocale().

Glad you solved the problem 🙂 

  • Like 2

Share this post


Link to post
Share on other sites

Wow @matjazp - thanks for a brilliantly detailed answer - much appreciated. i must admin I am not very au fait with this locale stuff.

I guess I am a little curious why PW's cleanBasename() has issues with this and yet $sanitizer->filename() and $sanitizer->pagName() with Sanitizer::translate do not. I guess I feel like they should all handle these translations the same way and so should all be subject to the same "issue".

 

Share this post


Link to post
Share on other sites
2 minutes ago, adrian said:

I guess I am a little curious why PW's cleanBasename() has issues with this and yet $sanitizer->filename() and $sanitizer->pagName() with Sanitizer::translate do not. I guess I feel like they should all handle these translations the same way and so should all be subject to the same "issue".

Yep. But it's hard to work on things that are working and you are trying to make them not working just do debug them 🙂 

Share this post


Link to post
Share on other sites
24 minutes ago, matjazp said:

Just to test again, could you @PWaddict try this:

d(basename("ä"));

with and without translated "C" in LanguageSupportModule? Though I'm getting the correct results regardless of "C" value.

I'm getting "ä" (2) on both.

I translated the "C" string for the languages long time ago for 2 reasons: 

- Displaying on frontend the months in date format for each locale.
- Adding months on page names via ProcessSetupPageName module.

For the main language actually I had "en_US.utf8, English_United States" and for the alternate languages "es_ES.utf8, Spanish_Spain.1252" & "de_DE.utf8, German_Germany.1252". On each locale the first string is for Linux and the 2nd for Windows. I left both there as the "C" notes saying: Specify CSV string of locales to try multiple locales in order. That way I don't need to switch locales when for example I migrate the database from the live server on localhost for developing, testing etc.

It seems that I don't need the "en_US.utf8, English_United States" for the main language so I left it empty but what if the main language wasn't English? How could I do the above if translating the "C" string on main language is causing problems on cleanBasename?

Share this post


Link to post
Share on other sites
5 hours ago, matjazp said:

I cant't help any more since I'm going to a vacation for a few days. It would be helpful if you find the reason for all this. Will it help if you use just "en-US" for the windows locale? Or try this script: https://www.zen-cart.com/attachment.php?s=ecb022422821941d39f3bff5511c3ecb&attachmentid=16404&d=1465221878

It doesn't matter if I enter a valid or a non-valid locale on "C" string. The cleanBasename will always be broken if "C" isn't empty. I tried this on the fresh PW installation and the same problem happens so I will post an issue on GitHub.

Thanks for the help @adrian & @matjazp and wish you Merry Christmas!

  • Like 1

Share this post


Link to post
Share on other sites

Having a dot on the text field it doesn't process the filename properly after that dot. It happens on both Windows & Linux.

Text Field value: T. Test ä
Filename: t._test____1545258287.jpg

Text Field value: Test ä T.
Filename: test_a_t._1545258287.jpg

Note: That issue doesn't happen on 1.2.2.

  • Like 1

Share this post


Link to post
Share on other sites
4 hours ago, PWaddict said:

Having a dot on the text field it doesn't process the filename properly after that dot. It happens on both Windows & Linux.

Thanks @PWaddict - it should be fixed in 1.2.5

  • Thanks 1

Share this post


Link to post
Share on other sites
On 12/21/2018 at 4:27 PM, PWaddict said:

It doesn't matter if I enter a valid or a non-valid locale on "C" string. The cleanBasename will always be broken if "C" isn't empty. I tried this on the fresh PW installation and the same problem happens so I will post an issue on GitHub

I'm still not satisfied as I can't replicate this. I would like to perform some more tests, but don't want to pollute this thread, so if you are interested in narrowing down this issue, please PM me, @PWaddict 

  • Like 1

Share this post


Link to post
Share on other sites

@PWaddict could you please modify $basename = strtolower($basename); to $basename = mb_strtolower($basename); in cleanBasename method in /wire/core/Pagefiles.php (line 568).

  • Like 1
  • Thanks 1

Share this post


Link to post
Share on other sites
2 hours ago, matjazp said:

@PWaddict could you please modify $basename = strtolower($basename); to $basename = mb_strtolower($basename); in cleanBasename method in /wire/core/Pagefiles.php (line 568).

It's working PERFECT. Thank you. Please post the solution on the GitHub issue.

  • Like 1

Share this post


Link to post
Share on other sites

Thanks for the feedback. I posted suggested solution on the github. 

On 12/21/2018 at 6:26 AM, adrian said:

I guess I am a little curious why PW's cleanBasename() has issues with this and yet $sanitizer->filename() and $sanitizer->pagName() with Sanitizer::translate do not.

That's because $sanitizer->(file)name() checks for multibyte support and uses mb_strtolower().

  • Like 1

Share this post


Link to post
Share on other sites
2 hours ago, matjazp said:

@PWaddict could you please modify $basename = strtolower($basename); to $basename = mb_strtolower($basename); in cleanBasename method in /wire/core/Pagefiles.php (line 568).

Nice catch!

It's interesting because many of the $sanitizer methods make use of the internal nameFilter() method which uses mb_strtolower.

If you actually follow the cleanBasename method it goes through $sanitizer filename(), which uses name(), which uses nameFilter() which leads me to believe that it might actually be possible to just remove that that: $basename = strtolower($basename); line from the cleanBasename() method completely. I just tested this and it's actually pretty close - there are a couple of problems - one is the regex on #578 needs A-Z added to it. The other is that beautify doesn't get passed through to nameFilter() which is a condition for mb_strtolower() being called.

Anyway, that was just an interesting excursion into what is actually going on and where 🙂

  • Like 1

Share this post


Link to post
Share on other sites

Hi @PWaddict

Could you please make the thread readable by putting your long trace of logs into "spoilers"? This one and the another one:

On 12/20/2018 at 10:32 PM, PWaddict said:

Here are the results:

 

 

  • Like 1

Share this post


Link to post
Share on other sites

@adrian I found a small bug. Using slashes for example on the title field the image doesn't rename properly. For example on title field I have: Poster/Flyer and the image renamed to flyer.jpg where it should be poster_flyer.jpg.

  • Like 1

Share this post


Link to post
Share on other sites
8 hours ago, PWaddict said:

@adrian I found a small bug. Using slashes for example on the title field the image doesn't rename properly. For example on title field I have: Poster/Flyer and the image renamed to flyer.jpg where it should be poster_flyer.jpg.

Should be fixed now!

  • Thanks 1

Share this post


Link to post
Share on other sites

Hello @adrian

Today I noticed a very strange behaviour with the module. If I upload an image on the Image or CroppableImage3 field and then add a new repeater item on a repeater field and publish / save the page, the image doesn't display on front-end. The image and its variations are visible on back-end and on the related folder in assets.

If I first add a new repeater item on a repeater field and then upload an image on the Image or CroppableImage3 field then there is NO problem. WTF?

I verified that this is caused by the module cause when I temporarily disable the rule there was NO problem. My rule is: {$page->title}_{$file->mtime} with Rename on Save checked.

I'm using PW 3.0.135.

Share this post


Link to post
Share on other sites

@PWaddict - I feel like I have replicated your described workflow and I am not seeing any problems so I will need more troubleshooting from you. 

Why doesn't the image display on the frontend - is the code trying to display an image with a non-existant path?
What code are you using to display the image?
What are the image settings - anything related to the max files or overwrite settings that are relevant?

Anything you can do to narrow it down further would be very helpful.

Share this post


Link to post
Share on other sites

The structure on my template is in this order:

various fields
Image field
Repeater field
Repeater field
various fields

The image doesn't display on frontend because it seems that it doesn't get saved in database??? I'm checking if the image exists like this: if($page->image) etc. There is nothing wrong in the code on template cause if I save the page AGAIN then this time the image is properly getting saved and displayed on frontend.

Image Maximum files allowed: 1
Formatted value: Automatic

EDIT: It's a multi-language site.

Share this post


Link to post
Share on other sites

I am testing on a multi-language site and just changed to max files 1 and it's still all working as expected. Sorry, I am not sure what else to look at right now. I am curious what Tracy's PageFiles panel reports after the initial saving of the page.

Share this post


Link to post
Share on other sites
1 hour ago, adrian said:

I am curious what Tracy's PageFiles panel reports after the initial saving of the page.

Tracy displays them in orange color as orphans.

Share this post


Link to post
Share on other sites

Hm, after I checked the "Overwrite existing files?" on image field the problem is gone. So, the module to properly work needs that option checked?

Share this post


Link to post
Share on other sites

Does it help if you use $filePage instead of $page for the rule?

What about "name" instead of "title"?

What about if you don't have the $file->mtime component?

 

Share this post


Link to post
Share on other sites

Ok, I think I have narrowed it down - if you don't have "overwrite" checked and you use $file->mtime it doesn't know how to name the file at the correct point it needs to. It's also necessary to have "Rename on Save" checked to have this problem.

Let me see if I can fix.

  • Like 1

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By BitPoet
      Here's a small new module that started as a spinoff of a memcache proof-of-concept. Cache your strings and partials in-memory using Redis as a backend.
      CacheRedis
      All you need is a running Redis database. The module supports connection through regular TCP, over TLS and via unix domain sockets. Host and port are configurable, and authentication is supported too. Here's a screenshot of the module configuration options:

      I'll not go into too many details about the usage, you can see everything explained in the README on GitHub, and just highlight the most important points.
      When the module is active, you'll have a wired $redis variable, which means you can reach the module as $redis, wire("redis") or within Wire classes / modules as $this->redis.
      CacheRedis is strongly influenced by WireCache, and its usage is (hopefully) straight forward.
      // Store an entry in the cache under the given key name with the given value: $redis->store("cached_value_number_one", $expire, $value); // Retrieve a value from the cache $value = $redis->fetch($key); // Delete a cache entry $redis->delete("my_other_cached_value"); // Clear the whole cache $redis->flush(); // Retrieve a value from the cache, and if not found, create it through the given function // and store it with a lifetime of 5 minutes (300 seconds) $value = $redis->fetch($key, 300, function() use($page) { return "Page last changed on " . strftime('%m/%d/%Y %H:%M', $page->modified | $page->created); }); // Render a file using wireRenderFile and store it in the cache. // We'll pass a selector as the expiry value so this cache gets // emptied every time a page matching the selector is saved. $news = $redis->renderFile("partials/news.php", 'template=blog-post', ["page" => $page]); The module is still very crude work in progress, but I hope some of you feel daring, try it out and let me know in case anything breaks.
      Have fun!
    • By joshua
      This module is (yet another) way for implementing a cookie management solution.
      Of course there are several other possibilities:
      - https://processwire.com/talk/topic/22920-klaro-cookie-consent-manager/
      - https://github.com/webmanufaktur/CookieManagementBanner
      - https://github.com/johannesdachsel/cookiemonster
      - https://www.oiljs.org/
      - ... and so on ...
      In this module you can configure which kind of cookie categories you want to manage:

      You can also enable the support for respecting the Do-Not-Track (DNT) header to don't annoy users, who already decided for all their browsing experience.
      Currently there are four possible cookie groups:
      - Necessary (always enabled)
      - Statistics
      - Marketing
      - External Media
      All groups can be renamed, so feel free to use other cookie group names. I just haven't found a way to implement a "repeater like" field as configurable module field ...
      When you want to load specific scripts ( like Google Analytics, Google Maps, ...) only after the user's content to this specific category of cookies, just use the following script syntax:
      <script type="optin" data-type="text/javascript" data-category="statistics" data-src="/path/to/your/statistic/script.js"></script> <script type="optin" data-type="text/javascript" data-category="marketing" data-src="/path/to/your/mareketing/script.js"></script> <script type="optin" data-type="text/javascript" data-category="external_media" data-src="/path/to/your/external-media/script.js"></script> <script type="optin" data-type="text/javascript" data-category="marketing">console.log("Inline scripts are also working!");</script> The type has to be "optin" to get recognized by PrivacyWire, the data-attributes are giving hints, how the script shall be loaded, if the data-category is within the cookie consents of the user. These scripts are loaded asynchronously after the user made the decision.
      If you want to give the users the possibility to change their consent, you can use the following Textformatter:
      [[privacywire-choose-cookies]] It's planned to add also other Textformatters to opt-out of specific cookie groups or delete the whole consent cookie.
      You can also add a custom link to output the banner again with a link / button with following class:
      <a href="#" class="privacywire-show-options">Show Cookie Options</a> <button class="privacywire-show-options">Show Cookie Options</button> This module is still in development, but we already use it on several production websites.
      You find it here: PrivacyWire Git Repo
      Download as .zip
      I would love to hear your feedback 🙂
      CHANGELOG
      0.0.5 Multi-language support included completely (also in TextFormatter). Added possibility to async load other assets (e.g. <img type="optin" data-category="marketing" data-src="https://via.placeholder.com/300x300">) 0.0.4 Added possibility to add an imprint link to the banner 0.0.3 Multi-language support for module config (still in development) 0.0.2 First release 0.0.1 Early development
    • By MoritzLost
      This is a new module that provides a simple solution to clearing all your cache layers at once, and an extensible interface to perform various cache-related actions.
      The simple motivation behind this module was that I was tired of manually clearing caches in several places after deploying a change on a live site. The basic purpose of this module is a simple Clear all caches link in the Setup menu which clears out all caches, no matter where they hide. You can customize what exactly the module does through it's configuration menu:
      Expire or delete all cache entries in the database, or selectively clear caches by namespace ($cache API) Clear the the template render cache. Clear out specific folders inside your site's cache directory (/site/assets/cache) Refresh version strings for static assets to bust client-side browser caches (this requires some setup, see the full documentation for details). This is the basic function of the module. However, you can also add different cache management action through the API and execute them through the module's interface. For this advanced usage, the module provides:
      An interface to see all available cache actions and execute them. A system log and logging output on the module page to see verify what the module is doing. A CacheControlTools class with utility functions to clear out different caches. An API to add cache actions, execute them programmatically and even modify the default action. Permission management, allowing you granular control over which user roles can execute which actions. The complete documentation can be found in the module's README.
      Beta release
      Note that I consider this a Beta release. Since the module is relatively aggressive in deleting some caches, I would advise you to install in on a test environment before using it on a live site.
      Let me know if you're getting any errors, have trouble using the module or if you have suggestions for improvement!
      In particular, can someone let me know if this module causes any problems with the ProCache module? I don't own or use it, so I can't check. As far as I can tell, ProCache uses a folder inside the cache directory to cache static pages, so my module should be able to clear the ProCache site cache as well, I'd appreciate it if someone can test that for me.
      Future plans
      If there is some interest in this, I plan to expand this to a more general cache management solution. I particular, I would like to add additional cache actions. Some ideas that came to mind:
      Warming up the template render cache for publicly accessible pages. Removing all active user sessions. Let me know if you have more suggestions!
      Links
      https://github.com/MoritzLost/ProcessCacheControl ProcessCacheControl in the Module directory

    • By David Karich
      Admin Page Tree Multiple Sorting
      ClassName: ProcessPageListMultipleSorting
      Extend the ordinary sort of children of a template in the admin page tree with multiple properties. For each template, you can define your own rule. Write each template (template-name) in a row, followed by a colon and then the additional field names for sorting.
      Example: All children of the template "blog" to be sorted in descending order according to the date of creation, then descending by modification date, and then by title. Type:
      blog: -created, -modified, title  Installation
      Copy the files for this module to /site/modules/ProcessPageListMultipleSorting/ In admin: Modules > Check for new modules. Install Module "Admin Page Tree Multible Sorting". Alternative in ProcessWire 2.4+
      Login to ProcessWire backend and go to Modules Click tab "New" and enter Module Class Name: "ProcessPageListMultipleSorting" Click "Download and Install"   Compatibility   I have currently tested the module only under PW 2.6+, but think that it works on older versions too. Maybe someone can give a feedback.     Download   PW-Repo: http://modules.processwire.com/modules/process-page-list-multiple-sorting/ GitHub: https://github.com/FlipZoomMedia/Processwire-ProcessPageListMultipleSorting     I hope someone can use the module. Have fun and best regards, David
×
×
  • Create New...