Jump to content
horst

Page Image Manipulator 1

Recommended Posts

Hey @sarah_hue, welcome to the forums and thanks for the kind words.

The recreation is forced by the optional second param of pimLoad. If you let it out or set it to false it takes the cached variation:

$imagewithwatermark = $img->pimLoad('tw'[, false] )-> ...

.
.
PS: viele Grüße in die Narrenhochburg Köln, Tätä!  :)

  • Like 2

Share this post


Link to post
Share on other sites

Hi Horst, thanks so much for creating this module.

I have a question regarding page images that are set to allow multiple uploads per page, and which are placed into the body with CKEditor. Is there a method you would recommend for attacking each of these images, or would I be better off forcing my authors to use Hanna to place their images and tuck the image manipulation call in the hanna code?

Share this post


Link to post
Share on other sites

Hi @creativejay, I definitely would go with Hanna codes in RTEs.

  • Like 1

Share this post


Link to post
Share on other sites

Okay, I've written a bit in Hanna Code editor, and I'm getting this error:

Exception: Cannot read the pngAlphaImageFile!

Now, if I echo the URL for the file I set as the watermark image, it's correct.

Is this error referring to the way my file was saved? I used Photoshop's Save for Web, PNG-24, with Transparency, convert to sRGB. Is there something else I ought to be doing? I checked your sample action but I don't see save settings, and it has too much styling for what I want to do (and I'm using a smaller-than-image watermark).

In case it's an error with my coding, here's my Hanna Code:

<?php

if(isset($img)) {
  $myImage = wire('page')->blog_images->eq($img);
  //echo $myImage->url;
} else {
  $myImage = wire('page')->blog_images->first();
  //echo $myImage->url;
}

if(isset($pos)) {
  // If the position is set, we're good
} else {
  // otherwise we make sure the position is set to the default.
  $pos = 'SE';
}

if(isset($pad)) {
  // If the padding is set, we're good
} else {
  // otherwise we make sure the padding is set to the default.
  $pad = '2';
}

$username = wire('user')->name;
$AlphaImageUser = "{$config->urls->assets}images/authorwmk/swmb-{$username}.png";
// echo $AlphaImageUser;
$pngAlphaImage = $AlphaImageUser;

if($myImage != '') { 
    // Here's where the PageImageManipulator watermark code goes
    $imgsrc = $myImage->pimLoad('SwMb')->watermarkLogo($pngAlphaImage, $position=$pos, $padding=$pad);  // **this is the line triggering the error
    $newimg = $imgsrc->height(400)->url;
    echo $newimg;
    echo "<a href='{$imgsrc->url}' title='Click for Full Size' /><img src='{$newimg}' class='align_center' alt='{wire('page')->title}' /></a>";
    echo "<p><small>{$myImage->description}</small></p>";
}

Share this post


Link to post
Share on other sites

Hey, I think you simply need to respect the scope here in Line 26:

$config->urls->assets ...

 Try it with:

wire("config")->urls->assets
$AlphaImageUser = wire("config")->urls->assets . "images/authorwmk/swmb-{$username}.png";
Edited by horst

Share this post


Link to post
Share on other sites
wire("config")->urls->assets
$AlphaImageUser = wire("config")->urls->assets . "images/authorwmk/swmb-{$username}.png";

Thanks for the quick reply. Unfortunately this results in no change. The echo of $AlphaImageUser is the same for both wire("config")->... and $config->... (and both result in the correct path).

Share this post


Link to post
Share on other sites

Ah, sorry. I'm in hurry. Haven't read thoroughly.

So, 24 bit photoshop png should be fine. The error is triggered here: https://github.com/horst-n/PageImageManipulator/blob/master/ImageManipulator.class.php#L1651

It is only triggered when the file isn't existing or isn't readable: https://github.com/horst-n/PageImageManipulator/blob/master/ImageManipulator.class.php#L2437

It has nothing todo with the PNG type at this point here.

Are you sure the filename is correct?

You can test it in your code here before passing it to the pim:

echo "<pre>" . $AlphaImageUser . "\n";
echo realpath($AlphaImageUser) . "\n";
echo (is_readable(realpath($AlphaImageUser)) ? 'is readable' : 'UHM, is NOT readable!') . "\n</pre>";

Share this post


Link to post
Share on other sites

Thanks! I am getting the 'UHM' version, though I'm not sure why.

The results are:

/swatchmob/site/assets/images/authorwmk/swmb-mls.png

UHM, is NOT readable!

But the image does exist at http://www.creativejay.com/swatchmob/site/assets/images/authorwmk/swmb-mls.png so I'm really not sure what makes this path unreadable.

Edited to add: I had the same problem if I called the URL from an image field (on the user's profile) as the PNG source, as well.

Share this post


Link to post
Share on other sites

Oh, so does you have differences between your path and the output from realpath:

echo "<pre>" . $AlphaImageUser . "\n";
echo realpath($AlphaImageUser) . "\n";

??

..., and what does it say here with this tests:

echo "<pre>with realpath:\n";

// test with realpath
echo (file_exists(realpath($AlphaImageUser)) ? 'file exists' : 'file do NOT exist!') . "\n;
echo (is_readable(realpath($AlphaImageUser)) ? 'is readable' : 'UHM, is NOT readable!') . "\n";

// test without realpath
echo "\nwithout realpath:\n";

echo (file_exists($AlphaImageUser) ? 'file exists' : 'file do NOT exist!') . "\n;
echo (is_readable($AlphaImageUser) ? 'is readable' : 'UHM, is NOT readable!') . "\n";

echo "</pre>";

Share this post


Link to post
Share on other sites
with realpath:file do NOT exist!UHM, is NOT readable!without realpath:file do NOT exist!UHM, is NOT readable!

As you saw, there's a path associated in the case of "without realpath" and "with realpath" outputs nothing.

Sorry to lean on you heavily for this, I've never encountered this problem before.

Share this post


Link to post
Share on other sites

AH, it says file does not exist!!!

So, we have to use path instead of url, I think. :lol:

// not ->urls
$AlphaImageUser = "{$config->urls->assets}images/authorwmk/swmb-{$username}.png";

// but ->paths
$AlphaImageUser = "{$config->paths->assets}images/authorwmk/swmb-{$username}.png";
  • Like 1

Share this post


Link to post
Share on other sites

That solves the missing image.

Unfortunately there's a new error now..  :o

with realpath:/home/creative/public_html/swatchmob/site/assets/images/authorwmk/swmb-mls.pngfile existsis readablewithout realpath:/home/creative/public_html/swatchmob/site/assets/images/authorwmk/swmb-mls.pngfile existsis readable

Error: Maximum execution time of 60 seconds exceeded (line 41 of /home/creative/public_html/swatchmob/wire/core/WireData.php)
This error message was shown because you are logged in as a Superuser. Error has been logged.

Share this post


Link to post
Share on other sites

You should take out the debug code snippets, now after we have solved that path thingy.

How many images are in the pipe for processing? around 10 or more?

Share this post


Link to post
Share on other sites

On this page there are five.

No change after removing the debug code (other than the code not outputting).

I am on shared hosting, does that bump me right out of the running for using this module?

Edited by creativejay

Share this post


Link to post
Share on other sites

I know from hosts where it comes to timeouts with around 10 images in 30 seconds. So with your host it seems to be 5 images in 60 seconds, what is super lazy processing.??

Share this post


Link to post
Share on other sites

According to my host, my server has a minimum "Dual 5530 Gainstown processors with 8 cores, RAID-10 protected hard disk space, and 8 GB of RAM."

I can increase my max_execution_time in the .ini so that it hopefully has time to run. I just have to find the right folder(s) to put the .ini in. Tried to change it in /.htaccess with no success.

Default is to cache these files, right? :lol:

Share this post


Link to post
Share on other sites

I've got it running but it's painfully slow on every page load, not just the first. I built a manual check for the resized image into my HannaCode to speed it up. That made a huge difference, even though I thought PIM checks for the file before it starts. Or maybe, as usual, it's me.

Can you tell me what about the following code seems to be forcing the image to re-create every time?

<?php
if(wire('page')->template = 'blog-post') {
  $width = '375';
  $myImage = wire('page')->blog_images->eq($img);
  if($myImage->description) {$alt = $myImage->description;}
  
  if($on='Y') {
	$pimImg = $config->paths->files . wire('page')->id . "/" . "pim_swmb_" . $myImage->width($width)->name;
    $pimImgBig = $config->paths->files . wire('page')->id . "/" . "pim_swmb_" . $myImage->name;
    echo $pimImg;
    if(file_exists($pimImg)) { 
        $wmkImg = $config->urls->files . wire('page')->id . "/" . "pim_swmb_" . $myImage->width($width)->name;
        $wmkImgBig = $config->urls->files . wire('page')->id . "/" . "pim_swmb_" . $myImage->name;
        echo "<a href='{$wmkImgBig}' title='Click for Full Size' /><img src='{$wmkImg}' class='align_center' alt='{$alt}' /></a><p><small>{$alt}</small></p>";
    } else { 
    $username = wire('page')->createdUser->name;
	$AlphaImageUser = "{$config->paths->assets}images/authorwmk/swmb-{$username}.png";
	$pngAlphaImage = $AlphaImageUser;
	$imgsrc = $myImage->pimLoad("SwMb", false)->watermarkLogo($pngAlphaImage, $position=$pos, $padding=$pad)->pimSave();
    // output image
    $newimg = $imgsrc->width($width)->url;
	echo "<a href='{$imgsrc->url}' title='Click for Full Size' /><img src='{$newimg}' class='align_center' alt='{$alt}' /></a><p><small>{$alt}</small></p>";
	}
} else {
	$newimg = $myImage->width($width)->url;
	echo "<a href='{$myImage->url}' title='Click for Full Size' /><img src='{$newimg}' class='align_center' alt='{$alt}' /></a><p><small>{$alt}</small></p>"; 
}
}

Thanks again!

Share this post


Link to post
Share on other sites

Strange code you have here, not really getting what you doing there manually creating img path etc.

But this condition will always be true.

if($on='Y') {

Share this post


Link to post
Share on other sites

This will also be always true:

  1. if(wire('page')->template = 'blog-post') {

Share this post


Link to post
Share on other sites

Hi Soma, thanks for reading it over!

Strange code you have here, not really getting what you doing there manually creating img path etc.

But this condition will always be true.

if($on='Y') {

As I mentioned, it seemed like Page Image Manipulator was making the images fresh each time the page loaded (with no changes to HannaCode or the page images field), so I was trying to test that theory, and also speed up the page load (which it has).

$on is a variable that I wanted to provide for the page author, so that if the image already has a watermark, or if it was sourced from another creator, we wouldn't watermark the image. is $on something global I'm not aware of? I can easily change that name.

This will also be always true:

  1. if(wire('page')->template = 'blog-post') {

I added that because on my home page (of template swmb-home) I was getting an error that I was trying to get eq() on a non object. Adding that line fixed it.

Share this post


Link to post
Share on other sites

@creativejay - what Soma is getting at is that in PHP (and many other coding languages, maybe all ?) a single equals sign does not check if one thing equals the other, but rather makes it equal. So even though you have the if(), that line is always setting $on to "Y".

You need to use two equals signs, eg:

if($on=='Y') {

In some situations you even want to make use of three. Here is a useful discussion on the differences:

http://stackoverflow.com/questions/2063480/the-3-different-equals

Share this post


Link to post
Share on other sites

Ah! Thank you for rubbing my nose in it, adrian. I would claim to know the difference, but then I do things like that. And worse, don't spot them after.

My question does remain, though. Any idea why PIM seems to re-process the image on every page load unless I check for the file and skip it manually?

<?php
if(wire('page')->template == 'blog-post') {
    // lay some ground rules
  $width = '375';
  $myImage = wire('page')->blog_images->eq($img);
  $prfix = 'swatchmob';
  if($myImage->description) {$alt = $myImage->description;}
    // check if the watermark is needed
  if($on =='Y') {
    // check if the watermark exists already
    $pimImg = $config->paths->files . wire('page')->id . "/" . "pim_" . $prfix . "_" . $myImage->width($width)->name;
    $pimImgBig = $config->paths->files . wire('page')->id . "/" . "pim_" . $prfix . "_" . $myImage->name;
    if(file_exists($pimImg)) {
        $wmkImg = $config->urls->files . wire('page')->id . "/" . "pim_" . $prfix . "_" . $myImage->width($width)->name;
        $wmkImgBig = $config->urls->files . wire('page')->id . "/" . "pim_" . $prfix . "_" . $myImage->name;
        echo "<a href='{$wmkImgBig}' title='Click for Full Size' /><img src='{$wmkImg}' class='align_center' alt='{$alt}' /></a>";
    } else {
    // build the file with the watermark
    $username = wire('page')->createdUser->name;
    $AlphaImageUser = "{$config->paths->assets}images/authorwmk/swmb-{$username}.png";
    $pngAlphaImage = $AlphaImageUser;
    $imgsrc = $myImage->pimLoad($prfix, false)->watermarkLogo($pngAlphaImage, $position=$pos, $padding=$pad)->pimSave();
    // output image
    $newimg = $imgsrc->width($width)->url;
    echo "<a href='{$imgsrc->url}' title='Click for Full Size' /><img src='{$newimg}' class='align_center' alt='{$alt}' /></a>";
    }
} else {
    $newimg = $myImage->width($width)->url;
    echo "<a href='{$myImage->url}' title='Click for Full Size' /><img src='{$newimg}' class='align_center' alt='{$alt}' /></a>";
}
if($alt) { echo "<p><small>{$alt}</small></p>"; }
}
Edited by creativejay

Share this post


Link to post
Share on other sites

Ah! Thank you for rubbing my nose in it, adrian. I would claim to know the difference, but then I do things like that. And worse, don't spot them after.

That wasn't my intention at all :) We have all fallen victim to this one - several times!

I don't ever remember to do it, but it is why it is recommended to do:

f("Y"==$on){

With it reversed like that, if you forget the second equals sign, it will throw an error, rather than assigning the value!

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By eelkenet
      Hi! I've created a small Inputfield module called InputfieldFloatRange which allows you to use an HTML5 <input type="range" ../> slider as an InputField. I needed something like this for a project where the client needs to be able to tweak this value more based on 'a feeling' than just entering a boring old number. Maybe more people can use this so I'm hereby releasing it into the wild. 
      EDIT: You can now install it directly from the Modules directory: http://modules.processwire.com/modules/inputfield-float-range/
       
      What is it?
      The missing range slider Inputfield for Processwire. 
      What does it do?
      This module extends InputfieldFloat and allows you to use HTML5 range sliders for number fields in your templates.
      It includes a visible and editable value field, to override/tweak the value if required.  
      Features
      Min/max values Precision (number of decimals) Optional step value (Read more) Optional manual override of the selected value (will still adhere to the rules above) Configurable rounding of manually entered values (floor, round, ceil, disable) Usage
      Clone / zip repo Install FieldtypeFloatRange, this automatically installs the Inputfield Create new field of type `Float (range)` or convert an existing `Float`, `Integer` or `Text` field. To render the field's value simply echo `$page->field` Demo
      A field with Min=0, Max=1, Step=0.2, Precision=2

      Field with settings Min=0, Max=200, Step=0.25, Precision=2

       
      Todo
      Make the display-field's size configurable (will use the Input Size field setting)  Hopefully become redundant  
      Changelog
      005 (current version)
      - Fix bug where the Inputfield would not work properly within repeaters / repeater matrices
      004
      - Make rounding of manually entered values configurable (floor, round, ceil or disable)
      - Fix small JS bug when the value-display field was not displayed
      - Update README
      003
      - Code cleanup, add some ModuleInfo data & LICENSE
      - Submit to PW Modules directory (http://modules.processwire.com/modules/inputfield-float-range/)
      002
      - Fix issue where setting the step value to an empty value created problem with validation
      - Make the display-field optional
      001
      - Initial release
       
      Thanks!
       
       
    • By Gadgetto
      Status update links (inside this thread) for SnipWire development will be always posted here:
      2019-10-18
      2019-08-08
      2019-06-15
      2019-06-02
      2019-05-25
      If you are interested, you can test the current state of development:
      https://github.com/gadgetto/SnipWire
      Please note that the software is not yet intended for use in a production system (alpha version).
      If you like, you can also submit feature requests and suggestions for improvement. I also accept pull requests.
      ---- INITIAL POST FROM 2019-05-25 ----
      I wanted to let you know that I am currently working on a new ProcessWire module that fully integrates the Snipcart Shopping Cart System into ProcessWire. (this is a customer project, so I had to postpone the development of my other module GroupMailer).
      The new module SnipWire offers full integration of the Snipcart Shopping Cart System into ProcessWire.
      Here are some highlights:
      simple setup with (optional) pre-installed templates, product fields, sample products (quasi a complete shop system to get started immediately) store dashboard with all data from the snipcart system (no change to the snipcart dashboard itself required) Integrated REST API for controlling and querying snipcart data webhooks to trigger events from Snipcart (new order, new customer, etc.) multi currency support self-defined/configurable tax rates etc. Development is already well advanced and I plan to release the module in the next 2-3 months.
      I'm not sure yet if this will be a "Pro" module or if it will be made available for free.
      I would be grateful for suggestions and hints!
      (please have a look at the screenshots to get an idea what I'm talking about)
       




    • By Robin S
      Another little admin helper module...
      Template Field Widths
      Adds a "Field widths" field to Edit Template that allows you to quickly set the widths of inputfields in the template.

      Why?
      When setting up a new template or trying out different field layouts I find it a bit slow and tedious to have to open each field individually in a modal just to set the width. This module speeds up the process.
      Installation
      Install the Template Field Widths module.
      Config options
      You can set the default presentation of the "Field widths" field to collapsed or open. Field widths entered into the Template Field Widths inputfield are only applied if the Edit Template form is submitted with the Template Field Widths inputfield in an opened state. "Collapsed" is the recommended setting if you think you might also use core inputs for setting field widths in a template context. You can choose Name or Label as the primary identifier shown for the field. The unchosen alternative will become the title attribute shown on hover. You can choose to show the original field width next to the template context field width.  
      https://github.com/Toutouwai/TemplateFieldWidths
      https://modules.processwire.com/modules/template-field-widths/
    • By NehaPillai
      Hello Everyone, I was trying to update SEO meta title, description and meta keywords for my website in Process Wire CMS but it saving in the backend but it is not reflecting on my website, Please help me regarding this error. Please find below attached screen shot for your ref. TIA.


    • By adrian
      Tracy Debugger for ProcessWire
      The ultimate “swiss army knife” debugging and development tool for the ProcessWire CMF/CMS

       
      Integrates and extends Nette's Tracy debugging tool and adds 35+ custom tools designed for effective ProcessWire debugging and lightning fast development
      The most comprehensive set of instructions and examples is available at: https://adrianbj.github.io/TracyDebugger
      Modules Directory: http://modules.processwire.com/modules/tracy-debugger/
      Github: https://github.com/adrianbj/TracyDebugger
      A big thanks to @tpr for introducing me to Tracy and for the idea for this module and for significant feedback, testing, and feature suggestions.
×
×
  • Create New...