Jump to content
horst

Page Image Manipulator 1

Recommended Posts

Hey @sarah_hue, welcome to the forums and thanks for the kind words.

The recreation is forced by the optional second param of pimLoad. If you let it out or set it to false it takes the cached variation:

$imagewithwatermark = $img->pimLoad('tw'[, false] )-> ...

.
.
PS: viele Grüße in die Narrenhochburg Köln, Tätä!  :)

  • Like 2

Share this post


Link to post
Share on other sites

Hi Horst, thanks so much for creating this module.

I have a question regarding page images that are set to allow multiple uploads per page, and which are placed into the body with CKEditor. Is there a method you would recommend for attacking each of these images, or would I be better off forcing my authors to use Hanna to place their images and tuck the image manipulation call in the hanna code?

Share this post


Link to post
Share on other sites

Hi @creativejay, I definitely would go with Hanna codes in RTEs.

  • Like 1

Share this post


Link to post
Share on other sites

Okay, I've written a bit in Hanna Code editor, and I'm getting this error:

Exception: Cannot read the pngAlphaImageFile!

Now, if I echo the URL for the file I set as the watermark image, it's correct.

Is this error referring to the way my file was saved? I used Photoshop's Save for Web, PNG-24, with Transparency, convert to sRGB. Is there something else I ought to be doing? I checked your sample action but I don't see save settings, and it has too much styling for what I want to do (and I'm using a smaller-than-image watermark).

In case it's an error with my coding, here's my Hanna Code:

<?php

if(isset($img)) {
  $myImage = wire('page')->blog_images->eq($img);
  //echo $myImage->url;
} else {
  $myImage = wire('page')->blog_images->first();
  //echo $myImage->url;
}

if(isset($pos)) {
  // If the position is set, we're good
} else {
  // otherwise we make sure the position is set to the default.
  $pos = 'SE';
}

if(isset($pad)) {
  // If the padding is set, we're good
} else {
  // otherwise we make sure the padding is set to the default.
  $pad = '2';
}

$username = wire('user')->name;
$AlphaImageUser = "{$config->urls->assets}images/authorwmk/swmb-{$username}.png";
// echo $AlphaImageUser;
$pngAlphaImage = $AlphaImageUser;

if($myImage != '') { 
    // Here's where the PageImageManipulator watermark code goes
    $imgsrc = $myImage->pimLoad('SwMb')->watermarkLogo($pngAlphaImage, $position=$pos, $padding=$pad);  // **this is the line triggering the error
    $newimg = $imgsrc->height(400)->url;
    echo $newimg;
    echo "<a href='{$imgsrc->url}' title='Click for Full Size' /><img src='{$newimg}' class='align_center' alt='{wire('page')->title}' /></a>";
    echo "<p><small>{$myImage->description}</small></p>";
}

Share this post


Link to post
Share on other sites

Hey, I think you simply need to respect the scope here in Line 26:

$config->urls->assets ...

 Try it with:

wire("config")->urls->assets
$AlphaImageUser = wire("config")->urls->assets . "images/authorwmk/swmb-{$username}.png";
Edited by horst

Share this post


Link to post
Share on other sites
wire("config")->urls->assets
$AlphaImageUser = wire("config")->urls->assets . "images/authorwmk/swmb-{$username}.png";

Thanks for the quick reply. Unfortunately this results in no change. The echo of $AlphaImageUser is the same for both wire("config")->... and $config->... (and both result in the correct path).

Share this post


Link to post
Share on other sites

Ah, sorry. I'm in hurry. Haven't read thoroughly.

So, 24 bit photoshop png should be fine. The error is triggered here: https://github.com/horst-n/PageImageManipulator/blob/master/ImageManipulator.class.php#L1651

It is only triggered when the file isn't existing or isn't readable: https://github.com/horst-n/PageImageManipulator/blob/master/ImageManipulator.class.php#L2437

It has nothing todo with the PNG type at this point here.

Are you sure the filename is correct?

You can test it in your code here before passing it to the pim:

echo "<pre>" . $AlphaImageUser . "\n";
echo realpath($AlphaImageUser) . "\n";
echo (is_readable(realpath($AlphaImageUser)) ? 'is readable' : 'UHM, is NOT readable!') . "\n</pre>";

Share this post


Link to post
Share on other sites

Thanks! I am getting the 'UHM' version, though I'm not sure why.

The results are:

/swatchmob/site/assets/images/authorwmk/swmb-mls.png

UHM, is NOT readable!

But the image does exist at http://www.creativejay.com/swatchmob/site/assets/images/authorwmk/swmb-mls.png so I'm really not sure what makes this path unreadable.

Edited to add: I had the same problem if I called the URL from an image field (on the user's profile) as the PNG source, as well.

Share this post


Link to post
Share on other sites

Oh, so does you have differences between your path and the output from realpath:

echo "<pre>" . $AlphaImageUser . "\n";
echo realpath($AlphaImageUser) . "\n";

??

..., and what does it say here with this tests:

echo "<pre>with realpath:\n";

// test with realpath
echo (file_exists(realpath($AlphaImageUser)) ? 'file exists' : 'file do NOT exist!') . "\n;
echo (is_readable(realpath($AlphaImageUser)) ? 'is readable' : 'UHM, is NOT readable!') . "\n";

// test without realpath
echo "\nwithout realpath:\n";

echo (file_exists($AlphaImageUser) ? 'file exists' : 'file do NOT exist!') . "\n;
echo (is_readable($AlphaImageUser) ? 'is readable' : 'UHM, is NOT readable!') . "\n";

echo "</pre>";

Share this post


Link to post
Share on other sites
with realpath:file do NOT exist!UHM, is NOT readable!without realpath:file do NOT exist!UHM, is NOT readable!

As you saw, there's a path associated in the case of "without realpath" and "with realpath" outputs nothing.

Sorry to lean on you heavily for this, I've never encountered this problem before.

Share this post


Link to post
Share on other sites

AH, it says file does not exist!!!

So, we have to use path instead of url, I think. :lol:

// not ->urls
$AlphaImageUser = "{$config->urls->assets}images/authorwmk/swmb-{$username}.png";

// but ->paths
$AlphaImageUser = "{$config->paths->assets}images/authorwmk/swmb-{$username}.png";
  • Like 1

Share this post


Link to post
Share on other sites

That solves the missing image.

Unfortunately there's a new error now..  :o

with realpath:/home/creative/public_html/swatchmob/site/assets/images/authorwmk/swmb-mls.pngfile existsis readablewithout realpath:/home/creative/public_html/swatchmob/site/assets/images/authorwmk/swmb-mls.pngfile existsis readable

Error: Maximum execution time of 60 seconds exceeded (line 41 of /home/creative/public_html/swatchmob/wire/core/WireData.php)
This error message was shown because you are logged in as a Superuser. Error has been logged.

Share this post


Link to post
Share on other sites

You should take out the debug code snippets, now after we have solved that path thingy.

How many images are in the pipe for processing? around 10 or more?

Share this post


Link to post
Share on other sites

On this page there are five.

No change after removing the debug code (other than the code not outputting).

I am on shared hosting, does that bump me right out of the running for using this module?

Edited by creativejay

Share this post


Link to post
Share on other sites

I know from hosts where it comes to timeouts with around 10 images in 30 seconds. So with your host it seems to be 5 images in 60 seconds, what is super lazy processing.??

Share this post


Link to post
Share on other sites

According to my host, my server has a minimum "Dual 5530 Gainstown processors with 8 cores, RAID-10 protected hard disk space, and 8 GB of RAM."

I can increase my max_execution_time in the .ini so that it hopefully has time to run. I just have to find the right folder(s) to put the .ini in. Tried to change it in /.htaccess with no success.

Default is to cache these files, right? :lol:

Share this post


Link to post
Share on other sites

I've got it running but it's painfully slow on every page load, not just the first. I built a manual check for the resized image into my HannaCode to speed it up. That made a huge difference, even though I thought PIM checks for the file before it starts. Or maybe, as usual, it's me.

Can you tell me what about the following code seems to be forcing the image to re-create every time?

<?php
if(wire('page')->template = 'blog-post') {
  $width = '375';
  $myImage = wire('page')->blog_images->eq($img);
  if($myImage->description) {$alt = $myImage->description;}
  
  if($on='Y') {
	$pimImg = $config->paths->files . wire('page')->id . "/" . "pim_swmb_" . $myImage->width($width)->name;
    $pimImgBig = $config->paths->files . wire('page')->id . "/" . "pim_swmb_" . $myImage->name;
    echo $pimImg;
    if(file_exists($pimImg)) { 
        $wmkImg = $config->urls->files . wire('page')->id . "/" . "pim_swmb_" . $myImage->width($width)->name;
        $wmkImgBig = $config->urls->files . wire('page')->id . "/" . "pim_swmb_" . $myImage->name;
        echo "<a href='{$wmkImgBig}' title='Click for Full Size' /><img src='{$wmkImg}' class='align_center' alt='{$alt}' /></a><p><small>{$alt}</small></p>";
    } else { 
    $username = wire('page')->createdUser->name;
	$AlphaImageUser = "{$config->paths->assets}images/authorwmk/swmb-{$username}.png";
	$pngAlphaImage = $AlphaImageUser;
	$imgsrc = $myImage->pimLoad("SwMb", false)->watermarkLogo($pngAlphaImage, $position=$pos, $padding=$pad)->pimSave();
    // output image
    $newimg = $imgsrc->width($width)->url;
	echo "<a href='{$imgsrc->url}' title='Click for Full Size' /><img src='{$newimg}' class='align_center' alt='{$alt}' /></a><p><small>{$alt}</small></p>";
	}
} else {
	$newimg = $myImage->width($width)->url;
	echo "<a href='{$myImage->url}' title='Click for Full Size' /><img src='{$newimg}' class='align_center' alt='{$alt}' /></a><p><small>{$alt}</small></p>"; 
}
}

Thanks again!

Share this post


Link to post
Share on other sites

Strange code you have here, not really getting what you doing there manually creating img path etc.

But this condition will always be true.

if($on='Y') {

Share this post


Link to post
Share on other sites

This will also be always true:

  1. if(wire('page')->template = 'blog-post') {

Share this post


Link to post
Share on other sites

Hi Soma, thanks for reading it over!

Strange code you have here, not really getting what you doing there manually creating img path etc.

But this condition will always be true.

if($on='Y') {

As I mentioned, it seemed like Page Image Manipulator was making the images fresh each time the page loaded (with no changes to HannaCode or the page images field), so I was trying to test that theory, and also speed up the page load (which it has).

$on is a variable that I wanted to provide for the page author, so that if the image already has a watermark, or if it was sourced from another creator, we wouldn't watermark the image. is $on something global I'm not aware of? I can easily change that name.

This will also be always true:

  1. if(wire('page')->template = 'blog-post') {

I added that because on my home page (of template swmb-home) I was getting an error that I was trying to get eq() on a non object. Adding that line fixed it.

Share this post


Link to post
Share on other sites

@creativejay - what Soma is getting at is that in PHP (and many other coding languages, maybe all ?) a single equals sign does not check if one thing equals the other, but rather makes it equal. So even though you have the if(), that line is always setting $on to "Y".

You need to use two equals signs, eg:

if($on=='Y') {

In some situations you even want to make use of three. Here is a useful discussion on the differences:

http://stackoverflow.com/questions/2063480/the-3-different-equals

Share this post


Link to post
Share on other sites

Ah! Thank you for rubbing my nose in it, adrian. I would claim to know the difference, but then I do things like that. And worse, don't spot them after.

My question does remain, though. Any idea why PIM seems to re-process the image on every page load unless I check for the file and skip it manually?

<?php
if(wire('page')->template == 'blog-post') {
    // lay some ground rules
  $width = '375';
  $myImage = wire('page')->blog_images->eq($img);
  $prfix = 'swatchmob';
  if($myImage->description) {$alt = $myImage->description;}
    // check if the watermark is needed
  if($on =='Y') {
    // check if the watermark exists already
    $pimImg = $config->paths->files . wire('page')->id . "/" . "pim_" . $prfix . "_" . $myImage->width($width)->name;
    $pimImgBig = $config->paths->files . wire('page')->id . "/" . "pim_" . $prfix . "_" . $myImage->name;
    if(file_exists($pimImg)) {
        $wmkImg = $config->urls->files . wire('page')->id . "/" . "pim_" . $prfix . "_" . $myImage->width($width)->name;
        $wmkImgBig = $config->urls->files . wire('page')->id . "/" . "pim_" . $prfix . "_" . $myImage->name;
        echo "<a href='{$wmkImgBig}' title='Click for Full Size' /><img src='{$wmkImg}' class='align_center' alt='{$alt}' /></a>";
    } else {
    // build the file with the watermark
    $username = wire('page')->createdUser->name;
    $AlphaImageUser = "{$config->paths->assets}images/authorwmk/swmb-{$username}.png";
    $pngAlphaImage = $AlphaImageUser;
    $imgsrc = $myImage->pimLoad($prfix, false)->watermarkLogo($pngAlphaImage, $position=$pos, $padding=$pad)->pimSave();
    // output image
    $newimg = $imgsrc->width($width)->url;
    echo "<a href='{$imgsrc->url}' title='Click for Full Size' /><img src='{$newimg}' class='align_center' alt='{$alt}' /></a>";
    }
} else {
    $newimg = $myImage->width($width)->url;
    echo "<a href='{$myImage->url}' title='Click for Full Size' /><img src='{$newimg}' class='align_center' alt='{$alt}' /></a>";
}
if($alt) { echo "<p><small>{$alt}</small></p>"; }
}
Edited by creativejay

Share this post


Link to post
Share on other sites

Ah! Thank you for rubbing my nose in it, adrian. I would claim to know the difference, but then I do things like that. And worse, don't spot them after.

That wasn't my intention at all :) We have all fallen victim to this one - several times!

I don't ever remember to do it, but it is why it is recommended to do:

f("Y"==$on){

With it reversed like that, if you forget the second equals sign, it will throw an error, rather than assigning the value!

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By d'Hinnisdaël
      Happy new year, everybody 🥬
      I've been sitting on this Dashboard module I made for a client and finally came around to cleaning it up and releasing it to the wider public. This is how it looks.
      ProcessWire Dashboard

      If anyone is interested in trying this out, please go ahead! I'd love to get some feedback on it. If this proves useful and survives some real-world testing, I'll add this to the module directory.
      Download
      You can find the latest release on Github.
      Documentation
      Check out the documentation to get started. This is where you'll find information about included panel types and configuration options.
      Custom Panels
      My goal was to make it really simple to create custom panels. The easiest way to do that is to use the panel type template and have it render a file in your templates folder. This might be enough for 80% of all use cases. For anything more complex (FormBuilder submissions? Comments? Live chat?), you can add new panel types by creating modules that extend the DashboardPanel base class. Check out the documentation on custom panels or take a look at the HelloWorld panel to get started. I'm happy to merge any user-created modules into the main repo if they might be useful to more than a few people.
       Disclaimer
      This is a pre-release version. Please treat it as such — don't install it on production sites. Just making sure 🍇
      Roadmap
      These are the things I'm looking to implement myself at some point. The wishlist is a lot longer, but those are the 80/20 items that I probably won't regret spending time on.
      Improve documentation & add examples ⚙️ Panel types Google Analytics ⚙️ Add new page  🔥 Drafts 🔥 At a glance / Page counter 404s  Layout options Render multiple tabs per panel panel groups with heading and spacing between ✅ panel wrappers as grid item (e.g. stacked notices) ✅ Admin themes support AdminThemeReno and AdminThemeDefault ✅ Shortcuts panel add a table layout with icon, title & summary ✅ Chart panel add default styles for common chart types ✅ load chart data from JS file (currently passed as PHP array) Collection panel support image columns ✅ add buttons: view all & add new ✅
    • By Gadgetto
      Status update links (inside this thread) for SnipWire development will be always posted here:
      2020-01-14 --> new date range picker, discount editor, order notifiactions, order statuses, and more ... 2019-11-15 --> orders filter, order details, download + resend invoices, refunds 2019-10-18 --> list filters, REST API improvements, new docs platform, and more ... 2019-08-08 --> dashboard interface, currency selector, managing Orders, Customers and Products, Added a WireTabs, refinded caching behavior 2019-06-15 --> taxes provider, shop templates update, multiCURL implementation, and more ... 2019-06-02 --> FieldtypeSnipWireTaxSelector 2019-05-25 --> SnipWire will be free and open source If you are interested, you can test the current state of development:
      https://github.com/gadgetto/SnipWire
      Please note that the software is not yet intended for use in a production system (alpha version).
      If you like, you can also submit feature requests and suggestions for improvement. I also accept pull requests.
      ---- INITIAL POST FROM 2019-05-25 ----
      I wanted to let you know that I am currently working on a new ProcessWire module that fully integrates the Snipcart Shopping Cart System into ProcessWire. (this is a customer project, so I had to postpone the development of my other module GroupMailer).
      The new module SnipWire offers full integration of the Snipcart Shopping Cart System into ProcessWire.
      Here are some highlights:
      simple setup with (optional) pre-installed templates, product fields, sample products (quasi a complete shop system to get started immediately) store dashboard with all data from the snipcart system (no change to the snipcart dashboard itself required) Integrated REST API for controlling and querying snipcart data webhooks to trigger events from Snipcart (new order, new customer, etc.) multi currency support self-defined/configurable tax rates etc. Development is already well advanced and I plan to release the module in the next 2-3 months.
      I'm not sure yet if this will be a "Pro" module or if it will be made available for free.
      I would be grateful for suggestions and hints!
      Please have a look at the screenshots to get an idea what I'm talking about (open spoiler):
      (Please note: these screenshots are from an early development state of SnipWire. To see actual screens please have a look at later posts below!)
       
    • By Robin S
      This module is inspired by and similar to the Template Stubs module. The author of that module has not been active in the PW community for several years now and parts of the code for that module didn't make sense to me, so I decided to create my own module. Auto Template Stubs has only been tested with PhpStorm because that is the IDE that I use.
      Auto Template Stubs
      Automatically creates stub files for templates when fields or fieldgroups are saved.
      Stub files are useful if you are using an IDE (e.g. PhpStorm) that provides code assistance - the stub files let the IDE know what fields exist in each template and what data type each field returns. Depending on your IDE's features you get benefits such as code completion for field names as you type, type inference, inspection, documentation, etc.
      Installation
      Install the Auto Template Stubs module.
      Configuration
      You can change the class name prefix setting in the module config if you like. It's good to use a class name prefix because it reduces the chance that the class name will clash with an existing class name.
      The directory path used to store the stub files is configurable.
      There is a checkbox to manually trigger the regeneration of all stub files if needed.
      Usage
      Add a line near the top of each of your template files to tell your IDE what stub class name to associate with the $page variable within the template file. For example, with the default class name prefix you would add the following line at the top of the home.php template file:
      /** @var tpl_home $page */ Now enjoy code completion, etc, in your IDE.

      Adding data types for non-core Fieldtype modules
      The module includes the data types returned by all the core Fieldtype modules. If you want to add data types returned by one or more non-core Fieldtype modules then you can hook the AutoTemplateStubs::getReturnTypes() method. For example, in /site/ready.php:
      // Add data types for some non-core Fieldtype modules $wire->addHookAfter('AutoTemplateStubs::getReturnTypes', function(HookEvent $event) { $extra_types = [ 'FieldtypeDecimal' => 'string', 'FieldtypeLeafletMapMarker' => 'LeafletMapMarker', 'FieldtypeRepeaterMatrix' => 'RepeaterMatrixPageArray', 'FieldtypeTable' => 'TableRows', ]; $event->return = $event->return + $extra_types; }); Credits
      Inspired by and much credit to the Template Stubs module by mindplay.dk.
       
      https://github.com/Toutouwai/AutoTemplateStubs
      https://modules.processwire.com/modules/auto-template-stubs/
    • By Mike Rockett
      Jumplinks for ProcessWire
      Release: 1.5.60
      Composer: rockett/jumplinks
      ⚠️ NOTICE: 1.5.60 is an important security patch-release for an XSS vulnerability discovered by @phlp. It's HIGHLY RECOMMENDED that all Jumplinks users update to the latest version as soon as possible.
      Jumplinks is an enhanced version of the original ProcessRedirects by Antti Peisa.
      The Process module manages your permanent and temporary redirects (we'll call these "jumplinks" from now on, unless in reference to redirects from another module), useful for when you're migrating over to ProcessWire from another system/platform. Each jumplink supports wildcards, shortening the time needed to create them.
      Unlike similar modules for other platforms, wildcards in Jumplinks are much easier to work with, as Regular Expressions are not fully exposed. Instead, parameters wrapped in curly braces are used - these are described in the documentation.
      Under Development: 2.0, to be powered by FastRoute
      As of version 1.5.0, Jumplinks requires at least ProcessWire 2.6.1 to run.
      View on GitLab
      Download via the Modules Directory
      Read the docs
      Features
      The most prominent features include:
      Basic jumplinks (from one fixed route to another) Parameter-based wildcards with "Smart" equivalents Mapping Collections (for converting ID-based routes to their named-equivalents without the need to create multiple jumplinks) Destination Selectors (for finding and redirecting to pages containing legacy location information) Timed Activation (activate and/or deactivate jumplinks at specific times) 404-Monitor (for creating jumplinks based on 404 hits) Additionally, the following features may come in handy:
      Stale jumplink management Legacy domain support for slow migrations An importer (from CSV or ProcessRedirects) Feedback & Feature Requests
      I’d love to know what you think of this module. Please provide some feedback on the module as a whole, or even regarding smaller things that make it whole. Also, please feel free to submit feature requests and their use-cases.
      Note: Features requested so far have been added to the to-do list, and will be added to 2.0, and not the current dev/master branches.
      Open Source

      Jumplinks is an open-source project, and is free to use. In fact, Jumplinks will always be open-source, and will always remain free to use. Forever. If you would like to support the development of Jumplinks, please consider making a small donation via PayPal.
      Enjoy! 🙂
    • By Robin S
      Add Image URLs
      Allows images/files to be added to Image/File fields by pasting URLs.

      Usage
      Install the Add Image URLs module.
      A "Paste URLs" button will be added to all image and file fields. Use the button to show a textarea where URLs may be pasted, one per line. Images/files are added when the page is saved.
       
      https://github.com/Toutouwai/AddImageUrls
      https://modules.processwire.com/modules/add-image-urls/
×
×
  • Create New...