Jump to content
horst

Page Image Manipulator 1

Recommended Posts

Hi Horst,

pim2 v0.2.9 running on PW 2.8.62 overwrites the original image instead of making a variation.

I'm using the canvas method

<img src="<? echo $image->pim2Load('pim')->setQuality(90)->setOutputFormat('png')->canvas(240,160)->pimSave()->httpUrl; ?>">

chears,
JFN.

 

Is this thread abandoned??

Edited by JFn
no reaction

Share this post


Link to post
Share on other sites

Good day, @horst!

Was messing with an old site of mine. I did not even remember I used pim2 on this one. And getting to use this powerful tool once again was a pleasure. Thank you for your work!

I had to make a overblurred version of an image for a background. So I used smooth(255) about a 10 times in a row. That did the trick, but the code looks kind of ugly. Am I missing some shortcut way to do it in a more beautiful manner?

Share this post


Link to post
Share on other sites

Hi @Ivan Gretsky, thanks for the nice words.

To make an image overblurred, there is only the "blur" and the "smooth" functions. But maybe you can experiment with using "pixelate" before "smooth"?

pixelate(2) or pixelate(3) and then smooth(255), (regarding your desription, maybe 2-3 times smooth(255))

Or isn't that what you are asking for?

  • Like 1

Share this post


Link to post
Share on other sites

@Ivan Gretsky, if you have Imagick installed you could use this function I wrote a while back for easy ImageMagick effects:

It does quite a nice blur. But now that supporting IE is less of an issue you could also try a CSS filter.

  • Like 2

Share this post


Link to post
Share on other sites

Hi Jonathan, sorry, I completly missed that one. 😳

Will looking into it next week. 🤞

And thanks for showing the issue by video, what makes it very clear to follow!

Share this post


Link to post
Share on other sites

@Jonathan Lahijani Hmm, there is no fast fix possible ATM. BUT you may use this code, passing the options array as second param to pim2Load, what works as expected:

$image1->pim2Load('i1')->setOptions(['outputFormat'=>'jpg'])->pimSave(); // FAILES (with outputFormat, all other settings work as expected)
$image2->pim2Load('i2', ['outputFormat'=>'jpg'])->pimSave();  // works!!

Summary: all option settings work in both ways, BUT changing the outputFormat only works correctly when passed as options argument into pim2Load().

(I think it needs a massive rewrite to fix that properly, for that I have no time atm 😞)

Share this post


Link to post
Share on other sites

There are serious issues with this module running PW 3.0.123+. Didn't have time to debug properly, but on different sites the pim2load didn't work anymore.

Two different examples that didn't work anymore:
$img->pim2Load('img_name')->width(640)->grayscale()->setQuality(80)->pimSave()->url;
$img->pim2Load('img_name')->setQuality(90)->setOutputFormat('png')->canvas(240,160)->pimSave()->httpUrl;

I ended up disabling the module and using core image manipulations (except for the grayscale... it looks much better in color anyway 😎)

Share this post


Link to post
Share on other sites

@JFn I cannot confirm this. I tested with different newer PW versions up to 3.0.131. Everything is working as expected and like with older PW versions.

Only thing from your examples that did not work, is to use the ->setOutputFormat(). How to handle this, please read my post directly above yours.

 

Share this post


Link to post
Share on other sites

Just a heads up, I'm getting this warning on PHP 7.3.6 :

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /home/zzzzzz/dev/site/assets/cache/FileCompiler/site/modules/PageImageManipulator/ImageManipulator02.class.php on line 525 

 

Share this post


Link to post
Share on other sites

@Macrura thanks for the hint.

Have you tried to change that continue into break at line 525? Does it solve the Warning?

Share this post


Link to post
Share on other sites

yes, it solves the warning for sure.

On a separate topic – is there anyway to set the color of watermark text?

Share this post


Link to post
Share on other sites
10 hours ago, Macrura said:

On a separate topic – is there anyway to set the color of watermark text?

Sorry, no. The current text watermark method analyzes the images and decides between white, gray and black in a automated way. The reason behind that is, you can apply text to any images without knowing which colors it includes.

  • Like 1

Share this post


Link to post
Share on other sites

I am using this module (v0.2.9) to generate low quality previews for use with lazysizes js using following code

$imgLow = $img->pim2Load('lowq', true)->setOptions(['quality' => 20])->pixelate(3)->smooth(255)->pimSave();

This is working fine but I quite frequently get a warning:

PHP Warning: rename(/home/m1698/Sites/processwire/site/assets/files/14172/p1010866_geschnitten-1.780x0-pim2-lowq.jpg.tmp,/home/m1698/Sites/processwire/site/assets/files/14172/p1010866_geschnitten-1.780x0-pim2-lowq.jpg): No such file or directory in /home/m1698/Sites/processwire/site/assets/cache/FileCompiler/site/modules/PageImageManipulator/ImageManipulator02.class.php:715

It seems that the warning is thrown by rename() because it is being executed on a non existing file ($dest). Somehow $dest must have been deleted.

But strange enough, the renamed file exists. So the rename operation seems to have been run successfully.

Any idea what might be causing this?
 

Share this post


Link to post
Share on other sites

Thank you for this great module.

In the log I find multiple of these exceptions:

Error when trying to resize watermarkLogo to fit to the MemoryImage. (in /site/assets/cache/FileCompiler/site/modules/PageImageManipulator/ImageManipulator02.class.php line 1986)

My guess is that some of the images that I am trying to resize are too large (but I am not sure).

Any suggestion how to fix this, so I can avoid fatal exceptions?

 

Share this post


Link to post
Share on other sites
1 hour ago, eydun said:

My guess is that some of the images that I am trying to resize are too large (but I am not sure).

Some infos may help. How are the dimensions of the images (orig images and the watermark image) How much is the dedicated memory for PHP on your server / account?

Share this post


Link to post
Share on other sites

ProcessWire 3.0.98
Pageimage Manipulator 2    0.2.9

Some files(?) put pim2 in endless loop . Loop in ImageManipulator02.class.php :

        public function __construct($entryItem=null, $options=array(), $bypassOperations=false) {

            // version check module == class
            $m = wire('modules')->get('PageImageManipulator02')->getModuleInfo();
            $m = preg_replace('/(\d)(?=\d)/', '$1.', str_pad("{$m['version']}", 3, "0", STR_PAD_LEFT));
            $c = preg_replace('/(\d)(?=\d)/', '$1.', str_pad("{$this->version}", 3, "0", STR_PAD_LEFT));
            if(!version_compare($m, $c, '=')) {
                throw new WireException("The versions of Module PageImageManipulator02 ($m) and it dependency classfile ImageManipulator02 ($c) are inconsist
ent!)");
                return;
            }

            $this->bypassOperations = true===$bypassOperations ? true : false;
            // validate PageImage, FileImage, MemoryImage

            if($entryItem instanceof Pageimage) {

                $this->pageimage = $entryItem;
                $this->entryItem = 'page';
                $this->filename = $entryItem->filename;
                $this->isOriginal = $entryItem->original===NULL ? true : false;

                if(!$this->isOriginal) {
                    // traversing up 'til reaching root reference
                    $this->originalImage = $entryItem->original;
                    while(null !== $this->originalImage->original) {
					// !!!!!!!!!!!! ENDLESS LOOP HERE !!!!!!!!!!!!!!!!!!!!!!!
                        $reference = $this->originalImage->original;
                        $this->originalImage = $reference;
                    }
                }
            }

 

  • Like 2

Share this post


Link to post
Share on other sites

Thanks for the replies.

I use PW 3.0.148 and PIM2 0.2.9.

Here is my code:

$imgWidth = 255;
$imgHeight = 312;
$imgPadding = 5;

$image->pim2Load($product->title)->setOutputFormat('png')->canvas($imgWidth, $imgHeight, array(255, 255, 255, 0) ,'center', $imgPadding)->pimSave();

Actually @ak1001 suggestion of a endless loop, sounds more plausible than it is caused by a too large image.

I use a function to selected random images to display, so currently I do not know which source-images are causing the exception.

Share this post


Link to post
Share on other sites

Investigating further, in my case problem i think with some file names.  For example one page with three images break down on image named 30x30.jpg. I think processwire thinks that it is a variation image forewer.

mysql> select pages_id, data, sort from field_tovarimages where pages_id = 9771;
+----------+--------------+------+
| pages_id | data         | sort |
+----------+--------------+------+
|     9771 | 30_belyi.jpg |    0 |
|     9771 | 19480.jpg    |    1 |
|     9771 | 30x30.jpg    |    2 |
+----------+--------------+------+
3 rows in set (0.00 sec)

So in  pim 

$this->originalImage == $this->originalImage->original
                       

and it makes loop ?

  • Like 1

Share this post


Link to post
Share on other sites

So,  public function ___isVariation in class Pageimage have a regexp 

$re1 = '/^'  ..
   '(\d+)x(\d+)' .>    // 50x50 
   '([pd]\d+x\d+|[a-z]{1,2})?' . <>// nw or p30x40 or d30x40
   '(?:-([-_a-z0-9]+))?' .   // -suffix1 or -suffix1-suffix2, etc.
   '\.' . $this->ext() . <>  // .jpg
   '$/';

that will match names like 30x30.jpg and always says this is a variation image. And this will cause the pim go in endless loop. Don't know is there some consequnces for processwire, seems only pim react abnormally.

I will rename all images for now, and will ask users to not use such type names, but some prevention methods must be used i think

  • Like 1

Share this post


Link to post
Share on other sites

Hi @ak1001, many thanks for your investigations.

Please can you provide me with some informations, so that I can test it locally here, and try to update the ___isVariation stuff to fit with recent PW versions?

(When pim was build, we don't have had imge-rendering-engines and the image structures as it is today. We only have had the imagesizer.php and the pageimage.php, where I copy pasted that method from.) 

Which version of PW are you using:

Do you use Pim1 or Pim2:

Which module version of Pim:

What is the exact full URL of the image(s) in question:

 

 

Share this post


Link to post
Share on other sites
On 2/11/2020 at 2:54 PM, horst said:

Hi @ak1001, many thanks for your investigations.

Please can you provide me with some informations

Hi @horst
ProcessWire 3.0.98
Pageimage Manipulator 2    0.2.9

exact urls something like site/assets/files/9771/30x30.jpg
pim image : site/assets/files/9771/30x30.-pim2-wm3.jpg

Also i was lazy to rename images so i just count loops in PageImageManipulator02.class.php


 

		// Construct & Destruct the ImageManipulator02 for a single image
        public function __construct($entryItem=null, $options=array(), $bypassOperations=false) {

				...

                if(!$this->isOriginal) {
                    // traversing up 'til reaching root reference
                    $this->originalImage = $entryItem->original;
                    $countloop = 0;
                    while(null !== $this->originalImage->original) {
                        $countloop++;
                        $reference = $this->originalImage->original;
                        $this->originalImage = $reference;
                        if($countloop > 5) {
                            error_log("---- ImageManipulator02 loop!  ".__LINE__);
                            error_log("---- loop filename= ".$this->filename .", ".__LINE__);
                            break;
                        }
                    }
                }
				
				...


 

  • Like 1

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By joshua
      This module is (yet another) way for implementing a cookie management solution.
      Of course there are several other possibilities:
      - https://processwire.com/talk/topic/22920-klaro-cookie-consent-manager/
      - https://github.com/webmanufaktur/CookieManagementBanner
      - https://github.com/johannesdachsel/cookiemonster
      - https://www.oiljs.org/
      - ... and so on ...
      In this module you can configure which kind of cookie categories you want to manage:

      You can also enable the support for respecting the Do-Not-Track (DNT) header to don't annoy users, who already decided for all their browsing experience.
      Currently there are four possible cookie groups:
      - Necessary (always enabled)
      - Statistics
      - Marketing
      - External Media
      All groups can be renamed, so feel free to use other cookie group names. I just haven't found a way to implement a "repeater like" field as configurable module field ...
      When you want to load specific scripts ( like Google Analytics, Google Maps, ...) only after the user's content to this specific category of cookies, just use the following script syntax:
      <script type="optin" data-type="text/javascript" data-category="statistics" data-src="/path/to/your/statistic/script.js"></script> <script type="optin" data-type="text/javascript" data-category="marketing" data-src="/path/to/your/mareketing/script.js"></script> <script type="optin" data-type="text/javascript" data-category="external_media" data-src="/path/to/your/external-media/script.js"></script> <script type="optin" data-type="text/javascript" data-category="marketing">console.log("Inline scripts are also working!");</script> The type has to be "optin" to get recognized by PrivacyWire, the data-attributes are giving hints, how the script shall be loaded, if the data-category is within the cookie consents of the user. These scripts are loaded asynchronously after the user made the decision.
      If you want to give the users the possibility to change their consent, you can use the following Textformatter:
      [[privacywire-choose-cookies]] It's planned to add also other Textformatters to opt-out of specific cookie groups or delete the whole consent cookie.
      You can also add a custom link to output the banner again with a link / button with following class:
      <a href="#" class="privacywire-show-options">Show Cookie Options</a> <button class="privacywire-show-options">Show Cookie Options</button> This module is still in development, but we already use it on several production websites.
      You find it here: PrivacyWire Git Repo
      Download as .zip
      I would love to hear your feedback 🙂
      CHANGELOG
      0.0.5 Multi-language support included completely (also in TextFormatter). Added possibility to async load other assets (e.g. <img type="optin" data-category="marketing" data-src="https://via.placeholder.com/300x300">) 0.0.4 Added possibility to add an imprint link to the banner 0.0.3 Multi-language support for module config (still in development) 0.0.2 First release 0.0.1 Early development
    • By MoritzLost
      This is a new module that provides a simple solution to clearing all your cache layers at once, and an extensible interface to perform various cache-related actions.
      The simple motivation behind this module was that I was tired of manually clearing caches in several places after deploying a change on a live site. The basic purpose of this module is a simple Clear all caches link in the Setup menu which clears out all caches, no matter where they hide. You can customize what exactly the module does through it's configuration menu:
      Expire or delete all cache entries in the database, or selectively clear caches by namespace ($cache API) Clear the the template render cache. Clear out specific folders inside your site's cache directory (/site/assets/cache) Refresh version strings for static assets to bust client-side browser caches (this requires some setup, see the full documentation for details). This is the basic function of the module. However, you can also add different cache management action through the API and execute them through the module's interface. For this advanced usage, the module provides:
      An interface to see all available cache actions and execute them. A system log and logging output on the module page to see verify what the module is doing. A CacheControlTools class with utility functions to clear out different caches. An API to add cache actions, execute them programmatically and even modify the default action. Permission management, allowing you granular control over which user roles can execute which actions. The complete documentation can be found in the module's README.
      Beta release
      Note that I consider this a Beta release. Since the module is relatively aggressive in deleting some caches, I would advise you to install in on a test environment before using it on a live site.
      Let me know if you're getting any errors, have trouble using the module or if you have suggestions for improvement!
      In particular, can someone let me know if this module causes any problems with the ProCache module? I don't own or use it, so I can't check. As far as I can tell, ProCache uses a folder inside the cache directory to cache static pages, so my module should be able to clear the ProCache site cache as well, I'd appreciate it if someone can test that for me.
      Future plans
      If there is some interest in this, I plan to expand this to a more general cache management solution. I particular, I would like to add additional cache actions. Some ideas that came to mind:
      Warming up the template render cache for publicly accessible pages. Removing all active user sessions. Let me know if you have more suggestions!
      Links
      https://github.com/MoritzLost/ProcessCacheControl ProcessCacheControl in the Module directory

    • By David Karich
      Admin Page Tree Multiple Sorting
      ClassName: ProcessPageListMultipleSorting
      Extend the ordinary sort of children of a template in the admin page tree with multiple properties. For each template, you can define your own rule. Write each template (template-name) in a row, followed by a colon and then the additional field names for sorting.
      Example: All children of the template "blog" to be sorted in descending order according to the date of creation, then descending by modification date, and then by title. Type:
      blog: -created, -modified, title  Installation
      Copy the files for this module to /site/modules/ProcessPageListMultipleSorting/ In admin: Modules > Check for new modules. Install Module "Admin Page Tree Multible Sorting". Alternative in ProcessWire 2.4+
      Login to ProcessWire backend and go to Modules Click tab "New" and enter Module Class Name: "ProcessPageListMultipleSorting" Click "Download and Install"   Compatibility   I have currently tested the module only under PW 2.6+, but think that it works on older versions too. Maybe someone can give a feedback.     Download   PW-Repo: http://modules.processwire.com/modules/process-page-list-multiple-sorting/ GitHub: https://github.com/FlipZoomMedia/Processwire-ProcessPageListMultipleSorting     I hope someone can use the module. Have fun and best regards, David
    • By dimitrios
      Hello,
      this module can publish content of a Processwire page on a Facebook page, triggered by saving the Processwire page.
      To set it up, configure the module with a Facebook app ID, secret and a Page ID. Following is additional configuration on Facebook for developers:
      Minimum Required Facebook App configuration:
      on Settings -> Basics, provide the App Domains, provide the Site URL, on Settings -> Advanced, set the API version (has been tested up to v3.3), add Product: Facebook Login, on Facebook Login -> Settings, set Client OAuth Login: Yes, set Web OAuth Login: Yes, set Enforce HTTPS: Yes, add "https://www.example.com/processwire/page/" to field Valid OAuth Redirect URIs. This module is configurable as follows:
      Templates: posts can take place only for pages with the defined templates. On/Off switch: specify a checkbox field that will not allow the post if checked. Specify a message and/or an image for the post.
      Usage
      edit the desired PW page and save; it will post right after the initial Facebook log in and permission granting. After that, an access token is kept.
       
      Download
      PW module directory: http://modules.processwire.com/modules/auto-fb-post/ Github: https://github.com/kastrind/AutoFbPost   Note: Facebook SDK for PHP is utilized.


×
×
  • Create New...