Jump to content
horst

Page Image Manipulator 1

Recommended Posts

Hi Horst,

pim2 v0.2.9 running on PW 2.8.62 overwrites the original image instead of making a variation.

I'm using the canvas method

<img src="<? echo $image->pim2Load('pim')->setQuality(90)->setOutputFormat('png')->canvas(240,160)->pimSave()->httpUrl; ?>">

chears,
JFN.

 

Is this thread abandoned??

Edited by JFn
no reaction

Share this post


Link to post
Share on other sites

Good day, @horst!

Was messing with an old site of mine. I did not even remember I used pim2 on this one. And getting to use this powerful tool once again was a pleasure. Thank you for your work!

I had to make a overblurred version of an image for a background. So I used smooth(255) about a 10 times in a row. That did the trick, but the code looks kind of ugly. Am I missing some shortcut way to do it in a more beautiful manner?

Share this post


Link to post
Share on other sites

Hi @Ivan Gretsky, thanks for the nice words.

To make an image overblurred, there is only the "blur" and the "smooth" functions. But maybe you can experiment with using "pixelate" before "smooth"?

pixelate(2) or pixelate(3) and then smooth(255), (regarding your desription, maybe 2-3 times smooth(255))

Or isn't that what you are asking for?

  • Like 1

Share this post


Link to post
Share on other sites

@Ivan Gretsky, if you have Imagick installed you could use this function I wrote a while back for easy ImageMagick effects:

It does quite a nice blur. But now that supporting IE is less of an issue you could also try a CSS filter.

  • Like 2

Share this post


Link to post
Share on other sites

Hi Jonathan, sorry, I completly missed that one. 😳

Will looking into it next week. 🤞

And thanks for showing the issue by video, what makes it very clear to follow!

Share this post


Link to post
Share on other sites

@Jonathan Lahijani Hmm, there is no fast fix possible ATM. BUT you may use this code, passing the options array as second param to pim2Load, what works as expected:

$image1->pim2Load('i1')->setOptions(['outputFormat'=>'jpg'])->pimSave(); // FAILES (with outputFormat, all other settings work as expected)
$image2->pim2Load('i2', ['outputFormat'=>'jpg'])->pimSave();  // works!!

Summary: all option settings work in both ways, BUT changing the outputFormat only works correctly when passed as options argument into pim2Load().

(I think it needs a massive rewrite to fix that properly, for that I have no time atm 😞)

Share this post


Link to post
Share on other sites

There are serious issues with this module running PW 3.0.123+. Didn't have time to debug properly, but on different sites the pim2load didn't work anymore.

Two different examples that didn't work anymore:
$img->pim2Load('img_name')->width(640)->grayscale()->setQuality(80)->pimSave()->url;
$img->pim2Load('img_name')->setQuality(90)->setOutputFormat('png')->canvas(240,160)->pimSave()->httpUrl;

I ended up disabling the module and using core image manipulations (except for the grayscale... it looks much better in color anyway 😎)

Share this post


Link to post
Share on other sites

@JFn I cannot confirm this. I tested with different newer PW versions up to 3.0.131. Everything is working as expected and like with older PW versions.

Only thing from your examples that did not work, is to use the ->setOutputFormat(). How to handle this, please read my post directly above yours.

 

Share this post


Link to post
Share on other sites

Just a heads up, I'm getting this warning on PHP 7.3.6 :

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /home/zzzzzz/dev/site/assets/cache/FileCompiler/site/modules/PageImageManipulator/ImageManipulator02.class.php on line 525 

 

Share this post


Link to post
Share on other sites

@Macrura thanks for the hint.

Have you tried to change that continue into break at line 525? Does it solve the Warning?

Share this post


Link to post
Share on other sites

yes, it solves the warning for sure.

On a separate topic – is there anyway to set the color of watermark text?

Share this post


Link to post
Share on other sites
10 hours ago, Macrura said:

On a separate topic – is there anyway to set the color of watermark text?

Sorry, no. The current text watermark method analyzes the images and decides between white, gray and black in a automated way. The reason behind that is, you can apply text to any images without knowing which colors it includes.

  • Like 1

Share this post


Link to post
Share on other sites

I am using this module (v0.2.9) to generate low quality previews for use with lazysizes js using following code

$imgLow = $img->pim2Load('lowq', true)->setOptions(['quality' => 20])->pixelate(3)->smooth(255)->pimSave();

This is working fine but I quite frequently get a warning:

PHP Warning: rename(/home/m1698/Sites/processwire/site/assets/files/14172/p1010866_geschnitten-1.780x0-pim2-lowq.jpg.tmp,/home/m1698/Sites/processwire/site/assets/files/14172/p1010866_geschnitten-1.780x0-pim2-lowq.jpg): No such file or directory in /home/m1698/Sites/processwire/site/assets/cache/FileCompiler/site/modules/PageImageManipulator/ImageManipulator02.class.php:715

It seems that the warning is thrown by rename() because it is being executed on a non existing file ($dest). Somehow $dest must have been deleted.

But strange enough, the renamed file exists. So the rename operation seems to have been run successfully.

Any idea what might be causing this?
 

Share this post


Link to post
Share on other sites

Thank you for this great module.

In the log I find multiple of these exceptions:

Error when trying to resize watermarkLogo to fit to the MemoryImage. (in /site/assets/cache/FileCompiler/site/modules/PageImageManipulator/ImageManipulator02.class.php line 1986)

My guess is that some of the images that I am trying to resize are too large (but I am not sure).

Any suggestion how to fix this, so I can avoid fatal exceptions?

 

Share this post


Link to post
Share on other sites
1 hour ago, eydun said:

My guess is that some of the images that I am trying to resize are too large (but I am not sure).

Some infos may help. How are the dimensions of the images (orig images and the watermark image) How much is the dedicated memory for PHP on your server / account?

Share this post


Link to post
Share on other sites

ProcessWire 3.0.98
Pageimage Manipulator 2    0.2.9

Some files(?) put pim2 in endless loop . Loop in ImageManipulator02.class.php :

        public function __construct($entryItem=null, $options=array(), $bypassOperations=false) {

            // version check module == class
            $m = wire('modules')->get('PageImageManipulator02')->getModuleInfo();
            $m = preg_replace('/(\d)(?=\d)/', '$1.', str_pad("{$m['version']}", 3, "0", STR_PAD_LEFT));
            $c = preg_replace('/(\d)(?=\d)/', '$1.', str_pad("{$this->version}", 3, "0", STR_PAD_LEFT));
            if(!version_compare($m, $c, '=')) {
                throw new WireException("The versions of Module PageImageManipulator02 ($m) and it dependency classfile ImageManipulator02 ($c) are inconsist
ent!)");
                return;
            }

            $this->bypassOperations = true===$bypassOperations ? true : false;
            // validate PageImage, FileImage, MemoryImage

            if($entryItem instanceof Pageimage) {

                $this->pageimage = $entryItem;
                $this->entryItem = 'page';
                $this->filename = $entryItem->filename;
                $this->isOriginal = $entryItem->original===NULL ? true : false;

                if(!$this->isOriginal) {
                    // traversing up 'til reaching root reference
                    $this->originalImage = $entryItem->original;
                    while(null !== $this->originalImage->original) {
					// !!!!!!!!!!!! ENDLESS LOOP HERE !!!!!!!!!!!!!!!!!!!!!!!
                        $reference = $this->originalImage->original;
                        $this->originalImage = $reference;
                    }
                }
            }

 

  • Like 2

Share this post


Link to post
Share on other sites

Thanks for the replies.

I use PW 3.0.148 and PIM2 0.2.9.

Here is my code:

$imgWidth = 255;
$imgHeight = 312;
$imgPadding = 5;

$image->pim2Load($product->title)->setOutputFormat('png')->canvas($imgWidth, $imgHeight, array(255, 255, 255, 0) ,'center', $imgPadding)->pimSave();

Actually @ak1001 suggestion of a endless loop, sounds more plausible than it is caused by a too large image.

I use a function to selected random images to display, so currently I do not know which source-images are causing the exception.

Share this post


Link to post
Share on other sites

Investigating further, in my case problem i think with some file names.  For example one page with three images break down on image named 30x30.jpg. I think processwire thinks that it is a variation image forewer.

mysql> select pages_id, data, sort from field_tovarimages where pages_id = 9771;
+----------+--------------+------+
| pages_id | data         | sort |
+----------+--------------+------+
|     9771 | 30_belyi.jpg |    0 |
|     9771 | 19480.jpg    |    1 |
|     9771 | 30x30.jpg    |    2 |
+----------+--------------+------+
3 rows in set (0.00 sec)

So in  pim 

$this->originalImage == $this->originalImage->original
                       

and it makes loop ?

  • Like 1

Share this post


Link to post
Share on other sites

So,  public function ___isVariation in class Pageimage have a regexp 

$re1 = '/^'  ..
   '(\d+)x(\d+)' .>    // 50x50 
   '([pd]\d+x\d+|[a-z]{1,2})?' . <>// nw or p30x40 or d30x40
   '(?:-([-_a-z0-9]+))?' .   // -suffix1 or -suffix1-suffix2, etc.
   '\.' . $this->ext() . <>  // .jpg
   '$/';

that will match names like 30x30.jpg and always says this is a variation image. And this will cause the pim go in endless loop. Don't know is there some consequnces for processwire, seems only pim react abnormally.

I will rename all images for now, and will ask users to not use such type names, but some prevention methods must be used i think

  • Like 1

Share this post


Link to post
Share on other sites

Hi @ak1001, many thanks for your investigations.

Please can you provide me with some informations, so that I can test it locally here, and try to update the ___isVariation stuff to fit with recent PW versions?

(When pim was build, we don't have had imge-rendering-engines and the image structures as it is today. We only have had the imagesizer.php and the pageimage.php, where I copy pasted that method from.) 

Which version of PW are you using:

Do you use Pim1 or Pim2:

Which module version of Pim:

What is the exact full URL of the image(s) in question:

 

 

Share this post


Link to post
Share on other sites
On 2/11/2020 at 2:54 PM, horst said:

Hi @ak1001, many thanks for your investigations.

Please can you provide me with some informations

Hi @horst
ProcessWire 3.0.98
Pageimage Manipulator 2    0.2.9

exact urls something like site/assets/files/9771/30x30.jpg
pim image : site/assets/files/9771/30x30.-pim2-wm3.jpg

Also i was lazy to rename images so i just count loops in PageImageManipulator02.class.php


 

		// Construct & Destruct the ImageManipulator02 for a single image
        public function __construct($entryItem=null, $options=array(), $bypassOperations=false) {

				...

                if(!$this->isOriginal) {
                    // traversing up 'til reaching root reference
                    $this->originalImage = $entryItem->original;
                    $countloop = 0;
                    while(null !== $this->originalImage->original) {
                        $countloop++;
                        $reference = $this->originalImage->original;
                        $this->originalImage = $reference;
                        if($countloop > 5) {
                            error_log("---- ImageManipulator02 loop!  ".__LINE__);
                            error_log("---- loop filename= ".$this->filename .", ".__LINE__);
                            break;
                        }
                    }
                }
				
				...


 

  • Like 1

Share this post


Link to post
Share on other sites

Hi! I just found a problem adding a watermar when 2 different images have the same name but the extensions are jpg and jpeg the result is only one image.

I fixed it commenting lines 554 to 556 on ImageManipulator02.class.php file.

Eg: "photo1.jpg" and "photo1.jpeg"

foreach ($images as $img){
     $img->pim2Load("wtmd", true)->height(480)->watermarkLogo($watermark, $position = 'center', $padding = 2)->pimSave()->httpUrl;
} // The result is photo1.jpg

imagen.thumb.png.e3a06d4ba259083259feec57b64f4d78.png

  • Like 1

Share this post


Link to post
Share on other sites
1 hour ago, Crowdland Technology said:

Hi! I just found a problem adding a watermar when 2 different images have the same name but the extensions are jpg and jpeg the result is only one image.

@Crowdland Technology Many thanks. I have fixed it in the Github Repo.

  • Like 2

Share this post


Link to post
Share on other sites

Hello @horst me again with problems. Tried to enable webp support and get this error:

imagen.thumb.png.beeb29d31bef03ab15da546108263571.png

"Error when trying to save the MemoryImage: we have no Targetfilename!
In /site/assets/cache/FileCompiler/site/modules/PageImageManipulator/ImageManipulator02.class.php line 674"

I'm using your implementation with the Strategy 1 from this post:
https://processwire.com/blog/posts/webp-images-and-more/#strategy-1-automatically-delivering-webp-for-jpg-png-images

Everything works until I need to create the image with the watermark.

The code for the watermark is:

$image_url = $prop->images->eq(0)->pim2Load("wtm",true)->height(480)->watermarkLogo($watermark, $position='center', $padding=2) ->pimSave()->url;

Thank you!

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By d'Hinnisdaël
      Happy new year, everybody 🥬
      I've been sitting on this Dashboard module I made for a client and finally came around to cleaning it up and releasing it to the wider public. This is how it looks.
      ProcessWire Dashboard

      If anyone is interested in trying this out, please go ahead! I'd love to get some feedback on it. If this proves useful and survives some real-world testing, I'll add this to the module directory.
      Download
      You can find the latest release on Github.
      Documentation
      Check out the documentation to get started. This is where you'll find information about included panel types and configuration options.
      Custom Panels
      My goal was to make it really simple to create custom panels. The easiest way to do that is to use the panel type template and have it render a file in your templates folder. This might be enough for 80% of all use cases. For anything more complex (FormBuilder submissions? Comments? Live chat?), you can add new panel types by creating modules that extend the DashboardPanel base class. Check out the documentation on custom panels or take a look at the HelloWorld panel to get started. I'm happy to merge any user-created modules into the main repo if they might be useful to more than a few people.
       Disclaimer
      This is a pre-release version. Please treat it as such — don't install it on production sites. Just making sure 🍇
      Roadmap
      These are the things I'm looking to implement myself at some point. The wishlist is a lot longer, but those are the 80/20 items that I probably won't regret spending time on.
      Improve documentation & add examples ⚙️ Panel types Google Analytics ⚙️ Add new page  🔥 Drafts 🔥 At a glance / Page counter 404s  Layout options Render multiple tabs per panel panel groups with heading and spacing between ✅ panel wrappers as grid item (e.g. stacked notices) ✅ Admin themes support AdminThemeReno and AdminThemeDefault ✅ Shortcuts panel add a table layout with icon, title & summary ✅ Chart panel add default styles for common chart types ✅ load chart data from JS file (currently passed as PHP array) Collection panel support image columns ✅ add buttons: view all & add new ✅
    • By Pip
      Hi everyone!
      I'm trying out the Login/Register module for my site. Noted that the module assigns the newly registered user to login-register role. 
      Once you modify the login-register role's permissions, particularly adding page-edit, the new member role will be set to guest. 
      Thing is I'd like to grant my new users the power to create their own pages. Any advice? 
      Thanks. 
    • By Gadgetto
      SnipWire - Snipcart integration for ProcessWire
      Snipcart is a powerful 3rd party, developer-first HTML/JavaScript shopping cart platform. SnipWire is the missing link between Snipcart and the content management framework ProcessWire.
      With SnipWire, you can quickly turn any ProcessWire site into a Snipcart online shop. The SnipWire plugin helps you to get your store up and running in no time. Detailed knowledge of the Snipcart system is not required.
      SnipWire is free and open source licensed under Mozilla Public License 2.0! A lot of work and effort has gone into development. It would be nice if you could donate an amount to support further development:

      Status update links (inside this thread) for SnipWire development
      2020-07-03 -- SnipWire 0.8.7 (beta) released! Fixes some small bugs and adds an indicator for TEST mode 2020-04-06 -- SnipWire 0.8.6 (beta) released! Adds support for Snipcart subscriptions and also fixes some problems 2020-03-21 -- SnipWire 0.8.5 (beta) released! Improves SnipWires webhooks interface and provides some other fixes and additions 2020-03-03 -- SnipWire 0.8.4 (beta) released! Improves compatibility for Windows based Systems. 2020-03-01 -- SnipWire 0.8.3 (beta) released! The installation and uninstallation process has been heavily revised. 2020-02-08 -- SnipWire 0.8.2 (beta) released! Added a feature to change the cart and catalogue currency by GET, POST or SESSION param 2020-02-03 -- SnipWire 0.8.1 (beta) released! All custom classes moved into their own namespaces. 2020-02-01 -- SnipWire is now available via ProcessWire's module directory! 2020-01-30 -- SnipWire 0.8.0 (beta) first public release! (module just submitted to the PW modules directory) 2020-01-28 -- added Custom Order Fields feature (first SnipWire release version is near!) 2020-01-21 -- Snipcart v3 - when will the new cart system be implemented? 2020-01-19 -- integrated taxes provider finished (+ very flexible shipping taxes handling) 2020-01-14 -- new date range picker, discount editor, order notifiactions, order statuses, and more ... 2019-11-15 -- orders filter, order details, download + resend invoices, refunds 2019-10-18 -- list filters, REST API improvements, new docs platform, and more ... 2019-08-08 -- dashboard interface, currency selector, managing Orders, Customers and Products, Added a WireTabs, refinded caching behavior 2019-06-15 -- taxes provider, shop templates update, multiCURL implementation, and more ... 2019-06-02 -- FieldtypeSnipWireTaxSelector 2019-05-25 -- SnipWire will be free and open source Plugin Key Features
      Fast and simple store setup Full integration of the Snipcart dashboard into the ProcessWire backend (no need to leave the ProcessWire admin area) Browse and manage orders, customers, discounts, abandoned carts, and more Multi currency support Custom order and cart fields Process refunds and send customer notifications from within the ProcessWire backend Process Abandoned Carts + sending messages to customers from within the ProcessWire backend Complete Snipcart webhooks integration (all events are hookable via ProcessWire hooks) Integrated taxes provider (which is more flexible then Snipcart own provider) Useful Links
      SnipWire in PW modules directory SnipWire Docs (please note that the documentation is a work in progress) SnipWire @GitHub (feature requests and suggestions for improvement are welcome - I also accept pull requests) Snipcart Website  

       
      ---- INITIAL POST FROM 2019-05-25 ----
       
    • By Sten
      Hello
      Till now I hacked something with the twig template but it works no more with new PW versions so I look forward to create a module. I am working on a site in multiple languages : French, English, Italian, German, Spanish, Portuguese, Hebrew, Russian. The new posts are entered in any language with a field for language. Till now, I got twig files to get the translations with constants defined for each part of the pages.
      So I'd like to create a module to include theses files added according to the url /fr/en/...
      Have you some observations to do before I begin about the direction to take ?
      Thank you
    • By ukyo
      Mystique Module for ProcessWire CMS/CMF
      Github repo : https://github.com/trk/Mystique
      Mystique module allow you to create dynamic fields and store dynamic fields data on database by using a config file.
      Requirements
      ProcessWire 3.0 or newer PHP 7.0 or newer FieldtypeMystique InputfieldMystique Installation
      Install the module from the modules directory:
      Via Composer:
      composer require trk/mystique Via git clone:
      cd your-processwire-project-folder/ cd site/modules/ git clone https://github.com/trk/Mystique.git Module in live reaction with your Mystique config file
      This mean if you remove a field from your config file, field will be removed from edit screen. As you see on youtube video.
      Using Mystique with your module or use different configs path, autoload need to be true for modules
      Default configs path is site/templates/configs/, and your config file name need to start with Mystique. and need to end with .php extension.
      Adding custom path not supporting anymore !
      // Add your custom path inside your module class`init` function, didn't tested outside public function init() { $path = __DIR__ . DIRECTORY_SEPARATOR . 'configs' . DIRECTORY_SEPARATOR; Mystique::add($path); } Mystique module will search site/modules/**/configs/Mystique.*.php and site/templates/Mystique.*.php paths for Mystique config files.
      All config files need to return a PHP ARRAY like examples.
      Usage almost same with ProcessWire Inputfield Api, only difference is set and showIf usage like on example.
      <?php namespace ProcessWire; /** * Resource : testing-mystique */ return [ 'title' => __('Testing Mystique'), 'fields' => [ 'text_field' => [ 'label' => __('You can use short named types'), 'description' => __('In file showIf working like example'), 'notes' => __('Also you can use $input->set() method'), 'type' => 'text', 'showIf' => [ 'another_text' => "=''" ], 'set' => [ 'showCount' => InputfieldText::showCountChars, 'maxlength' => 255 ], 'attr' => [ 'attr-foo' => 'bar', 'attr-bar' => 'foo' ] ], 'another_text' => [ 'label' => __('Another text field (default type is text)') ] ] ]; Example:
      site/templates/configs/Mystique.seo-fields.php <?php namespace ProcessWire; /** * Resource : seo-fields */ return [ 'title' => __('Seo fields'), 'fields' => [ 'window_title' => [ 'label' => __('Window title'), 'type' => Mystique::TEXT, // or InputfieldText 'useLanguages' => true, 'attr' => [ 'placeholder' => __('Enter a window title') ] ], 'navigation_title' => [ 'label' => __('Navigation title'), 'type' => Mystique::TEXT, // or InputfieldText 'useLanguages' => true, 'showIf' => [ 'window_title' => "!=''" ], 'attr' => [ 'placeholder' => __('Enter a navigation title') ] ], 'description' => [ 'label' => __('Description for search engines'), 'type' => Mystique::TEXTAREA, 'useLanguages' => true ], 'page_tpye' => [ 'label' => __('Type'), 'type' => Mystique::SELECT, 'options' => [ 'basic' => __('Basic page'), 'gallery' => __('Gallery'), 'blog' => __('Blog') ] ], 'show_on_nav' => [ 'label' => __('Display this page on navigation'), 'type' => Mystique::CHECKBOX ] ] ]; Searching data on Mystique field is limited. Because, Mystique saving data to database in json format. When you make search for Mystique field, operator not important. Operator will be changed with %= operator.
      Search example
      $navigationPages = pages()->find('my_mystique_field.show_on_nav=1'); $navigationPages = pages()->find('my_mystique_field.page_tpye=gallery');
×
×
  • Create New...