Jump to content
ryan

ProcessWire Dev Branch

Recommended Posts

I just noticed that the root page in the admin now is just called "Start"? Why is this now like this, I don't really understand the reason behind this as it was like with regular pages in the tree, taking the title of the page or configurable by the template setting. This was a great feature which is now locked?

I want to change it and can't find where "Start" is coming from. Better change it back to how it was before.

Share this post


Link to post
Share on other sites

I reported this already somewhere some time ago but don't know where.

Repeater Field

When using a fieldset open/close field in the fields for a repeater (when editing the field) the fields doesn't get indented like when doing it in templates fields edit.

post-100-0-91722700-1383829388_thumb.png

Another thing I noticed and most likely to do with the new admin theme. (still a lot of details cause problems, which was fine before)

When adding a new element in a repeater the layout of the one faded in is different and I can't delete it cause the trash icon is screwed.

After saving the page the layout of the repeater element changes and the icon is back again.

post-100-0-91204900-1383829524_thumb.png

Share this post


Link to post
Share on other sites
I want to change it and can't find where "Start" is coming from. Better change it back to how it was before.

I have no idea where that's coming from. It's not something I'm seeing here. I've never named anything "Start", but that's kind of cute in a Windows-kind of way. It's not locked for me either (I can change it here). I'm not aware of any core changes that would have anything to do with this. 

PHP 5.3.22, PDO enabled (double-checked in phpinfo() and my hoster)

That's odd. This is the line that's throwing that exception. Apparently a class_exists("PDO") is failing in your PHP install. Usually that would mean that PDO isn't installed. If you'd like, you can try commenting out that line to see if PHP is perhaps incorrect about the lack of PDO. But my guess would be that either PDO isn't really installed, or class_exists("PDO"); is not a reliable way to tell if the PDO class exists (?). 

When using a fieldset open/close field in the fields for a repeater (when editing the field) the fields doesn't get indented like when doing it in templates fields edit.

I've never specifically added it to that part. I was kind of assuming fieldsets within repeaters were a bit unlikely. But clearly I'm wrong on that. :)

When adding a new element in a repeater the layout of the one faded in is different and I can't delete it cause the trash icon is screwed.
After saving the page the layout of the repeater element changes and the icon is back again.

Looks like the icons are the wrong color, for starters. Most likely there is a style being applied to the existing repeater items that isn't applied to new repeater items. That should be a simple fix, I'll work on tracking it down. 

Share this post


Link to post
Share on other sites

I have no idea where that's coming from. It's not something I'm seeing here. I've never named anything "Start", but that's kind of cute in a Windows-kind of way. It's not locked for me either (I can change it here). I'm not aware of any core changes that would have anything to do with this. 

Ok odd, it seems like it's added through German Langauge Pack... and translated the "Home" to "Start".. wtf :)=

Share this post


Link to post
Share on other sites

Soma, I was able to duplicate the Repeater ready item issue and it should be fixed in the latest commit. 

Share this post


Link to post
Share on other sites

Thanks Ryan.

The label "Start" comes from here:

post-100-0-72170000-1383835088_thumb.png

I'm not sure this setting makes much sense?

Share this post


Link to post
Share on other sites

Without that setting, pages like Home and Trash would retain those labels unless the the LanguageSupportFields module is installed. Since this is an optional module, I figured the system pages should still be translatable via a language pack. 

Share this post


Link to post
Share on other sites

I just noticed some warnings with imagesizer when I have debug mode on..

The image sizing seem to work though, but seems odd to have so many warnings shown on frontend.

Notice: Undefined variable: thumb2 in /xxxxx/core/ImageSizer.php on line 370

Warning: imagejpeg() expects parameter 1 to be resource, null given in /xxxxx/wire/core/ImageSizer.php on line 370

Warning: rename(/xxxxx/site/assets/files/1016/fv1b7390_kl-1.600x0_tmp.jpg,/xxxx/site/assets/files/1016/fv1b7390_kl-1.600x0.jpg) [function.rename.php]: No such file or directory in /xxxx/wire/core/ImageSizer.php on line 384

Warning: iptcembed() [function.iptcembed.php]: Unable to open /xxxx/site/assets/files/1016/fv1b7390_kl-1.600x0.jpg in /xxxx/wire/core/ImageSizer.php on line388

Warning: chmod() [function.chmod.php]: No such file or directory in /xxxx/wire/core/Pageimage.php on line 210

Notice: Undefined variable: thumb2 in /xxxx/wire/core/ImageSizer.php on line 370

Warning: imagejpeg() expects parameter 1 to be resource, null given in /xxxxx/wire/core/ImageSizer.php on line 370

Warning: rename(/xxxx/site/assets/files/1016/fv1b7281_kl-1.600x0_tmp.jpg,/xxxx/site/assets/files/1016/fv1b7281_kl-1.600x0.jpg) [function.rename.php]: No such file or directory in /xxxx/wire/core/ImageSizer.php on line 384

Warning: iptcembed() [function.iptcembed.php]: Unable to open /xxx/site/assets/files/1016/fv1b7281_kl-1.600x0.jpg in /xxxx/wire/core/ImageSizer.php on line388

Warning: chmod() [function.chmod.php]: No such file or directory in /xxxx/wire/core/Pageimage.php on line 210
 

Also wanted to mention once again, that sizing images that already have the desired dimension it fails and no image is shown.

Like 

$image->size(940,0)->url and if the source image already has 940px it fails and no image shown. This is now since a long time and has been reported and is (very) annoying :)

Share this post


Link to post
Share on other sites
I just noticed some warnings with imagesizer when I have debug mode on..

Is this dev branch? None of those line numbers in the errors line up with the line numbers in the file. Also, I don't see any of those warnings and I've pretty much got debug mode on all the time locally. 

Also wanted to mention once again, that sizing images that already have the desired dimension it fails and no image is shown.

Like 

$image->size(940,0)->url and if the source image already has 940px it fails and no image shown. This is now since a long time and has been reported and is (very) annoying 

I also tried to duplicate this but couldn't. Here's the code I used: 

$img = $page->images->first();
$img2 = $img->size($img->width, 0); 
echo "<img src='$img2->url'>";

Is it possible you've got a different ImageSizer.php somehow?

EDIT: 

Soma never mind–I'm the one that's got a different ImageSizer.php  :huh: not sure how this has gone uncommitted for so long, committing now... 

  • Like 2

Share this post


Link to post
Share on other sites

Hi guys,

I am really new to here and I would have missed many posts. I have read there is a thought to look at composer and also switching to PDO .

I am happy to help in the PW development. But I am not sure where we are at present. I would like to add a module so people can still install in site/modules folder.

Though in composer world people don't like that, let me know how you are going to download the modules ?

Is it inside `vendor` or is it inside `site/modules` as the current PW is doing ? I am happy to contribute a module for PW to support composer usage. ( Happy to hear your thoughts for if you already started then I don't need to re-invent anything here )

If composer a small recommendation about the PDO and usage :

I have a bit of background in aura, so you should really have a look at  https://github.com/auraphp/Aura.Sql/tree/develop-2 . The ExtendedPdo is lazy loaded https://github.com/auraphp/Aura.Sql/tree/develop-2#lazy-connection .

Also the IN ( usage is also simple https://github.com/auraphp/Aura.Sql/tree/develop-2#array-quoting

Share this post


Link to post
Share on other sites

I just installed a clean copy of the dev branch and sorting images in InputfieldImage seems buggy.
Viewing the images as a list, I can't drag an image beyond the browser's viewport.
So I can't, for example, drag the last image to make it the first, because the first image is beyond my viewport.

On 2.3, if I start dragging an image beyond the viewport, then the browser automatically scrolls up or down the page (depending on which direction I'm dragging).

On the dev branch, there is no scrolling - the page stays in place, so I can't drag up or down beyond what I can see.


Also I noticed that when in grid view, sorting of images is a bit clunky.
If I try to move the last image to be first, sometimes the first image won't budge away.

After I do successfully release the image, the lightbox always appears, which is also a bit annoying.

On Chrome, both in list view and in grid view, the image I drag disappears until I drop it.

I'm testing on Firefox and Chrome (latest versions) on Windows 7.

If my explanation isn't clear I can post a video of these issues.

Grid view is a great addition! Much easier to work with when you have more than a few images!
 

Share this post


Link to post
Share on other sites

To the above post.

ui sortable is screwed because of the addition of  overflow-y: scroll on the body. It's a known bug I ran into even couple years ago and seems still there in jquery ui. pff

Once you scroll the page and start dragging a item, it is offset by a margin and not on you cursor anymore, makes it impossible to drag sort or scroll. Once you remove the overflow-y: scroll from the body it's all good again.

Not sure what else could fix the problem, as removing overflow-y: scroll on the body will bring back the content jumping on dropdowns that are longer than window.

  • Like 1

Share this post


Link to post
Share on other sites

ui sortable is screwed because of the addition of  overflow-y: scroll on the body. It's a known bug I ran into even couple years ago and seems still there in jquery ui. pff

 

Once you scroll the page and start dragging a item, it is offset by a margin and not on you cursor anymore, makes it impossible to drag sort or scroll. Once you remove the overflow-y: scroll from the body it's all good again.

I guess it's this:

http://bugs.jqueryui.com/ticket/8297

(closed bug: notabug)

Resolution set to invalid

jQuery and jQuery UI do not support setting overflow on the body or html.

Share this post


Link to post
Share on other sites

To the above post.

ui sortable is screwed because of the addition of  overflow-y: scroll on the body. It's a known bug I ran into even couple years ago and seems still there in jquery ui. pff

Once you scroll the page and start dragging a item, it is offset by a margin and not on you cursor anymore, makes it impossible to drag sort or scroll. Once you remove the overflow-y: scroll from the body it's all good again.

Not sure what else could fix the problem, as removing overflow-y: scroll on the body will bring back the content jumping on dropdowns that are longer than window.

Thanks for the info Soma!

That is indeed the problem.

I don't know about the issue with content jumping, but it's definitely a problem if drag and drop sorting doesn't work...

Share this post


Link to post
Share on other sites
I have read there is a thought to look at composer and also switching to PDO .

I'm very enthusiastic about composer support. The dev branch (PW 2.4) has already switched to PDO. Though it still supports mysqli for the 3rd party modules that use it. The $database API variable refers to WireDatabasePDO connection and the $db API variable continues to refer to the mysqli connection (which is now lazy loaded–no connection made unless a module or one's site asks for the $db variable). 

Though in composer world people don't like that, let me know how you are going to download the modules ?

2.3 dev/2.4 includes a module installer/updater from the admin. It's essentially a bare essentials version of Soma's ModulesManager (using much the same code actually). I do like the idea of providing another module installation option via composer. 

Is it inside `vendor` or is it inside `site/modules` as the current PW is doing ? I am happy to contribute a module for PW to support composer usage. ( Happy to hear your thoughts for if you already started then I don't need to re-invent anything here )

All 3rd party PW modules are inside /site/modules/ whereas all core modules are installed in /wire/modules/. So I think the answer to your question is /site/modules/, though am not sure how that works or is compatible with Composer?

Also the IN ( usage is also simple https://github.com/a...2#array-quoting
 
I noticed this issue several times when converting from mysqli to PDO. Good thinking on your solution there! Another shortcoming I noticed of native PDO is that there's no way to bind table names like you would parameters. 
 
Also I noticed that when in grid view, sorting of images is a bit clunky. If I try to move the last image to be first, sometimes the first image won't budge away.
 
Hold the image in that first spot for a second and the sorting should realize what you are trying to do. If the behavior is still not there, try editing your image field (Setup > Fields > your image field) and changing the default layout to be the grid rather than the list. Does it make any difference with the behavior?
 
On Chrome, both in list view and in grid view, the image I drag disappears until I drop it.
 
I've not experienced this behavior. Anyone else run into this?

 

ui sortable is screwed because of the addition of  overflow-y: scroll on the body. It's a known bug I ran into even couple years ago and seems still there in jquery ui. pff

Once you scroll the page and start dragging a item, it is offset by a margin and not on you cursor anymore, makes it impossible to drag sort or scroll. Once you remove the overflow-y: scroll from the body it's all good again.

Not sure what else could fix the problem, as removing overflow-y: scroll on the body will bring back the content jumping on dropdowns that are longer than window.

 

I hadn't run into this issue yet, but just confirmed it now. Glad you know what was causing it! I would have probably spent hours trying to figure that one out. I think the best bet is just to remove the 'overflow-y: scroll' or make it conditional. The jumping on the menus is only a minor annoyance, whereas the lack of ability to drag beyond the visible portion of the screen is a big problem. What if we just added the 'overflow-y: scroll' conditionally, when the height of the window's content area is greater than the height of the window?

Share this post


Link to post
Share on other sites

If the behavior is still not there, try editing your image field (Setup > Fields > your image field) and changing the default layout to be the grid rather than the list. Does it make any difference with the behavior?

Yes. Sorting is more responsive.

I noticed a small usability issue with the button that toggles between list view and grid view.

The clickable area of the button is a bit small and if I click a bit to the left outside the button then it collapses the images field.

This could be fixed by adding some left padding to the button. I'm just not sure where to make that edit.

Share this post


Link to post
Share on other sites

I noticed 2.3.11 is just being released :) Nice work with the admin switcher. Is anyone else experiencing an error (unable to complete your request...) when trying to install a clean version from the dev branch? When I install 2.3.11 from the master branch and checkout to dev after installing it seems to work fine.

PHP 5.5.3 and MySQL 5.5.33 (MAMP)

Share this post


Link to post
Share on other sites

downloded 2.3.11 dev zipper file

installa ok no problemos 

mamp php 5.4

mysequel 5.5.29

  • Like 1

Share this post


Link to post
Share on other sites

I'm having more problems on my local development enviroment since I'm using Mavericks so this one might be on me too.

Share this post


Link to post
Share on other sites

@arjen

I'm using php from liip, formally from entropy.ch. I use it since MacOS 10.2 or so. Never had any problems with it.

It's easy to install, and runs on the native Apple shipped Apache. And works out of the box with the default MySQL Server

If you're want to shift or interested leave me a message.

  • Like 2

Share this post


Link to post
Share on other sites

\wire\modules\Process\ProcessModule\ProcessModule.module

line 56: needs new line (otherwise translation broken for 'Download and Install')

        $this->labels['download_install'] = $this->input->get->update ? $this->_('Download and Update') :
        $this->_('Download and Install');
 
  • Like 2

Share this post


Link to post
Share on other sites

Thanks Manfred62, just corrected that and will send in the next commit. 

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.

×
×
  • Create New...