Jump to content
Pete

ProcessEmailToPage

Recommended Posts

Ok sorted it out to use the Username on the Emailadress field get it working....but the script holds on this error

Error: Call to a member function add() on a non-object (line 360 of /var/www/webxxx/html/rezepte/site/modules/ProcessEmailToPage/ProcessEmailToPage.module)

This error message was shown because you are logged in as a Superuser. Error has been logged. 

it's this lines:

// Iterate through any attachments if we have an images field for this page
if (isset($message['attachment'])) {
    foreach ($message['attachment'] as $attachment) {
        // We need to make the filename safe before continuing
        $attachment['filename'] = $this->sanitizer->pageName($attachment['filename'], true);
        // Write the file directly to the /files/pageid/ folder, then add it to ProcessWire (adds info to the DB)
        if(strlen($attachment['data'])>0){
            file_put_contents($page->images->path . $attachment['filename'], $attachment['data']);
            $page->images->add($page->images->path . $attachment['filename']);
        }
    }
    $page->save();
}

i''ve send a normal email via handy (no html header, footer, signature) with an image attachment....

regards mr-fan

Share this post


Link to post
Share on other sites

@mr-fan,

It looks like you are using my latest version of this module - I was playing around with attachments and embedding them into RTE fields. I think the error is coming from the images field. Does your page have an images field? Is it named "images"?

Share this post


Link to post
Share on other sites

....forgot top tell that i use the lastet version from here...

yes there is a imagefield but named "Bilder" .....is this hardcoded somewhere?

-> and yes until this line the script works and setup the page correctly!!

Thank and regards mr-fan

Share this post


Link to post
Share on other sites

Great - tested -> works....asap i will provide german translation and if some others test the new functions may update this version....looks really good!

Thank you adrian!

If needed i could send you one of the favorite recipes translated.....;)

  • Like 1

Share this post


Link to post
Share on other sites

@mr-fan - thanks for testing. I am not sure this module is getting a lot of use, so I am not expecting many others to test so maybe I'll just submit a PR to Pete to get this new version committed to Github and available from the modules directory.

Share this post


Link to post
Share on other sites

...i will test it with different mailprogs and settings....i find this is a very usefull addon!

but until now it works like a charm!

one thin would maybe a nice option....that may could easy done?

if some emailclient use html tags and u don't want them in the textarea just the clean text transmitted - is there a chance to get a flag for striptags? for the body field and the additional fields - could be a general setting, too.

This would provide more secure to get the content in a usable format.

Best Regards mr-fan

Share this post


Link to post
Share on other sites
if some emailclient use html tags and u don't want them in the textarea just the clean text transmitted - is there a chance to get a flag for striptags? for the body field and the additional fields - could be a general setting, too.

It already strips out all html tags except 

<br><br /><p><strong><b><a><img>

Although looking at this, it should probably be expanded to include <em> and maybe even <b> and <i>

Does this take care of your request, or is it something else I am not understanding? Or is the stripping of tags not working for you?

Share this post


Link to post
Share on other sites

Oh that explains some questions....i use many different textareas for testing - if i test modules i don't only break it down to just my usecase since i'm testing addons in my former cms for a long time and for many devs.

(making stupid userthings is one of my strenght - so i'm finding a way down to murphy's law.)

i used textareas with different markups like MarkDown and there i was getting tags that are allowed <br> and so on -> MarkDown isn' working korrekt there and show the tags in cleartext.

But this is a very special test/usecase.

i found the code for this - if someone read's this threat he could finaly set it for such usecases to get special results.

Thanks again for your work and response!

(while i'm testing new versions i'll learn a lot from the changes and i enjoy it since modules are written in a really easy way in processwire so that a php noob could understand OOP that simple make sence and isn't that hard or abstract anymore!!)

// Run it through ProcessWire's sanitizer for good measure - restricts only to basic HTML tags
if($this->embedImages == 'TRUE' && $category->imagesField != ''){
	$message_body = $this->sanitizer->textarea($message_body, array('allowableTags' => '<br><br /><p><strong><b><a><img>'));
}
else{
	$message_body = $this->sanitizer->textarea($message_body, array('allowableTags' => '<br><br /><p><strong><b><a>'));
}

Share this post


Link to post
Share on other sites

Great module, however I'm having a problem with attachments.  I have the original image field, however the attachments don't show up.

@Adrian, Is the fork that you are working on the same as what's published on the ProcessWire page for Process Email To Page?

Much Thanks to @Pete and @Adrian for working on this module. 

Share this post


Link to post
Share on other sites

Hi Charles,

I think my fork is well ahead on the attachment functionality. In my limited tests I think it was working in all situations, but I might have missed something - so many different things to consider with different email clients. Anyway, please test my version and let us know how it goes for you.

  • Like 1

Share this post


Link to post
Share on other sites

Adrian,

Your changes made the difference.  It works great now. Thanks a million.

Best Regards,

Charles

  • Like 1

Share this post


Link to post
Share on other sites

Is there a way to get some additional message header information (i.e the FROM Address and the email DATE) to show up and could possibly be mapped to a PW field?

Share this post


Link to post
Share on other sites

Is there a way to get some additional message header information (i.e the FROM Address and the email DATE) to show up and could possibly be mapped to a PW field?

This should be very easy to add. Sorry I don't have time in the next few days and so it will probably have to wait till the new year, but if you are in a hurry, take a look at:

http://flourishlib.com/docs/fMailbox

That shows what you need to add: "received" (date) and "from". If you decide to add this support before I get a chance to look into, please send me a PR :)

It seems like going forward, this module needs to be further configurable so you can decide what fields you want stored and which PW fields you want them added to.

  • Like 1

Share this post


Link to post
Share on other sites

Hi again - I have just committed an update to my fork that supports capturing the received date and the from address (actually I parsed out the name associated with the email address). Is that what you are looking for, or do you actually want the email address? If so, I might need to add an option to choose what is required.

Anyway, let me know if things work for you.

  • Like 1

Share this post


Link to post
Share on other sites

Adrian,

You are indeed a miracle worker and a very talented developer.  Thanks for updating this module!  The new changes are immediately useful and I owe you a depth of gratitude.

Best Regards,

Charles

  • Like 1

Share this post


Link to post
Share on other sites

I think you are way too kind, but I am very glad I could help out a little. Please let me know if you do need access to the from email address, rather than the name and I'll sort that out.

Share this post


Link to post
Share on other sites

Adrian,

From the limited testing I have done so far, it is giving me the email address.  I need to test from other email providers other than Yahoo to see what shows up.  Either way, this is more than what I had yesterday.

I believe that the more functionality that this module has (being able to map email metadata with actual PW fields), the better it will serve the diverse needs of the PW community.  I also hope we can get these changes merged with the published version on the PW website.

Thanks again, as you have made my day. 

Best Regards,

Charles

Share this post


Link to post
Share on other sites

Interesting - maybe the account you are sending from doesn't have a name in the from address field, eg: "John Smith" <john@example.com>

I think it would be great to be able to match up the sender with a PW user account, most likely via their email address. This is easy to do, I just don't know what most people would want and don't want to end up with too many config options. 

I am also not sure just how many people are actually using this module, especially given how effective the PW admin is on mobile devices.

Anyone else out there have any thoughts on this - are others using this module? Should it simply populate a text field with the sender's name/email address, or try to match up to a PW user account? I might need to do some testing of the returned data to see what is actually being returned and match if possible.

Share this post


Link to post
Share on other sites

Ok, I first had the From field mapped to a PW Email Field.   My Yahoo account has the email and name both mapped to my email address, hence that's why the email address showed up.  I then tested on Gmail and MSN and nothing showed up.  I then understood the problem and changed the PW field to a text field and then the name showed up when importing Yahoo, Gmail and MSN emails.

Operator error on my part.  The Name field works great.

Share this post


Link to post
Share on other sites

That makes sense - thanks for clarifying the reason for the email address actually being populated. I have just pushed another update that now has three separate options: name, email, user

The first two are obvious. The third one (user) needs to be pointed to a page field that has "user" as the template of selectable pages. Also, you might want to set Label Field to "name" rather than the default "title". When the page is created, this field will grab the user from the list of PW users based on the email address, which means you then have full access to all other fields in the user template. It also sets the created and modified users on the Settings tab to this user. This should make it pretty powerful for emailing in blog posts and the like.

I probably need to add some checks to deal with the email address not matching a PW user, but I'll wait for the next update for that.

Let me know how it works for you.

This is what the result looks like on the new page:

post-985-0-24194400-1419654832_thumb.png

post-985-0-65063700-1419657201_thumb.png

  • Like 1

Share this post


Link to post
Share on other sites

FYI, I had a problem with the body text not showing up.  I looked at your code and ended up doing a diff to see what was going on.  Somehow the following code was dropped from the update:

$page->{$category->bodyField} = $body;

I added this code to the recent update and then the body text showed up again.

post-756-0-98398500-1419658355_thumb.png

  • Like 1

Share this post


Link to post
Share on other sites

FYI, I had a problem with the body text not showing up.  I looked at your code and ended up doing a diff to see what was going on.  Somehow the following code was dropped from the update:

Oops - sorry about that - fixed that and added a couple of checks around the user detection.

I am thinking the next important addition is treating attached images differently to attached files.

  • Like 1

Share this post


Link to post
Share on other sites

I have just committed another update that has a separate field for attachments that are not images. An email can now contain both and they will be treated separately with images being embedded in the body text when appropriate, but keeping other file types only a "attachments" and stored in the selected files field.

  • Like 1

Share this post


Link to post
Share on other sites

I finally got around to do some thorough testing of the new capabilities.  I tested on Customized Email, Gmail, Yahoo and MSN (Outlook) and everything works great.

I especially like how you treated the attachments and split out the From and email address.  Thanks again for all of the enhancements.

  • Like 1

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By Macrura
      PrevNextTabs Module
      Github: https://github.com/outflux3/PrevNextTabs
      Processwire helper modules for adding page navigation within the editor.
      Overview
      This is a very simple module that adds Previous and Next links inline with the tabs on the page editor. Hovering over the tab shows the title of the previous or next page (using the admin's built in jqueryUI tooltips.)
      Usage
      This module is typically used during development where you or your editors need to traverse through pages for the purpose of proofing, flagging and/or commenting. Rather than returning to the page tree or lister, they can navigate with these links.
      Warnings
      If you are using PW version 2.6.1 or later, the system will prevent you from leaving the page if you have unsaved edits.
      For earlier versions, to avoid accidentally losing changes made to a page that might occur if a user accidentally clicks on one of these, make sure to have the Form Save Reminder module installed.
      http://modules.processwire.com/modules/prev-next-tabs/
    • By Gadgetto
      SnipWire - Snipcart integration for ProcessWire
      Snipcart is a powerful 3rd party, developer-first HTML/JavaScript shopping cart platform. SnipWire is the missing link between Snipcart and the content management framework ProcessWire.
      With SnipWire, you can quickly turn any ProcessWire site into a Snipcart online shop. The SnipWire plugin helps you to get your store up and running in no time. Detailed knowledge of the Snipcart system is not required.
      SnipWire is free and open source licensed under Mozilla Public License 2.0! A lot of work and effort has gone into development. It would be nice if you could donate an amount to support further development:

      Status update links (inside this thread) for SnipWire development
      2020-03-21 -- SnipWire 0.8.5 (beta) released! Improves SnipWires webhooks interface and provides some other fixes and additions 2020-03-03 -- SnipWire 0.8.4 (beta) released! Improves compatibility for Windows based Systems. 2020-03-01 -- SnipWire 0.8.3 (beta) released! The installation and uninstallation process has been heavily revised. 2020-02-08 -- SnipWire 0.8.2 (beta) released! Added a feature to change the cart and catalogue currency by GET, POST or SESSION param 2020-02-03 -- SnipWire 0.8.1 (beta) released! All custom classes moved into their own namespaces. 2020-02-01 -- SnipWire is now available via ProcessWire's module directory! 2020-01-30 -- SnipWire 0.8.0 (beta) first public release! (module just submitted to the PW modules directory) 2020-01-28 -- added Custom Order Fields feature (first SnipWire release version is near!) 2020-01-21 -- Snipcart v3 - when will the new cart system be implemented? 2020-01-19 -- integrated taxes provider finished (+ very flexible shipping taxes handling) 2020-01-14 -- new date range picker, discount editor, order notifiactions, order statuses, and more ... 2019-11-15 -- orders filter, order details, download + resend invoices, refunds 2019-10-18 -- list filters, REST API improvements, new docs platform, and more ... 2019-08-08 -- dashboard interface, currency selector, managing Orders, Customers and Products, Added a WireTabs, refinded caching behavior 2019-06-15 -- taxes provider, shop templates update, multiCURL implementation, and more ... 2019-06-02 -- FieldtypeSnipWireTaxSelector 2019-05-25 -- SnipWire will be free and open source Plugin Key Features
      Fast and simple store setup Full integration of the Snipcart dashboard into the ProcessWire backend (no need to leave the ProcessWire admin area) Browse and manage orders, customers, discounts, abandoned carts, and more Multi currency support Custom order and cart fields Process refunds and send customer notifications from within the ProcessWire backend Process Abandoned Carts + sending messages to customers from within the ProcessWire backend Complete Snipcart webhooks integration (all events are hookable via ProcessWire hooks) Integrated taxes provider (which is more flexible then Snipcart own provider) Useful Links
      SnipWire in PW modules directory SnipWire Docs (please note that the documentation is a work in progress) SnipWire @GitHub (feature requests and suggestions for improvement are welcome - I also accept pull requests) Snipcart Website  
      ---- INITIAL POST FROM 2019-05-25 ----
       
    • By horst
      Croppable Image 3
      for PW 3.0.20+
      Module Version 1.2.0
      Sponsored by http://dreikon.de/, many thanks Timo & Niko!
      You can get it in the modules directory!
      Please refer to the readme on github for instructions.
       
      - + - + - + - + - + - + - + - + - + - NEWS - 2020/03/19 - + - + - + - + - + - + - + - + - + - 
      There is a new Version in the pipe, that supports WebP too: 
       
      - + - + - + - + - + - + - + - + - + - NEWS - 2020/03/19 - + - + - + - + - + - + - + - + - + - 
       
       
      -------------------------------------------------------------------------
       
      Updating from prior versions:
       
      Updating from Croppable Image 3 with versions prior to 1.1.7, please do this as a one time step:
      In the PW Admin, go to side -> modules -> new, use "install via ClassName" and use CroppableImage3 for the Module Class Name. This will update your existing CroppableImage3 module sub directory, even if it is called a new install. After that, the module will be recogniced by the PW updater module, what makes it a lot easier on further updates.
      -------------------------------------------------------------------------
       
      For updating from the legacy Thumbnail / CropImage to CroppableImage3 read on here.
       
      -------------------------------------------------------------------------
       
    • By Robin S
      Inspired by a recent question.
      Image Crop Ratios
      Allows preset aspect ratios to be defined per image field for the ProcessWire image crop tool.
      The module adds a select dropdown to the crop tool. Choose an aspect ratio and the crop area will be fixed to that ratio.
      Screencast

      Installation
      Install the Image Crop Ratios module.
      Configuration
      Default aspect ratios for all image fields can be defined in the module config. Aspect ratios for specific image fields can be defined on the Input tab of the field settings. You can override the ratio settings in template context if needed. Insert a hyphen as the first item in the ratio settings unless you want to force a ratio to be applied to the crop tool. The hyphen represents a blank option that allows a free crop area to be drawn. Usage
      Click the "Crop" link on the details view of an image thumbnail. Click the "Crop" icon at the top of the editor window. Choose an option from the "Ratio" select dropdown.  
      https://github.com/Toutouwai/ImageCropRatios
      https://modules.processwire.com/modules/image-crop-ratios/
×
×
  • Create New...