[Solved] Set table field via a hook

[ngrmm]

I would like to run this via a hook:

$page->of(false);
foreach($page->table as $row) {
	if($row->pass == "") {
		$pass = new Password();
		$string = $pass->randomAlnum(22);
		$row->pass = $string;
	}
}
$page->save('table');

and tried this:

$this->addHookAfter('Pages::save', function($event) {
	$p = $event->arguments('page');		
	if($p->id == 1599) return; // my page
	$p->of(false);
	foreach($p->table as $row) {
		if($row->pass == "") {
			$pass = new Password();
			$string = $pass->randomAlnum(22);
			$row->pass = $string;
		}
	}
	$p->save('table');
});

But I get a 500 error. Is it an infinite loop?

 

SOLVED

Edited April 19, 2023 by ngrmm
solved

[ngrmm]

this worked
 

$this->addHookBefore('Pages::save', function($event) {
	$p = $event->arguments("page");
	if($p->id == "1599") {
		$p->of(false);
		foreach($p->table as $row) {
			if($row->pass == "") {
				$pass = new Password();
				$string = $pass->randomAlnum(22);
				$row->pass = $string;
			}
		}
	}
});

 

[gebeer]

Great you solve it. Jut for explanation: if you hook after Pages::save and save the page again within that hook, this will cause an infinite loop as you already have observed.

To avoid this you can either use a before hook like you did or take advantage of the the $page->save([options]) by using `$page->save(['noHooks' => true])`