Jump to content

image rotation is on wrong direction


Mikael
 Share

Recommended Posts

Hi community! Thank you for the great system!

But I have faced with a problem. Given an image. When I upload the image to image field - image gets rotation in wrong direction..

 

1920695795_Screenshotfrom2020-12-0212-59-49.png.64e89e6a25fc348a31cd85525d2c8683.png

 

On the above image you can see the third image rotated on the contrary...

https://github.com/processwire/processwire/blob/d8945198f4a6a60dab23bd0462e8a6285369dcb9/wire/core/ImageSizerEngineGD.php#L477

DSC01828.zipAlso if I change the above line to:

$angle = 360 + $degree;

then it rotates it correct.. So it seems like script rotates image in wrong direction.. What to do with that? Thanks!

I have attached zip with original image.DSC01828.zip

Link to comment
Share on other sites

I have no solution yet. @Robin S seems to have found a way, but I had no time to test what he wrote in the issue. I was always hoping that Ryan will come up with a fix sooner than I have to build a quickfix on my own. I thought of adding custom buttons/checkboxes to rotate the image after saving... For now I've just added a comment that says "if the orientation is wrong please use this online editor and upload the image again" 😞 

Link to comment
Share on other sites

@bernhard But where can I take a look at Robin S solution ? I even did not expect that meeting brother in misfortune could make me so happy. Your web site looks great. We are also a German team. Our link will be encrypted in this message, like a little puzzle) So need to fix it and 'get it work'.. I don't know if the extension of website where I have error with image does matter, but if it does it is 'com'. 

Link to comment
Share on other sites

@Robin S is a genius! 🙂 

Based on his posts in the github issue I did the following and finally got the bug fixed (it seems):

 

For Server Side Resizing:

Search for "$corrections = array(" in all your files. You should find 3 files:

YXjQreP.png

Replace those arrays with this one:

		$corrections = array(
			'1' => array(0, 0),
			'2' => array(0, 1),
			'3' => array(180, 0),
			'4' => array(0, 2),
			'5' => array(90, 1),
			'6' => array(90, 0),
			'7' => array(270, 1),
			'8' => array(270, 0)
		);

This did already fix my issue.

Client Side:

Replace PWImageResizer.js with this file created by @Robin S and delete the old minified version PWImageResizer.min.js to make sure that the new version is loaded: https://github.com/processwire/processwire-issues/files/4660217/PWImageResizer.zip

 

Would be great to hear if that also fixed your issue @Mikael ?

Thx again @Robin S for the great work!!

  • Like 2
  • Thanks 1
Link to comment
Share on other sites

1 minute ago, Mikael said:

Hope it will not back again)

It will be back on the next update of ProcessWire unless Ryan fixes the issue in the core until then. So you either need to wait with that update or you apply the changes again after your upgrade.

Link to comment
Share on other sites

What I do not understand is why the original code has worked for 15+ years and now (within a sudden) it should not do anymore. As far as I could not find any changes in the EXIF specs. ??

Are you sure that the corrections arrays are wrong, really? Or may it be that the browsers have changed to a behave that rotates images ONLY BY VIEW, and that this new browser behave has to be corrected elsewhere in the inspection and processing workflow?

Just wondering.

  • Like 1
Link to comment
Share on other sites

Until today, since 20+ years, every time when I inspected such behaves, it comes out at 100% that the source image simply got the wrong notation in the EXIF rotation flag. 

Mostly directly when created from a camera, but also came from image tools that rotated images without updating the EXIF rotation flag.

In my opinion, the new browser behave isn't of any help but makes it more "mysterious" for regular users when working within image processing chains. The ONLY point where this new behave is helpful is when original images will be displayed on the front in a webpage (and have uncorrected rotation).

Link to comment
Share on other sites

Hm. I thought maybe I could strip the EXIF data from the image but did not have enough time to look into it. Do you know if PW has a method for that? Otherwise it seems to be 7 lines of code using php+imagick (which I'm using).

Link to comment
Share on other sites

EXIF data is stripped out with every processing function that uses GD-lib. So, if you just use creating a 100% width "variation" and store it as the "new" original image, all your EXIF data is lost. (GD-lib simply does not keep any image markers by design. Historically it was build to create small images for the web, and everything that may bloat filesize is dropped)

PW every time reads the EXIF data from the original image that regularly will be kept untouched.

  • Thanks 1
Link to comment
Share on other sites

  • 10 months later...
On 12/3/2020 at 12:00 PM, horst said:

What I do not understand is why the original code has worked for 15+ years and now (within a sudden) it should not do anymore. As far as I could not find any changes in the EXIF specs. ??

This has been an intermittent issue for me with PW as long as I can remember.

  • Like 1
Link to comment
Share on other sites

  • 4 weeks later...

Just came across this issue today with one of my clients.  Unfortunately @Robin S's fix(es) didn't make any difference for me (applied to PW 3.0165).

Turning off client-size resize option in the image field made no difference

The image in question's Orientation is reported as "Rotate 270 CW" via an online EXIF reader, but oddly enough, I got different behaviour in my local dev environment to that in production (could be differences in the PHP/GD engine versions I guess).  In dev, the image was rotated 90 CW, but in production 180 CW. 🤔

Link to comment
Share on other sites

  • 4 weeks later...

Hey @horst — sorry for pinging, but I'm pretty sure you're most likely to know what's going on here 🙂

So, I've been having similar issues with one site, where there are a lot of profile pics etc. Quite often uploaded images are not correctly rotated by ProcessWire. It's not super common issue, but common enough to cause major problems for admins.

Now, one pic which I'm currently testing (I can share a link if it's important) reports EXIF orientation as 8:

Am I reading that source wrong, or is there a mistake?

The array provided by @bernhard fixes the issue for me, and seems to be in line with at least that single source. I am not well versed in this topic, so be kind; I may be entirely missing the point here 🙂

  • Like 1
Link to comment
Share on other sites

40 minutes ago, teppo said:

Based on some other sources, such as https://www.impulseadventure.com/photo/exif-orientation.html, orientation 8 actually requires 90 degrees CCW (or 270 degrees CW).

If you want to have a bit of fun, I recommend the EXIF specs:

2.3 (2010)
2.3 (2012 revision, including fixes in the orientation part)
2.31 (2019)

All of them say of orientation 8 “The 0th row is the visual left-hand side of the image, and the 0th column is the visual bottom,” so 90° CCW seems correct. Further down you can find such gems as

Orientation = 8 is equivalent to an arrangement that is turned Orientation = 3 90 degrees clockwise”. Skip to Orientation 3:

Orientation = 3 is equivalent to an arrangement that is turned Orientation = 6 90 degrees clockwise” …

Orientation = 6 is equivalent to an arrangement that is turned Orientation = 1 90 degrees clockwise”. Right. Thankfully, Orientation 1 is self-sufficient:

Orientation = 1 is created when 0th row of the coded image data stored in the Exif image file and the visual top of the display screen, and 0th column and visual left, will each be matched for display”. Hooray.

I feel like I’m in an escape room.

  • Like 3
  • Haha 2
Link to comment
Share on other sites

Just to add to the reports, I have coincidentally encountered this issue just minutes ago and thankfully remembered this thread. Bernhard’s/Robin S’s fix worked for my image. It was EXIF orientation 6 (confirmed this to be in line with the specs. 90° CW to make it upright), shot on some old-ish Samsung phone and uploaded without client side resizing. The original showed up fine, but the generated variations were upside-down. Thanks!

  • Like 2
Link to comment
Share on other sites

On 12/3/2021 at 11:10 AM, teppo said:

Hey @horst — sorry for pinging, but I'm pretty sure you're most likely to know what's going on here 🙂

Hi @teppo, I'm not able to react quickly to this. I will try to investigate and / or set up an in-depth-test for that issue and want to take in some of the images where @bernhard and / or @Robin S solutions worked fine. Just trying to get a new working solution for all situations. But I only can schedule this after the 22. december, unfortunately not earlier. 😞

@teppoCan you PM me a zip with the wrong original image, and maybe one corrected from PW, or only the original image and what you have changed in the code so that it comes out correctly?

Link to comment
Share on other sites

11 hours ago, bernhard said:

I've had to deal with this issue today and I tried my fix from last year and unfortunately got wrong results as well 😞 

Hey Bernhard. Just to confirm: do you mean that the corrected image rotations array didn't fix the issue for you? If so, did you have client side image resizing enabled, and did you try if disabling that makes any change?

14 hours ago, horst said:

@teppoCan you PM me a zip with the wrong original image, and maybe one corrected from PW, or only the original image and what you have changed in the code so that it comes out correctly?

 

PM'd.

  • Like 1
Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
 Share

  • Recently Browsing   0 members

    • No registered users viewing this page.
×
×
  • Create New...