Jump to content

Image dropped during API operations (page save)


Guy Verville
 Share

Recommended Posts

We have a script that synchronizes data from a CSV file on a daily basis. The data that is synchronized all belong to a page type. However, not all data of this type of template is inspected. For example, we have a field called "sku_image" that is manually filled in by the administrator. 
When there is data to synchronize, the script modifies the relevant fields, then saves the page with the help of a function:

protected function savePage(Page $page, $reportErrors = true) {
		try {
			$page->setOutputFormatting(false);
			$page->save();
            $page->setOutputFormatting(true);
            $this->wire('log')->save('centura-synchro', $page->title);
		} catch(Exception $e) {
			if($reportErrors) {
				$this->error($e->getMessage());
                $this->wire('log')->save('centura-synchro-errors', $page->title . "=> " . $e->getMessage());
			}
		}
		return $page;

However, for some time now, and we don't know why, the entries in the "sku image" field for saved pages have been systematically deleted from the "field_sku_image" table!

The image files remain in each folder, but the reference in the table disappears. The field is a very standard image field and is not processed during synchronization except that when the page object is saved. The other data that is not processed in the synchronization remains in place. It is as if the variable $page forgot the data it is supposed to contain. It's a great mystery.

Synchronization is performed with a special "user" who has editing rights for these pages.

What could cause such behaviour?

Link to comment
Share on other sites

7 hours ago, Guy Verville said:

When there is data to synchronize, the script modifies the relevant fields

That would probably the relevant part that we would need to see to make an educated guess. Does the script perchance replace the Pageimage object assigned to sku_image with an empty one?

  • Like 1
Link to comment
Share on other sites

Hi BitPoet,

No, the script load the actual page object and processes it.

if($existingPage = $this->pageExists($query = 'name=' . $itemSku)) {
	$extractedData = "";
			// we compare the previous json data from the page with the actual jsonEncoded csv line
			if($existingPage->p21_json != '') {
				$extractedData = $existingPage->p21_json;
			}
			...
			//These are two strings to compare
			$equal = $this->comparePage($extractedData, json_encode($data));
			if($equal) {
				...
				no change made
				return false
			}
			// there is difference, so we populate the page with the new data.
			// image field and other fields are not affected by $data
			// the function "prepareData" uses $existingPage->set($field, $data [XX]);
			$existingPage = $this->prepareData($existingPage, $data);
			...
			$this->savePage($existingPage,true);
			return true;
}
protected function savePage(Page $page, $reportErrors = true) {
		try {
			$page->of(false);
			$page->save();
            $this->wire('log')->save('centura-synchro', $page->title);
		} catch(Exception $e) {
			if($reportErrors) {
				$this->error($e->getMessage());
                $this->wire('log')->save('centura-synchro-errors', $page->title . "=> " . $e->getMessage());
			}
		}
		return $page;
	}

protected function prepareData($p, $data = null) {

		$fields = $this->generalTools->p21fields;
		...
		foreach($fields as $field) {
				...
					$p->set($field, $data[$ctn]);
				...
		}
		$p->p21_json = json_encode($data);
		...
		return $p;
	}

public function pageExists(string $query) {
		$page = $this->pages->get($query);

		if($page->id === 0) {
			// page do not exist
			return false;
		}
		return $page;
	}

 

Link to comment
Share on other sites

Hm. sku_image is definitely not contained in p21fields? The line below is apparently the only one that modifies the page's field values, so still the most likely suspect (unless there's more in the code you left out or some hook magic somewhere else). Maybe outputting $field to the log can shed some more light there. Also, check compareData for singe/double equal sign mixup in if conditions.

$p->set($field, $data[$ctn]);
  • Like 1
Link to comment
Share on other sites

No, p21fields are the reference to csv file we read daily. "sku_image" is an image that must be treated manually.

I queried about the hooks, but nothing relevant here, certainly not around the image.

My programmer colleague suggested me to desactivate the processChangeLog module which was installed recently, which track changes. But I doubt that it can cause problems.

And this table is so simple...

Capture d’écran, le 2019-09-30 à 08.28.27.png

Link to comment
Share on other sites

It stopped working and/or changed its expected and known behaviour without any changes in the code itself, while keeping the exact same workflow?

Check the CSV.

The content in each field, the encoding, the first row/headers, everything.
In Excel, LibreOffice, VS Code, Notepad, whatever.
You, a colleague, someone not involved in programming/code/data management.

  • Like 2
Link to comment
Share on other sites

Hi, the CSV file is the same, and this field is not involved. The CSV file contains essentially basic data such as sku name, prices for different regions. The price is the data that changes from time to time. The image is not a field in this CSV file.

I made my test on that file and everything operates normally. This is when the $page is saved that something is lost. So my next step is to stop the process and see what's inside the object.

Link to comment
Share on other sites

I have perhaps a beginning of an answer. Using Tracy debugger, I checked three times the file object in the $page, before making the changes, after making the changes, and after having saved the page. The $page object changed after the save. The image file is now in an array...

The first, being read before change anything.
1265936017_Capturedcranle2019-09-3010_27_20.png.abd70c56b28c185bd07a32022778fed9.png

The second, the changes have been set. The image object is the same.

1576927635_Capturedcranle2019-09-3010_27_43.png.0824e8061f0cfb3facdec02608a35c66.png

I apply the changes. Boom!

1140398295_Capturedcranle2019-09-3010_28_30.png.a697b831c2420331364ba4e5593df928.png

While the formatted value should not interfere here, since the output formatting is off there is perhaps something to look here...

image.thumb.png.9b2e62b2a0545f4cd84349a04000df26.png

On my log, I wrote the filename before and after the save. The second name does not show if I call with $page->sku_image->basename. I have to drop the ->base name part. But this does not explain why the image entry disappear.

if ($existingPage->template->name = "sku-ceramic") {
    $image = $existingPage->sku_image->basename;
}
$this->savePage($existingPage,true);
if ($existingPage->template->name = "sku-ceramic") {
    $this->wire('log')->save('centura-synchro-images', $existingPage->id . "|". $image . "|". $existingPage->sku_image);
}

image.thumb.png.c8c2355e982a4940248a508372e11455.png

Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
 Share

  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By Xonox
      Hi,
      I have a site that has events where the users can make a reservation and something really weird is happening. This is the code:
      $form = array( 'name' => $sanitizer->text($input->post->name), 'email' => $sanitizer->email($input->post->email), 'phone' => $phone, ); $p = new Page(); $p->template = 'reservation'; $p->parent = wire('pages')->get('/agenda/' . $sanitizer->text($input->post->page_target) . '/'); $p->name = microtime(); $p->title = $form['name']; $p->save(); // CODE TO SEND EMAIL BELOW The user path is:
      1. User fills the form with name, email, phone and some more information.
      2. Form is validated to see if every information is ok.
      3. Information is saved into a new page (reservation template).
      4. Send email to user.
      Everything works fine except in one case:
      When the same user fills the same form more than once (to add reserves for one or more friends), usually using the same number and email, the friend's name is not filled in the "title" field. This seems to be the only field that fails, it shows empty on the backoffice. However, the email sent to the user has the name (using the same $form['name'] variable).
      Am I missing something?
×
×
  • Create New...