Jump to content
Wanze

SeoMaestro

Recommended Posts

The admin page and repeaters are getting listed as pages in structuredData:

grafik.png.9cfa315d377203ed18048b0726a5fa8e.png

I'm using the latest PW and module version. Is this a bug or a configuration issue?

Thanks for your support,
rjgamer

Share this post


Link to post
Share on other sites
23 hours ago, rjgamer said:

The admin page and repeaters are getting listed as pages in structuredData:

****

I'm using the latest PW and module version. Is this a bug or a configuration issue?

Thanks for your support,
rjgamer

I found the issue and created a pull request with a fix.

Problem: If SeoMaestro is mapped to a page fieldset or page repeater (e.g. $page->meta->seo), the fieldset will be handle as first page for the breadcrumb aka structured data and got listed as item.

Solution: I added a check to prevent the listing of pages based on PageRepeater.

Link to the pull request: https://github.com/wanze/SeoMaestro/pull/25 

  • Like 1

Share this post


Link to post
Share on other sites

Any idea how I can use an image which is inside a pagetable to populate the og:image property?

Share this post


Link to post
Share on other sites

Hi @Wanze,

I saw, that the SeoMaestro Fields have no fallback to default language, like other processwire fields, if the current language value is not set.

Is this possible?

Share this post


Link to post
Share on other sites

Hello @Wanze,

I realized that I have some pages (248 out of 1377) missing from sitemap, Google notified me. Quite a lot page and I can't figure why they are not generated to the sitemap as all the other pages. Is there any limit or config for this? These pages are not hidden, there is no special settings for them, similar product pages as the others which are included in the sitemap.xml.

I tried to set cache to 0, regenerated the XML several times without success.

I read this in the readme.md:
⚠ If your installation has lot of pages and the request takes too long to generate the sitemap, or if you run into memory problems, it is better disable the automatic generation. Use the `\SeoMaestro\SitemapManager` class to create the sitemap on your own, e.g. via CLI script.

Is there a better/faster solution for this? Should I use other module or method to generate my sitemap?

With current settings and hardware the sitemap generation stops at 30secs, despite the max execution time was set to 120secs

Share this post


Link to post
Share on other sites
On 10/8/2020 at 10:06 PM, markus_blue_tomato said:

Hi @Wanze,

I saw, that the SeoMaestro Fields have no fallback to default language, like other processwire fields, if the current language value is not set.

Is this possible?

I would have to look how ProcessWire handles this case, not sure if it's easily doable. Currently, I don't have time available, if you'd like to take a look - I'm happy to merge a pull request 😄

Cheers

Share this post


Link to post
Share on other sites
20 hours ago, Andoro said:

 

With current settings and hardware the sitemap generation stops at 30secs, despite the max execution time was set to 120secs

Hi @Andoro

From your description it sounds like you have a memory problem. Do you see anything in the logs? Try bumping your "memory_limit" setting in your php.ini file, does it help?

Cheers

Share this post


Link to post
Share on other sites
On 11/1/2020 at 11:10 PM, Wanze said:

I would have to look how ProcessWire handles this case, not sure if it's easily doable. Currently, I don't have time available, if you'd like to take a look - I'm happy to merge a pull request 😄

Cheers

Sure, didn't find yet where the output happens of the meta data.

How do you add the meta property to the Page?  I only know this way: https://processwire.com/api/ref/wire/add-hook-property/ but did not found it in the code

Share this post


Link to post
Share on other sites
20 hours ago, markus_blue_tomato said:

Sure, didn't find yet where the output happens of the meta data.

How do you add the meta property to the Page?  I only know this way: https://processwire.com/api/ref/wire/add-hook-property/ but did not found it in the code

The module uses an object "PageFieldValue" which holds the hydrated data from the database and gets initialized by the fieldtype: https://github.com/wanze/SeoMaestro/blob/master/src/PageFieldValue.php

Each meta data group has its own class to render specific data, e.g. this one for the "meta" group: https://github.com/wanze/SeoMaestro/blob/master/src/MetaSeoData.php

Hope that helps a bit 😊

  • Thanks 1

Share this post


Link to post
Share on other sites
On 11/7/2020 at 5:50 PM, Wanze said:

The module uses an object "PageFieldValue" which holds the hydrated data from the database and gets initialized by the fieldtype: https://github.com/wanze/SeoMaestro/blob/master/src/PageFieldValue.php

Each meta data group has its own class to render specific data, e.g. this one for the "meta" group: https://github.com/wanze/SeoMaestro/blob/master/src/MetaSeoData.php

Hope that helps a bit 😊

Thanks! I have created a PR with a fix: https://github.com/wanze/SeoMaestro/pull/27

  • Thanks 1

Share this post


Link to post
Share on other sites

This module is great, my biggest problem is that you have to edit the field to set default values site wide. I'd like my clients to manage some of that themselves in the settings area i have setup.

Can the Default Values of the field be inherited from another page? I guess I could write a hook to edit the field when saving a certain template but wondered if there was an easier solution.

  • Like 1

Share this post


Link to post
Share on other sites

Hi here,

I think I misunderstand how it works. I just saw that google crawled a website, and all page title look like that in google: `inherit | mysite.com` 🤦‍♂️😂

In first instance I had that code in _init.php :

// page title fallback
$title = $page->get('my_seo.meta_title|title'); // fail, it output 'inherit'

modified to :

// page title fallback
$title = ($page->get('my_seo.meta_title') === 'inherit') ? $page->title : $page->my_seo->meta_title; // ofc it works

 

How other dev do ?

  • Like 1

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.

×
×
  • Create New...