Jump to content

SeoMaestro


Wanze

Recommended Posts

23 hours ago, rjgamer said:

The admin page and repeaters are getting listed as pages in structuredData:

****

I'm using the latest PW and module version. Is this a bug or a configuration issue?

Thanks for your support,
rjgamer

I found the issue and created a pull request with a fix.

Problem: If SeoMaestro is mapped to a page fieldset or page repeater (e.g. $page->meta->seo), the fieldset will be handle as first page for the breadcrumb aka structured data and got listed as item.

Solution: I added a check to prevent the listing of pages based on PageRepeater.

Link to the pull request: https://github.com/wanze/SeoMaestro/pull/25 

  • Like 1
Link to comment
Share on other sites

  • 3 weeks later...
  • 1 month later...
  • 4 weeks later...

Hello @Wanze,

I realized that I have some pages (248 out of 1377) missing from sitemap, Google notified me. Quite a lot page and I can't figure why they are not generated to the sitemap as all the other pages. Is there any limit or config for this? These pages are not hidden, there is no special settings for them, similar product pages as the others which are included in the sitemap.xml.

I tried to set cache to 0, regenerated the XML several times without success.

I read this in the readme.md:
⚠ If your installation has lot of pages and the request takes too long to generate the sitemap, or if you run into memory problems, it is better disable the automatic generation. Use the `\SeoMaestro\SitemapManager` class to create the sitemap on your own, e.g. via CLI script.

Is there a better/faster solution for this? Should I use other module or method to generate my sitemap?

With current settings and hardware the sitemap generation stops at 30secs, despite the max execution time was set to 120secs

Link to comment
Share on other sites

On 10/8/2020 at 10:06 PM, markus_blue_tomato said:

Hi @Wanze,

I saw, that the SeoMaestro Fields have no fallback to default language, like other processwire fields, if the current language value is not set.

Is this possible?

I would have to look how ProcessWire handles this case, not sure if it's easily doable. Currently, I don't have time available, if you'd like to take a look - I'm happy to merge a pull request ?

Cheers

Link to comment
Share on other sites

20 hours ago, Andoro said:

 

With current settings and hardware the sitemap generation stops at 30secs, despite the max execution time was set to 120secs

Hi @Andoro

From your description it sounds like you have a memory problem. Do you see anything in the logs? Try bumping your "memory_limit" setting in your php.ini file, does it help?

Cheers

Link to comment
Share on other sites

On 11/1/2020 at 11:10 PM, Wanze said:

I would have to look how ProcessWire handles this case, not sure if it's easily doable. Currently, I don't have time available, if you'd like to take a look - I'm happy to merge a pull request ?

Cheers

Sure, didn't find yet where the output happens of the meta data.

How do you add the meta property to the Page?  I only know this way: https://processwire.com/api/ref/wire/add-hook-property/ but did not found it in the code

Link to comment
Share on other sites

20 hours ago, markus_blue_tomato said:

Sure, didn't find yet where the output happens of the meta data.

How do you add the meta property to the Page?  I only know this way: https://processwire.com/api/ref/wire/add-hook-property/ but did not found it in the code

The module uses an object "PageFieldValue" which holds the hydrated data from the database and gets initialized by the fieldtype: https://github.com/wanze/SeoMaestro/blob/master/src/PageFieldValue.php

Each meta data group has its own class to render specific data, e.g. this one for the "meta" group: https://github.com/wanze/SeoMaestro/blob/master/src/MetaSeoData.php

Hope that helps a bit ?

  • Thanks 1
Link to comment
Share on other sites

On 11/7/2020 at 5:50 PM, Wanze said:

The module uses an object "PageFieldValue" which holds the hydrated data from the database and gets initialized by the fieldtype: https://github.com/wanze/SeoMaestro/blob/master/src/PageFieldValue.php

Each meta data group has its own class to render specific data, e.g. this one for the "meta" group: https://github.com/wanze/SeoMaestro/blob/master/src/MetaSeoData.php

Hope that helps a bit ?

Thanks! I have created a PR with a fix: https://github.com/wanze/SeoMaestro/pull/27

  • Thanks 1
Link to comment
Share on other sites

  • 4 weeks later...

This module is great, my biggest problem is that you have to edit the field to set default values site wide. I'd like my clients to manage some of that themselves in the settings area i have setup.

Can the Default Values of the field be inherited from another page? I guess I could write a hook to edit the field when saving a certain template but wondered if there was an easier solution.

  • Like 1
Link to comment
Share on other sites

  • 2 weeks later...

Hi here,

I think I misunderstand how it works. I just saw that google crawled a website, and all page title look like that in google: `inherit | mysite.com` ?‍♂️?

In first instance I had that code in _init.php :

// page title fallback
$title = $page->get('my_seo.meta_title|title'); // fail, it output 'inherit'

modified to :

// page title fallback
$title = ($page->get('my_seo.meta_title') === 'inherit') ? $page->title : $page->my_seo->meta_title; // ofc it works

 

How other dev do ?

  • Like 1
Link to comment
Share on other sites

  • 1 month later...

I hit a back-end error with a default value on this module

Basically I set the default opengraph image to an image within a pagereference field, like so: {banner.image}

This works fine if it exists, but if it doesn't, it hits a fatal error

Link to comment
Share on other sites

  • 2 weeks later...

Hi @Wanze - great module by the way

Please can you tell me how I can omit or override the og:url tag?

I have made changes to the URL structure of one particular page tree of my site, to remove the parent name from the url string. This is carrying over to SEO maestro for all but the parent page. I tried unsetting it in the renderMetatags hook, and overwriting it with $page->opengraph->url = "new url"; in the template, but to no avail.

Edit: I see by looking into the module that the og:url is just set from httpUrl and can't be overwritten like other aspects

Link to comment
Share on other sites

  • 4 weeks later...

Hello,

Im trying to get body field from my repeater matrix to od description in SEOMaestro bu somehow can't get it to work.

meta.jpg.01af2b710482d068812391b21fac01b3.jpgmeta2.jpg.5ab10e2435398c5dbd40cff630488072.jpg

Right now I get title and other fields first then the body field. How can I achieve this in default settings.

debugger.jpg.59739960b9db1a5287f39a299057088e.jpg

Thank you

R

Link to comment
Share on other sites

  • 3 weeks later...
  • 2 months later...

Hi, I'm having and issue when sharing webpages using Seomaestro on WhatsApp.

When I share a webpage copying the url to WhatsApp on desktop or mobile, I get no OG preview.

If I remove the image field from Opengraph I get the preview of Domain and page title without the og:image.

I have tested Opengraph on facebook and is working fine, I also tested on https://iframely.com/ and is everything seems ok.

Has anyone had this issue?

Link to comment
Share on other sites

  • 1 month later...

Hmm, when I'm using an absolute URL for the open graph image, when you share the link in WhatsApp it doesn't seem to render the preview for me. I'm not sure if this is because it doesn't add the width and height properties or what the issue is. Has anyone experienced a similar issue?

Link to comment
Share on other sites

6 hours ago, alexm said:

I've got a case where I need to set the opengraph URL to that of another on a particular page via api, but I don't believe this can be done?

Any input would be greatly appreciated.

I'm not sure if that fit to your needs - I did that before in a template file, for a page that renders different output depending on URL segments:

//the custom url
$itemurl = "{$page->httpUrl}/{$slug}";

//alter seomaestros canonical url
$page->seo->meta->canonicalUrl = $itemurl; 

// set custom og:url
$wire->addHookAfter('SeoMaestro::renderMetatags', function (HookEvent $event) use($itemurl) {
	$tags = $event->arguments(0);
	$group = $event->arguments(1);
	if ($group === 'opengraph') {
		$tags['url'] = '<meta property="og:url" content="'.$itemurl.'">';
		$event->return = $tags;
	}
});

 

  • Thanks 1
Link to comment
Share on other sites

5 hours ago, sz-ligatur said:
// set custom og:url
$wire->addHookAfter('SeoMaestro::renderMetatags', function (HookEvent $event) use($itemurl) {
	$tags = $event->arguments(0);
	$group = $event->arguments(1);
	if ($group === 'opengraph') {
		$tags['url'] = '<meta property="og:url" content="'.$itemurl.'">';
		$event->return = $tags;
	}
});

@sz-ligatur that's perfect thank you!

Link to comment
Share on other sites

  • 4 months later...

Hey @Wanze... 

just a short question or idea (if you will)...

is there a function I can hook into whenever the sitemap is generated or updated in order to submit a PING to Google, Bing, or whatever?

Looked into the module and couldn't find anything I could use. The closest was shouldGenerateSitemap() but placing a hook there isn't possible.

My idea is, that whenever I use your module, I use it to find out if I need to ping Google whenever there was a sitemap.xml update. The ping-logic exists so far, but right now I use it most of the time just whenever a site was saved. Not perfect but it works.

Could be a nice addition to the module itself. Either as hook or as feature.

 

Link to comment
Share on other sites

  • 1 month later...

Hey @Wanze I've maybe figured out a problem with your module - see: https://github.com/wanze/SeoMaestro/issues/40

Edit: Because this seems for me that this could be a problem for anybody else, I'll copy the text and images here - anyone else facing this problem?

Seo image is duplacated multiple times:

  • PW Ver. 3.0.184
  • Modul Ver. 1.1.0
  • PHP 7.4
  • Settings - see. Screenshot below

Description:
Till now I've only setup one image on the Homepage (page id 1) for the SEO image field.
But it seems, that every time  I save the page  I visit the page an extra image is created in site/assets/files/1234 the folder corresponding to the page I'm saving.

EDIT OUUUCH -It seems even worse: - The suspicious files are generated every time the page is loaded in frontend - see last three screenshots.

999075392_2021-12-2011_11_58.jpg.cfa38b9d40b7c5b4e995b2404c273100.jpg

1295879251_2021-12-2011_13_13.jpg.03c3cff43d41d6f1402162b4f3671c12.jpg648843762_2021-12-2011_14_14.jpg.a02fd1f3700809277921516b0c362ba5.jpg

This blows up the assets folder enormously and is absolutely weird.

For more screenshots see attachments.

2021-12-20 10_48_32.jpg

2021-12-20 10_44_08.jpg

2021-12-20 10_39_12.jpg

Screenshot 2021-12-20 at 10-30-13 Feld bearbeiten seo_meta • stadthalle-kelkheim local.png

Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
  • Recently Browsing   0 members

    • No registered users viewing this page.
×
×
  • Create New...