Jump to content

[Solved] API image upload I need to replace instead of adding


Xonox
 Share

Recommended Posts

Hi,

 

I'm trying to upload images from a folder into a page. I need to replace the images instead of adding. The image field already has the replace existing images turned on, but it doesn't seem to be enough.

 

My code:

foreach($files as $file) {

	if(substr($file, 0, 1) != '.' && $file != '.' && $file != '..') {

		// Get SKU
		$file_sku = substr($file, 0, 9);

		// Check for book
		$book = $pages->get('sku=' . $file_sku);
		if(!$book->id) {

			// Book doesn't exist

		}
		else {

			// Upload image into book !!! THIS CODE ADDS FILE INSTEAD OF REPLACING. HOW CAN I REPLACE?
			$book->book_images->add($upload_directory . '/' . $file);

			// Delete file
			unlink($upload_directory . '/' . $file);

		}

		// Save book
		if($book->id) $book->save();

	}

}

 

What am I missing?

Link to comment
Share on other sites

5 hours ago, adrian said:

I don't think that replace setting is honored by the API.

I don't think any of the image field settings are honoured by $pageimages->add(). Not "valid file extensions", not "maximum files allowed", not min/max width/height, etc. It's a shame as it means you have to do a lot of manual validation if using add().

  • Like 1
Link to comment
Share on other sites

7 minutes ago, Robin S said:

I don't think any of the image field settings are honoured by $pageimages->add(). Not "valid file extensions", not "maximum files allowed", not min/max width/height, etc. It's a shame as it means you have to do a lot of manual validation if using add().

Yeah, pretty sure you're right. 

Here's an old discussion about it in case you want to read some of Ryan's thoughts on the matter:
https://github.com/ryancramerdesign/ProcessWire/issues/1122

  • Like 1
Link to comment
Share on other sites

24 minutes ago, Robin S said:

It's a shame as it means you have to do a lot of manual validation if using add().

I had to handle this kind of validation in my AddImageUrls module, so the code there might be useful for anyone else needing to do the same: https://github.com/Toutouwai/AddImageUrls/blob/f67ebe9729fc54d629fe939be2f9d3e9c7f68c16/AddImageUrls.module#L118-L170

  • Like 2
Link to comment
Share on other sites

Hi,

Thank you for your help.

Here's what I've got so far and working:

foreach($files as $file) {

	if(substr($file, 0, 1) != '.' && $file != '.' && $file != '..') {

		// Get SKU
		$file_sku = substr($file, 0, 9);

		// Check for book
		$book = $pages->get('sku=' . $file_sku);
		if(!$book->id) {

			// Book doesn't exist

		}
		else {

			// Check if image already exists
			foreach($book->book_images as $image){

				// Remove existing image
				if($file == $image) {
					$book->book_images->remove($image);
					$book->save();
				}

			}

			// Add new image
			$book->book_images->add($upload_directory . '/' . $file);

		}

		// Save book
		if($book->id) $book->save();

	}

}

The only problem with this code, is that the new image doesn't keep the same order. It's always added at the end. Is there any way to make it load into the same position?

Link to comment
Share on other sites

27 minutes ago, adrian said:

Note the mention of the new ->replace() method as well

@adrian thank you very much for your help, so far. However, it doesn't seems to be working:

$book->book_images->replace($book->book_images->path . $image, $upload_directory . '/' . $file);

Doesn't return any error but it doesn't replace the image! 😞

Link to comment
Share on other sites

@adrian, thanks for your help. The examples given weren't really helping because the file name wasn't kept. For each time de file was replace it would add "-1", "-2" etc. to the file name. I managed to make it work and I am posting the code, in case someone needs something like this.

foreach($files as $file) {

	if(substr($file, 0, 1) != '.' && $file != '.' && $file != '..') {

		// Get SKU
		$file_sku = substr($file, 0, 9);

		// Check for book
		$book = $pages->get('sku=' . $file_sku);
		if(!$book->id) {

			// Book doesn't exist

		}
		else {

			// Check if image already exists
			$replace = false;
			foreach($book->book_images as $image){

				// Replace image
				if($file == $image) {
					$book->book_images->delete($image);
					$book->save();
					$book->book_images->add($upload_directory . '/' . $file);
					$book->save();

					// Place image in the right position: after previous or as first
					if(isset($previous_image)) {
						$old_item = $book->book_images->get($previous_image);
						$new_item = $book->book_images->last();
						$book->book_images->insertAfter($new_item, $old_item);
					}
					else {
						$old_item = $book->book_images->first(); 
						$new_item = $book->book_images->last();
						$book->book_images->insertBefore($new_item, $old_item); 
					}
					$replace = true;

				}

				$previous_image = $image;

			}

			// Add image to book
			if(!$replace) {
				$book->book_images->add($upload_directory . '/' . $file);
			}

			// Save book
			$book->save();

			// Delete processed file
			unlink($upload_directory . '/' . $file);

		}

	}

}

 

  • Like 2
Link to comment
Share on other sites

  • Xonox changed the title to [Solved] API image upload I need to replace instead of adding

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
 Share

  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By Saleena Jhon
      Hello There, I have saw a post that was covering event-calendar with php, ajax and js. That was showing a monthly overview when I click on a "month" button or when I switch the month. And show the events on one particular date when I pick a day. Also, most events are kind of exhibitions and so they have a start date and an end date much later, and occur on each day in-between as well. So on the template I put two date picking fileds date_start and date_end. Is there an elegant way to select the events using the API? If yes, kindly help me out.
      Thanks in Advance
      Regards: 
       
    • By opalepatrick
      I am working on my first Process Module. I am creating forms. Fairly straightforward. However, I really can't work out how to create multiple fieldsets?
      $fieldset = $this->modules->get('InputfieldFieldset'); $fieldset->label = 'Customer Source'; $field = $this->modules->get('InputfieldPage'); $field->inputfield = 'InputfieldSelect'; $field->findPagesSelector = 'parent_id=1449, include=hidden'; $field->labelFieldName = 'yff-lead'; $field->name = 'yfflead'; $field->columnWidth = 16; $fieldset->add($field); $field = $this->modules->get('InputfieldPage'); $field->inputfield = 'InputfieldSelect'; $field->findPagesSelector = 'parent_id=1452, include=hidden'; $field->labelFieldName = 'customer-type'; $field->name = 'customertype'; $field->columnWidth = 16; $fieldset->add($field); //Rinse and Repeat $fieldset->label = 'Contacts'; $field = $this->modules->get('InputfieldPage'); $field->inputfield = 'InputfieldSelect'; $field->findPagesSelector = 'parent_id=1538, include=hidden'; $field->labelFieldName = 'salutation'; $field->name = 'salutation'; $field->columnWidth = 16; $fieldset->add($field); I can create the first fieldset (Customer Source) but then get into trouble as the second fieldset overwrites the first. I understand why, but trying to use the open and close fieldset routine has flummoxed me. Any help appreciated.
    • By VeiJari
      Hello forum, we're trying to use Processwire as our REST-API. We are having problems with our API login to Processwire from frontend. It gives us 403 error.
      We have installed ProcessWire to subdirectory (/api/*) and our frontend is static JS files at root ( / ). Apache access logs gives 404 to our POST-request, but browser devtools shows 403 for our POST /api/login request. 
      Processwire backend panel works. We also have a GET endpoint for the API that returns 200 with correct payload.  So we're wondering why does our GET works but POST doesn't?
      Does this have something to do with Processwire .htaccess, or is this because of our webhost? What should we check first? Any help would be appreciated.
    • By rjgamer
      Hi,
      is there a hook after the current (active) page got created? Or which method got called in the Page class after the Constructor of the current page got initialized?
      Thanks.
       
    • By killedfriendz
      I am very sorry for asking this but i totally do not understand how to set values of checbox using API. 
      I have checbox field on my page with name "order_status". 
      So i've tried few ways to make it checked but it still doesn't work:
       
      $userPage->order_status->value = 1; $userPage->order_status->add(1); $userPage->order_status->add(true); Could you please tell me how to do it?
×
×
  • Create New...